Re: [RESULT][VOTE] Merge branch HBASE-19064 back to master

2018-06-28 Thread OpenInx
Nice job, I will pay attention to the UT too.. On Thu, Jun 28, 2018 at 6:37 PM, 张铎(Duo Zhang) wrote: > Merged back to master. Will keep an eye on the nightly build and flakey > dashboard. > > Thanks. > > 2018-06-28 8:56 GMT+08:00 张铎(Duo Zhang) : > > > One week since we start the vote, and now

Re: [RESULT][VOTE] Merge branch HBASE-19064 back to master

2018-06-28 Thread Duo Zhang
Merged back to master. Will keep an eye on the nightly build and flakey dashboard. Thanks. 2018-06-28 8:56 GMT+08:00 张铎(Duo Zhang) : > One week since we start the vote, and now we have 4 binding +1s, a 0, and > no -1s, so the vote passes. Let me close the vote. > > There are still small issues

[RESULT][VOTE] Merge branch HBASE-19064 back to master

2018-06-27 Thread Duo Zhang
One week since we start the vote, and now we have 4 binding +1s, a 0, and no -1s, so the vote passes. Let me close the vote. There are still small issues for branch HBASE-19064, will merge back to master after we fix them all. Thanks all for voting. 2018-06-26 18:20 GMT+08:00 Ashish Singhi : >

Re: [VOTE] Merge branch HBASE-19064 back to master

2018-06-26 Thread Ashish Singhi
SGTM. +1 Regards, Ashish On Tue, Jun 26, 2018 at 12:30 PM, 张铎(Duo Zhang) wrote: > Here is my +1. > > As the performance test shows that there is no performance downgrading if > we do not enable sync replication, and the feature basically works, I think > it is OK to merge it back to master

Re: [VOTE] Merge branch HBASE-19064 back to master

2018-06-26 Thread Duo Zhang
Here is my +1. As the performance test shows that there is no performance downgrading if we do not enable sync replication, and the feature basically works, I think it is OK to merge it back to master branch. We will continue working on polishing and optimizing it for the 3.0 release. 2018-06-26

Re: [VOTE] Merge branch HBASE-19064 back to master

2018-06-26 Thread OpenInx
Hi guys I've tested the write performance on both master branch and HBASE-19064 branch. Here's the JIRA [1]. The conclusion(Pasted from the comment): The QPS & AVG latency are similar when comparing the master branch with async replication and HBASE-19064 with async replication. BTW the QPS of

Re: [VOTE] Merge branch HBASE-19064 back to master

2018-06-21 Thread Guanghao Zhang
+1 2018-06-21 18:26 GMT+08:00 mengli721014 on 163 dot com : > 0 > > 使用AquaMail for Android发送 > http://www.aqua-mail.com > > > > 在 2018年6月21日 下午4:21:26 "张铎(Duo Zhang)" 写道: > > In HBASE-19064 we aim to implement sync replication feature for HBase. You >> can see the design doc for more details on

Re: [VOTE] Merge branch HBASE-19064 back to master

2018-06-21 Thread mengli721014 on 163 dot com
0 使用AquaMail for Android发送 http://www.aqua-mail.com 在 2018年6月21日 下午4:21:26 "张铎(Duo Zhang)" 写道: In HBASE-19064 we aim to implement sync replication feature for HBase. You can see the design doc for more details on how it works

Re: [VOTE] Merge branch HBASE-19064 back to master

2018-06-21 Thread Yu Li
+1 Best Regards, Yu On 21 June 2018 at 16:49, 张铎(Duo Zhang) wrote: > Review board link: > > https://reviews.apache.org/r/67683/ > > 2018-06-21 16:21 GMT+08:00 张铎(Duo Zhang) : > > > In HBASE-19064 we aim to implement sync replication feature for HBase. > You > > can see the design doc for more

Re: [VOTE] Merge branch HBASE-19064 back to master

2018-06-21 Thread Duo Zhang
Review board link: https://reviews.apache.org/r/67683/ 2018-06-21 16:21 GMT+08:00 张铎(Duo Zhang) : > In HBASE-19064 we aim to implement sync replication feature for HBase. You > can see the design doc for more details on how it works > >

[VOTE] Merge branch HBASE-19064 back to master

2018-06-21 Thread Duo Zhang
In HBASE-19064 we aim to implement sync replication feature for HBase. You can see the design doc for more details on how it works https://docs.google.com/document/d/193D3aOxD-muPIZuQfI4Zo3_qg6-Nepeu_kraYJVQkiE/edit# And now the feature basically works, we have tested it on real clusters, and