[
https://issues.apache.org/jira/browse/HTTPCORE-620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006396#comment-17006396
]
ASF subversion and git services commented on HTTPCORE-620:
--
Co
On Tue, 2019-12-31 at 21:55 +0100, Michael Osipov wrote:
> Am 2019-12-31 um 21:14 schrieb Oleg Kalnichevski:
> > On Tue, 2019-12-31 at 15:10 -0500, Gary Gregory wrote:
> > > This is -1 from me, as this a classic anti-pattern: You are using
> > > the
> > > enum's ordinal value for sorting :-(
> > >
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006397#comment-17006397
]
Oleg Kalnichevski commented on HTTPCLIENT-2045:
---
[~michael-o] HttpClie
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Oleg Kalnichevski updated HTTPCLIENT-2045:
--
Fix Version/s: 5.0
Issue Type: Improvement (was: Bug)
Prio
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006405#comment-17006405
]
Michael Osipov commented on HTTPCLIENT-2045:
Thanks. I just wanted to ha
Am 2020-01-01 um 14:29 schrieb Oleg Kalnichevski:
On Tue, 2019-12-31 at 21:55 +0100, Michael Osipov wrote:
Am 2019-12-31 um 21:14 schrieb Oleg Kalnichevski:
On Tue, 2019-12-31 at 15:10 -0500, Gary Gregory wrote:
This is -1 from me, as this a classic anti-pattern: You are using
the
enum's ordin
[
https://issues.apache.org/jira/browse/HTTPCORE-617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated HTTPCORE-617:
Summary: Reference RFC 7230 instead of old RFCs in code comments (was:
Reference RFC 723
On Tue, 2019-12-31 at 14:02 -0800, Ryan Schmitt wrote:
> I read through that, but I didn't see a specific explanation of what
> would
> need to be fixed and how.
>
> Either way, it's not really interesting. I need to be able to call S3
> as-is, warts and all, or the client is unusable.
>
> On Tue
Folks
Shall I proceed with HttpCore 5.0-beta11 release or not?
Do we still need to rename anything in core?
Oleg
-
To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org
For additional commands, e-mail: dev-h...@hc.apache.org
Am 2020-01-01 um 14:45 schrieb Oleg Kalnichevski:
Folks
Shall I proceed with HttpCore 5.0-beta11 release or not?
Do we still need to rename anything in core?
Nothing left on my list. From my POV, you may go ahead. Gary, Ryan?
M
---
On Wed, Jan 1, 2020 at 8:47 AM Michael Osipov wrote:
> Am 2020-01-01 um 14:45 schrieb Oleg Kalnichevski:
> > Folks
> >
> > Shall I proceed with HttpCore 5.0-beta11 release or not?
> >
> > Do we still need to rename anything in core?
>
> Nothing left on my list. From my POV, you may go ahead. Gary
On Wed, Jan 1, 2020 at 9:23 AM Gary Gregory wrote:
> On Wed, Jan 1, 2020 at 8:47 AM Michael Osipov wrote:
>
>> Am 2020-01-01 um 14:45 schrieb Oleg Kalnichevski:
>> > Folks
>> >
>> > Shall I proceed with HttpCore 5.0-beta11 release or not?
>> >
>> > Do we still need to rename anything in core?
>>
Gary D. Gregory created HTTPCORE-621:
Summary: Rename enum AuthSchemes to StandardAuthScheme
Key: HTTPCORE-621
URL: https://issues.apache.org/jira/browse/HTTPCORE-621
Project: HttpComponents HttpCo
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory moved HTTPCORE-621 to HTTPCLIENT-2046:
--
Key: HTTPCLIENT-2046 (was: HTTPCORE-621)
garydgregory opened a new pull request #196: [HTTPCLIENT-2046] Rename enum
AuthSchemes to StandardAuthScheme.
URL: https://github.com/apache/httpcomponents-client/pull/196
I know, the branch say "core' in the name, but it's for the client.
https://issues.apache.org/jira/browse/HTTPCL
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated HTTPCLIENT-2046:
External issue URL: https://github.com/apache/httpcomponents-client/pull/196
On Wed, Jan 1, 2020 at 9:43 AM Gary Gregory wrote:
>
>
> On Wed, Jan 1, 2020 at 9:23 AM Gary Gregory
> wrote:
>
>> On Wed, Jan 1, 2020 at 8:47 AM Michael Osipov
>> wrote:
>>
>>> Am 2020-01-01 um 14:45 schrieb Oleg Kalnichevski:
>>> > Folks
>>> >
>>> > Shall I proceed with HttpCore 5.0-beta11 re
michael-o commented on issue #196: [HTTPCLIENT-2046] Rename enum AuthSchemes to
StandardAuthScheme.
URL:
https://github.com/apache/httpcomponents-client/pull/196#issuecomment-570059391
Gary, did you not notice my PR for this a couple of days ago?
--
michael-o commented on issue #196: [HTTPCLIENT-2046] Rename enum AuthSchemes to
StandardAuthScheme.
URL:
https://github.com/apache/httpcomponents-client/pull/196#issuecomment-570060917
I don't see a reason to maintain an enum if you always use a string only.
--
garydgregory commented on issue #193: Authschemename rework
URL:
https://github.com/apache/httpcomponents-client/pull/193#issuecomment-570062747
@michael-o
I could go either way here. We have an almost 1-1 mapping before this patch
between the enum and the interface impls (except for o
garydgregory commented on issue #196: [HTTPCLIENT-2046] Rename enum AuthSchemes
to StandardAuthScheme.
URL:
https://github.com/apache/httpcomponents-client/pull/196#issuecomment-570062824
> I don't see a reason to maintain an enum if you always use a string only.
I just saw it, plea
michael-o commented on issue #193: Authschemename rework
URL:
https://github.com/apache/httpcomponents-client/pull/193#issuecomment-570063434
Ok, I think I have an idea how to reconcile both ideas, since we have
classes and enums, e.g., HttpStatus, EventFilter singular and enums are
exha
On Wed, 2020-01-01 at 09:54 -0500, Gary Gregory wrote:
> On Wed, Jan 1, 2020 at 9:43 AM Gary Gregory
> wrote:
> >
> > On Wed, Jan 1, 2020 at 9:23 AM Gary Gregory > > wrote:
> > > On Wed, Jan 1, 2020 at 8:47 AM Michael Osipov <
> > > micha...@apache.org> wrote:
> > > > Am 2020-01-01 um 14:45 schr
I eagerly await the release of beta11. I'll follow up with my commit to
upgrade the client:
https://github.com/rschmitt/httpcomponents-client/commit/390d9f3aae00e98c50d41aa20c6c2075e7a13915
On Wed, Jan 1, 2020 at 5:45 AM Oleg Kalnichevski wrote:
> Folks
>
> Shall I proceed with HttpCore 5.0-be
It looks like we already have logic from the Apache 4 integration that will
handle consecutive slashes:
https://github.com/aws/aws-sdk-java-v2/blob/2a30f2b349209918a857a860266bb46102c2/http-clients/apache-client/src/main/java/software/amazon/awssdk/http/apache/internal/impl/ApacheHttpRequestFa
I think b11 can go ahead.
Gary
On Wed, Jan 1, 2020, 12:33 Oleg Kalnichevski wrote:
> On Wed, 2020-01-01 at 09:54 -0500, Gary Gregory wrote:
> > On Wed, Jan 1, 2020 at 9:43 AM Gary Gregory
> > wrote:
> > >
> > > On Wed, Jan 1, 2020 at 9:23 AM Gary Gregory > > > wrote:
> > > > On Wed, Jan 1, 20
On Wed, 2020-01-01 at 14:00 -0500, Gary Gregory wrote:
> I think b11 can go ahead.
>
> Gary
Folks
That effectively means no more renaming and moving things around
without deprecation and a migration path.
I will proceed with the release later today or tomorrow.
Oleg
>
> On Wed, Jan 1, 202
This is still a beta release, right? My understanding is that we're going
to treat it as a release candidate and try to avoid breaking changes, but
we can still make them if necessary (e.g. to fix some show-stopping defect).
On Wed, Jan 1, 2020 at 11:08 AM Oleg Kalnichevski wrote:
> On Wed, 2020
On Wed, 2020-01-01 at 11:25 -0800, Ryan Schmitt wrote:
> This is still a beta release, right? My understanding is that we're
> going
> to treat it as a release candidate and try to avoid breaking changes,
> but
> we can still make them if necessary (e.g. to fix some show-stopping
> defect).
>
Tha
I suppose this is as good a time as any to ask: why do single-core
IOReactors support the Exception callback (for error logging), but not
multi-core IOReactors? Also, how should this callback be configured when
creating a client? (I wasn't able to immediately find the relevant config
method to call
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006499#comment-17006499
]
ASF subversion and git services commented on HTTPCLIENT-2043:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006501#comment-17006501
]
ASF subversion and git services commented on HTTPCLIENT-2046:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006500#comment-17006500
]
ASF subversion and git services commented on HTTPCLIENT-2044:
[
https://issues.apache.org/jira/browse/HTTPCLIENT-2043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006498#comment-17006498
]
ASF subversion and git services commented on HTTPCLIENT-2043:
michael-o commented on issue #193: Authschemename rework
URL:
https://github.com/apache/httpcomponents-client/pull/193#issuecomment-570086437
@garydgregory I have now reconciled with subsequent cleanup. Please have a
look.
T
Am 2020-01-01 um 14:45 schrieb Oleg Kalnichevski:
Folks
Shall I proceed with HttpCore 5.0-beta11 release or not?
Do we still need to rename anything in core?
One nit during testing which should be addressed before GA:
When running: JSSEProviderIntegrationTest and Conscrypt JAR does not
cont
On Wed, 2020-01-01 at 12:03 -0800, Ryan Schmitt wrote:
> I suppose this is as good a time as any to ask: why do single-core
> IOReactors support the Exception callback (for error logging), but
> not
> multi-core IOReactors?
MultiCoreIOReactor is nothing more than a collection of
SingleCoreIOReacto
I can't help but observe that this is a workaround for the lack of logging
in core; the client is basically dependency-injecting Slf4j into core. The
`LoggingIOSessionDecorator` on the previous line would appear to be doing
the same thing.
On Wed, Jan 1, 2020 at 2:45 PM Oleg Kalnichevski wrote:
38 matches
Mail list logo
