[GitHub] [httpcomponents-client] j3graham commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883266643 ## httpclient5/src/test/java/org/apache/hc/client5/http/utils/TestBase64.java: ## @@ -108,21 +108,6 @@ void decodeUnpadded() {

[GitHub] [httpcomponents-client] j3graham commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883266409 ## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ## @@ -30,39 +30,41 @@ import org.apache.hc.core5.annotation.Internal;

[GitHub] [httpcomponents-client] j3graham commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883266278 ## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ## @@ -30,39 +30,41 @@ import org.apache.hc.core5.annotation.Internal;

[GitHub] [httpcomponents-client] j3graham commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883266186 ## httpclient5/pom.xml: ## @@ -80,6 +80,7 @@ commons-codec commons-codec + test Review Comment: It's removed -- This is

[GitHub] [httpcomponents-client] j3graham commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883246952 ## httpclient5/src/test/java/org/apache/hc/client5/http/utils/TestBase64.java: ## @@ -108,21 +108,6 @@ void decodeUnpadded() {

[GitHub] [httpcomponents-client] j3graham commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883246292 ## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ## @@ -0,0 +1,223 @@ +/* + *

[GitHub] [httpcomponents-client] michael-o commented on a diff in pull request #370: HTTPCLIENT-2218: Use Java 8 Base64 utility

2022-05-26 Thread GitBox
michael-o commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r882932243 ## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ## @@ -30,39 +30,41 @@ import org.apache.hc.core5.annotation.Internal;

Re: HttpCore 5.2-beta2 release notes

2022-05-26 Thread Michael Osipov
Am 2022-05-26 um 10:41 schrieb Oleg Kalnichevski: Folks Please review and amend the HttpCore 5.2-beta2 release notes. This would also be the right moment to run the latest code from the master branch and see if there are any test failures, or propose release process improvements.

HttpCore 5.2-beta2 release notes

2022-05-26 Thread Oleg Kalnichevski
Folks Please review and amend the HttpCore 5.2-beta2 release notes. This would also be the right moment to run the latest code from the master branch and see if there are any test failures, or propose release process improvements.

Re: HttpCore and HttpClient releases soon?

2022-05-26 Thread Oleg Kalnichevski
On Wed, 2022-05-25 at 21:33 +0200, Michael Osipov wrote: > Am 2022-05-24 um 09:18 schrieb Oleg Kalnichevski: > > Folks > > > > I would like to cut new releases of HttpCore 5.1, HttpCore 5.2 and > > HttpClient 5.2. Will there be two more PMCs around to help me with > > the > > release? > > I am