j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883246952
########## httpclient5/src/test/java/org/apache/hc/client5/http/utils/TestBase64.java: ########## @@ -108,21 +108,6 @@ void decodeUnpadded() { checkDecode("BBBBAAA"); } - @Test - void decodeUrlSafe() { - final char underscore = '_'; - final char minus = '-'; - - checkDecode(fourOf(minus)); - checkDecode(fourOf(underscore)); - } - - @Test - void mixedUrlAndRegularEncoded() { - checkDecode("++__"); - checkDecode("--//"); - } - Review Comment: Having dropped the special handling of URl-safe encoding, a lot less of this is needed. I'm cleaning it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@hc.apache.org For additional commands, e-mail: dev-h...@hc.apache.org