j3graham commented on code in PR #370: URL: https://github.com/apache/httpcomponents-client/pull/370#discussion_r883266278
########## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ########## @@ -30,39 +30,41 @@ import org.apache.hc.core5.annotation.Internal; -import java.nio.charset.StandardCharsets; - import static java.util.Base64.getEncoder; import static java.util.Base64.getMimeDecoder; /** * Provide implementations of the Base64 conversion methods from commons-codec, delegating to the Java Base64 * implementation. * <p> + * * <ul>Only the features currently used by http-client are implemented here rather than all the features of commons-coded</ul> Review Comment: Done ########## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ########## @@ -30,39 +30,41 @@ import org.apache.hc.core5.annotation.Internal; -import java.nio.charset.StandardCharsets; - import static java.util.Base64.getEncoder; import static java.util.Base64.getMimeDecoder; /** * Provide implementations of the Base64 conversion methods from commons-codec, delegating to the Java Base64 * implementation. * <p> + * * <ul>Only the features currently used by http-client are implemented here rather than all the features of commons-coded</ul> Review Comment: Done ########## httpclient5/src/main/java/org/apache/hc/client5/http/utils/Base64.java: ########## @@ -30,39 +30,41 @@ import org.apache.hc.core5.annotation.Internal; -import java.nio.charset.StandardCharsets; - import static java.util.Base64.getEncoder; import static java.util.Base64.getMimeDecoder; /** * Provide implementations of the Base64 conversion methods from commons-codec, delegating to the Java Base64 * implementation. * <p> + * * <ul>Only the features currently used by http-client are implemented here rather than all the features of commons-coded</ul> * Notes: * <p> * <ul>commons-codec accepts null inputs, so this is also accepted here. This is not done in the Java 8 implementation</ul> - * <ul>decoding invalid inputs returns an empty value. The Java 8 implementation throws an exception, which is caught here</ul> - * <ul>commons-codec decoders accept both standard and url-safe variants of input. This needs to be remapped for Java 8, as it - * will accept either one or the other, but not both. This is likely a rarely-needed requirement, but is provided to avoid - * compatibility surprises. + * <ul>Decoding invalid inputs returns an empty value. The Java 8 implementation throws an exception, which is caught here</ul> Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
