[GitHub] hive pull request #132: #HIVE-15631

2018-01-22 Thread Tartarus0zm
Github user Tartarus0zm closed the pull request at: https://github.com/apache/hive/pull/132 ---

[GitHub] hive pull request #295: HIVE-15631

2018-01-22 Thread Tartarus0zm
GitHub user Tartarus0zm opened a pull request: https://github.com/apache/hive/pull/295 HIVE-15631 When the Hive client is started, the sessionid is printed from the console. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Tartarus

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-22 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/#review195891 --- This change looks good! I only spotted some small code-duplication

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-22 Thread Marta Kuczora via Review Board
> On Jan. 19, 2018, 1:02 p.m., Adam Szita wrote: > > Overall looks good, I just have small observations. > > > > One more nitpick: some helper methods could be static e.g. > > getYearAndMonthCols Thanks a lot Adam for the review. Good point, changed the getYearAndMonthPartCols and getYearPart

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-22 Thread Marta Kuczora via Review Board
> On Jan. 19, 2018, 11:50 a.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestDropPartitions.java > > Lines 341 (patched) > > > > > > Question: Does this behave

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-22 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/ --- (Updated Jan. 22, 2018, 12:38 p.m.) Review request for hive, Peter Vary and Ada

Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/ --- Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar. Bu

[jira] [Created] (HIVE-18509) Create tests for table manipulation related methods (create, alter, drop)

2018-01-22 Thread Peter Vary (JIRA)
Peter Vary created HIVE-18509: - Summary: Create tests for table manipulation related methods (create, alter, drop) Key: HIVE-18509 URL: https://issues.apache.org/jira/browse/HIVE-18509 Project: Hive

Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/ --- Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar. Bu

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-22 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/#review195897 --- Thanks a lot Peter for the patch! It looks good to me, I only have

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/#review195898 --- Nice job, looks good to me, one minor question standalone-metast

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-22 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195900 --- Thanks for this patch Marta, it looks good! I've made a few recomm

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/#review195904 --- Thanks for the patch Marta! Only one question below standalone-m

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 22, 2018, 2:33 p.m.) Review request for hive, Alan Gates, Marta K

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-22 Thread Peter Vary via Review Board
> On Jan. 22, 2018, 1:41 p.m., Marta Kuczora wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 409 (patched) > > > > > > After dropping the functions,

[jira] [Created] (HIVE-18510) Enable running checkstyle on test sources as well

2018-01-22 Thread Adam Szita (JIRA)
Adam Szita created HIVE-18510: - Summary: Enable running checkstyle on test sources as well Key: HIVE-18510 URL: https://issues.apache.org/jira/browse/HIVE-18510 Project: Hive Issue Type: Improvem

Re: Review Request 65217: Create tests to cover alterPartition and renamePartition methods

2018-01-22 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65217/#review195910 --- Thanks a lot Adam for the patch. It looks good to me, I just have

Re: Review Request 65265: HIVE-18509 Create tests for table manipulation related methods (create, alter, drop)

2018-01-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/ --- (Updated Jan. 22, 2018, 3:36 p.m.) Review request for hive, Marta Kuczora, Adam

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-22 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/ --- (Updated Jan. 22, 2018, 3:38 p.m.) Review request for hive, Marta Kuczora, Adam

[jira] [Created] (HIVE-18511) Fix generated checkstyle errors

2018-01-22 Thread Peter Vary (JIRA)
Peter Vary created HIVE-18511: - Summary: Fix generated checkstyle errors Key: HIVE-18511 URL: https://issues.apache.org/jira/browse/HIVE-18511 Project: Hive Issue Type: Sub-task Repor

[jira] [Created] (HIVE-18512) Get Results ReadAhead

2018-01-22 Thread BELUGA BEHR (JIRA)
BELUGA BEHR created HIVE-18512: -- Summary: Get Results ReadAhead Key: HIVE-18512 URL: https://issues.apache.org/jira/browse/HIVE-18512 Project: Hive Issue Type: Improvement Components:

Review Request 65271: JDBC: Provide a way for JDBC users to pass cookie info via connection string

2018-01-22 Thread Vaibhav Gumashta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65271/ --- Review request for hive and Thejas Nair. Bugs: HIVE-18447 https://issues.ap

Re: Review Request 65047: Fix for HIVE-18393

2018-01-22 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65047/#review195935 --- Overall, looks good to me. I'm really not that familiar with the s

Re: Review Request 65250: HIVE-18387

2018-01-22 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65250/ --- (Updated Jan. 22, 2018, 10:33 p.m.) Review request for hive and Ashutosh Chauha

[jira] [Created] (HIVE-18513) Query results caching

2018-01-22 Thread Jason Dere (JIRA)
Jason Dere created HIVE-18513: - Summary: Query results caching Key: HIVE-18513 URL: https://issues.apache.org/jira/browse/HIVE-18513 Project: Hive Issue Type: Bug Components: Query Plan

[jira] [Created] (HIVE-18514) add service output for ranger to WM DDL operations

2018-01-22 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18514: --- Summary: add service output for ranger to WM DDL operations Key: HIVE-18514 URL: https://issues.apache.org/jira/browse/HIVE-18514 Project: Hive Issue T

[jira] [Created] (HIVE-18515) Custom Hive on Spark Tab in Spark Web UI

2018-01-22 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-18515: --- Summary: Custom Hive on Spark Tab in Spark Web UI Key: HIVE-18515 URL: https://issues.apache.org/jira/browse/HIVE-18515 Project: Hive Issue Type: Sub-task

[jira] [Created] (HIVE-18516) load data should rename files consistent with insert statements for ACID Tables

2018-01-22 Thread Deepak Jaiswal (JIRA)
Deepak Jaiswal created HIVE-18516: - Summary: load data should rename files consistent with insert statements for ACID Tables Key: HIVE-18516 URL: https://issues.apache.org/jira/browse/HIVE-18516 Proje

Review Request 65276: HIVE-18516

2018-01-22 Thread Deepak Jaiswal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/ --- Review request for hive, Eugene Koifman and Jason Dere. Bugs: HIVE-18516 ht