Re: Review Request 69914: HIVE-21227: HIVE-20776 causes view access regression

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69914/ --- (Updated Feb. 8, 2019, 6:48 a.m.) Review request for hive and Vihang

Re: Review Request 69914: HIVE-21227: HIVE-20776 causes view access regression

> On Feb. 7, 2019, 5:48 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Line 2509 (original), 2512 (patched) > > > >

Review Request 69914: HIVE-21227: HIVE-20776 causes view access regression

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69914/ --- Review request for hive and Vihang Karajgaonkar. Bugs: hive-21227

Re: Review Request 69831: Port from master to branch-3 HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69831/ --- (Updated Jan. 24, 2019, 8:30 p.m.) Review request for hive and Vihang

Re: Review Request 69831: Port from master to branch-3 HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69831/ --- (Updated Jan. 24, 2019, 5:19 p.m.) Review request for hive and Vihang

Review Request 69831: Port from master to branch-3 HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69831/ --- Review request for hive and Vihang Karajgaonkar. Bugs: hive-20776

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/#review212157 ---

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Jan. 18, 2019, 9:30 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Jan. 18, 2019, 3:45 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Jan. 10, 2019, 11:20 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java > > Lines 254 (patched) > > > > > > Its not

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Jan. 17, 2019, 10:33 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Jan. 10, 2019, 9:10 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetastoreFilterHook.java > > Lines 318 (patched) > > > > > >

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4711 (patched) > > > > > > move this

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4655 (patched) > > > > > > same comment

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Jan. 8, 2019, 9:44 p.m., Vihang Karajgaonkar wrote: > > Thanks for the patch. Do we really need to introduce > > authorizeTableForPartitionMetadata in these API calls. For the common case, > > it can potentially degrade API performance. For instance, for fetching a > > single partition,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Jan. 8, 2019, 8:03 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Jan. 4, 2019, 4:07 p.m.) Review request for hive, Adam Holley, Morio

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Dec. 31, 2018, 6:54 a.m.) Review request for hive, Adam Holley, Morio

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 662 (patched) > > > > > > The

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Dec. 22, 2018, 12:27 a.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4621 (patched) > > > > > > This is the

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 1405 (patched) > > > > > > I thought we were

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 662 (patched) > > > > > > The

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 816 (patched) > > > > > > Nit:

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 4621 (patched) > > > > > > This is the

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 2934 (patched) > > > > > > What is this extra

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 20, 2018, 2:46 p.m., Sergio Pena wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java > > Lines 220-221 (patched) > > > > > > These two

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 11:33 p.m., Morio Ramdenbourg wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java > > Lines 2458 (patched) > > > > > > This

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Dec. 19, 2018, 10:50 p.m.) Review request for hive, Adam Holley,

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 4:43 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 5235 (patched) > > > > > > Can we make

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

> On Dec. 19, 2018, 4:43 p.m., Karthik Manamcheri wrote: > > standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > > Lines 2956 (patched) > > > > > > All of this

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Dec. 19, 2018, 6:57 a.m.) Review request for hive, Peter Vary, Sergio

Re: Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- (Updated Dec. 19, 2018, 6:56 a.m.) Review request for hive, Peter Vary, Sergio

Review Request 69585: HIVE-20776: Run HMS filterHooks on server-side in addition to client-side

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69585/ --- Review request for hive, Peter Vary, Sergio Pena, and Vihang Karajgaonkar.

Re: Review Request 65985: HIVE-18783: ALTER TABLE post-commit listener does not include the transactional listener responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65985/#review199027 ---