Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

2021-07-26 Thread Panos Garefalakis
uot;Owen O'Malley" wrote: > > I can do the publishing. Thank you all! > > > > .. Owen > > > > On Fri, Jul 23, 2021 at 10:16 AM Panos Garefalakis > > wrote: > > > > > Thank you all for your help! With 3 binding votes this release passed! > >

Re: [VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

2021-07-23 Thread Panos Garefalakis
t; > > * Built and tested >> > > > > > > * Built hive main branch using it >> > > > > > > * Verified signatures and checksums >> > > > > > > >> > > > > > > It is too bad that we didn't get HIVE-251

[VOTE] Should we release Hive Storage API 2.8.0-rc0 ?

2021-06-21 Thread Panos Garefalakis
Hello all, Following on previous discussions, I would like to propose a new storage-api release including HIVE-24458 . Shall we release the following artifacts as Hive Storage API 2.8.0? tar: http://home.apache.org/~pgaref/hive-storage-2.8.0/

Re: [VOTE] Should we release Hive Storage API 2.7.3-rc0 ?

2021-06-21 Thread Panos Garefalakis
anka > wrote: > > > +1 (non binding) > > > > Built and verified unit tests > > Built and tested ORC > > Verified HIVE-24458 functionality and performance gains > > > > Regards, > > Pavan > > > > > > > On Jun 8, 2021, at 2:14 AM, Pan

[VOTE] Should we release Hive Storage API 2.7.3-rc0 ?

2021-06-08 Thread Panos Garefalakis
Hello all, I would like to propose a new storage-api release with HIVE-24458 in it (as discussed in a previous thead). Shall we release the following artifacts as Hive Storage API 2.7.3? tar: http://home.apache.org/~pgaref/hive-storage-2.7.3/

Re: Requesting a new storage release

2021-06-07 Thread Panos Garefalakis
Thanks for initiating this Pavan! Just sharing some context here: https://issues.apache.org/jira/browse/ORC-744 umbrella Jira introduces Lazy IO on Apache ORC with significant IO and CPU savings. In addition to the newly introduced vector filters, there is an effort to support SArgs to

Re: [EXTERNAL] Hive meetup

2021-02-24 Thread Panos Garefalakis
Great idea indeed! I wish we could make these somewhat regular. Seems like we already have a few of topics to discuss: * New testing infra * Iceberg integration * Release process However in one of the next ones we could have talks about particular features, integrations, improvements etc. Would

Re: Upgrade ORC to 1.6

2021-01-15 Thread Panos Garefalakis
the near future and release 1.6.7 officially to > depend upon? > > Regards, > Laszlo Bodor > > > Panos Garefalakis ezt írta (időpont: 2021. jan. 14., > Cs, 18:33): > >> Hello Hive team, >> >> I am happy to announce that as of today Apache HIve precom

Upgrade ORC to 1.6

2021-01-14 Thread Panos Garefalakis
Hello Hive team, I am happy to announce that as of today Apache HIve precommit tests with ORC-1.6.7 (snapshot) are passing on master branch! There were more than a few compatibility and bug fixes required to make the jump from 1.5 but the version upgrade actually enables (among other things):

Re: Apply for permission to edit Hive Wikipages

2020-08-13 Thread Panos Garefalakis
Hello Liquan, I believe @Ashutosh Chauhan or @Thejas Nair could help with this. Cheers, Panagiotis On Wed, Aug 12, 2020 at 8:45 PM Liquan Pei wrote: > My Apache Confluence ID is liquanpei. > > On Wed, Aug 12, 2020 at 10:43 AM Liquan Pei wrote: > > > Hi, > > > > I am applying for

Re: Building Hive on JDK11

2020-07-13 Thread Panos Garefalakis
st folks run on OpenJDK or Oracle. > > Thanks. > > On Mon, Jul 13, 2020 at 10:44 AM Panos Garefalakis > wrote: > > > Hey David, > > > > The current CI process is using a pre-populated docker image for running > > the tests: https://hub.docker.com/r/kgyrtkirk

Re: Building Hive on JDK11

2020-07-13 Thread Panos Garefalakis
Hey David, The current CI process is using a pre-populated docker image for running the tests: https://hub.docker.com/r/kgyrtkirk/hive-dev-box/tags The image is build based on the sources located here: https://github.com/kgyrtkirk/hive-dev-box/blob/master/tools/install_sdk.bash So I believe first

Re: Failed CI Jobs

2020-07-06 Thread Panos Garefalakis
Hey David, I had the same issue -- ended-up re-submitting the tests. I believe a new job was added recently scanning the apache/hive for active PRs (to avoid marking them stale). However, as there were too many active PRs most of the PR tests ended-up timing out. We should change that job to

Re: Reviewers and assignees of PRs

2020-06-18 Thread Panos Garefalakis
Hey Zoltan, Thanks for doing this! This is definitely a step towards the right direction. My only suggestion would be to make reviewing per package/label instead of files. This will make the process a bit more clear. I recently bumped into this GitHub action that lets you automatically label PRs

Re: Fix backslash escaping

2020-06-10 Thread Panos Garefalakis
Hey Max, Is there a ticket related to this PR? Please reopen the PR to trigger the tests so that people can take a look. Cheers, Panagiotis On Wed, Jun 10, 2020 at 8:47 PM Max Khon wrote: > Hello, > > Hive JDBC has serious issues with the backslash escaping, however this PR > has been

Re: Open old PRs

2020-06-01 Thread Panos Garefalakis
Same here, however, there are still ~ 430 PRs pending on master. Thanks Zoltan for this great initiative! Cheers, Panagiotis On Mon, Jun 1, 2020 at 2:33 PM David Mollitor wrote: > Thanks so much for the work on this. > > Just cleaned up mine. > > On Sat, May 30, 2020 at 10:16 AM Zoltan

[DISCUSS] Enable Github Autolink feature

2020-04-15 Thread Panos Garefalakis
Hello all, Github's autolink feature recognizes patterns like `HIVE-XXX` in commits or PRs and can automatically link to an issue tracking system like https://issues.apache.org/jira/browse/HIVE-XXX. It's already being used in a

Re: Review Request 72113: DML execution on TEZ always outputs the message 'No rows affected'

2020-02-14 Thread Panos Garefalakis via Review Board
in the query out are caused by the counters.findCounter() that initializes an empty counter when reading a non existent counter -- then all HIVE_COUNTERS are printed by PostExecTezSummaryPrinter - Panos Garefalakis On Feb. 13, 2020, 3:40 p.m., Attila Magyar wrote

Re: Review Request 71871: StringIndexOutOfBoundsException when getting sessionId from worker node name

2019-12-05 Thread Panos Garefalakis via Review Board
> On Dec. 5, 2019, 4:43 p.m., Panos Garefalakis wrote: > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java > > Lines 478 (patched) > > <https://reviews.apache.org/r/71871/diff/1/?file=2181935#file2181935line478> > > > > H

Re: Review Request 71871: StringIndexOutOfBoundsException when getting sessionId from worker node name

2019-12-05 Thread Panos Garefalakis via Review Board
this operation you would place the **nodeName.length() > workerNodePrefix.length()** check on the left part of the expression. - Panos Garefalakis On Dec. 4, 2019, 11:05 a.m., Attila Magyar wrote: > > --- > This is an auto

Re: Review Request 71845: ConcurrentModificationException in TriggerValidatorRunnable stops trigger processing

2019-12-02 Thread Panos Garefalakis via Review Board
> On Dec. 2, 2019, 12:43 p.m., Panos Garefalakis wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > > Line 533 (original), 533 (patched) > > <https://reviews.apache.org/r/71845/diff/1/?file=2180361#file2180361line533

Re: Review Request 71845: ConcurrentModificationException in TriggerValidatorRunnable stops trigger processing

2019-12-02 Thread Panos Garefalakis via Review Board
edList? - Panos Garefalakis On Nov. 29, 2019, 9:57 a.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Panos Garefalakis via Review Board
> On Nov. 19, 2019, 10:24 p.m., Panos Garefalakis wrote: > > ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java > > Lines 192 (patched) > > <https://reviews.apache.org/r/71784/diff/1/?file=2173907#file2173907line193> > > > > The solut

Re: Review Request 71784: HiveProtoLoggingHook might leak memory

2019-11-19 Thread Panos Garefalakis via Review Board
s used to track all protobuf messages right? Is it acceptable to drop messages here? - Panos Garefalakis On Nov. 19, 2019, 3:43 p.m., Attila Magyar wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 71707: Performance degradation on single row inserts

2019-11-05 Thread Panos Garefalakis via Review Board
> On Nov. 5, 2019, 4:33 p.m., Panos Garefalakis wrote: > > standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/utils/FileUtils.java > > Lines 328 (patched) > > <https://reviews.apache.org/r/71707/diff/2/?file=2171542#file2171542line335

Re: Review Request 71707: Performance degradation on single row inserts

2019-11-05 Thread Panos Garefalakis via Review Board
t make sense to have hdfs a the base case and others separately? and maybe throw a warn message here when the filesystem is not supported? - Panos Garefalakis On Nov. 5, 2019, 3:32 p.m., Attila Magyar wrote: > > --- > This is a