[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637847#comment-13637847
]
Phabricator commented on HIVE-2340:
---
njain has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13637860#comment-13637860
]
Phabricator commented on HIVE-2340:
---
njain has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13635314#comment-13635314
]
Phabricator commented on HIVE-2340:
---
njain has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13636073#comment-13636073
]
Phabricator commented on HIVE-2340:
---
navis has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626434#comment-13626434
]
Hudson commented on HIVE-2340:
--
Integrated in Hive-trunk-hadoop2 #147 (See
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626937#comment-13626937
]
Hudson commented on HIVE-2340:
--
Integrated in Hive-trunk-h0.21 #2053 (See
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624794#comment-13624794
]
Navis commented on HIVE-2340:
-
When auto.convert.join is true(default for now), RSDedup cannot
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624938#comment-13624938
]
Ashutosh Chauhan commented on HIVE-2340:
Also, HIVE-4302 is resolved now, so
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624131#comment-13624131
]
Harish Butani commented on HIVE-2340:
-
The problem with PTF is in plan generation. In
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13624314#comment-13624314
]
Ashutosh Chauhan commented on HIVE-2340:
Following tests failed on latest patch:
*
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621953#comment-13621953
]
Navis commented on HIVE-2340:
-
I think CP for PTF is broken. Especially for single sourced
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622473#comment-13622473
]
Ashutosh Chauhan commented on HIVE-2340:
[~navis] I am not sure which test case you
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622927#comment-13622927
]
Navis commented on HIVE-2340:
-
CP for RS is correctly modifies schema of RS, and it makes CP
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13622946#comment-13622946
]
Ashutosh Chauhan commented on HIVE-2340:
In PTF handling we do keep a copy of
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623113#comment-13623113
]
Navis commented on HIVE-2340:
-
Got it. I've updated patch (added small comment on this).
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13623262#comment-13623262
]
Ashutosh Chauhan commented on HIVE-2340:
Cool. Running test on latest patch. Will
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621675#comment-13621675
]
Gunther Hagleitner commented on HIVE-2340:
--
[~navis]: The patch doesn't apply
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621677#comment-13621677
]
Ashutosh Chauhan commented on HIVE-2340:
Would love to see this make it in 0.11.
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13621819#comment-13621819
]
Navis commented on HIVE-2340:
-
[~hagleitn] Thanks. I'll check that.
optimize
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600413#comment-13600413
]
Gunther Hagleitner commented on HIVE-2340:
--
Ran unit tests as well. All passed.
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13600482#comment-13600482
]
Phabricator commented on HIVE-2340:
---
hagleitn has accepted the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591995#comment-13591995
]
Gunther Hagleitner commented on HIVE-2340:
--
[~navis]: I've tried the latest patch
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591997#comment-13591997
]
Gunther Hagleitner commented on HIVE-2340:
--
HIVE-2340.14.patch that is.
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13592046#comment-13592046
]
Navis commented on HIVE-2340:
-
[~hagleitn]: It seemed affected by HIVE-948, which is recently
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576309#comment-13576309
]
Navis commented on HIVE-2340:
-
[~hagleitn]: Thanks for your help.
Tests are failed by
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576337#comment-13576337
]
Gunther Hagleitner commented on HIVE-2340:
--
[~navis]: Are you suggesting to just
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13576343#comment-13576343
]
Navis commented on HIVE-2340:
-
[~hagleitn]: Yes, it was HIVE-2339 and I'm not sure that it's
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13574224#comment-13574224
]
Gunther Hagleitner commented on HIVE-2340:
--
[~navis]: Disabling the join merge
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572273#comment-13572273
]
Phabricator commented on HIVE-2340:
---
navis has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571130#comment-13571130
]
Gunther Hagleitner commented on HIVE-2340:
--
Ah, that's good info. Makes sense now.
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571168#comment-13571168
]
Phabricator commented on HIVE-2340:
---
njain has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13571177#comment-13571177
]
Phabricator commented on HIVE-2340:
---
njain has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13572126#comment-13572126
]
Phabricator commented on HIVE-2340:
---
hagleitn has commented on the revision HIVE-2340
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570645#comment-13570645
]
Gunther Hagleitner commented on HIVE-2340:
--
[~navis]: I think in general the logic
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570813#comment-13570813
]
Navis commented on HIVE-2340:
-
@Gunther Hagleitner: I also considered ratio thing, but number
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568361#comment-13568361
]
Navis commented on HIVE-2340:
-
@Gunther Hagleitner,
This optimization copies configuration of
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13568466#comment-13568466
]
Phabricator commented on HIVE-2340:
---
navis has commented on the revision HIVE-2340 [jira]
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566810#comment-13566810
]
Gunther Hagleitner commented on HIVE-2340:
--
FYI: Ran all unit tests on patch .9.
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566898#comment-13566898
]
Phabricator commented on HIVE-2340:
---
hagleitn has commented on the revision HIVE-2340
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13566902#comment-13566902
]
Gunther Hagleitner commented on HIVE-2340:
--
Partial review on phabricator. Biggest
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13559914#comment-13559914
]
Ashutosh Chauhan commented on HIVE-2340:
Thanks, Navis for updating the patch. I
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560424#comment-13560424
]
Navis commented on HIVE-2340:
-
These are not removed but just merged with other rules. For
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556513#comment-13556513
]
Ashutosh Chauhan commented on HIVE-2340:
Yeah, correct JOIN-GBY and GBY-GBY are
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556608#comment-13556608
]
Yin Huai commented on HIVE-2340:
Let me explain the reason that I introduced the fake RS
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556620#comment-13556620
]
Yin Huai commented on HIVE-2340:
The current implementation of the patch of YSmart covers
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556651#comment-13556651
]
Ashutosh Chauhan commented on HIVE-2340:
Thanks Yin for explaining. Your ASCII art
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13556660#comment-13556660
]
Yin Huai commented on HIVE-2340:
Yes, I agree.
optimize orderby followed
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1373#comment-1373
]
Ashutosh Chauhan commented on HIVE-2340:
[~navis] I played with HIVE-2206 over last
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13555803#comment-13555803
]
Yin Huai commented on HIVE-2340:
[~ashutoshc] Can you let me know cases of JOIN-GROUPBY and
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13541214#comment-13541214
]
Navis commented on HIVE-2340:
-
@Ashutosh
I've abandoned working on this cause HIVE-2206 is
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13163523#comment-13163523
]
jirapos...@reviews.apache.org commented on HIVE-2340:
-
[
https://issues.apache.org/jira/browse/HIVE-2340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13162689#comment-13162689
]
Navis commented on HIVE-2340:
-
https://reviews.apache.org/r/2991/
optimize
52 matches
Mail list logo