Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Carl Steinbach
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote: > > LICENSE, line 421 > > > > > > Please replace with the license text from CVS. > > Prasad Mujumdar wrote: > I am still not fully convinced that copying the CVS

Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Prasad Mujumdar
> On June 18, 2012, 7:36 p.m., Carl Steinbach wrote: > > I think it's important to get local mode working and also put a Java > > wrapper in place before committing this. ok. I will make changes and update the patch. > On June 18, 2012, 7:36 p.m., Carl Steinbach wrote: > > LICENSE, line 421 >

Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/#review8349 --- One more request: Can you add an Eclipse launch configuration similar

Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/#review8346 --- I think it's important to get local mode working and also put a Java w

Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Carl Steinbach
> On June 18, 2012, 6:01 p.m., Prasad Mujumdar wrote: > > LICENSE, line 421 > > > > > > This is the text posted on the SQLLine site site from where the hive > > build is downloading the jar. Since we are not using the

Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/ --- (Updated June 18, 2012, 6:19 p.m.) Review request for hive and Carl Steinbach.

Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/#review8331 --- LICENSE This i

Re: Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-18 Thread Carl Steinbach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/#review8321 --- LICENSE This i

Review Request: HIVE-3100: Integrate SQLLine command line editor

2012-06-17 Thread Prasad Mujumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5381/ --- Review request for hive and Carl Steinbach. Description --- The patch is to