Re: Review Request 37778: HIVE-11634

2015-11-02 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review104741 --- Ship it! - John Pullokkaran On Oct. 29, 2015, 11:32 p.m., Hari S

Re: Review Request 37778: HIVE-11634

2015-11-02 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review104740 --- Ship it! Ship It! - John Pullokkaran On Oct. 29, 2015, 11:32 p.

Re: Review Request 37778: HIVE-11634

2015-10-29 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review104502 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSe

Re: Review Request 37778: HIVE-11634

2015-10-29 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 29, 2015, 11:32 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 37778: HIVE-11634

2015-10-28 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 28, 2015, 10:48 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 37778: HIVE-11634

2015-10-26 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 26, 2015, 1:55 p.m.) Review request for hive, Ashutosh Chauhan, J

Re: Review Request 37778: HIVE-11634

2015-10-12 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 12, 2015, 10:52 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 37778: HIVE-11634

2015-10-11 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review102185 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSe

Re: Review Request 37778: HIVE-11634

2015-10-08 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 8, 2015, 5:26 p.m.) Review request for hive, Ashutosh Chauhan, Je

Re: Review Request 37778: HIVE-11634

2015-10-07 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review101840 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFac

Re: Review Request 37778: HIVE-11634

2015-10-07 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 7, 2015, 10:57 p.m.) Review request for hive, Ashutosh Chauhan, J

Re: Review Request 37778: HIVE-11634

2015-10-07 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review101814 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFac

Re: Review Request 37778: HIVE-11634

2015-10-07 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review101810 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFac

Re: Review Request 37778: HIVE-11634

2015-10-07 Thread Hari Sankar Sivarama Subramaniyan
> On Oct. 7, 2015, 6:21 p.m., John Pullokkaran wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFactory.java, > > line 377 > > > > > > 1. We shouldn't remove non deterministic UDFs. > >

Re: Review Request 37778: HIVE-11634

2015-10-07 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 7, 2015, 7:47 p.m.) Review request for hive, Ashutosh Chauhan, Je

Re: Review Request 37778: HIVE-11634

2015-10-07 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review101804 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFac

Re: Review Request 37778: HIVE-11634

2015-10-01 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review101292 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/pcr/PcrExprProcFac

Re: Review Request 37778: HIVE-11634

2015-10-01 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Oct. 1, 2015, 11:42 p.m.) Review request for hive, Ashutosh Chauhan, J

Re: Review Request 37778: HIVE-11634

2015-09-17 Thread Jesús Camacho Rodríguez
> On Sept. 17, 2015, 6:05 p.m., Jesús Camacho Rodríguez wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSeparator.java, > > line 276 > > > > > > Could we add an exit condition if all alias

Re: Review Request 37778: HIVE-11634

2015-09-17 Thread Jesús Camacho Rodríguez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review99389 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSep

Re: Review Request 37778: HIVE-11634

2015-09-10 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Sept. 10, 2015, 6:40 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 37778: HIVE-11634

2015-09-10 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Sept. 10, 2015, 5:29 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 37778: HIVE-11634

2015-09-04 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review97820 --- ql/src/test/queries/clientpositive/pcs.q (line 12)

Re: Review Request 37778: HIVE-11634

2015-09-04 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review97819 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSep

Re: Review Request 37778: HIVE-11634

2015-09-04 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review97818 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSep

Re: Review Request 37778: HIVE-11634

2015-09-04 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review97816 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/PartitionColumnsSep

Re: Review Request 37778: HIVE-11634

2015-09-04 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review97806 --- ql/src/java/org/apache/hadoop/hive/ql/optimizer/Optimizer.java (lin

Re: Review Request 37778: HIVE-11634

2015-09-04 Thread John Pullokkaran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/#review97804 --- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 119

Re: Review Request 37778: HIVE-11634

2015-09-03 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Sept. 3, 2015, 6:06 p.m.) Review request for hive, Ashutosh Chauhan, J

Re: Review Request 37778: HIVE-11634

2015-08-27 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Aug. 27, 2015, 10:30 p.m.) Review request for hive, Ashutosh Chauhan,

Re: Review Request 37778: HIVE-11634

2015-08-26 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- (Updated Aug. 26, 2015, 8:22 p.m.) Review request for hive, Ashutosh Chauhan, J

Review Request 37778: HIVE-11634

2015-08-25 Thread Hari Sankar Sivarama Subramaniyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37778/ --- Review request for hive, Ashutosh Chauhan, Jesús Camacho Rodríguez, and John Pul