Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review138763 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1992)

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote: > > I modified some codes in the latest patch. > On 6月 18, 2016, 12:21 a.m., Thejas Nair wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 57 > >

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 6月 21, 2016, 2:10 a.m.) Review request for hive. Changes --- I

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review138347 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 6月 3, 2016, 5:50 p.m., Vaibhav Gumashta wrote: > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcWithMiniHA.java, > > line 157 > > > > > > Can you add a test with a join query as well? The join

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 6月 15, 2016, 6:50 a.m.) Review request for hive. Changes --- I

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review136073 ---

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 5月 18, 2016, 9:54 a.m.) Review request for hive. Changes --- I

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 4月 22, 2016, 1:33 a.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 565 > > > > > > nit: is it enough to just use Arrays.asList? That's right. I will use just

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review130014 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 4月 15, 2016, 11:38 a.m.) Review request for hive. Changes ---

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review124234 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 3月 18, 2016, 5:57 p.m., Sergey Shelukhin wrote: > > Thanks for the reviewing. > On 3月 18, 2016, 5:57 p.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 210 > > >

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 3月 16, 2016, 8:51 a.m.) Review request for hive. Changes ---

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On Feb. 3, 2016, 10:41 p.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 530 > > > > > > actually, do we expect more than one file here, should we handle this > >

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 2月 3, 2016, 9:32 a.m.) Review request for hive. Changes ---

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review117680 --- ql/src/java/org/apache/hadoop/hive/ql/Driver.java (line 1870)

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review117697 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 1月 14, 2016, 5:36 p.m., Prasad Mujumdar wrote: > > service/if/TCLIService.thrift, line 272 > > > > > > Does it need to be a required parameter ? Adding a new required > > parameter in the middle will make it

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On Jan. 14, 2016, 5:36 p.m., Prasad Mujumdar wrote: > > service/if/TCLIService.thrift, line 272 > > > > > > Does it need to be a required parameter ? Adding a new required > > parameter in the middle will make it

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 1月 25, 2016, 9:25 a.m.) Review request for hive. Changes ---

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review114504 --- My apologies for jumping in late in the review I am curious about

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 1月 13, 2016, 11:54 p.m., Sergey Shelukhin wrote: > > service/if/TCLIService.thrift, line 271 > > > > > > is it possible to avoid changing field IDs? I think backward compat > > might depend on them. Field

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 1月 14, 2016, 5:36 p.m., Prasad Mujumdar wrote: > > My apologies for jumping in late in the review > > > > I am curious about why you chose HiveServer2 interface to implement this. I > > guess one can work it around by 'INSERT OVERWRITE DIRECTORY .. SELECT ..' > > and so one of the

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review114334 --- service/if/TCLIService.thrift (line 271)

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 1月 8, 2016, 7:18 a.m.) Review request for hive. Changes ---

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 1月 5, 2016, 8:15 a.m.) Review request for hive. Changes --- I

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review111316 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On Dec. 3, 2015, 9:40 p.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 390 > > > > > > some existing configuration is probably needed (and better) > > Takanobu

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- (Updated 12月 18, 2015, 7:13 a.m.) Review request for hive. Changes ---

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On Dec. 3, 2015, 9:48 p.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 509 > > > > > > please log instead > > Takanobu Asanuma wrote: > Like this? >

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 12月 3, 2015, 9:48 p.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 481 > > > > > > this seems similar with the code in SQLOperation, perhaps they can be > >

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

> On 12月 3, 2015, 9:40 p.m., Sergey Shelukhin wrote: > > jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java, line 390 > > > > > > some existing configuration is probably needed (and better) IIUC, hive

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review108891 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Re: Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/#review108889 --- jdbc/src/java/org/apache/hive/jdbc/HiveQueryResultSet.java (line

Review Request 40867: HIVE-11527 - bypass HiveServer2 thrift interface for query results

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40867/ --- Review request for hive. Repository: hive-git Description --- This is a