Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Aihua Xu
> On Oct. 14, 2016, 3:38 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 123 > > > > > > I verified against derby and it works fine. > > > > Let me verify other

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152688 --- beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (lin

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Chaoyu Tang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152686 --- beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java (lin

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Aihua Xu
> On Oct. 14, 2016, 2:18 p.m., Yongzhi Chen wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java, line 231 > > > > > > Is that possible a command has more than one lines? Yes. It's possible. Hiv

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Yongzhi Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152674 --- beeline/src/java/org/apache/hive/beeline/HiveSchemaHelper.java (l

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Aihua Xu
> On Oct. 13, 2016, 8:42 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 289 > > > > > > Yeah. I thought about changing the error. But we are committing one > > script fi

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-14 Thread Peter Vary
> On Oct. 13, 2016, 8:42 p.m., Aihua Xu wrote: > > beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java, line 289 > > > > > > Yeah. I thought about changing the error. But we are committing one > > script fi

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-13 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/ --- (Updated Oct. 13, 2016, 8:43 p.m.) Review request for hive. Changes ---

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-13 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152574 --- beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java

Re: Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-13 Thread Peter Vary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/#review152518 --- Thanks Aihua for your patch. Only some nits, and questions. Thank

Review Request 52835: HIVE-14926: Keep Schema in consistent state where schemaTool fails or succeeds

2016-10-13 Thread Aihua Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52835/ --- Review request for hive. Repository: hive-git Description --- HIVE-14926