Patch for implementing ap_document_root as a hook

2007-04-23 Thread Jakob Goldbach
Hi, Attached is a patch which implements ap_document_root(r) as a hook. This way modules can set document_root on the fly. (think vhost_alias) AND get the right DOCUMENT_ROOT env. variable (as set by ap_add_common_vars(r)). The patch also changes ap_core_translate to use ap_document_root(r) inst

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Jakob Goldbach
It is now in bugzilla as #42192 /Jakob

Re: DO NOT REPLY [Bug 42192] - Implementing ap_document_root as a hook

2007-04-23 Thread William A. Rowe, Jr.
[EMAIL PROTECTED] wrote: > > --- Additional Comments From [EMAIL PROTECTED] 2007-04-23 01:38 --- > This patch changes the semantics of an existing API, so it'll randomly break > things. That's a no-no. On what planet? We can break things in 2.3 for 2.4 or 3.0. Breakage is good. (I ha

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread William A. Rowe, Jr.
Jakob Goldbach wrote: > Hi, > > Attached is a patch which implements ap_document_root(r) as a hook. > This way modules can set document_root on the fly. (think vhost_alias) > AND get the right DOCUMENT_ROOT env. variable (as set by > ap_add_common_vars(r)). > > The patch also changes ap_core_tran

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Jakob Goldbach
-1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The problem is not really doing the translation. I can always provide my own translate handler in my module. But in t

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Brian J. France
On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The problem is not really doing the translation. I can always

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Paul Querna
Brian J. France wrote: On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. I thought map_to_storage was made to do per-dir configuration. Not path-translation. The problem is not really doing the tr

Re: [mod_wombat] Bug (and patch!) Tracking Logistics

2007-04-23 Thread Brian McCallister
On Apr 22, 2007, at 4:52 PM, Sander Temme wrote: On Apr 22, 2007, at 2:00 PM, Brian McCallister wrote: Should I pester folks to create a new httpd component in bugzilla (mod_wombat) or just track issues and patches as a separate project (and hence pester folks to set that up)? I'd favor a

Re: bug with Apache 1.3 NetWare build system

2007-04-23 Thread Brad Nicholes
>>> On 4/19/2007 at 11:36 AM, in message <[EMAIL PROTECTED]>, Guenter Knauf <[EMAIL PROTECTED]> wrote: > Hi Brad, > I've just found that we have same bug in the AP13 build system as what I > fixed long time ago with the AP2x build system already; in each > NWGNUmakefile.mak you can read: > # > #

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Akins, Brian
On 4/23/07 11:33 AM, "Paul Querna" <[EMAIL PROTECTED]> wrote: > +1, I've been down this road before too. +1 on the concept. Still looking at patch. -- Brian Akins Chief Operations Engineer Turner Digital Media Technologies

Re: Fixed: Truncated uploads in mod_perl 1 from FF2.0/Win

2007-04-23 Thread Issac Goldstand
Random autoconf question before I go ahead with this... I'm staging on ubuntu-server-64 (6.06), and autoconf isn't generating a depcomp file. This is in the current MANIFEST so I can't roll without it (or removing it from the MANIFEST). I can build nicely without it, so my plan is to remove it f

[RELEASE CANDIDATE] libapreq 1.34-RC1

2007-04-23 Thread Issac Goldstand
The apreq developers are planning a maintenance release of libapreq1. This version primarily addresses an issue noted with FireFox 2.0 truncating file uploads in SSL mode. Please give the tarball at http://people.apache.org/~issac/libapreq-1.34-RC1.tar.gz a try and report comments/problems/etc.

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread William A. Rowe, Jr.
Brian J. France wrote: > > On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: > >>> -1 on the face of things. The map_to_storage hook was added to >>> accomplish what you desire. >> >> I thought map_to_storage was made to do per-dir configuration. Not >> path-translation. Actually it does both

RFC: replace r->subprocess_env was Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread Akins, Brian
This idea has been rattling around in my head off and on for a while. What is we replaced all the r->subprocess_env with something a little more interesting... General "environment" API: /* "directly" set an env variable. Will always show up in env list */ apr_status_t ap_set_env(request_rec *r,

Re: Patch for implementing ap_document_root as a hook

2007-04-23 Thread William A. Rowe, Jr.
William A. Rowe, Jr. wrote: > Brian J. France wrote: >> On Apr 23, 2007, at 10:32 AM, Jakob Goldbach wrote: >> -1 on the face of things. The map_to_storage hook was added to accomplish what you desire. >>> I thought map_to_storage was made to do per-dir configuration. Not >>> path-transl