Fwd: Re: exports break even but not equal...

2012-08-09 Thread Guenter Knauf
Hi all, below a post I received from NormW where he was on some awk export script hacking, and found these in-consistencies ... Original-Nachricht Seems the header should change: http_log.h In httpd-trunk: From ap_config.h: * @note AP_DECLARE_DATA extern type

Fix for Windows bug#52476

2012-08-09 Thread Claudio Caldato (MS OPEN TECH)
Please code review the fix and let me know if you find any issue. Attached is the proposed patch for server\mpm\winnt\child.c Summary for code reviewers: If AcceptFilter is 'connect' or 'none', we read data from socket on worker thread. We use blocking recv and assign context-overlapped.Pointer

RE: Fix for Windows bug#52476

2012-08-09 Thread Claudio Caldato (MS OPEN TECH)
Better patch, fixed minor issue after another code review. Thanks Claudio From: Claudio Caldato (MS OPEN TECH) [mailto:claud...@microsoft.com] Sent: Thursday, August 9, 2012 11:13 AM To: dev@httpd.apache.org Subject: Fix for Windows bug#52476 Please code review the fix and let me know if you

Re: Fix for Windows bug#52476

2012-08-09 Thread Jeff Trawick
On Thu, Aug 9, 2012 at 2:26 PM, Claudio Caldato (MS OPEN TECH) claud...@microsoft.com wrote: Better patch, fixed minor issue after another code review. I tested and seemed to get good results, but my testing isn't reproducible enough with/without various patches to be conclusive. A couple of

Re: Fix for Windows bug#52476

2012-08-09 Thread Jeff Trawick
On Thu, Aug 9, 2012 at 3:52 PM, Jeff Trawick traw...@gmail.com wrote: On Thu, Aug 9, 2012 at 2:26 PM, Claudio Caldato (MS OPEN TECH) claud...@microsoft.com wrote: Better patch, fixed minor issue after another code review. I tested and seemed to get good results, but my testing isn't

[PATCH] does ab actually work over SSL for anyone?

2012-08-09 Thread Jeff Trawick
Index: support/ab.c === --- support/ab.c(revision 1370289) +++ support/ab.c(working copy) @@ -1347,11 +1347,21 @@ good++; close_connection(c); } +else if

Re: Fix for Windows bug#52476

2012-08-09 Thread Jeff Trawick
On Thu, Aug 9, 2012 at 4:28 PM, Jeff Trawick traw...@gmail.com wrote: On Thu, Aug 9, 2012 at 3:52 PM, Jeff Trawick traw...@gmail.com wrote: On Thu, Aug 9, 2012 at 2:26 PM, Claudio Caldato (MS OPEN TECH) claud...@microsoft.com wrote: Better patch, fixed minor issue after another code review.

Re: Fix for Windows bug#52476

2012-08-09 Thread Jeff Trawick
On Thu, Aug 9, 2012 at 5:50 PM, Jeff Trawick traw...@gmail.com wrote: On Thu, Aug 9, 2012 at 4:28 PM, Jeff Trawick traw...@gmail.com wrote: On Thu, Aug 9, 2012 at 3:52 PM, Jeff Trawick traw...@gmail.com wrote: On Thu, Aug 9, 2012 at 2:26 PM, Claudio Caldato (MS OPEN TECH)

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-09 Thread William A. Rowe Jr.
On 8/8/2012 9:03 AM, Joe Orton wrote: On Wed, Aug 08, 2012 at 08:00:25AM +0200, Kaspar Brand wrote: My thinking was that people should explicitly tell configure that they want to link with the libs in a build directory (so that they don't accidentally use a directory which might only

Re: Linking mod_ssl with a specific OpenSSL version

2012-08-09 Thread William A. Rowe Jr.
On 8/8/2012 8:56 PM, Ben Laurie wrote: On Wed, Aug 8, 2012 at 5:03 PM, Joe Orton jor...@redhat.com wrote: On Wed, Aug 08, 2012 at 08:00:25AM +0200, Kaspar Brand wrote: My thinking was that people should explicitly tell configure that they want to link with the libs in a build directory (so

Re: Fix for Windows bug#52476

2012-08-09 Thread William A. Rowe Jr.
On 8/9/2012 11:26 AM, Claudio Caldato (MS OPEN TECH) wrote: Better patch, fixed minor issue after another code review. Sadly, it won't fix the defect. Yes, you are successfullly performing a blocking initial read. And the pipe remains unblocked for the rest of the connection, so any further

Re: Linking mod_ssl with a specific OpenSSL version (Re: svn commit: r1358167 - in /httpd/httpd/trunk: acinclude.m4 modules/ssl/ssl_engine_init.c)

2012-08-09 Thread William A. Rowe Jr.
On 8/8/2012 4:45 AM, Ben Laurie wrote: On Wed, Aug 8, 2012 at 2:47 AM, Guenter Knauf fua...@apache.org wrote: Am 08.08.2012 07:39, schrieb Kaspar Brand: On 06.08.2012 22:08, William A. Rowe Jr. wrote: On 8/5/2012 10:10 PM, Kaspar Brand wrote: On 05.08.2012 14:38, Guenter Knauf wrote: Am