Re: fate of mod_lbmethod_rr (was: Re: [VOTE] Release Apache httpd 2.4.19 as GA)

On Tue, Mar 22, 2016 at 4:15 PM, Jeff Trawick wrote: > On Tue, Mar 22, 2016 at 5:03 PM, William A Rowe Jr > wrote: > >> On Tue, Mar 22, 2016 at 3:38 PM, Jeff Trawick wrote: >> >>> On Tue, Mar 22, 2016 at 3:55 PM, William A Rowe Jr

Re: svn commit: r1736216 - in /httpd/httpd/trunk: include/httpd.h modules/http/http_request.c server/mpm/event/event.c server/mpm/motorz/motorz.c server/mpm/simple/simple_io.c server/util_filter.c

On 22 Mar 2016, at 7:08 PM, yla...@apache.org wrote: > URL: http://svn.apache.org/viewvc?rev=1736216=rev > Log: > Follow up to r1734656: restore c->data_in_input_filters usage to > see if it helps unblocking test framework. I created an almost identical patch before doing an update, the only

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

I've had success with Jeff's minimalist nghttp build schema. A larger effort at a cmake for the full stack (lib+apps) has been in the works for a month or two now, haven't had a chance to try it. On Mar 22, 2016 6:27 PM, "Jan Ehrhardt" wrote: > Jeff Trawick in

Re: TLS session ticket key (shared) renewal

Am 23.03.2016 um 00:30 schrieb Paul Querna: On Tue, Mar 22, 2016 at 3:32 PM, Yann Ylavic > wrote: On Tue, Mar 22, 2016 at 4:18 PM, Paul Querna > wrote: > My thought was to add support for

Re: TLS session ticket key (shared) renewal

On Tue, Mar 22, 2016 at 3:32 PM, Yann Ylavic wrote: > On Tue, Mar 22, 2016 at 4:18 PM, Paul Querna wrote: > > My thought was to add support for either multiple files, or multiple > values > > in the existing `SSLSessionTicketKeyFile`. Then add support to

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

Jeff Trawick in gmane.comp.apache.devel (Tue, 22 Mar 2016 18:11:59 -0400): >What version of nghttp2 are you using? I always use git head of nghttp2. So that is > v1.8.0 ATM >Are you using the cmake build for httpd? No. I open the *.dsw / *.dsp in with VC9 / VC11, after applying these

Re: About the relevance of bitfields usage (was: fate of mod_lbmethod_rr...)

On Tue, Mar 22, 2016 at 5:08 PM, Yann Ylavic wrote: > > > Common sense tells me that alignment should be preserved, but unless we > can > > trust the spec to ensure that assumption, we should err on the side of > > caution. > > So let's not use bitfields, there are other

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

On Tue, Mar 22, 2016 at 6:37 PM, Jeff Trawick wrote: > On Tue, Mar 22, 2016 at 6:31 PM, Jacob Champion > wrote: > >> On 03/22/2016 03:11 PM, Jeff Trawick wrote: >> > What version of nghttp2 are you using? >> > Are you using the cmake build for httpd? >>

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

On Tue, Mar 22, 2016 at 6:31 PM, Jacob Champion wrote: > On 03/22/2016 03:11 PM, Jeff Trawick wrote: > > What version of nghttp2 are you using? > > Are you using the cmake build for httpd? > > I'm not currently in Windows to be able to check for sure, but I > *believe* I'm

Re: TLS session ticket key (shared) renewal

On Tue, Mar 22, 2016 at 4:18 PM, Paul Querna wrote: > My thought was to add support for either multiple files, or multiple values > in the existing `SSLSessionTicketKeyFile`. Then add support to decrypt from > any of the known keys, and have a setting (or the first loaded key)

Re: Need hints from those building mod_http2 and mod_proxy_http2 on Windows

On 03/22/2016 03:11 PM, Jeff Trawick wrote: > What version of nghttp2 are you using? > Are you using the cmake build for httpd? I'm not currently in Windows to be able to check for sure, but I *believe* I'm running nghttp2 1.8.0. > FWIW I just found that I needed nghttp2 >= 1.4.0 on Windows to

Need hints from those building mod_http2 and mod_proxy_http2 on Windows

What version of nghttp2 are you using? Are you using the cmake build for httpd? FWIW I just found that I needed nghttp2 >= 1.4.0 on Windows to fix bad linkage in nghttp2 functions that mod_http2 didn't use when I built before. (not related to cmake) After resolving that I now see a bunch of

Re: About the relevance of bitfields usage (was: fate of mod_lbmethod_rr...)

On Tue, Mar 22, 2016 at 10:50 PM, William A Rowe Jr wrote: > I still can't find anything in the spec that suggests that extending these > is assured to maintain bitwise alignment. Indeed there is none, that's why users should not depend on it, IMHO. > > That said, we can,

Re: About the relevance of bitfields usage (was: fate of mod_lbmethod_rr...)

I still can't find anything in the spec that suggests that extending these is assured to maintain bitwise alignment. That said, we can, provided we add an aligned break between them. That might mean introducing an interview flag, followed by a new series of bitwise flags between, for example,

About the relevance of bitfields usage (was: fate of mod_lbmethod_rr...)

... if we cannot extend them. On Tue, Mar 22, 2016 at 10:03 PM, William A Rowe Jr wrote: > > If devs want to promote an API and then continuously break ABI on trunk, > I'm way beyond arguing with such individuals. Just a few choice examples > which had necessitated major

Re: fate of mod_lbmethod_rr (was: Re: [VOTE] Release Apache httpd 2.4.19 as GA)

On Tue, Mar 22, 2016 at 5:03 PM, William A Rowe Jr wrote: > On Tue, Mar 22, 2016 at 3:38 PM, Jeff Trawick wrote: > >> On Tue, Mar 22, 2016 at 3:55 PM, William A Rowe Jr >> wrote: >> >>> Can anyone get mod_lbmethod_rr.c to build? >>>

Re: [VOTE] Release Apache httpd 2.4.19 as GA

On Tue, Mar 22, 2016 at 3:38 PM, Jeff Trawick wrote: > On Tue, Mar 22, 2016 at 3:55 PM, William A Rowe Jr > wrote: > >> Can anyone get mod_lbmethod_rr.c to build? >> > > That's funny actually. The very first version README.cmake in trunk says > that

Re: svn commit: r1736242 - /httpd/httpd/branches/2.4.x/modules/proxy/examples/mod_lbmethod_rr.dsp

I think the argument will quickly become moot... see other thread. I also don't expect we will persist .dsp on trunk for very much longer, /shrug On Tue, Mar 22, 2016 at 3:56 PM, Yann Ylavic wrote: > On Tue, Mar 22, 2016 at 9:00 PM, wrote: > > Author:

fate of mod_lbmethod_rr (was: Re: [VOTE] Release Apache httpd 2.4.19 as GA)

On Tue, Mar 22, 2016 at 3:38 PM, Jeff Trawick wrote: > On Tue, Mar 22, 2016 at 3:55 PM, William A Rowe Jr > wrote: > >> Can anyone get mod_lbmethod_rr.c to build? >> > > That's funny actually. The very first version README.cmake in trunk says > that

Re: svn commit: r1736251 - in /httpd/httpd/branches/2.4.x: ./ modules/http2/h2_filter.c

Thanks, Yann. > Am 22.03.2016 um 21:48 schrieb yla...@apache.org: > > Author: ylavic > Date: Tue Mar 22 20:48:47 2016 > New Revision: 1736251 > > URL: http://svn.apache.org/viewvc?rev=1736251=rev > Log: > Merge r1736250 from trunk: > > mod_http2: no variadic macro in C89, use equivalent

Re: svn commit: r1736243 - /httpd/httpd/trunk/modules/cache/mod_socache_shmcb.c

+1 > Am 22.03.2016 um 21:55 schrieb Yann Ylavic : > >> On Tue, Mar 22, 2016 at 9:09 PM, William A Rowe Jr >> wrote: >> Without objection, I'll be committing the backport in an hr or so for the >> morning T this hardly seems to merit a vote, but any

Re: svn commit: r1736242 - /httpd/httpd/branches/2.4.x/modules/proxy/examples/mod_lbmethod_rr.dsp

On Tue, Mar 22, 2016 at 9:00 PM, wrote: > Author: wrowe > Date: Tue Mar 22 20:00:08 2016 > New Revision: 1736242 > > URL: http://svn.apache.org/viewvc?rev=1736242=rev > Log: > Ensure we pick up modules/proxy/*.h headers > > Modified: >

Re: svn commit: r1736243 - /httpd/httpd/trunk/modules/cache/mod_socache_shmcb.c

On Tue, Mar 22, 2016 at 9:09 PM, William A Rowe Jr wrote: > Without objection, I'll be committing the backport in an hr or so for the > morning T this hardly seems to merit a vote, but any objections > are welcome. +1

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Done in r1736250 (and merged in r1736251). On Tue, Mar 22, 2016 at 9:27 PM, Stefan Eissing wrote: > Hmm, I thought we had that fixed by adding the proper compiler flags in > maintainer mode. Will fix tomorrow morning. > > Stefan > >> Am 22.03.2016 um 20:59 schrieb

Re: [VOTE] Release Apache httpd 2.4.19 as GA

On Tue, Mar 22, 2016 at 3:55 PM, William A Rowe Jr wrote: > Can anyone get mod_lbmethod_rr.c to build? > That's funny actually. The very first version README.cmake in trunk says that mod_lbmethod_rr.c doesn't build on Windows, yet the only build support I can find for that

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Hmm, I thought we had that fixed by adding the proper compiler flags in maintainer mode. Will fix tomorrow morning. Stefan > Am 22.03.2016 um 20:59 schrieb Eric Covener : > >> On Tue, Mar 22, 2016 at 3:57 PM, William A Rowe Jr >> wrote: >> Finally,

Re: svn commit: r1736243 - /httpd/httpd/trunk/modules/cache/mod_socache_shmcb.c

Without objection, I'll be committing the backport in an hr or so for the morning T this hardly seems to merit a vote, but any objections are welcome. On Tue, Mar 22, 2016 at 3:06 PM, wrote: > Author: wrowe > Date: Tue Mar 22 20:06:32 2016 > New Revision: 1736243 > > URL:

Re: [VOTE] Release Apache httpd 2.4.19 as GA

On Tue, Mar 22, 2016 at 3:55 PM, William A Rowe Jr wrote: > Can anyone get mod_lbmethod_rr.c to build? > I guess I'll try soon with cmake on Windows, once prereqs are built and I add a line or two to CMakeLists.txt for that module :) (I'm backpedaling to trunk from 2.4.19

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Am 22.03.2016 um 20:59 schrieb William A Rowe Jr: On Tue, Mar 22, 2016 at 2:58 PM, Reindl Harald > wrote: Am 22.03.2016 um 20:55 schrieb William A Rowe Jr: Can anyone get mod_lbmethod_rr.c to build? my Fedora 23

VOTE RECALLED: (Was: Re: [VOTE] Release Apache httpd 2.4.19 as GA)

Due to the Window's build issue, I am recalling this vote. With http://svn.apache.org/viewvc?view=revision=1736157, it looks like this issue is resolved. Will give it until 8am (Eastern) tomorrow and will kick off 2.4.20 T

Re: [VOTE] Release Apache httpd 2.4.19 as GA

On Tue, Mar 22, 2016 at 3:57 PM, William A Rowe Jr wrote: > Finally, just confirming we have decided that C99 is now the minimum > supported compiler feature set- used for the vardic macros in h2_filter.c? I don't think that is meant to be bumped. We definitely had simpler

Re: [VOTE] Release Apache httpd 2.4.19 as GA

On Tue, Mar 22, 2016 at 2:58 PM, Reindl Harald wrote: > > Am 22.03.2016 um 20:55 schrieb William A Rowe Jr: > >> Can anyone get mod_lbmethod_rr.c to build? >> > > my Fedora 23 rpm-spec builds without any issue or change - most modules > external sub-apckages and typically

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Am 22.03.2016 um 20:55 schrieb William A Rowe Jr: Can anyone get mod_lbmethod_rr.c to build? my Fedora 23 rpm-spec builds without any issue or change - most modules external sub-apckages and typically used ones static [root@srv-rhsoft:~]$ /bin/ls -1 /fileserver/yum-repo/fc23/x86_64/ |

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Finally, just confirming we have decided that C99 is now the minimum supported compiler feature set- used for the vardic macros in h2_filter.c? On Mon, Mar 21, 2016 at 12:37 PM, Jim Jagielski wrote: > The pre-release test tarballs for Apache httpd 2.4.19 can be found > at the

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Can anyone get mod_lbmethod_rr.c to build? I'm seeing 'name' : is not a member of 'proxy_balancer' errors, as well as ap_proxy_retry_worker() undefined (converted into an optional function, perhaps?) On Mon, Mar 21, 2016 at 12:37 PM, Jim Jagielski wrote: > The pre-release

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Note that mod_socache_shmcb.c introduced UINT_MAX without including limits.h... whoops. Investigating. On Mon, Mar 21, 2016 at 12:37 PM, Jim Jagielski wrote: > The pre-release test tarballs for Apache httpd 2.4.19 can be found > at the usual place: > >

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

On 22 Mar 2016, at 7:11 PM, Yann Ylavic wrote: > In r1736216, I tried to restore c->data_in_input_filters usage as > prior to r1734656. > Does it help (or I'll revert)? Got caught up in other stuff before I could get to the bottom of this :( It looks like we need to

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Stefan Eissing in gmane.comp.apache.devel (Tue, 22 Mar 2016 11:38:31 +0100): >I added the missing line in trunk and 2.4.x. Jan, are you able >to verify that the current 2.4.x builds for you? Thanks! I did not check the current build, but added the line myself and went ahead:

Re: [VOTE] Release Apache httpd 2.4.19 as GA

While we're not an official voter, I did want to advise we’ve tested this release on our platform and saw no problems with our high level tests. > [X ] +1: Good to go Tested on CentOS 6 x86_64. — Jacob Perkins Product Owner cPanel Inc. jacob.perk...@cpanel.net

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

In r1736216, I tried to restore c->data_in_input_filters usage as prior to r1734656. Does it help (or I'll revert)? On Tue, Mar 22, 2016 at 1:02 PM, Jim Jagielski wrote: > Well, we gotta do something. This is a significant breakage. > >> On Mar 15, 2016, at 4:29 AM, Yann

Re: [VOTE] Release Apache httpd 2.4.19 as GA

On 2016-03-21 18:37, Jim Jagielski wrote: > The pre-release test tarballs for Apache httpd 2.4.19 can be found > at the usual place: > > http://httpd.apache.org/dev/dist/ > > I'm calling a VOTE on releasing these as Apache httpd 2.4.19 GA. > > [ ] +1: Good to go > [ ] +0: meh > [ ] -1:

Re: TLS session ticket key (shared) renewal

My thought was to add support for either multiple files, or multiple values in the existing `SSLSessionTicketKeyFile`. Then add support to decrypt from any of the known keys, and have a setting (or the first loaded key) would be used to encrypt all new keys. This would allow for rotation in a

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

Well, we gotta do something. This is a significant breakage. > On Mar 15, 2016, at 4:29 AM, Yann Ylavic wrote: > > On Tue, Mar 15, 2016 at 12:42 AM, Graham Leggett wrote: >> On 14 Mar 2016, at 10:48 AM, Ruediger Pluem wrote: >> >>>

Re: svn commit: r1734656 - in /httpd/httpd/trunk: ./ include/ modules/http/ server/ server/mpm/event/ server/mpm/motorz/ server/mpm/simple/

Am 14.03.2016 um 09:48 schrieb Ruediger Pluem: On 03/12/2016 01:43 AM, minf...@apache.org wrote: Author: minfrin Date: Sat Mar 12 00:43:58 2016 New Revision: 1734656 URL: http://svn.apache.org/viewvc?rev=1734656=rev Log: core: Extend support for setting aside data from the network input filter

Re: Proposed change to mpm_register_socket_callback(): apr_socket_t -> apr_pollfd_t

> On Mar 15, 2016, at 3:28 PM, Graham Leggett wrote: > > The trouble with the above is that because of the pool cleanup we now have, > pfds[3] needs to live as long as pool p. In your example it does, but there > is nothing stopping someone trying to allocate pfds[3] on the

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Yes, *sad face*. There was a reason our grandfathers kept everything in one source file... I added the missing line in trunk and 2.4.x. Jan, are you able to verify that the current 2.4.x builds for you? Thanks! -Stefan > Am 22.03.2016 um 11:25 schrieb Jim Jagielski : > >

Re: [VOTE] Release Apache httpd 2.4.19 as GA

Ugg, ugg and triple ugg. I have a mind to recall 2.4.19, but will leave the vote open to ensure we don't have problems w/ other platforms before we re-T > On Mar 21, 2016, at 9:49 PM, Jan Ehrhardt wrote: > > Jim Jagielski in gmane.comp.apache.devel (Mon, 21 Mar 2016

Re: [VOTE] Release Apache httpd 2.4.19 as GA

> Am 22.03.2016 um 02:49 schrieb Jan Ehrhardt : > > Jim Jagielski in gmane.comp.apache.devel (Mon, 21 Mar 2016 13:37:40 > -0400): >> [x] +0: meh > > mod_http2.so will not build 'out of the box' on Windows, because > mod_http2.dsp is missing > > # Begin Source File > >

Re: [VOTE] Release Apache httpd 2.4.19 as GA

On 22/03/2016 03:37, Jim Jagielski wrote: The pre-release test tarballs for Apache httpd 2.4.19 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.19 GA. [x ] +1: Good to go [ ] +0: meh [ ] -1: Danger Will