Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread William A Rowe Jr
On Thu, Jul 30, 2020 at 3:19 PM Daniel Ruggeri wrote: > > On 7/30/2020 2:41 PM, William A Rowe Jr wrote: > > On Thu, Jul 30, 2020 at 10:10 AM Jim Jagielski wrote: > >> >> > On Jul 30, 2020, at 5:55 AM, Christophe JAILLET < >> christophe.jail...@wanadoo.fr> wrote: >> > >> > I wouldn't say it is

[RESULT] [VOTE] Release httpd-2.4.45

2020-07-30 Thread Daniel Ruggeri
Hi, all;    I thank everyone for their testing and quick feedback. While we had enough votes and positive feedback, we have some easily fixable warnings which have precedence for holding up a release.    To that end, I will close this vote and declare 2.4.45 dead on the vine.    I will roll

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Daniel Ruggeri
On 7/30/2020 2:41 PM, William A Rowe Jr wrote: > On Thu, Jul 30, 2020 at 10:10 AM Jim Jagielski > wrote: > > > > On Jul 30, 2020, at 5:55 AM, Christophe JAILLET > > wrote: > > > > I wouldn't say it is a show

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread William A Rowe Jr
On Thu, Jul 30, 2020 at 10:10 AM Jim Jagielski wrote: > > > On Jul 30, 2020, at 5:55 AM, Christophe JAILLET < > christophe.jail...@wanadoo.fr> wrote: > > > > I wouldn't say it is a show stopper, but I thought that we had a travis > job for that. > > Apparently, it is on trunk only (see r1879370

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Eric Covener
On Wed, Jul 29, 2020 at 11:26 AM Daniel Ruggeri wrote: > > Hi, all; >Please find below the proposed release tarball and signatures: > https://dist.apache.org/repos/dist/dev/httpd/ > > I would like to call a VOTE over the next few days to release this > candidate tarball as 2.4.45: > [ ] +1:

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Steffen Land
aplogno warnings on 2.4.40 was a reason to skip. www.apachelounge.com/viewtopic.php?t=8329=aplogno On Thursday 30/07/2020 at 17:10, Jim Jagielski wrote: On Jul 30, 2020, at 5:55 AM, Christophe JAILLET wrote: I wouldn't say it is a show stopper, but I thought that we had a travis

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Steffen
Thanks for you reply Graham, Indeed apt-util warnings not relevant here. You said below : ... more Windows testing over at APR . For HTTPD enough ? We test HTTPD and APR quite intensive with a few members, even on production level on different configurations. The code is quite good,

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Jim Jagielski
> On Jul 30, 2020, at 5:55 AM, Christophe JAILLET > wrote: > > I wouldn't say it is a show stopper, but I thought that we had a travis job > for that. > Apparently, it is on trunk only (see r1879370 which is not backported, maybe > on purpose) > I agree that it's not a show-stopper but

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Joe Orton
On Thu, Jul 30, 2020 at 11:55:09AM +0200, Christophe JAILLET wrote: > I've not tested yet, but looking at Steffen Land compilation error logs on > Windows, I've been surprised by: > >    Warning    C4003    modules\proxy\mod_proxy_fcgi.c    180 not enough > arguments for function-like macro

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread jean-frederic clere
On 29/07/2020 17:26, Daniel Ruggeri wrote: [X] +1: It's not just good, it's good enough! Tested on fedora32 x86_64. -- Cheers Jean-Frederic

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Christophe JAILLET
Le 29/07/2020 à 17:26, Daniel Ruggeri a écrit : Hi, all;    Please find below the proposed release tarball and signatures: https://dist.apache.org/repos/dist/dev/httpd/ I would like to call a VOTE over the next few days to release this candidate tarball as 2.4.45: [ ] +1: It's not just good,

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Graham Leggett
On 30 Jul 2020, at 11:16, Steffen Land wrote: > +1 on Windows. > > I am in doubt for a -0 : > > Still quite some (more) warnings, now 432, attached Win64 warnings with the > ones from APR-UTIL. > > I think a goal is (must be) that we get warning free on all platforms, now it > looks bad on

Re: [VOTE] Release httpd-2.4.45

2020-07-30 Thread Steffen Land
HTTPd 2.4.45 Warning C4267 modules\http\http_filters.c 284 '+=': conversion from 'size_t' to 'apr_int32_t', possible loss of data Warning C4267 modules\http\http_filters.c 473 '=': conversion from 'size_t' to 'int', possible loss of data Warning C4267