Re: svn commit: r1892587 - in /httpd/httpd/trunk: os/unix/unixd.c server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c

2021-08-25 Thread Ruediger Pluem
On 8/25/21 12:22 AM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Aug 24 22:22:40 2021 > New Revision: 1892587 > > URL: http://svn.apache.org/viewvc?rev=1892587&view=rev > Log: > mpm_{event,worker,prefork}: late stop of children processes on restart. > > Change how the main process ha

Re: svn commit: r1892587 - in /httpd/httpd/trunk: os/unix/unixd.c server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c

2021-08-25 Thread Yann Ylavic
On Wed, Aug 25, 2021 at 9:53 AM Ruediger Pluem wrote: > > On 8/25/21 12:22 AM, yla...@apache.org wrote: > > > @@ -3753,16 +3761,13 @@ static int event_pre_config(apr_pool_t * > > if (!retained) { > > retained = ap_retained_data_create(userdata_key, > > sizeof(*retained)); > >

Re: svn commit: r1892587 - in /httpd/httpd/trunk: os/unix/unixd.c server/listen.c server/mpm/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/worker.c

2021-08-25 Thread Yann Ylavic
On Wed, Aug 25, 2021 at 11:26 AM Yann Ylavic wrote: > > On Wed, Aug 25, 2021 at 9:53 AM Ruediger Pluem wrote: > > > > Why is this no longer needed? > > Thanks for noticing, I'll revert. r1892595. > > > Regards; > Yann.

Fixed: apache/httpd#1839 (trunk - f390a45)

2021-08-25 Thread Travis CI
Build Update for apache/httpd - Build: #1839 Status: Fixed Duration: 20 mins and 38 secs Commit: f390a45 (trunk) Author: Yann Ylavic Message: mpm_{event,worker,prefork}: follow up to r1892587: restore ungraceful on MPM change. While at it add a comment for th

Re: Late(r) stop of children processes on restart

2021-08-25 Thread Yann Ylavic
On Tue, Jun 29, 2021 at 3:00 PM Rainer Jung wrote: > > Am 29.06.2021 um 14:31 schrieb Stefan Eissing: > > Can comment really on the diff, but totally agree on the goal to minimize > > the unresponsive time and make graceful less disruptive. > > > > So +1 for that. > > +1 on the intention as well.

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread Yann Ylavic
On Wed, Aug 25, 2021 at 1:14 AM Travis CI wrote: > > apache / httpd > > trunk > > Build #1831 was broken > 21 mins and 33 secs > Yann Ylavic > 243c5fa CHANGESET → > > mpm_{event,worker,prefork}: late stop of children processes on restart. (unrelated to this change, Build #1819 failed the same ear

Re: Late(r) stop of children processes on restart

2021-08-25 Thread Rainer Jung
Thanks for the headroom explanation Yann, good reading! Rainer Am 25.08.2021 um 13:23 schrieb Yann Ylavic: On Tue, Jun 29, 2021 at 3:00 PM Rainer Jung wrote: Am 29.06.2021 um 14:31 schrieb Stefan Eissing: Can comment really on the diff, but totally agree on the goal to minimize the unrespo

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 13:53 schrieb Yann Ylavic : > > On Wed, Aug 25, 2021 at 1:14 AM Travis CI wrote: >> >> apache / httpd >> >> trunk >> >> Build #1831 was broken >> 21 mins and 33 secs >> Yann Ylavic >> 243c5fa CHANGESET → >> >> mpm_{event,worker,prefork}: late stop of children processes o

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 15:06 schrieb ste...@eissing.org: > > > >> Am 25.08.2021 um 13:53 schrieb Yann Ylavic : >> >> On Wed, Aug 25, 2021 at 1:14 AM Travis CI wrote: >>> >>> apache / httpd >>> >>> trunk >>> >>> Build #1831 was broken >>> 21 mins and 33 secs >>> Yann Ylavic >>> 243c5fa CHANGE

Re: http2 test suite

2021-08-25 Thread Joe Orton
On Mon, Aug 23, 2021 at 03:03:34PM +0200, ste...@eissing.org wrote: > > > > Am 23.08.2021 um 14:40 schrieb Joe Orton : > > > > On Mon, Aug 23, 2021 at 12:59:19PM +0200, ste...@eissing.org wrote: > >> The http2 test suites in https://github.com/icing/mod_h2 and svn trunk are > >> now nearly iden

Re: http2 test suite

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 15:30 schrieb Joe Orton : > > On Mon, Aug 23, 2021 at 03:03:34PM +0200, ste...@eissing.org wrote: >> >> >>> Am 23.08.2021 um 14:40 schrieb Joe Orton : >>> >>> On Mon, Aug 23, 2021 at 12:59:19PM +0200, ste...@eissing.org wrote: The http2 test suites in https://github.c

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 15:15 schrieb ste...@eissing.org: > > > >> Am 25.08.2021 um 15:06 schrieb ste...@eissing.org: >> >> >> >>> Am 25.08.2021 um 13:53 schrieb Yann Ylavic : >>> >>> On Wed, Aug 25, 2021 at 1:14 AM Travis CI wrote: apache / httpd trunk Build

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread Yann Ylavic
On Wed, Aug 25, 2021 at 3:37 PM ste...@eissing.org wrote: > > Follow up: if I do a "time.sleep(2)" after each "apachectl" in my > test suite, it works fine. > > Speculating: my test suite does commonly a GET after a reload to > see if the reloaded server is responding. And then fires requests > ag

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 15:54 schrieb Yann Ylavic : > > On Wed, Aug 25, 2021 at 3:37 PM ste...@eissing.org wrote: >> >> Follow up: if I do a "time.sleep(2)" after each "apachectl" in my >> test suite, it works fine. >> >> Speculating: my test suite does commonly a GET after a reload to >> see if

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread Yann Ylavic
On Wed, Aug 25, 2021 at 3:56 PM ste...@eissing.org wrote: > > > > > Am 25.08.2021 um 15:54 schrieb Yann Ylavic : > > > > On Wed, Aug 25, 2021 at 3:37 PM ste...@eissing.org > > wrote: > >> > >> Follow up: if I do a "time.sleep(2)" after each "apachectl" in my > >> test suite, it works fine. > >>

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 16:04 schrieb Yann Ylavic : > > On Wed, Aug 25, 2021 at 3:56 PM ste...@eissing.org wrote: >> >> >> >>> Am 25.08.2021 um 15:54 schrieb Yann Ylavic : >>> >>> On Wed, Aug 25, 2021 at 3:37 PM ste...@eissing.org >>> wrote: Follow up: if I do a "time.sleep(2)" aft

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread Yann Ylavic
On Wed, Aug 25, 2021 at 4:04 PM Yann Ylavic wrote: > > On Wed, Aug 25, 2021 at 3:56 PM ste...@eissing.org wrote: > > > > I could add that in the test config as header to a certain location. > > > > However, will all new connections get to new gen children once the > > new number has been spotted?

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 16:16 schrieb Yann Ylavic : > > On Wed, Aug 25, 2021 at 4:04 PM Yann Ylavic wrote: >> >> On Wed, Aug 25, 2021 at 3:56 PM ste...@eissing.org >> wrote: >>> >>> I could add that in the test config as header to a certain location. >>> >>> However, will all new connections g

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
Ok, brute-forced it a bit. The test suite now always does a stop/start cycle on config changes as reload now longer works reliably. Takes a bit more time, but not overly so on my machine. Cheers, Stefan > Am 25.08.2021 um 16:22 schrieb ste...@eissing.org: > > > >> Am 25.08.2021 um 16:16 schrie

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
It should be fixed now with r1892599, I believe. > Am 25.08.2021 um 13:53 schrieb Yann Ylavic : > > On Wed, Aug 25, 2021 at 1:14 AM Travis CI wrote: >> >> apache / httpd >> >> trunk >> >> Build #1831 was broken >> 21 mins and 33 secs >> Yann Ylavic >> 243c5fa CHANGESET → >> >> mpm_{event,wor

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread Yann Ylavic
Thanks, looks good, it probably needs a backport to 2.4.x since the first travis failure was there (Build #1819). Let's see how it works after several runs before maybe. On Wed, Aug 25, 2021 at 5:02 PM ste...@eissing.org wrote: > > It should be fixed now with r1892599, I believe. > > > Am 25.08.2

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 17:06 schrieb Yann Ylavic : > > Thanks, looks good, it probably needs a backport to 2.4.x since the > first travis failure was there (Build #1819). > Let's see how it works after several runs before maybe. +1 Let's see what Joe and Travis can do to wreck it. > On Wed, Aug

Canceled: apache/httpd#1842 (trunk - 3259f23)

2021-08-25 Thread Travis CI
Build Update for apache/httpd - Build: #1842 Status: Canceled Duration: ? Commit: 3259f23 (trunk) Author: Stefan Eissing Message: mod_http2: fixes a use-after-read of an integer value when passing a stream identifier for further IO checking. A non-issue s

Canceled: apache/httpd#1841 (trunk - 376e04c)

2021-08-25 Thread Travis CI
Build Update for apache/httpd - Build: #1841 Status: Canceled Duration: ? Commit: 376e04c (trunk) Author: Stefan Eissing Message: * test/modules/http2: using stop/start instead of reload when changing apache configs to give reliable results. The new reload

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread Joe Orton
On Wed, Aug 25, 2021 at 05:08:06PM +0200, ste...@eissing.org wrote: > > > > Am 25.08.2021 um 17:06 schrieb Yann Ylavic : > > > > Thanks, looks good, it probably needs a backport to 2.4.x since the > > first travis failure was there (Build #1819). > > Let's see how it works after several runs bef

Re: Broken: apache/httpd#1831 (trunk - 243c5fa)

2021-08-25 Thread ste...@eissing.org
> Am 25.08.2021 um 17:34 schrieb Joe Orton : > > On Wed, Aug 25, 2021 at 05:08:06PM +0200, ste...@eissing.org wrote: >> >> >>> Am 25.08.2021 um 17:06 schrieb Yann Ylavic : >>> >>> Thanks, looks good, it probably needs a backport to 2.4.x since the >>> first travis failure was there (Build #1