Re: Problems in apr_rmm.c

2005-08-03 Thread Joe Orton
On Tue, Aug 02, 2005 at 04:26:44PM -0400, Fenlason, Josh wrote: Has anyone seen any problems in apr_rmm.c on systems with shared memory and ldap enabled? When I stop Apache via Crtl-C, I'm getting the Windows error saying that something is a miss in Apache. Stepping into the debugger, reveals

Re: [PATCH] fix util_ldap with older OpenLDAPs

2005-08-03 Thread Joe Orton
On Wed, Aug 03, 2005 at 11:24:49AM -0600, Brad Nicholes wrote: This is why I would like to see the release of 2.2 as soon as possible. My only explanation is that I missed changing the NULL parameter to ldc-ldap when I did the backport of the conversion from global to per-connection from

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-08-02 Thread Joe Orton
On Fri, Jul 22, 2005 at 02:24:50PM +0200, Sander Striker wrote: Joe Orton wrote: On Fri, Jul 22, 2005 at 12:11:56PM -, Martin Kraemer wrote: Author: martin Date: Fri Jul 22 05:11:55 2005 New Revision: 220307 URL: http://svn.apache.org/viewcvs?rev=220307view=rev Log: Allow

Re: perl-framework: cgi.t 21 test failures due to missing mod_cgi.log file

2005-08-01 Thread Joe Orton
On Mon, Aug 01, 2005 at 12:04:42AM -0700, Girish Muraly wrote: I ran the httpd-tests and I got 21 test failures in the perl-framework due to t/modules/cgi.t and 1 error due to t/modules/include.t. The errors are: [just the snippet from running t/TEST] t/modules/cgi...NOK 14#

Re: perl-framework: cgi.t 21 test failures due to missing mod_cgi.log file

2005-08-01 Thread Joe Orton
On Mon, Aug 01, 2005 at 02:11:04AM -0700, Girish Muraly wrote: Hi Joe, I am running the tests on Fedora Core 3. My Apache (version 2.0.54) is configured as part of a LAMP stack and I am running tests on each of the components (Apache, Mysql and PHP,Perl,Python). I am quite new to the

Re: [PATCH] fix util_ldap with older OpenLDAPs

2005-07-28 Thread Joe Orton
On Wed, Jul 27, 2005 at 11:39:36PM +0200, Graham Leggett wrote: Joe Orton wrote: Any objections to this? None at all - if the v2.0 code can be made more stable this is always a good thing, but there are lots more problems in the v2.0 code that are fixed in the v2.2 rewrite. Ah, sorry

Re: [PATCH] graceful restart bug as opportunity

2005-07-27 Thread Joe Orton
On Wed, Jul 27, 2005 at 12:40:58PM +0100, Colm MacCarthaigh wrote: configure.in makes a big deal about determining AP_SIG_GRACEFUL, which defaults to SIGUSR1, but uses SIGWINCH on Linux 2.0. But then mpm_common.c goes ahead and ignores this for actually sending the signal, SIGUSR1 is

[PATCH] fix util_ldap with older OpenLDAPs

2005-07-27 Thread Joe Orton
Since 2.0.54, it seems mod_auth_ldap just segfaults on any request if built against older versions of OpenLDAP, 2.2.20 and earlier (pre-2005). It looks like this was another regression caused the addition of the LDAPConnectionTimeout option. (New features, stable branch, regressions? Hmmm,

Re: svn commit: r219940 - in /httpd/httpd/trunk: docs/manual/mod/mod_ssl.xml modules/ssl/ssl_expr.h modules/ssl/ssl_expr_eval.c modules/ssl/ssl_expr_parse.y modules/ssl/ssl_expr_scan.l

2005-07-22 Thread Joe Orton
On Wed, Jul 20, 2005 at 04:42:59PM -, Martin Kraemer wrote: Author: martin Date: Wed Jul 20 09:42:58 2005 New Revision: 219940 URL: http://svn.apache.org/viewcvs?rev=219940view=rev Log: Collaborative work: (Thanks, dreid!) Implement OID checking for mod_ssl. This code allows for

Re: svn commit: r219940 - in /httpd/httpd/trunk: docs/manual/mod/mod_ssl.xml modules/ssl/ssl_expr.h modules/ssl/ssl_expr_eval.c modules/ssl/ssl_expr_parse.y modules/ssl/ssl_expr_scan.l

2005-07-22 Thread Joe Orton
On Fri, Jul 22, 2005 at 11:12:07AM +0100, Joe Orton wrote: On Wed, Jul 20, 2005 at 04:42:59PM -, Martin Kraemer wrote: Author: martin Date: Wed Jul 20 09:42:58 2005 New Revision: 219940 URL: http://svn.apache.org/viewcvs?rev=219940view=rev Log: Collaborative work: (Thanks

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-07-22 Thread Joe Orton
On Fri, Jul 22, 2005 at 12:11:56PM -, Martin Kraemer wrote: Author: martin Date: Fri Jul 22 05:11:55 2005 New Revision: 220307 URL: http://svn.apache.org/viewcvs?rev=220307view=rev Log: Allow extraction of the values of SSL certificate extensions into environment variables, so that

Re: svn commit: r219520 - /httpd/httpd/branches/2.2.x/

2005-07-20 Thread Joe Orton
On Mon, Jul 18, 2005 at 11:58:21AM -0500, William Rowe wrote: Thanks Paul, you just collided with the refactoring of 2.1.x proxy. Is this refactoring complete? Apart from the compiler warnings, a bunch of the t/ssl/proxy.t tests have started failing with the trunk code. With worker, the

Re: Apache in a loop during startup

2005-07-19 Thread Joe Orton
On Tue, Jul 19, 2005 at 01:02:56AM -0700, Dirk-Willem van Gulik wrote: with config: SSLSessionCache dbm:/var/run/ssl_scache SSLSessionCacheTimeout 300 SSLMutexfile:/var/run/ssl_mutex Using s/shmcb/dbm/ and SSLMutex default is IMO the best default

Re: svn commit: r218978 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c

2005-07-19 Thread Joe Orton
On Thu, Jul 14, 2005 at 07:43:35AM -0400, Jeff Trawick wrote: I'm so confused while trying to draw the line between alternate RFC-compliant philosophy fixes for actual RFC violations fixes for security issues I think CHANGES should be crystal clear on what change has a security

Re: [Patch 2.0] d2i_SSL_SESSION args for 0.9.7f-/0.9.7g/0.9.8

2005-07-08 Thread Joe Orton
On Thu, Jul 07, 2005 at 06:51:04PM -0500, William Rowe wrote: Attached is a backport of rev 209530, which demanded a little bit of rework to make it functional. This resolves build issues which caused errors in 0.9.7f and prior on Win32 and build failures on Netware. This patch correctly

Re: svn commit: r209723 - /httpd/httpd/trunk/CHANGES

2005-07-08 Thread Joe Orton
On Fri, Jul 08, 2005 at 09:35:58AM -, Paul Querna wrote: Author: pquerna Date: Fri Jul 8 02:35:56 2005 New Revision: 209723 URL: http://svn.apache.org/viewcvs?rev=209723view=rev Log: The request smuggling issue did get assigned CAN-2005-2088. Ah, I was just about to commit a

Re: [Patch 2.0] d2i_SSL_SESSION args for 0.9.7f-/0.9.7g/0.9.8

2005-07-08 Thread Joe Orton
On Fri, Jul 08, 2005 at 09:53:44AM -0500, William Rowe wrote: At 01:48 AM 7/8/2005, Joe Orton wrote: On Thu, Jul 07, 2005 at 06:51:04PM -0500, William Rowe wrote: This resolves build issues which caused errors in 0.9.7f and prior on Win32 and build failures on Netware. This patch

Re: [PATCH] Allow for internal OpenSSL Session Cache

2005-07-08 Thread Joe Orton
On Tue, Jul 05, 2005 at 01:32:54PM -0400, Jim Jagielski wrote: I've run into this with some broken browsers. Basically, they require a non-null SessionID in the SSL transaction. If, for whatever reason, we disable the external SSL Session Cache, these browsers reports errors when connecting to

Re: [Patch 1.3] Strict proxy C-L / T-E conformance

2005-07-07 Thread Joe Orton
On Wed, Jul 06, 2005 at 02:53:52PM -0400, Jim Jagielski wrote: On Jul 6, 2005, at 2:22 PM, Joe Orton wrote: On Wed, Jul 06, 2005 at 11:45:21AM -0500, William Rowe wrote: ... +else { +char *len_end; +errno = 0; +c-len

Re: Philosophy, empty body still a request body?

2005-07-07 Thread Joe Orton
On Thu, Jul 07, 2005 at 11:03:33AM -0500, William Rowe wrote: Cool. Thank you for the clarification. Final question, please verify my guess that; Content-Length: is the same as Content-Length: 0 Why would you assume that? RFC2616, 14.13: Content-Length= Content-Length :

Re: Philosophy, empty body still a request body?

2005-07-07 Thread Joe Orton
On Thu, Jul 07, 2005 at 12:46:03PM -0500, William Rowe wrote: I didn't assume; I guessed :) Thank you for that observation Joe, Content-Length: is most definitely invalid according to the grammar. Although the grammar doesn't account for Content-Length: 0 0 does match 1*DIGIT -

Re: Patch for 2.0.54 + OpenSSL 0.9.8

2005-07-06 Thread Joe Orton
On Wed, Jul 06, 2005 at 11:10:33AM -0600, Brad Nicholes wrote: I think that there are a few more changes that need to be made. At least on NetWare it won't compile without the following additional patch. This one needs a typedef which is defined correctly for the version of OpenSSL in use,

Re: [Patch 1.3] Strict proxy C-L / T-E conformance

2005-07-06 Thread Joe Orton
On Wed, Jul 06, 2005 at 11:45:21AM -0500, William Rowe wrote: ... +else { +char *len_end; +errno = 0; +c-len = ap_strtol(content_length, len_end, 10); ... +if (errno || (c-len 0) || (len_end *len_end)) { You should

Re: svn commit: r202027 - in /httpd/httpd/trunk: CHANGES server/mpm_common.c

2005-06-27 Thread Joe Orton
On Mon, Jun 27, 2005 at 06:40:59PM -, Paul Querna wrote: Author: pquerna Date: Mon Jun 27 11:40:56 2005 New Revision: 202027 URL: http://svn.apache.org/viewcvs?rev=202027view=rev Log: *) server/mpm_common.c: Send a simple HTTP 1.0 request to every listener socket, instead of just

Re: error

2005-06-27 Thread Joe Orton
On Mon, Jun 27, 2005 at 02:46:23PM -0400, Cliff Woolley wrote: On Mon, 27 Jun 2005, Gustavo A. Baratto wrote: prefork.c:103: error: syntax error before '*' token prefork.c:103: warning: data definition has no type or storage class gmake[4]: *** [prefork.lo] Error 1 gmake[4]: Leaving

Re: Include Paths, was Re: error

2005-06-27 Thread Joe Orton
On Mon, Jun 27, 2005 at 12:41:42PM -0700, Paul Querna wrote: Joe Orton wrote: and then upload the preprocessed output prefork.o somewhere? Possibly you're picking up an installed mpm.h which was generated for a different MPM, or something like that. Actually, I have been hitting

Re: httpd 1.3 mod_cgi argv[0]

2005-06-26 Thread Joe Orton
On Thu, Jun 23, 2005 at 11:23:55AM +0200, David Welton wrote: [ Ok, trying this again as a subscriber... I guess the list mods missed it:-/ ] Hi, I've managed to tickle an obscure bug in Tcl's environment introspection by launching a 'starpack' (self contained Tcl executable+script) as a

Re: 2.1.6 is available for veto^H^H^H^Hvoting

2005-06-24 Thread Joe Orton
On Fri, Jun 24, 2005 at 01:03:57AM -0700, Paul Querna wrote: Please vote on releasing 2.1.6 as -alpha. +1 for alpha, manual test OK and httpd-test passes for this tarball on all-the-linuxes here. joe

Re: 2.1.5 available for testing

2005-06-20 Thread Joe Orton
On Fri, Jun 17, 2005 at 12:40:50AM -0700, Paul Querna wrote: Please test and vote on releasing 2.1.5 as -alpha. +1 for alpha, httpd-test'ed on a bunch of Linuxes here, looks good. Thanks Paul! Also +1 on basing the 2.1.x/2.2.x stabilisation branch on this per previous discussion. The C-L vs

Re: HTTPD 2.1 (Head) Build issues for NetWare...

2005-06-20 Thread Joe Orton
On Thu, Jun 16, 2005 at 08:43:00AM -0600, Brad Nicholes wrote: I have run into this one also and I still don't understand why the make is all of the sudden asking for yacc when this all worked before. Since neither mod_ssl nor BSD sockets are part of the standard NetWare

Re: [PATCH] sanitize installed config_vars.mk

2005-06-13 Thread Joe Orton
On Fri, Jun 10, 2005 at 11:23:49AM -0700, Paul Querna wrote: Joe Orton wrote: Patch below is an attempt to create a sanitized version of config_vars.mk which is suitable for the installed tree. The currently installed file has lots of references to the source and build trees in e.g

Re: svn commit: r189771 - /httpd/httpd/branches/fips-dev/acinclude.m4

2005-06-10 Thread Joe Orton
On Thu, Jun 09, 2005 at 04:10:54PM -, [EMAIL PROTECTED] wrote: Author: ben Date: Thu Jun 9 09:10:53 2005 New Revision: 189771 URL: http://svn.apache.org/viewcvs?rev=189771view=rev Log: Make path check more portable, make specifying a local OpenSSL build actually work. @@ -441,7

Re: [PATCH] Install should preserve executable flag on files from build/

2005-06-10 Thread Joe Orton
On Thu, Jun 09, 2005 at 03:50:12PM -0700, Daniel Rall wrote: When attempting to build Subversion trunk against the tip of httpd trunk, instdso.sh was not set executable as assumed by Subversion's build process. This is due to mishandling of the executable bit on files copied into httpd's

Re: svn commit: r189572 - /httpd/httpd/trunk/CHANGES

2005-06-09 Thread Joe Orton
On Wed, Jun 08, 2005 at 08:37:50AM -0700, Paul Querna wrote: I believe that we should be keeping items in the 2.1.x changelog at this point, since we have done several releases Ah, sorry, I remember the discussion about this previously but didn't remember if there was consensus on what to

Re: svn commit: r189761 - /httpd/httpd/branches/fips-dev/acinclude.m4

2005-06-09 Thread Joe Orton
On Thu, Jun 09, 2005 at 02:57:37PM -, [EMAIL PROTECTED] wrote: Author: ben Date: Thu Jun 9 07:57:36 2005 New Revision: 189761 URL: http://svn.apache.org/viewcvs?rev=189761view=rev Log: Die properly when path is bollocks. Did you mean to commit this to the branch? (given that it's not

Re: svn commit: r178990 - in /httpd/httpd/trunk: CHANGES server/config.c

2005-06-02 Thread Joe Orton
On Sun, May 29, 2005 at 09:39:40PM -, Paul Querna wrote: Author: pquerna Date: Sun May 29 14:39:39 2005 New Revision: 178990 URL: http://svn.apache.org/viewcvs?rev=178990view=rev Log: - Use a hash for the configuration command lookup implementation. Now modules can properly

Re: svn commit: r178990 - in /httpd/httpd/trunk: CHANGES server/config.c

2005-06-02 Thread Joe Orton
On Thu, Jun 02, 2005 at 02:05:05PM +0100, Joe Orton wrote: On Sun, May 29, 2005 at 09:39:40PM -, Paul Querna wrote: Author: pquerna Date: Sun May 29 14:39:39 2005 New Revision: 178990 URL: http://svn.apache.org/viewcvs?rev=178990view=rev Log: - Use a hash for the configuration

[PATCH] mod_include variable corruption issue

2005-05-31 Thread Joe Orton
PR 12655 is a rather natty pool lifetime issue... mod_include sets r-subprocess_env = r-main-subprocess_env in the subrequest, and may set variables in that table from the subrequest's r-pool. But it then goes and destroys the subrequest r-pool too early (despite the fact that it guarantees it

Re: svn commit: r153400 - in httpd/httpd/trunk: Makefile.in configure.in srclib/Makefile.in

2005-05-24 Thread Joe Orton
On Tue, May 24, 2005 at 12:30:23PM -0700, Paul Querna wrote: [EMAIL PROTECTED] wrote: Author: jorton Date: Fri Feb 11 06:08:24 2005 New Revision: 153400 URL: http://svn.apache.org/viewcvs?view=revrev=153400 Log: Support use of an external copy of the PCRE library: *

Re: svn commit: r170920 - /httpd/httpd/trunk/Makefile.in

2005-05-20 Thread Joe Orton
On Thu, May 19, 2005 at 07:56:46PM -0700, Bill Barker wrote: Joe Orton [EMAIL PROTECTED] wrote in message news:[EMAIL PROTECTED] On Thu, May 19, 2005 at 12:38:58PM -, Jean-Frederic Clere wrote: Author: jfclere Date: Thu May 19 05:38:57 2005 New Revision: 170920 URL: http

[PATCH] stop killing piped loggers

2005-05-20 Thread Joe Orton
As discussed previously; this patch stops killing piped loggers; except that prefork still kills them at shutdown and ungraceful restart since it signals the entire process group, so it's not entirely consistent. In all other cases (graceful restart with prefork; shutdown and both types of

Re: [PATCH] stop killing piped loggers

2005-05-20 Thread Joe Orton
On Fri, May 20, 2005 at 07:50:04AM -0400, Jeff Trawick wrote: On 5/20/05, Joe Orton [EMAIL PROTECTED] wrote: As discussed previously; this patch stops killing piped loggers; except that prefork still kills them at shutdown and ungraceful restart since it signals the entire process group, so

Re: svn commit: r170730 - /httpd/httpd/trunk/modules/experimental/mod_dbd.h

2005-05-20 Thread Joe Orton
On Wed, May 18, 2005 at 09:23:21AM -, [EMAIL PROTECTED] wrote: --- httpd/httpd/trunk/modules/experimental/mod_dbd.h (original) +++ httpd/httpd/trunk/modules/experimental/mod_dbd.h Wed May 18 02:23:20 2005 @@ -1,11 +1,25 @@ -/*Copyright (c) 2004, Nick Kew. All rights reserved. -

Re: [PATCH] worker.c: make pconf the parent for ptrans

2005-05-19 Thread Joe Orton
On Mon, May 16, 2005 at 04:49:10PM -0400, Joe Schaefer wrote: Jeff Trawick [EMAIL PROTECTED] writes: On 5/12/05, Joe Schaefer [EMAIL PROTECTED] wrote: Without this patch, the new apr_pool_join stuff in apr's trunk segfaults all over the place. Why? Is worker MPM doing something wrong

Re: svn commit: r170920 - /httpd/httpd/trunk/Makefile.in

2005-05-19 Thread Joe Orton
On Thu, May 19, 2005 at 12:38:58PM -, Jean-Frederic Clere wrote: Author: jfclere Date: Thu May 19 05:38:57 2005 New Revision: 170920 URL: http://svn.apache.org/viewcvs?rev=170920view=rev Log: Fix 32787 and the problems I have when using --enable-experimental-libtool. (libtool is an

Re: Apache DBD: completing the toolkit

2005-05-18 Thread Joe Orton
On Mon, May 16, 2005 at 11:40:29AM +0100, Nick Kew wrote: (2) mod_dbd is a utility for other modules, which it serves by exporting three functions, best explained by a brief extract from mod_dbd.h: ... In terms of API, I'd much rather see *just* the optional function exports to avoid

Re: [PATCH] piped_log_spawn leaks an fd

2005-05-18 Thread Joe Orton
On Tue, May 17, 2005 at 08:55:24AM -0400, Jeff Trawick wrote: On 5/16/05, Joe Orton [EMAIL PROTECTED] wrote: It's the month of the piped loggers... there's another issue in this code (just had the report this morning, by coincidence), that each time a piped logger is spawned (or respawned

[PATCH] piped_log_spawn leaks an fd

2005-05-17 Thread Joe Orton
It's the month of the piped loggers... there's another issue in this code (just had the report this morning, by coincidence), that each time a piped logger is spawned (or respawned), an fd is leaked. Without the fix to APR I committed earlier, this can cause the parent to segfault if enough piped

Re: [PATCH] SSL patch for ab (ApacheBench)

2005-05-17 Thread Joe Orton
On Wed, May 11, 2005 at 10:37:17PM +0900, Masaoki Kobayashi wrote: This is a patch for the version of ab on the trunk. In this version of ab, HAVE_OPENSSL controls if I have OpenSSL. I conformed to the way although I did not checked the case of HAVE_SSLC. Thanks a lot, and sorry for the slow

Re: [PATCH] PR 26467 child process can hang when piped logger goes away

2005-05-16 Thread Joe Orton
On Sun, May 15, 2005 at 08:22:32PM -0400, Jeff Trawick wrote: On 5/15/05, Joe Orton [EMAIL PROTECTED] wrote: I think it would be OK to make the behaviour change for 2.2 at least, since the current behaviour of losing log entries during graceful restart if using piped loggers is definitely

Re: [PATCH] PR 26467 child process can hang when piped logger goes away

2005-05-15 Thread Joe Orton
On Sun, May 15, 2005 at 09:22:57AM -0400, Jeff Trawick wrote: ... Joe Orton says, To fix this properly, I suppose piped loggers should not get SIGTERMedduring a graceful restart, they should read till EOF then exit(0): then when the last child attached to the piped logger for a particular

Re: [PATCH] SSL patch for ab (ApacheBench)

2005-05-10 Thread Joe Orton
On Tue, May 10, 2005 at 02:13:47PM +0900, Masaoki Kobayashi wrote: This patch modifies the support/ab.c to handle SSL/TLS properly. This looks really wonderful, thanks a lot for submitting this. Is there any chance that you can rediff this against the version of ab on the trunk?

Re: Listen-Protocol Branch

2005-05-06 Thread Joe Orton
On Thu, May 05, 2005 at 04:26:41PM -0700, Paul Querna wrote: Branch URL: https://svn.apache.org/repos/asf/httpd/httpd/branches/listen-protocol/ I have created a branch to: 1. Add a 'protocol' to the Listen Command. (done) 2. Add a Protocol command to force the protocol inside a vhost.

Re: [PATCH] Cleanup util_pcre.c

2005-05-04 Thread Joe Orton
On Wed, May 04, 2005 at 11:55:16AM -0700, Paul Querna wrote: server/util_pcre.c was copied here from srclib/pcre/pcreposix.c, and has since been de-libpcre'ized. It currently doesn't look anything like the standard httpd style, and it does not contain an ASL 2.0 License Header. Attached

[RFC] error_log spam for immediately-closed connections

2005-04-28 Thread Joe Orton
2.1 is logging a message for every connection which is closed with no request sent: since that's exactly what the dummy_connection() does this leaves a lot of weird-looking spam in the error_log when a server load spike passes with prefork. I think this should at least be downgraded to

Re: Thread safety of SSLRequire?

2005-04-26 Thread Joe Orton
On Mon, Apr 25, 2005 at 03:58:46PM -0700, Paul Querna wrote: Look at: http://svn.apache.org/repos/asf/httpd/httpd/trunk/modules/ssl/ssl_expr.c It has two globals: ssl_expr_info_type ssl_expr_info; char *ssl_expr_error; Which are used inside the ssl_expr_comp(), which is

Re: Proposed patch: always cleanup brigades in ap_pass_brigade

2005-04-26 Thread Joe Orton
On Mon, Apr 25, 2005 at 06:12:04PM -0500, Rici Lake wrote: I guess that depends on whether most filters use and recycle pass brigades. I suspect that most internal filters don't (and possibly have the model which Joe Schaefer describes, where the brigade is simply passed through), whereas

Re: svn commit: r164618 - /httpd/httpd/branches/2.0.x/STATUS

2005-04-26 Thread Joe Orton
On Mon, Apr 25, 2005 at 06:27:15PM -, Jim Jagielski wrote: Author: jim Date: Mon Apr 25 11:27:15 2005 New Revision: 164618 URL: http://svn.apache.org/viewcvs?rev=164618view=rev Log: Note quick hack, but it means we use some hidden knowledge. Modified:

Re: RFC: Who owns a passed brigade?

2005-04-25 Thread Joe Orton
On Fri, Apr 22, 2005 at 04:42:04PM -0500, Rici Lake wrote: On 22-Apr-05, at 9:32 AM, Joe Orton wrote: The issue here is really which party can *destroy* a brigade, right? Or perhaps which party *must* destroy a brigade. This is much less of an issue if neither party creates a new

Re: RFC: Who owns a passed brigade?

2005-04-25 Thread Joe Orton
On Mon, Apr 25, 2005 at 11:15:02AM -0400, Cliff Woolley wrote: On Mon, 25 Apr 2005, Joe Orton wrote: 1. update the util_filter.h documentation 2. add some APR_BUCKET_DEBUG code to abort() when brigades are used after being destroyed 3. adjust all filters to work with this model 4

Re: RFC: Who owns a passed brigade?

2005-04-25 Thread Joe Orton
On Mon, Apr 25, 2005 at 10:44:39AM -0500, Rici Lake wrote: Allocating the brigade out of the bucket allocator but continuing to register the cleanup with a pool (say, the request pool if that were appropriate) might work but it would be fragile. Fragile, why? That's exactly the right

Re: svn commit: r164606 - /httpd/httpd/branches/2.0.x/STATUS

2005-04-25 Thread Joe Orton
On Mon, Apr 25, 2005 at 05:21:42PM -, Jim Jagielski wrote: ... --- httpd/httpd/branches/2.0.x/STATUS (original) +++ httpd/httpd/branches/2.0.x/STATUS Mon Apr 25 10:21:40 2005 @@ -95,6 +95,11 @@ identify exactly what the proposed changes are! ] [ please append new backports at the

Re: Proposed patch: always cleanup brigades in ap_pass_brigade

2005-04-25 Thread Joe Orton
On Mon, Apr 25, 2005 at 03:58:59PM -0500, Rici Lake wrote: If we accept that the contents of a brigade are undefined when ap_pass_brigade returns, the caller has three options: -- call cleanup and reuse the brigade -- call destroy (which will first call cleanup) -- drop it on the floor and

Re: RFC: Who owns a passed brigade?

2005-04-22 Thread Joe Orton
On Thu, Apr 21, 2005 at 07:05:34PM -0500, Rici Lake wrote: On 21-Apr-05, at 5:51 PM, Nick Kew wrote: Rici Lake wrote: FWIW, I think the (apparent) practice, where the caller relinquishes ownership of the buckets but not the brigade itself, is more efficient since it avoids a lot of

Re: pcre and libtool

2005-04-19 Thread Joe Orton
On Tue, Apr 19, 2005 at 06:27:12PM +0100, Patrick Welche wrote: Looking in srclib/pcre/configure.in I see that there is dnl Handle --enable-shared-libraries LIBTOOL=./libtool LIBSUFFIX=la AC_ARG_ENABLE(shared, [ --disable-sharedbuild PCRE as a static

[PATCH] mod_ssl: merge ssl_hook_Translate into ssl_hook_ReadReq

2005-04-18 Thread Joe Orton
Is there any good reason why the ssl_hook_Translate functionality really has to be in a translate_name hook? PR 34452 is a nice snafu where the ssl-unclean-shutdown setting is not taking effect if using a reverse proxy, because the mod_ssl translate_hook never gets run. mod_proxy is only one

Re: 2.1 trunk = ab -v 2 segfault

2005-04-15 Thread Joe Orton
On Sat, Mar 26, 2005 at 11:27:27AM +0100, Alexander Lazic wrote: Hi, i use the 2.1 tunk ab and have found 2 segfaults, it think. the first one was easy to find: in ssl_print_cert_info() the buf is 64 not BUFSIZ for eg. =X509_NAME_oneline(dn, buf, BUFSIZ); The second one was not so

Re: svn commit: r160348 - httpd/httpd/trunk/server/core_filters.c

2005-04-15 Thread Joe Orton
On Thu, Apr 14, 2005 at 12:02:35PM -0700, Wilfredo Snchez Vega wrote: We're investigating possible issues in the system. One comment from a kernel developer: We are returning EWOULDBLOCK because the socket is in non-blocking. Inspecting the socket, so_state is 0x182 (0x100 is

Re: [STATUS] (httpd-2.1) Wed Apr 13 23:46:37 2005

2005-04-15 Thread Joe Orton
On Thu, Apr 14, 2005 at 04:12:25PM -0400, Geoff Thorpe wrote: On April 13, 2005 11:46 pm, Rodent of Unusual Size wrote: TODO ISSUES REMAINING IN MOD_SSL: [snip] * the shmcb code should just align its memory segment rather than jumping through all the safe memcpy and memset hoops

Re: 2.0.54 release candidate tarball available for testing

2005-04-12 Thread Joe Orton
On Tue, Apr 12, 2005 at 09:25:22AM +0200, Sander Striker wrote: Hi, As usual the tarballs are at: http://httpd.apache.org/dev/dist/ Please give 2.0.54 a whirl and report any problems (or successes) ;) +1 for release, looks good in httpd-test'ing here. Thanks for RMing. joe

Re: svn commit: r160909 - httpd/httpd/branches/2.0.x/modules/experimental/mod_cache.c

2005-04-11 Thread Joe Orton
On Mon, Apr 11, 2005 at 03:47:03PM -, Brad Nicholes wrote: Author: bnicholes Date: Mon Apr 11 08:47:03 2005 New Revision: 160909 URL: http://svn.apache.org/viewcvs?view=revrev=160909 Log: Fix a const/non-const conversion error when building with the strict Metrowerks compiler What

Re: [PATCH] mod_proxy_http

2005-04-01 Thread Joe Orton
On Wed, Mar 30, 2005 at 07:40:13PM +0200, Sander Striker wrote: It seems like mod_proxy_http is being cute and not sending an EOS bucket down the rest of the filter stack when it only receives headers. This (most likely) causes mod_cache's cache_save_filter to not be run when it receives a

Re: Flushing lingering CGI processes

2005-03-31 Thread Joe Orton
On Wed, Mar 30, 2005 at 11:02:05PM +0100, Nick wrote: I understand that if a CGI process is launched then gets stuck, if the CGI process keeps quiet, the apache server will not 'know' the http connection has broken so will not 'know' to kill the CGI process. The stuck CGI process and the

Re: scrap dbmmanage in favor of htdbm for 2.2? document as deprecated in 2.0?

2005-03-30 Thread Joe Orton
On Wed, Mar 30, 2005 at 04:58:40AM -0500, Jeff Trawick wrote: dbmmanage can be out of sync with Apache w.r.t. database formats used. htdbm uses exactly the same code as Apache so the set of database formats is the same and the default preference is the same. The dbmmanage script has to be

RFC: UserDir off by default for 2.1/2.2

2005-03-30 Thread Joe Orton
Enabling UserDir by default can allow remote users to determine whether a given username is valid on the system or not, even if no users have a public_html directory, from the difference between a 403 from a chmod 700 /home/realuser and a 404 from not finding /home/nosuchuser. After a few

Re: svn commit: r159470 - in httpd/httpd/branches/2.0.x: CHANGES STATUS include/mpm_common.h server/mpm/worker/worker.c server/mpm_common.c

2005-03-30 Thread Joe Orton
On Wed, Mar 30, 2005 at 12:16:03PM -0600, William Rowe wrote: At 03:42 AM 3/30/2005, [EMAIL PROTECTED] wrote: New Revision: 159470 URL: http://svn.apache.org/viewcvs?view=revrev=159470 *) Unix MPMs: Shut down the server more quickly when child processes are slow to exit. [Joe Orton

Re: svn commit: r157948 - in httpd/httpd/trunk/srclib/pcre: pcre.c study.c

2005-03-22 Thread Joe Orton
On Thu, Mar 17, 2005 at 05:50:31PM -, William Rowe wrote: Author: wrowe Date: Thu Mar 17 09:50:29 2005 New Revision: 157948 URL: http://svn.apache.org/viewcvs?view=revrev=157948 Log: Fix three problems with pcre for portability; 1. study.c's pointer arg didn't jive with

Re: Apache2 troubles with shmcb SSLSessionCache...

2005-03-21 Thread Joe Orton
On Fri, Mar 18, 2005 at 12:12:15PM -0500, Daniel Freedman wrote: Anyway, I'm using apache 2.0.53 (mpm-prefork) on Debian testing on two different ia32 machines, with generally similar installs, and exhibiting the following problem only on one of them (which complicates the problem, in my

Re: Bug handling Upgrade: TLS/1.0 header in ssl_engine_io.c

2005-03-10 Thread Joe Orton
On Tue, Mar 08, 2005 at 08:54:52PM -0700, Joel J Smith wrote: Hi httpd folks, It seems that Joe Orton introduced a bug while updating ssl_engine_io.c between version 109499 and version 59. The same bug was introduced into NetWare's mod_nw_ssl.c version 111327. (Please forgive me if that's

Re: svn commit: r156574 - in httpd/httpd/trunk: modules/generators/config5.m4 server/mpm/config.m4

2005-03-09 Thread Joe Orton
On Tue, Mar 08, 2005 at 10:40:35PM -, Paul Querna wrote: ... --- httpd/httpd/trunk/server/mpm/config.m4 (original) +++ httpd/httpd/trunk/server/mpm/config.m4 Tue Mar 8 14:40:33 2005 @@ -12,7 +12,25 @@ apache_cv_mpm=$APACHE_MPM -if test $apache_cv_mpm = worker -o

Re: piped log bug?

2005-03-08 Thread Joe Orton
On Tue, Mar 08, 2005 at 09:01:20PM +0200, Arkadi Shishlov wrote: On Tue, Mar 08, 2005 at 01:22:46PM -0500, Jeff Trawick wrote: On Tue, 08 Mar 2005 19:00:05 +0200, Arkadi Shishlov [EMAIL PROTECTED] wrote: So is there any progress with the issue or just nobody is interested? me

Re: svn commit: r156032 - httpd/httpd/branches/1.3.x/STATUS

2005-03-03 Thread Joe Orton
On Thu, Mar 03, 2005 at 06:56:47AM -0500, Jeff Trawick wrote: On Thu, 03 Mar 2005 11:20:29 -, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: jorton Date: Thu Mar 3 03:20:27 2005 New Revision: 156032 URL: http://svn.apache.org/viewcvs?view=revrev=156032 Log: Third time

Re: [VOTE] 2.1.3 as beta

2005-02-25 Thread Joe Orton
On Wed, Feb 23, 2005 at 10:22:12PM +, Nick Kew wrote: William A. Rowe, Jr. wrote: As to Nick's comment, I certainly agree with your position, there is not enough adoption of APR to -not- roll in the apr/apr-util Isn't that chicken-and-egg? APR is seen as part of Apache(httpd) by

Re: Listen 0.0.0.0:port is invalid

2005-02-23 Thread Joe Orton
On Tue, Feb 22, 2005 at 10:52:57PM -0800, Justin Erenkrantz wrote: No idea why I'm suddenly hitting this, but in preparation for 2.1.3, I spent another one of my patented hours searching for bugs in httpd that end up being bugs in the perl-framework tests. =( perl-framework generates

Re: Listen 0.0.0.0:port is invalid

2005-02-23 Thread Joe Orton
On Wed, Feb 23, 2005 at 09:42:12AM +, Joe Orton wrote: On Tue, Feb 22, 2005 at 10:52:57PM -0800, Justin Erenkrantz wrote: The issue with this is that wildcard IP addresses aren't really supposed to be explicit in Listen statements. httpd has a bunch of logic for inferring the right

Re: [VOTE] 2.1.3 as beta

2005-02-23 Thread Joe Orton
On Tue, Feb 22, 2005 at 11:04:54PM -0800, Justin Erenkrantz wrote: 2.1.3 tarballs at: http://httpd.apache.org/dev/dist/ Thanks, as ever! I'd like to get enough votes for 2.1.3 to be a beta and commence the feature freeze towards a 2.2.0 GA. Tested across a variety of Linuxes here, +1 for

Re: Use of brigade_split...

2005-02-18 Thread Joe Orton
On Fri, Feb 18, 2005 at 01:12:52AM -0800, Paul Querna wrote: First, let me say that apr_brigade_split is evil. Specifically the combination of apr_brigade_split() and an apr_brigade_destroy() which is a noop, yes; #23567 is another example of a leak caused by this. I'd also concluded that

Re: [PATCH] get a pointer to the raw cert from mod_ssl

2005-02-15 Thread Joe Orton
On Mon, Feb 14, 2005 at 05:51:50PM +, David Reid wrote: Joe Orton wrote: Here's an alternative implementation: does it work for you? This looks good to me and seems to work as required. Great! Care to commit it? Now done. joe

Re: [PATCH] PCRE/regex shakeup part 1

2005-02-14 Thread Joe Orton
On Sat, Feb 12, 2005 at 08:37:08AM +1100, NormW wrote: The following simple 'update' to the NWGNUmakefile in the 2.1 root gets the build process back on track and to completion for NetWare. Not tested the resulting build as yet, tho. :-) I applied that, thanks Norm. joe

Re: [PATCH] PCRE/regex shakeup part 1

2005-02-11 Thread Joe Orton
On Thu, Feb 10, 2005 at 09:46:11AM -0800, Justin Erenkrantz wrote: --On Thursday, February 10, 2005 3:45 PM + Joe Orton [EMAIL PROTECTED] wrote: No objections to going ahead with this? Not from here. Let's shoot to get the PCRE situation finally resolved for 2.2. -- justin OK

Re: [PATCH] get a pointer to the raw cert from mod_ssl

2005-02-10 Thread Joe Orton
Here's an alternative implementation: does it work for you? Index: ssl_private.h === --- ssl_private.h (revision 153210) +++ ssl_private.h (working copy) @@ -641,6 +641,9 @@ /* Variables */ void

Re: [PATCH] PCRE/regex shakeup part 1

2005-02-10 Thread Joe Orton
No objections to going ahead with this? On Thu, Jan 27, 2005 at 03:01:56PM +, Joe Orton wrote: There are two problems with the use of PCRE in httpd: firstly that there is no support for use of an external pcre library (PR27750), and secondly that use of the pcreposix.h interface can cause

Re: svn commit: r153273 - httpd/httpd/trunk/Makefile.in

2005-02-10 Thread Joe Orton
On Thu, Feb 10, 2005 at 09:17:20AM -0800, Justin Erenkrantz wrote: --On Thursday, February 10, 2005 4:38 PM + [EMAIL PROTECTED] wrote: Author: jorton Date: Thu Feb 10 08:38:47 2005 New Revision: 153273 URL: http://svn.apache.org/viewcvs?view=revrev=153273 Log: * Makefile.in: Use

Re: [PATCH] get a pointer to the raw cert from mod_ssl

2005-02-04 Thread Joe Orton
On Wed, Feb 02, 2005 at 09:08:02PM +, David Reid wrote: William A. Rowe, Jr. wrote: At 04:17 AM 2/2/2005, David Reid wrote: Basically this allows us to gain access to the actual cert structure. Agreed that raw cert isn't that useful, and somewhat frightens me in the environment

Re: svn commit: r126224 - /httpd/httpd/trunk/support/check_forensic

2005-02-03 Thread Joe Orton
On Thu, Feb 03, 2005 at 07:32:32AM -0800, Justin Erenkrantz wrote: On Thu, Feb 03, 2005 at 07:43:48AM -0500, Jeff Trawick wrote: which is not portable... z/OS doesn't have it, and I would assume that z/OS isn't the only reason we've been dragging around PrintPath all this time... Yikes.

Re: svn commit: r126224 - /httpd/httpd/trunk/support/check_forensic

2005-02-03 Thread Joe Orton
On Thu, Feb 03, 2005 at 10:44:47AM -0500, Jeff Trawick wrote: I didn't mean that, but that looks better ;) (what I meant was to use which cut to see if which works; the rest of the script already assumes that cut exists) I'm not sure if throwing away all the output satisfies Joe's concern;

Re: [PATCH] set username from certificates at a more appropriate time

2005-02-02 Thread Joe Orton
I presume this fixes #31418? Your patch makes sense to me. I could argue that it could even be done *before* the SSLRequire checking, such that the username is logged appropriately even if an SSLRequire triggers a 403, but I doubt that matters much. Thanks for looking at this!

Re: [PATCH] set username from certificates at a more appropriate time

2005-02-02 Thread Joe Orton
On Wed, Feb 02, 2005 at 10:07:56AM +, David Reid wrote: William A. Rowe, Jr. wrote: My only concern ... does this new scope pair up properly if the user cert has been renegotiated? If so +1 I'm unable to test that here, but maybe if someone has a system where renegotiation is

Re: [PATCH] get a pointer to the raw cert from mod_ssl

2005-02-02 Thread Joe Orton
On Wed, Feb 02, 2005 at 10:17:04AM +, David Reid wrote: Basically this allows us to gain access to the actual cert structure. I don't like the idea of exposing the X509 * directly especially not through a char * interface. Exposing the DER representation (e.g. base64-encoded) through

Re: [PATCH] get a pointer to the raw cert from mod_ssl

2005-02-02 Thread Joe Orton
On Wed, Feb 02, 2005 at 11:09:47AM +, David Reid wrote: Joe Orton wrote: On Wed, Feb 02, 2005 at 10:17:04AM +, David Reid wrote: Basically this allows us to gain access to the actual cert structure. I don't like the idea of exposing the X509 * directly especially not through

<    7   8   9   10   11   12   13   14   15   16   >