Re: [PATCH] ssl_ext_lookup #2

2005-09-20 Thread Joe Orton
On Tue, Sep 20, 2005 at 12:16:40PM +0200, Martin Kraemer wrote: > To recap the problem, Joe said: > > there > > seems to be a rather annoying fundamental problem: the match_headers > > hooks runs too early to be useful for this when doing per-dir client > > cert negotiation. > > I haven't traced i

Re: Issues for 2.1.8

2005-09-19 Thread Joe Orton
On Sun, Sep 18, 2005 at 02:24:48PM -0700, Paul Querna wrote: > I would like to tag and start a 2.1.8-beta cycle next weekend. Sounds great. I'm going to start looking for things in bugzilla which have regressed since 2.0.x and mark these with the new "regression" keyword which Joshua kindly add

Re: Apache 2.1/2.2/2.3...

2005-09-19 Thread Joe Orton
On Fri, Sep 16, 2005 at 03:49:12PM -0400, Joshua Slive wrote: > > Sander Striker wrote: > > >The latter should never happen. Develop on trunk, merge back to > >stable: 2.2 branch, or 2.2 branch and 2.0 branch. > > > >At least, that's what I envisioned after all the discussion on how > >to move o

Re: [PATCH] Mixed-cased SSLRequire operators in mod_ssl ?

2005-09-19 Thread Joe Orton
On Mon, Sep 19, 2005 at 11:40:24AM +0200, Martin Kraemer wrote: > On Tue, Aug 02, 2005 at 07:14:10PM +0200, Martin Kraemer wrote: > > Of course. BTW: do you think case insensitivity for the keywords > > is a good idea? I do, but I don't know if it would cause > > misinterpretation for some existing

Re: svn commit: r289593 - /httpd/httpd/branches/2.2.x/os/unix/os.h

2005-09-16 Thread Joe Orton
On Fri, Sep 16, 2005 at 12:15:50PM -0500, William Rowe wrote: > Joe Orton wrote: > >On Fri, Sep 16, 2005 at 04:07:04PM -, William Rowe wrote: > >> I'd prefer, before 2.2-final, to have AP_NEED_SET_MUTEX_PERMS defined > >> across all architectures as 1|0. Comm

Re: svn commit: r289593 - /httpd/httpd/branches/2.2.x/os/unix/os.h

2005-09-16 Thread Joe Orton
On Fri, Sep 16, 2005 at 04:07:04PM -, William Rowe wrote: > Author: wrowe > Date: Fri Sep 16 09:07:01 2005 > New Revision: 289593 > > URL: http://svn.apache.org/viewcvs?rev=289593&view=rev > Log: > > I'd prefer, before 2.2-final, to have AP_NEED_SET_MUTEX_PERMS defined > across all archit

Re: [PATCH] ssl_ext_lookup #2

2005-09-15 Thread Joe Orton
On Wed, Sep 14, 2005 at 11:11:44PM +0100, David Reid wrote: > OK, then what about the below. Looks good, +1 with just one nit - it's OK to presume that apr_array_make always succeeds. Thanks David :) (+1 for 2.2.x too) Can we just back out the mod_setenvif stuff from the trunk or is someone go

Re: [PATCH] ssl_ext_lookup #2

2005-09-14 Thread Joe Orton
On Mon, Sep 12, 2005 at 04:02:02PM +0100, David Reid wrote: > Following the comments from Joe, here is a revised patch that should > work better :-) I've tried to add a sensible comment about why we have > both functions listed. "OpenSSL... isn't up to much" isn't really very helpful (or sensible)

Re: [PATCH] ssl_ext_lookup

2005-09-12 Thread Joe Orton
On Sat, Sep 10, 2005 at 02:47:17AM +0100, David Reid wrote: > Following patch makes some changes to ssl_ext_lookup and changes it's > API, hence the post for review. > > Add some more warnings when things don't go as advertised. I don't think it's appropriate to log warnings (at least at APLOG_W

Re: svn commit: r239377 - /httpd/httpd/branches/2.0.x/STATUS

2005-09-12 Thread Joe Orton
On Sat, Sep 10, 2005 at 09:22:59AM -0400, Jeff Trawick wrote: > On 8/23/05, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > +*) Fix CAN-2005-2491, integer overflow in pcre. > > + http://svn.apache.org/viewcvs?rev=233493&view=rev > > + rediff for 2.0: http://people.apache.org/~jor

Re: How do I handle Unicode inside XML request bits?

2005-09-12 Thread Joe Orton
On Sun, Sep 11, 2005 at 05:13:54PM -0700, Brandon Fosdick wrote: ... > The litmus test fails with the message: > > 18. propget... FAIL (Property > {http://webdav.org/neon/litmus/}high-unicode had value , expected > 𐀀) > > Apparently the original text ("𐀀") from the request is

Re: [semi-PATCH] Allow out-of-tree apr/apu source

2005-09-12 Thread Joe Orton
On Sun, Sep 11, 2005 at 11:26:04PM -0700, Sander Temme wrote: > Trying to scratch a personal itch tonight. I'd like to build my > checked out tree against a checkout of {apr,apu}, which sit somewhere > else on my system. As far as I can tell, this is currently not > possible. I tried to point

Re: missing ssl.crt/ssl.key sub directories?

2005-09-02 Thread Joe Orton
On Fri, Sep 02, 2005 at 02:14:24AM -0500, William Rowe wrote: > It seems someone collapsed the ssl.crt/ and ssl.key/ directories from > the default ssl.conf file for 2.1 dev, yet didn't collapse them entirely > because the ca and other commented-out directives still keep the depth. > > Having ssl.

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-31 Thread Joe Orton
On Wed, Aug 31, 2005 at 06:54:03AM -0400, Jeff Trawick wrote: > On 8/31/05, Colm MacCarthaigh <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 31, 2005 at 10:24:49AM +0100, Joe Orton wrote: > > > Apologies for the previous empty mail ;) > > > > > > If the

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-31 Thread Joe Orton
On Tue, Aug 30, 2005 at 10:37:07PM +0100, Colm MacCarthaigh wrote: > On Tue, Aug 30, 2005 at 06:00:47PM +0100, Colm MacCarthaigh wrote: > > On Tue, Aug 30, 2005 at 05:25:07PM +0100, Joe Orton wrote: > > > So is mod_cgid still the default CGI module for worker because there >

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-30 Thread Joe Orton
On Tue, Aug 30, 2005 at 10:37:07PM +0100, Colm MacCarthaigh wrote: > On Tue, Aug 30, 2005 at 06:00:47PM +0100, Colm MacCarthaigh wrote: > > On Tue, Aug 30, 2005 at 05:25:07PM +0100, Joe Orton wrote: > > > > This has all sorts of consequences, the most annoying of which is th

Re: svn commit: r264737 - /httpd/httpd/trunk/docs/manual/stopping.xml

2005-08-30 Thread Joe Orton
On Tue, Aug 30, 2005 at 02:27:20PM +0100, Colm MacCarthaigh wrote: > On Tue, Aug 30, 2005 at 08:24:17AM -, [EMAIL PROTECTED] wrote: > > module="mpm_common">PidFile and cease listening on > > all ports. The parent will continue to run, and monitor children > > which are handling r

Re: Status of 2.1.7g

2005-08-30 Thread Joe Orton
On Tue, Aug 30, 2005 at 01:01:40PM +0100, Colm MacCarthaigh wrote: > On Mon, Aug 29, 2005 at 09:58:12PM -0700, Paul Querna wrote: > > We did find several non-showstopper issues with this tag. If anyone has > > a few spare minutes, it would be good to start back porting these from > > trunk to the

Re: mod_log_config: log thread id in hex

2005-08-30 Thread Joe Orton
On Sat, Aug 27, 2005 at 11:12:24AM -0400, Jeff Trawick wrote: > %{tid}P gets you thread id in decimal now. > %{hextid}P would show it in hex using relatively new apr_sprintf() > format, added in 1.2.0. Seems fine except that it introduces a softish dependency on apr >= 1.2.0 which is not enforced

Re: Status of PR 29528? (Memory leaks in mod_cgid)

2005-08-26 Thread Joe Orton
On Fri, Aug 26, 2005 at 10:03:55AM -0700, Justin Erenkrantz wrote: > I just had to upgrade my personal server to Solaris 10. With 2.0.54, I'm > now getting the mod_cgid process (Worker MPM) taking up GBs of memory. Eek. That sounds more like: http://issues.apache.org/bugzilla/show_bug.cgi?id=3

Re: PATCH: lazy initialization of TCP_NODELAY (workaround for 2.6 TCP_CORK problem)

2005-08-26 Thread Joe Orton
On Fri, Aug 26, 2005 at 01:23:15AM -0700, Brian Pane wrote: > > On Aug 26, 2005, at 12:55 AM, Joe Orton wrote: > > >On Fri, Aug 26, 2005 at 12:42:19AM -0700, Brian Pane wrote: > > > >>The attached patch delays the setting of TCP_NODELAY on client > &

Re: PATCH: lazy initialization of TCP_NODELAY (workaround for 2.6 TCP_CORK problem)

2005-08-26 Thread Joe Orton
On Fri, Aug 26, 2005 at 12:42:19AM -0700, Brian Pane wrote: > The attached patch delays the setting of TCP_NODELAY on client > connections until the first time core_output_filter has to do a > writev_it_all() or emulate_sendfile(). My motivation for this is to > work around the TCP_NODELAY/TCP_C

Re: 2.1.7 Available for Testing & Voting

2005-08-25 Thread Joe Orton
On Thu, Aug 25, 2005 at 04:36:06PM +0100, Colm MacCarthaigh wrote: > On Thu, Aug 25, 2005 at 11:29:17AM -0400, Jeff Trawick wrote: > > With this patch I can tell from syscall trace that we only get one > > socket now. But server dies mysteriously later. The mysterious death > > doesn't occur with

Re: 2.1.7 Available for Testing & Voting

2005-08-25 Thread Joe Orton
On Thu, Aug 25, 2005 at 09:09:18AM -0400, Jeff Trawick wrote: > On 8/22/05, Jeff Trawick <[EMAIL PROTECTED]> wrote: > > On 8/20/05, Paul Querna <[EMAIL PROTECTED]> wrote: > > > Bundled with APR & APR-Util 1.2.1: > > > http://people.apache.org/~pquerna/dev/httpd-2.1.7/ > > > > > > Please test and vo

Re: Graceful stop implementation nits

2005-08-25 Thread Joe Orton
On Thu, Aug 25, 2005 at 11:01:14AM +0100, Colm MacCarthaigh wrote: > Now that the ap_close_listeners() code is committed, implementing a > graceful stop is relatively trivial, I already have it working here for > me. However there are some complicated nits which I thought I'd solicit > feedback on.

Re: svn commit: r239711 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c

2005-08-24 Thread Joe Orton
On Wed, Aug 24, 2005 at 08:18:35PM +0100, Colm MacCarthaigh wrote: > On Wed, Aug 24, 2005 at 08:08:51PM +0100, Joe Orton wrote: > > On Wed, Aug 24, 2005 at 12:02:37PM -0700, Justin Erenkrantz wrote: > > > --On August 24, 2005 4:58:14 PM + [EMAIL PROTECTED] wrote: > >

Re: svn commit: r239711 - /httpd/httpd/trunk/server/mpm/prefork/prefork.c

2005-08-24 Thread Joe Orton
On Wed, Aug 24, 2005 at 12:02:37PM -0700, Justin Erenkrantz wrote: > --On August 24, 2005 4:58:14 PM + [EMAIL PROTECTED] wrote: > >This means that the listening sockets are freed for re-use. In the > >ordinary case, this makes no difference. However if for example admin > >changes "Listen 80" t

Re: Rev: 2.1.7 Available for Testing & Voting

2005-08-24 Thread Joe Orton
On Wed, Aug 24, 2005 at 10:32:12AM -0700, Sander Temme wrote: > I'm running with this patch, with -DDEBUG, on FreeBSD 4.10 (and Darwin): > > http://marc.theaimsgroup.com/?l=apache-httpd-dev&m=111435689526926&w=2 That patch looks OK, have you sent it upstream (or checked whether it is fixed in la

Re: svn commit: r239710 - in /httpd/httpd/trunk: include/ap_listen.h server/listen.c

2005-08-24 Thread Joe Orton
On Wed, Aug 24, 2005 at 04:51:24PM -, [EMAIL PROTECTED] wrote: > Author: colm > Date: Wed Aug 24 09:51:20 2005 > New Revision: 239710 > > URL: http://svn.apache.org/viewcvs?rev=239710&view=rev ... > +/** > + * Loop through the global ap_listen_rec list and close each of the sockets. > + */ >

Re: TCP_CORK in Linux 2.6: not broken, but it doesn't work with TCP_NODELAY

2005-08-23 Thread Joe Orton
On Mon, Aug 22, 2005 at 03:19:58PM +0100, Joe Orton wrote: > On Mon, Aug 22, 2005 at 02:52:38PM +0100, Joe Orton wrote: > > With the FC4 2.6.12-ish kernel I am seeing: > > > > - stuff sent by httpd fails to cork properly; partial frames are sent > >

Re: TCP_CORK in Linux 2.6: not broken, but it doesn't work with TCP_NODELAY

2005-08-22 Thread Joe Orton
On Mon, Aug 22, 2005 at 02:52:38PM +0100, Joe Orton wrote: > With the FC4 2.6.12-ish kernel I am seeing: > > - stuff sent by httpd fails to cork properly; partial frames are sent > ... i.e. what Greg reported. > > - stuff sent by your test case *does* get corked pro

Re: TCP_CORK in Linux 2.6: not broken, but it doesn't work with TCP_NODELAY

2005-08-22 Thread Joe Orton
On Sun, Aug 21, 2005 at 04:25:19PM -0700, Brian Pane wrote: > I've attached my test program in case it's useful to others. It's > run as > sendfile_test [--cork] [--nodelay] [--nonblock] filename > listener_port_number. This is rather useful, thanks Brian. I think you're missing the fact t

Re: 2.1.7 Available for Testing & Voting

2005-08-22 Thread Joe Orton
On Sun, Aug 21, 2005 at 03:58:00AM +0100, Nick Kew wrote: > On Sunday 21 August 2005 03:51, Nick Kew wrote: > > On Saturday 20 August 2005 20:27, Paul Querna wrote: > > > Bundled with APR & APR-Util 1.2.1: > > Oh, and, erm, _surely_ it must be time to unbundle those, > along with some of the other

Re: 2.1.7 Available for Testing & Voting

2005-08-22 Thread Joe Orton
On Sat, Aug 20, 2005 at 12:27:00PM -0700, Paul Querna wrote: > Bundled with APR & APR-Util 1.2.1: > http://people.apache.org/~pquerna/dev/httpd-2.1.7/ > > Please test and vote on releasing 2.1.7 as beta. Looks good from manual install and httpd-test run on: PASS: RHEL4/i686 RHEL3/i686 RHEL4/i686

Re: Rolling 2.1.7 On Friday

2005-08-20 Thread Joe Orton
On Sat, Aug 20, 2005 at 07:51:48AM -0400, Jim Jagielski wrote: > Joe Orton wrote: > > > > On Fri, Aug 19, 2005 at 03:07:03PM -0400, Jim Jagielski wrote: > > > On Aug 19, 2005, at 2:10 PM, Mladen Turk wrote: > > > >I said initially that you will have a proble

Re: Rolling 2.1.7 On Friday

2005-08-20 Thread Joe Orton
On Fri, Aug 19, 2005 at 03:07:03PM -0400, Jim Jagielski wrote: > On Aug 19, 2005, at 2:10 PM, Mladen Turk wrote: > >I said initially that you will have a problems with that patch. > >Since you don't have a windows platform, someone else might > >test that too. I'm on vacation starting tomorrow, so

Re: Rolling 2.1.7 On Friday

2005-08-19 Thread Joe Orton
On Fri, Aug 19, 2005 at 10:17:45AM -0400, Jim Jagielski wrote: > Well, what do you know. The balancer had never had any test cases > at ALL in httpd-test... A you've blown my sarcasm inhibitor now cap'n, I can't help it... Gee, really? Would that be why nobody seems sure whether it actually

Re: Rolling 2.1.7 On Friday

2005-08-19 Thread Joe Orton
On Fri, Aug 19, 2005 at 09:50:24AM -0400, Jim Jagielski wrote: > > On Aug 19, 2005, at 9:32 AM, Jim Jagielski wrote: > > >What platform... seems to work fine under Linux and OS X. > > > >This is what add_lbmethods does... > > > >Did you do a complete make diskclean and then rebuild? > > > > I've

Re: Some RFC 2616 questions

2005-08-19 Thread Joe Orton
On Thu, Aug 18, 2005 at 03:56:48PM -0700, Wilfredo Sánchez Vega wrote: > The spec for If-{None-}Match and If-{Un}Modified-Since is driving > me batty. > > The biggest item has to do with having to know the response code > for the request without processing the request. Specifically, 14.24

Re: Rolling 2.1.7 On Friday

2005-08-18 Thread Joe Orton
On Thu, Aug 18, 2005 at 06:28:56PM -0500, William Rowe wrote: > At 03:36 AM 8/18/2005, Joe Orton wrote: > >On Wed, Aug 17, 2005 at 10:43:01PM -0700, Paul Querna wrote: > >> Just a heads up, I am planning to RM and tag 2.1.7 (and re-branch from > >> trunk the 2.2.x br

Re: Rolling 2.1.7 On Friday

2005-08-18 Thread Joe Orton
On Wed, Aug 17, 2005 at 10:43:01PM -0700, Paul Querna wrote: > Just a heads up, I am planning to RM and tag 2.1.7 (and re-branch from > trunk the 2.2.x branch) on Friday or Saturday this week. I intend to > include APR and APR-Util 1.2.1 with this release. Sounds great. Can you exclude the mod_s

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-08-16 Thread Joe Orton
On Tue, Aug 16, 2005 at 04:45:41PM +0100, David Reid wrote: > Joe Orton wrote: > > On Mon, Aug 15, 2005 at 02:36:18PM +0100, Joe Orton wrote: > > > >>I just went to write a test case for the SetEnvIf function, and there > >>seems to be a rather annoying funda

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-08-16 Thread Joe Orton
On Mon, Aug 15, 2005 at 02:36:18PM +0100, Joe Orton wrote: > I just went to write a test case for the SetEnvIf function, and there > seems to be a rather annoying fundamental problem: the match_headers > hooks runs too early to be useful for this when doing per-dir client > cert neg

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-08-15 Thread Joe Orton
On Fri, Aug 05, 2005 at 08:00:01PM +0200, Martin Kraemer wrote: > On Tue, Aug 02, 2005 at 07:14:10PM +0200, Martin Kraemer wrote: > > I wanted something like > > > > SSLRequire "committers" in SSLPeerExtList("1.3.6.1.4.1.18060.1"); > > > > to mean "at least one extension with an OID of > > 1.3.

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

2005-08-12 Thread Joe Orton
On Fri, Aug 12, 2005 at 07:59:49AM +0100, Joe Orton wrote: > On Thu, Aug 11, 2005 at 07:56:38PM +0100, Nick Kew wrote: > > Justin Erenkrantz wrote: > > > > >>Fix ProxyPassReverse & family to work correctly in > > > > > > > > >This co

Re: svn commit: r231355 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c mod_proxy.h mod_proxy_http.c

2005-08-12 Thread Joe Orton
On Thu, Aug 11, 2005 at 07:56:38PM +0100, Nick Kew wrote: > Justin Erenkrantz wrote: > > >>Fix ProxyPassReverse & family to work correctly in > > > > > >This commit broke the build. > > Aaargh! Careless cut&paste. Sorry. Fixed - thanks. proxy_util.c: In function `ap_proxy_location_reverse_ma

Re: Compiling Apache-2.1.6-alpha error on SLES9 x86_64

2005-08-11 Thread Joe Orton
On Thu, Aug 11, 2005 at 03:06:51PM +0200, Andreas Steinmetz wrote: > Hu, Xuekun wrote: ... > > Since this is 64 bit, libexpat.la should be reference to /usr/lib64 > > instead of /usr/lib. ... > > > > Since some Linux (64bit) distributions maybe have lib/libexpat.la file, > > so I put the lib64 ch

Re: libssl as new core dependency ?

2005-08-10 Thread Joe Orton
On Tue, Aug 09, 2005 at 10:40:28PM +0100, Colm MacCarthaigh wrote: > mod_setenvif.c:126: error: syntax error before '*' token > mod_setenvif.c:126: warning: data definition has no type or storage class > mod_setenvif.c: In function `match_headers': > mod_setenvif.c:542: error: called object is not

Re: svn commit: r230733 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

2005-08-09 Thread Joe Orton
On Tue, Aug 09, 2005 at 11:40:36AM -0500, William Rowe wrote: > At 04:38 AM 8/9/2005, Joe Orton wrote: > > >Great, yes with last night's regression run the segfaults with worker > >were gone and the tests are all passing for prefork and worker again on > >the trunk

Re: RTC killed the open source project

2005-08-09 Thread Joe Orton
On Tue, Aug 09, 2005 at 09:05:45AM -0700, Paul Querna wrote: > The current blocking issue in APR & APR-Util is that we can *only* > release apr and apr-util of the exact same version number, due to > problems in the Netware build system. This means to release APR 1.2.0, > we must release APR-Util

Re: svn commit: r230733 - /httpd/httpd/trunk/modules/proxy/mod_proxy_http.c

2005-08-09 Thread Joe Orton
On Mon, Aug 08, 2005 at 07:11:39AM -0500, William Rowe wrote: > At 09:51 PM 8/7/2005, [EMAIL PROTECTED] wrote: > >Author: wrowe > >Date: Sun Aug 7 19:51:32 2005 > >New Revision: 230733 > > > >URL: http://svn.apache.org/viewcvs?rev=230733&view=rev > >Log: > > > > Fix a double-termination case in s

Re: CTR policy for experimental modules in A2.0?

2005-08-09 Thread Joe Orton
On Mon, Aug 08, 2005 at 01:46:30PM -0700, Paul Querna wrote: > Bill Stoddard wrote: > > Jim Jagielski wrote: > > > >> I have a bug I'd like to squash in mod_auth_ldap.c in 2.0 that doesn't > >> exist in 2.1/2.2 (non-existent authn_ldap_request_t req struct during > >> auth check)... since the modu

Re: svn commit: r230592 - in /httpd/httpd/branches/2.0.x: CHANGES STATUS modules/proxy/proxy_http.c

2005-08-07 Thread Joe Orton
On Sat, Aug 06, 2005 at 06:54:45PM -0500, William Rowe wrote: > At 05:28 PM 8/6/2005, Joe Orton wrote: > >That patch went through the normal 2.0.x review process and received > >three +1s and no vetoes. You absolutely cannot come along a few months > >later and say "

Re: svn commit: r230592 - in /httpd/httpd/branches/2.0.x: CHANGES STATUS modules/proxy/proxy_http.c

2005-08-06 Thread Joe Orton
On Sat, Aug 06, 2005 at 09:29:13PM -, William Rowe wrote: > Author: wrowe > Date: Sat Aug 6 14:29:05 2005 > New Revision: 230592 > > URL: http://svn.apache.org/viewcvs?rev=230592&view=rev > Log: > > As much as it pains me, seriously, it seems that reviewing the re-backport > of this code

Re: svn commit: r230453 - /httpd/httpd/trunk/server/vhost.c

2005-08-05 Thread Joe Orton
On Fri, Aug 05, 2005 at 09:40:23AM -0400, Joshua Slive wrote: > > > [EMAIL PROTECTED] wrote: > > >+return "Cannot not resolve address '0.0.0.0' -- " > > double negative Ha, I started off with "Could not"... but then changed it when I saw it was inconsistent with the other error :)

Re: [PATCH] fix util_ldap with older OpenLDAPs

2005-08-03 Thread Joe Orton
On Wed, Aug 03, 2005 at 11:24:49AM -0600, Brad Nicholes wrote: >This is why I would like to see the release of 2.2 as soon as > possible. My only explanation is that I missed changing the NULL > parameter to ldc->ldap when I did the backport of the conversion from > global to per-connection fr

Re: Problems in apr_rmm.c

2005-08-03 Thread Joe Orton
On Tue, Aug 02, 2005 at 04:26:44PM -0400, Fenlason, Josh wrote: > Has anyone seen any problems in apr_rmm.c on systems with shared memory > and ldap enabled? > When I stop Apache via Crtl-C, I'm getting the Windows error saying that > something is a miss in Apache. Stepping into the debugger, reve

Re: [PATCH] fix util_ldap with older OpenLDAPs

2005-08-03 Thread Joe Orton
On Wed, Jul 27, 2005 at 09:59:18PM +0100, Joe Orton wrote: > Since 2.0.54, it seems mod_auth_ldap just segfaults on any request if > built against older versions of OpenLDAP, 2.2.20 and earlier (pre-2005). I worked this out a little better. It triggers only the *second* time th

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-08-02 Thread Joe Orton
On Tue, Aug 02, 2005 at 03:23:44PM +0200, Martin Kraemer wrote: > On Tue, Aug 02, 2005 at 12:00:24PM +0100, Joe Orton wrote: > >> 1) this is a pretty specific to way to code it. Is there no way to make > >> it more general so that OID() is just a function like file() and can

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-08-02 Thread Joe Orton
On Fri, Jul 22, 2005 at 02:24:50PM +0200, Sander Striker wrote: > Joe Orton wrote: > >On Fri, Jul 22, 2005 at 12:11:56PM -, Martin Kraemer wrote: > > > >>Author: martin > >>Date: Fri Jul 22 05:11:55 2005 > >>New Revision: 220307 > >> > &g

Re: Thinkng something like this for mod_auth_svn

2005-08-01 Thread Joe Orton
On Mon, Aug 01, 2005 at 02:32:50AM -0700, Dirk-Willem van Gulik wrote: > Ok found the problem; turns out that if openssl does not have the > extension hardcoded in its objects.c (from objects.txt in crypto/objects; > compiled by a objects.pl perl scripts) then X509V3_EXT_print() does not do > anyth

Re: [PATCH] fix util_ldap with older OpenLDAPs

2005-07-28 Thread Joe Orton
On Wed, Jul 27, 2005 at 11:39:36PM +0200, Graham Leggett wrote: > Joe Orton wrote: > >Any objections to this? > > None at all - if the v2.0 code can be made more stable this is always a > good thing, but there are lots more problems in the v2.0 code that are > fixed in

[PATCH] fix util_ldap with older OpenLDAPs

2005-07-27 Thread Joe Orton
Since 2.0.54, it seems mod_auth_ldap just segfaults on any request if built against older versions of OpenLDAP, 2.2.20 and earlier (pre-2005). It looks like this was another regression caused the addition of the LDAPConnectionTimeout option. (New features, stable branch, regressions? Hmmm, I

Re: [PATCH] graceful restart bug as opportunity

2005-07-27 Thread Joe Orton
On Wed, Jul 27, 2005 at 12:40:58PM +0100, Colm MacCarthaigh wrote: > configure.in makes a big deal about determining AP_SIG_GRACEFUL, which > defaults to SIGUSR1, but uses SIGWINCH on Linux 2.0. But then > mpm_common.c goes ahead and ignores this for actually sending the > signal, SIGUSR1 is hard-c

Re: Missing Features of htdigest.c

2005-07-25 Thread Joe Orton
On Mon, Jul 25, 2005 at 08:24:39AM -0400, Geoffrey Young wrote: > I'll write an htpasswd replacement that will > > - allow for management of users using Basic or Digest algorithms > - allow for varying data stores > - allow for varying user algorithms (mixing of Basic and Digest in the > sam

Re: svn commit: r220307 - in /httpd/httpd/trunk/modules: metadata/mod_setenvif.c ssl/mod_ssl.c ssl/mod_ssl.h ssl/ssl_expr_eval.c

2005-07-22 Thread Joe Orton
On Fri, Jul 22, 2005 at 12:11:56PM -, Martin Kraemer wrote: > Author: martin > Date: Fri Jul 22 05:11:55 2005 > New Revision: 220307 > > URL: http://svn.apache.org/viewcvs?rev=220307&view=rev > Log: > Allow extraction of the values of SSL certificate extensions into > environment variables, so

Re: svn commit: r219940 - in /httpd/httpd/trunk: docs/manual/mod/mod_ssl.xml modules/ssl/ssl_expr.h modules/ssl/ssl_expr_eval.c modules/ssl/ssl_expr_parse.y modules/ssl/ssl_expr_scan.l

2005-07-22 Thread Joe Orton
On Fri, Jul 22, 2005 at 11:12:07AM +0100, Joe Orton wrote: > On Wed, Jul 20, 2005 at 04:42:59PM -, Martin Kraemer wrote: > > Author: martin > > Date: Wed Jul 20 09:42:58 2005 > > New Revision: 219940 > > > > URL: http://svn.apache.org/viewcvs?rev=219940&am

Re: svn commit: r219940 - in /httpd/httpd/trunk: docs/manual/mod/mod_ssl.xml modules/ssl/ssl_expr.h modules/ssl/ssl_expr_eval.c modules/ssl/ssl_expr_parse.y modules/ssl/ssl_expr_scan.l

2005-07-22 Thread Joe Orton
On Wed, Jul 20, 2005 at 04:42:59PM -, Martin Kraemer wrote: > Author: martin > Date: Wed Jul 20 09:42:58 2005 > New Revision: 219940 > > URL: http://svn.apache.org/viewcvs?rev=219940&view=rev > Log: > Collaborative work: (Thanks, dreid!) > Implement OID checking for mod_ssl. This code allows f

Re: svn commit: r219520 - /httpd/httpd/branches/2.2.x/

2005-07-19 Thread Joe Orton
On Mon, Jul 18, 2005 at 11:58:21AM -0500, William Rowe wrote: > Thanks Paul, you just collided with the refactoring of 2.1.x proxy. Is this refactoring complete? Apart from the compiler warnings, a bunch of the t/ssl/proxy.t tests have started failing with the trunk code. With worker, the serv

Re: [patch 1.3] The http_protocol.c C-L + T-E patch

2005-07-19 Thread Joe Orton
On Tue, Jul 19, 2005 at 02:59:14PM -0500, William Rowe wrote: > Paul? Joe? Jeff? Someone? > > This is the only showstopper to a 1.3.34 candidate today, > since 1.3.x/src/modules/proxy/mod_proxy.c rejects T-E > for proxy request bodies. Since the 1.3 proxy already rejects such requests what d

Re: svn commit: r218978 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_http.c

2005-07-19 Thread Joe Orton
On Thu, Jul 14, 2005 at 07:43:35AM -0400, Jeff Trawick wrote: > I'm so confused while trying to draw the line between > > alternate RFC-compliant philosophy > fixes for actual RFC violations > fixes for security issues > > I think CHANGES should be crystal clear on what change has a security > im

Re: Apache in a loop during startup

2005-07-19 Thread Joe Orton
On Tue, Jul 19, 2005 at 01:02:56AM -0700, Dirk-Willem van Gulik wrote: > > with config: > > SSLSessionCache dbm:/var/run/ssl_scache > SSLSessionCacheTimeout 300 > SSLMutexfile:/var/run/ssl_mutex Using s/shmcb/dbm/ and "SSLMutex default" is IMO the best

Re: svn commit: r209827 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ssl.html.en docs/manual/mod/mod_ssl.xml modules/ssl/mod_ssl.c modules/ssl/ssl_engine_config.c modules/ssl/ssl_private.h

2005-07-08 Thread Joe Orton
On Fri, Jul 08, 2005 at 03:58:47PM -, Jim Jagielski wrote: > Author: jim > Date: Fri Jul 8 08:58:46 2005 > New Revision: 209827 > > URL: http://svn.apache.org/viewcvs?rev=209827&view=rev > Log: > Good suggestion from a private Email. name changes. "nonenotnull" is a *good* name suggestion?

Re: [PATCH] Allow for internal OpenSSL Session Cache

2005-07-08 Thread Joe Orton
On Tue, Jul 05, 2005 at 01:32:54PM -0400, Jim Jagielski wrote: > I've run into this with some "broken" browsers. Basically, they > require a non-null SessionID in the SSL transaction. If, for whatever > reason, we disable the external SSL Session Cache, these > browsers reports errors when connecti

Re: [Patch 2.0] d2i_SSL_SESSION args for 0.9.7f-/0.9.7g/0.9.8

2005-07-08 Thread Joe Orton
On Fri, Jul 08, 2005 at 09:53:44AM -0500, William Rowe wrote: > > >At 01:48 AM 7/8/2005, Joe Orton wrote: > >>On Thu, Jul 07, 2005 at 06:51:04PM -0500, William Rowe wrote: > >>> > >>> This resolves build issues which caused errors in 0.9.7f and > >

Re: [Patch 2.0] d2i_SSL_SESSION args for 0.9.7f-/0.9.7g/0.9.8

2005-07-08 Thread Joe Orton
On Fri, Jul 08, 2005 at 09:17:29AM -0500, William Rowe wrote: > At 01:48 AM 7/8/2005, Joe Orton wrote: > >On Thu, Jul 07, 2005 at 06:51:04PM -0500, William Rowe wrote: > >> > >> This resolves build issues which caused errors in 0.9.7f and > >> prior on Win32

Re: svn commit: r209723 - /httpd/httpd/trunk/CHANGES

2005-07-08 Thread Joe Orton
On Fri, Jul 08, 2005 at 09:35:58AM -, Paul Querna wrote: > Author: pquerna > Date: Fri Jul 8 02:35:56 2005 > New Revision: 209723 > > URL: http://svn.apache.org/viewcvs?rev=209723&view=rev > Log: > The request smuggling issue did get assigned CAN-2005-2088. Ah, I was just about to commit a d

Re: [Patch 2.0] d2i_SSL_SESSION args for 0.9.7f-/0.9.7g/0.9.8

2005-07-07 Thread Joe Orton
On Thu, Jul 07, 2005 at 06:51:04PM -0500, William Rowe wrote: > Attached is a backport of rev 209530, which demanded a little > bit of rework to make it functional. > > This resolves build issues which caused errors in 0.9.7f and > prior on Win32 and build failures on Netware. This patch > correc

Re: Philosophy, empty body still a request body?

2005-07-07 Thread Joe Orton
On Thu, Jul 07, 2005 at 12:46:03PM -0500, William Rowe wrote: > I didn't assume; I guessed :) > > Thank you for that observation Joe, > > Content-Length: > > is most definitely invalid according to the grammar. Although > the grammar doesn't account for > > Content-Length: 0 "0" does match "

Re: Philosophy, empty body still a request body?

2005-07-07 Thread Joe Orton
On Thu, Jul 07, 2005 at 11:03:33AM -0500, William Rowe wrote: > Cool. Thank you for the clarification. Final question, please > verify my guess that; > > Content-Length: > > is the same as > > Content-Length: 0 Why would you assume that? RFC2616, 14.13: Content-Length= "Content-L

Re: [Patch 1.3] Strict proxy C-L / T-E conformance

2005-07-07 Thread Joe Orton
On Wed, Jul 06, 2005 at 02:53:52PM -0400, Jim Jagielski wrote: > > On Jul 6, 2005, at 2:22 PM, Joe Orton wrote: > > >On Wed, Jul 06, 2005 at 11:45:21AM -0500, William Rowe wrote: > >... > > > >>+else { > >>+

Re: [Patch 1.3] Strict proxy C-L / T-E conformance

2005-07-06 Thread Joe Orton
On Wed, Jul 06, 2005 at 11:45:21AM -0500, William Rowe wrote: ... > +else { > +char *len_end; > +errno = 0; > +c->len = ap_strtol(content_length, &len_end, 10); ... > +if (errno || (c->len < 0) || (len_end && *len_end)) {

Re: Patch for 2.0.54 + OpenSSL 0.9.8

2005-07-06 Thread Joe Orton
On Wed, Jul 06, 2005 at 11:10:33AM -0600, Brad Nicholes wrote: > I think that there are a few more changes that need to be made. At > least on NetWare it won't compile without the following additional > patch. This one needs a typedef which is defined correctly for the version of OpenSSL in us

Re: Include Paths, was Re: error

2005-06-27 Thread Joe Orton
On Mon, Jun 27, 2005 at 12:41:42PM -0700, Paul Querna wrote: > Joe Orton wrote: > > and then upload the preprocessed output "prefork.o" somewhere? Possibly > > you're picking up an installed mpm.h which was generated for a different > > MPM, or something l

Re: error

2005-06-27 Thread Joe Orton
On Mon, Jun 27, 2005 at 02:46:23PM -0400, Cliff Woolley wrote: > On Mon, 27 Jun 2005, Gustavo A. Baratto wrote: > > > prefork.c:103: error: syntax error before '*' token > > prefork.c:103: warning: data definition has no type or storage class > > gmake[4]: *** [prefork.lo] Error 1 > > gmake[4]: Le

Re: svn commit: r202027 - in /httpd/httpd/trunk: CHANGES server/mpm_common.c

2005-06-27 Thread Joe Orton
On Mon, Jun 27, 2005 at 06:40:59PM -, Paul Querna wrote: > Author: pquerna > Date: Mon Jun 27 11:40:56 2005 > New Revision: 202027 > > URL: http://svn.apache.org/viewcvs?rev=202027&view=rev Log: *) > server/mpm_common.c: Send a simple HTTP 1.0 request to every listener > socket, instead of j

Re: event MPM works with mod_ssl

2005-06-27 Thread Joe Orton
On Mon, Jun 27, 2005 at 10:49:26AM -0400, Greg Ames wrote: > my biggest hurdle in getting the event MPM to work with mod_ssl was > learning how to create a self signed server cert with openssl. > http://httpd.apache.org/docs-2.0/ssl/ssl_faq.html#ownca is very good but > refers to a sign.sh scrip

Re: httpd 1.3 mod_cgi argv[0]

2005-06-26 Thread Joe Orton
On Thu, Jun 23, 2005 at 11:23:55AM +0200, David Welton wrote: > [ Ok, trying this again as a subscriber... I guess the list mods missed it:-/ > ] > > Hi, I've managed to tickle an obscure bug in Tcl's environment > introspection by launching a 'starpack' (self contained Tcl > executable+script) a

Re: 2.1.6 is available for veto^H^H^H^Hvoting

2005-06-24 Thread Joe Orton
On Fri, Jun 24, 2005 at 01:03:57AM -0700, Paul Querna wrote: > Please vote on releasing 2.1.6 as -alpha. +1 for alpha, manual test OK and httpd-test passes for this tarball on all-the-linuxes here. joe

Re: 2.1.5 available for testing

2005-06-22 Thread Joe Orton
On Wed, Jun 22, 2005 at 03:02:50PM -0500, William Rowe wrote: > Prior to either patch we totally mishandled such requests. So the > only question which remains is; which behavior do we prefer? > As the RFC states this is not acceptable, my gut says reject ANY > request with both C-L and T-E of non

Re: HTTPD 2.1 (Head) Build issues for NetWare...

2005-06-20 Thread Joe Orton
On Thu, Jun 16, 2005 at 08:43:00AM -0600, Brad Nicholes wrote: > I have run into this one also and I still don't understand why the > make is all of the sudden asking for yacc when this all worked > before. Since neither mod_ssl nor BSD sockets are part of the > standard NetWare

Re: 2.1.5 available for testing

2005-06-20 Thread Joe Orton
On Fri, Jun 17, 2005 at 12:40:50AM -0700, Paul Querna wrote: > Please test and vote on releasing 2.1.5 as -alpha. +1 for alpha, httpd-test'ed on a bunch of Linuxes here, looks good. Thanks Paul! Also +1 on basing the 2.1.x/2.2.x stabilisation branch on this per previous discussion. The C-L vs

Re: [PATCH] sanitize installed config_vars.mk

2005-06-13 Thread Joe Orton
On Fri, Jun 10, 2005 at 11:23:49AM -0700, Paul Querna wrote: > Joe Orton wrote: > > Patch below is an attempt to create a sanitized version of > > config_vars.mk which is suitable for the installed tree. > > > > The currently installed file has lots of references to the

Re: [PATCH] Install should preserve executable flag on files from build/

2005-06-10 Thread Joe Orton
On Thu, Jun 09, 2005 at 03:50:12PM -0700, Daniel Rall wrote: > When attempting to build Subversion trunk against the tip of httpd > trunk, instdso.sh was not set executable as assumed by Subversion's > build process. This is due to mishandling of the executable bit on > files copied into httpd's i

Re: svn commit: r189771 - /httpd/httpd/branches/fips-dev/acinclude.m4

2005-06-10 Thread Joe Orton
On Thu, Jun 09, 2005 at 04:10:54PM -, [EMAIL PROTECTED] wrote: > Author: ben > Date: Thu Jun 9 09:10:53 2005 > New Revision: 189771 > > URL: http://svn.apache.org/viewcvs?rev=189771&view=rev > Log: > Make path check more portable, make specifying a local OpenSSL build > actually work. > @@ -

[PATCH] sanitize installed config_vars.mk

2005-06-10 Thread Joe Orton
Patch below is an attempt to create a sanitized version of config_vars.mk which is suitable for the installed tree. The currently installed file has lots of references to the source and build trees in e.g. EXTRA_INCLUDES, which cause various problems. (PR 28145, 20874, 29771, probably more) The p

Re: svn commit: r189761 - /httpd/httpd/branches/fips-dev/acinclude.m4

2005-06-09 Thread Joe Orton
On Thu, Jun 09, 2005 at 02:57:37PM -, [EMAIL PROTECTED] wrote: > Author: ben > Date: Thu Jun 9 07:57:36 2005 > New Revision: 189761 > > URL: http://svn.apache.org/viewcvs?rev=189761&view=rev > Log: > Die properly when path is bollocks. Did you mean to commit this to the branch? (given that i

Re: svn commit: r189572 - /httpd/httpd/trunk/CHANGES

2005-06-09 Thread Joe Orton
On Wed, Jun 08, 2005 at 08:37:50AM -0700, Paul Querna wrote: > I believe that we should be keeping items in the 2.1.x changelog at > this point, since we have done several releases Ah, sorry, I remember the discussion about this previously but didn't remember if there was consensus on what t

Re: svn commit: r178990 - in /httpd/httpd/trunk: CHANGES server/config.c

2005-06-02 Thread Joe Orton
On Thu, Jun 02, 2005 at 02:05:05PM +0100, Joe Orton wrote: > On Sun, May 29, 2005 at 09:39:40PM -, Paul Querna wrote: > > Author: pquerna > > Date: Sun May 29 14:39:39 2005 > > New Revision: 178990 > > > > URL: http://svn.apache.org/viewcvs?rev=178990&v

Re: svn commit: r178990 - in /httpd/httpd/trunk: CHANGES server/config.c

2005-06-02 Thread Joe Orton
On Sun, May 29, 2005 at 09:39:40PM -, Paul Querna wrote: > Author: pquerna > Date: Sun May 29 14:39:39 2005 > New Revision: 178990 > > URL: http://svn.apache.org/viewcvs?rev=178990&view=rev > Log: > - Use a hash for the configuration command lookup implementation. Now > modules can properly d

<    7   8   9   10   11   12   13   14   15   16   >