Hi,
why not having SCGI_DEFAULT_PORT in a .h file, just as AJP13_DEF_PORT?
This would avoid using SCGI_DEFAULT_PORT in one place and 4000 in another.
Moreover, this could be renamed as SCGI_DEF_PORT to be consistent with AJP.
Just my 2 cents.
CJ
Le 05/05/2014 16:02, traw...@apache.org a écrit
Hi,
The description and the CHANGES are about AH00784 but the patch is only
about adding 'status' to AH00783.
-else if (APR_EEXIST == status) {
+else if (APR_STATUS_IS_EEXIST(status)) {
seems not to change anything.
#define APR_STATUS_IS_EEXIST(s) ((s) == APR_EEXIST)
So, is so
r1588356
Should you share my analysis and should a CHANGE be useful for what I
think is a corner case, feel free to add something, or I can do it by
the end of the week.
Does this fix a crash or a parsing error or ...? (CHANGES)
Hi,
Changelog entry is about Header and RequestHeader but doc has only been
updated for the first one.
Moreover, a compatibility note should be, IMO, added for the updated syntax.
CJ
Le 17/04/2014 15:36, j...@apache.org a écrit :
Changes with Apache 2.4.10
+ *) mod_headers: Allow th
Hi,
AFAIK, no crash has ever been reported for that.
I just noted this while looking at PR56287 and found it odd.
A file such as:
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-
will trigger the scan past the end of the buffer behavior.
line 658: ap_regexec(]*(http-equi
Hi,
I've gone quickly thru the module and I have a few remarks:
- What is the use of FN_LOG_MARK on line 87? Couldn't we use
APLOG_MARK instead?
'connect_to_peer' is called only in one place with
module_index=APLOG_MODULE_INDEX
- Do things like AP_MODULE_MAGIC_AT_LEAST(20130702,2
Le 04/04/2014 13:59, Yann Ylavic a écrit :
On Fri, Apr 4, 2014 at 1:35 PM, Eric Covener wrote:
FYI not necessary to propose docs-only changes in STATUS, they are CTR.
Oh, I see, thanks for the information.
Should I (or one) backport it if no one else screams for a while then?
Just in case,
lol, sure
Le 14/02/2014 21:44, Plüm, Rüdiger, Vodafone Group a écrit :
-Ursprüngliche Nachricht-
Von: Christophe JAILLET > Gesendet: Freitag, 14. Februar 2014 21:39
An: dev@httpd.apache.org
Betreff: APR_FOPEN_BUFFERED and small files
Hi,
when a file is opened using apr_file_open wit
Le 10/01/2014 14:38, Jeff Trawick a écrit :
[ ] It is an accepted practice (but not required) to obscure or omit
the vulnerability impact in CHANGES or commit log information when
committing fixes for vulnerabilities to any branch.
[X] It is mandatory to provide best available description and
Sure,
but I personally prefer to keep only one exit point in functions.
Just a matter of taste.
CJ
Le 09/01/2014 20:17, Rainer Jung a écrit :
On 09.01.2014 19:48, jaillet...@apache.org wrote:
Author: jailletc36
Date: Thu Jan 9 18:48:11 2014
New Revision: 1556914
URL: http://svn.apache.org/
Not correct,
this is just a french man who didn't take time to check in a
dictionary... :)
I update...
Thx
CJ
Le 13/12/2013 19:57, Mike Rumph a écrit :
equivalant versus equivalent
Perhaps this is a difference in British versus American spelling,
correct?
Anyway, thanks for the commits
Le 15/09/2013 16:30, Rainer Jung a écrit :
I'm pretty sure from those pictures you would not be able to find the
point in time where I switched 2.4.6 and 2.4.7-dev between the servers.
In other words, does it mean that no special performance improvement is
to be expected ?
I remember to hav
Le 14/09/2013 16:01, minf...@apache.org a écrit :
Author: minfrin
Date: Sat Sep 14 14:01:27 2013
New Revision: 1523242
URL: http://svn.apache.org/r1523242
Log:
mod_filter: Allow mod_filter to undo equiv of change=yes that was
baked into a filter provider.
trunk patch: http://svn.apache.org/r15
Some discussion about it can be found at
http://stackoverflow.com/questions/4470645/acceptex-without-wsaioctl
CJ
Le 11/09/2013 12:26, Ivan Zhakov a écrit :
Hi,
The mpm_winnt uses AcceptEx API call to accept incoming connections.
But MSDN documentation states [1] that consumer should use WSAIo
Correct.
This was introduced in r1465115.
Fixed in trunk in r1490507.
Le 06/06/2013 17:54, Guenter Knauf a écrit :
ua/lua_passwd.c T
Le 28/04/2013 01:14, minf...@apache.org a écrit :
Author: minfrin
Date: Sat Apr 27 23:14:11 2013
New Revision: 1476694
URL: http://svn.apache.org/r1476694
Log:
mod_authnz_ldap: Allow using exec: callouts like SSLPassphraseDialog
for AuthLDAPBindPassword.
trunk patch: http://svn.apache.org/view
Hi,
doc also has to be clean the same way.
CJ
Le 31/03/2013 22:38, s...@apache.org a écrit :
Author: sf
Date: Sun Mar 31 20:38:17 2013
New Revision: 1463049
URL: http://svn.apache.org/r1463049
Log:
Remove partial non-working implementation of MD5-sess and qop=auth-int.
If anyone wants to fin
Hi,
they are 3 similar constructions in server/log.c
CJ
Le 31/03/2013 22:13, s...@apache.org a écrit :
Author: sf
Date: Sun Mar 31 20:13:48 2013
New Revision: 1463045
URL: http://svn.apache.org/r1463045
Log:
ap_log_error already logs the error string, no need to log it twice
Modified:
Yes, i work and test on trunk.
I'll give it a try.
Thx
CJ
Le 22/03/2013 22:14, Stefan Fritsch a écrit :
On Tuesday 19 March 2013, Marion & Christophe JAILLET wrote:
Le 18/03/2013 22:43, Stefan Fritsch a écrit :
On Thursday 14 March 2013, you wrote:
BTW, I tried to activate pool d
Le 18/03/2013 22:43, Stefan Fritsch a écrit :
On Thursday 14 March 2013, you wrote:
BTW, I tried to activate pool debug with using
|-enable-pool-debug=all but the server crashes while starting on
my test machine.
Do you know if it is supposed to work (and I do something wrong) or
no one uses
My goal was to check for useless memory allocation when calling logging
function.
Logging with TRACE is unlikely to output something on a production
machine. However, function called as parameters of the logging function
will still be called.
I made a check on the whole source code to check fo
Le 11/03/2013 20:32, Gregg Smith a écrit :
On 3/11/2013 9:38 AM, j...@apache.org wrote:
Author: jim
Date: Mon Mar 11 16:38:39 2013
New Revision: 1455225
URL: http://svn.apache.org/r1455225
Log:
Merge r1442865, r1442759, r1442326, r1442309, r1448171, r1418556,
r1448453, r1425771, r1425772, r14
Le 01/03/2013 11:43, Guenter Knauf a écrit :
Hi Christophe,
Am 01.03.2013 08:00, schrieb Christophe JAILLET:
To quick...
you can fix the svn log with:
svn propedit -r 1451478 --revprop svn:log
Gün.
Thanks, done.
CJ
Hi,
This may look useless, but I can't figure out why in function
'substring_conf' (line 752 in server/util.c) we allocate len+2 bytes ?
This seems to have been like that forever.
IMO, len+1 should be enough.
Changing that would be a huge memory usage improvement :).
Does any one has an idea
Le 17/12/2012 00:20, Stefan Fritsch a écrit :
+AP_DECLARE(void) ap_bin2hex(const void *src, apr_size_t srclen,
char *dest) +{
+const unsigned char *in = src;
+unsigned char *out = (unsigned char *)dest;
+apr_size_t i;
+
+for (i = 0; i < srclen; i++) {
+*out++ = c2x_table[
Here are a few things triggered by cppcheck.
Le 11/12/2012 21:08, humbed...@apache.org a écrit :
Author: humbedooh
Date: Tue Dec 11 20:08:24 2012
New Revision: 1420377
URL: http://svn.apache.org/viewvc?rev=1420377&view=rev
Log:
mod_lua: Add a lot of core httpd/apr functionality to mod_lua
(suc
Le 10/12/2012 21:53, jaillet...@apache.org a écrit :
Author: jailletc36
Date: Mon Dec 10 20:53:24 2012
New Revision: 1419755
URL: http://svn.apache.org/viewvc?rev=1419755&view=rev
Log:
Avoid unnecessary %s substitution
Modified:
httpd/httpd/trunk/modules/http/http_filters.c
Modified: htt
Le 06/12/2012 14:59, j...@apache.org a écrit :
Author: jim
Date: Thu Dec 6 13:59:32 2012
New Revision: 1417892
URL: http://svn.apache.org/viewvc?rev=1417892&view=rev
Log:
Merge r1404653 from trunk:
Allow for setting of sticky session split char...
Bugz 53893
[...]
--- httpd/httpd/branches/
101 - 128 of 128 matches
Mail list logo