Re: [1.3 PATCH] a different take on forensics

2004-01-28 Thread Jeff Trawick
Mads Toftum wrote: On Sat, Jan 24, 2004 at 12:58:40PM -0500, Jeff Trawick wrote: groan :( the problem was in the proof-of-concept modules; they neglected to add a null entry at the end of the command table, as shown below: Much better now. Once I remembered EnableExceptionHook it was smooth

Re: [1.3 PATCH] a different take on forensics

2004-01-25 Thread Mads Toftum
On Sat, Jan 24, 2004 at 12:58:40PM -0500, Jeff Trawick wrote: groan :( the problem was in the proof-of-concept modules; they neglected to add a null entry at the end of the command table, as shown below: Much better now. Once I remembered EnableExceptionHook it was smooth sailing. I'm still

Re: [1.3 PATCH] a different take on forensics

2004-01-24 Thread Jeff Trawick
Jeff Trawick wrote: Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html 1) automatically define AP_ENABLE_EXCEPTION_HOOK in ap_config.h for platforms that have been tested (AIX, Linux, Solaris already and I'll test HP-UX before long) 2) user can still enable it for

Re: [1.3 PATCH] a different take on forensics

2004-01-24 Thread Mads Toftum
On Sat, Jan 24, 2004 at 07:23:24AM -0500, Jeff Trawick wrote: url above now points to patch which implements these changes vote added to apache-1.3/STATUS Segfaults here (linux-2.4.23_pre8 - --enable-module=most --enable-shared=max) With mod_backtrace_13 enabled: #0 0x401291fc in

Re: [1.3 PATCH] a different take on forensics

2004-01-24 Thread Jeff Trawick
Mads Toftum wrote: On Sat, Jan 24, 2004 at 07:23:24AM -0500, Jeff Trawick wrote: url above now points to patch which implements these changes vote added to apache-1.3/STATUS Segfaults here (linux-2.4.23_pre8 - --enable-module=most --enable-shared=max) With mod_backtrace_13 enabled: #0

Re: [1.3 PATCH] a different take on forensics

2004-01-24 Thread Jeff Trawick
Mads Toftum wrote: On Sat, Jan 24, 2004 at 07:23:24AM -0500, Jeff Trawick wrote: url above now points to patch which implements these changes vote added to apache-1.3/STATUS Segfaults here (linux-2.4.23_pre8 - --enable-module=most --enable-shared=max) With mod_backtrace_13 enabled: #0

Re: [1.3 PATCH] a different take on forensics

2004-01-23 Thread Jeff Trawick
Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html There is a small patch to Apache 1.3 required to make the sample modules work. This is analogous to the toys using the Apache 2.1 exception hook which are described at

Re: [1.3 PATCH] a different take on forensics

2004-01-23 Thread Mads Toftum
On Fri, Jan 23, 2004 at 09:45:46AM -0500, Jeff Trawick wrote: (trying to make progress without spinning wheels in mud :) ) Here is a change I propose for the core patch to address some of the concerns (when to enable it): basically the patch listed above, but: 1) automatically define

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Ben Laurie
Jeff Trawick wrote: Ben Laurie wrote: Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html You should make the logged strings safe, like mod_log_forensic does, and I think the format should be compatible (which means no space after the colon). Thanks for taking a

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Jeff Trawick
Ben Laurie wrote: Jeff Trawick wrote: Ben Laurie wrote: You should make the logged strings safe, like mod_log_forensic does, and I think the format should be compatible (which means no space after the colon). Thanks for taking a look! I removed the space after the colon, but at present am

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Jim Jagielski
Anyway +1 (untested) for the core patch. +1 (tested) on the core-patch... I'm mulling over whether it should be included by default or, at least, runtime configurable :) -- === Jim Jagielski [|] [EMAIL PROTECTED]

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Jeff Trawick
Jim Jagielski wrote: Anyway +1 (untested) for the core patch. +1 (tested) on the core-patch... I'm mulling over whether it should be included by default or, at least, runtime configurable :) personally I would like to see one of those two so that users who are experiencing a problem that could

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Mads Toftum
On Thu, Jan 22, 2004 at 06:48:46AM -0500, Jeff Trawick wrote: anyone else lurking? A very nice idea - seen with my #apache hat on, it'd be really nice to get this when people turn up complaining about segfaults. With my old admin and security paranoid hats on, it would certainly be nice too -

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Bill Stoddard
Jeff Trawick wrote: Ben Laurie wrote: Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html You should make the logged strings safe, like mod_log_forensic does, and I think the format should be compatible (which means no space after the colon). Thanks for taking a

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Jeff Trawick
Bill Stoddard wrote: What is the purpose of the geteuid() call in run_fatal_exception_hook and when might it return 0? geteuid() returns 0 when running with root privileges the purpose of not running the hook as root is a nod to the possibility that the hook could be hijacked (dunno how since

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Jeff Trawick
Mads Toftum wrote: On Thu, Jan 22, 2004 at 06:48:46AM -0500, Jeff Trawick wrote: anyone else lurking? A very nice idea - seen with my #apache hat on, it'd be really nice to get this when people turn up complaining about segfaults. With my old admin and security paranoid hats on, it would

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Bill Stoddard
if the code is always built into the server (with/without EnableExceptionHook setting), perhaps we should add the #define AP_ENABLE_EXCEPTION_HOOK in ap_config.h for platforms where we know it will work +1 Bill

Re: [1.3 PATCH] a different take on forensics

2004-01-21 Thread Ben Laurie
Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html There is a small patch to Apache 1.3 required to make the sample modules work. This is analogous to the toys using the Apache 2.1 exception hook which are described at

Re: [1.3 PATCH] a different take on forensics

2004-01-21 Thread Jeff Trawick
Ben Laurie wrote: Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html You should make the logged strings safe, like mod_log_forensic does, and I think the format should be compatible (which means no space after the colon). Thanks for taking a look! I removed the space

[1.3 PATCH] a different take on forensics

2004-01-20 Thread Jeff Trawick
See http://www.apache.org/~trawick/exception_hook_13.html There is a small patch to Apache 1.3 required to make the sample modules work. This is analogous to the toys using the Apache 2.1 exception hook which are described at http://www.apache.org/~trawick/exception_hook.html.

Re: [1.3 PATCH] a different take on forensics

2004-01-20 Thread gregames
Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html There is a small patch to Apache 1.3 required to make the sample modules work. This is analogous to the toys using the Apache 2.1 exception hook which are described at