Kris,
I am in the process of adding virtual host info into the key
generation too. I'll include your work with mine if that's okay.
Paul J. Reder
Kris Verbeeck wrote:
Hi,
Some of our QA people discovered a problem when performing request
with a query string on a mod_cache enabled Apache
Kris,
Thank you for your contribution.
I committed the patch to mod_cache.c. Paul Reder is doing some work in the
code to generate the search key and will incorporate your patch when he is
complete.
Bill
Hi,
Some of our QA people discovered a problem when performing request
with a query
Kris Verbeeck [EMAIL PROTECTED] wrote:
apr_status_t cache_generate_key_default( request_rec *r, apr_pool_t*p,
char**key )
{
- *key = apr_pstrdup(p,r-uri);
+ *key = apr_pstrcat(p,r-uri, ?, r-args, NULL);
return APR_SUCCESS;
}
Hm... This should be something like:
If (r-args) {
Yes, I believe it should check r-args. I don't think you are stupid,
severely or otherwise... ;)
Pier Fumagalli wrote:
Kris Verbeeck [EMAIL PROTECTED] wrote:
apr_status_t cache_generate_key_default( request_rec *r, apr_pool_t*p,
char**key )
{
- *key = apr_pstrdup(p,r-uri);
+ *key =
Paul J. Reder [EMAIL PROTECTED] wrote:
Yes, I believe it should check r-args. I don't think you are stupid,
severely or otherwise... ;)
That's what _you_ think... Others (like me) tend to disagree! :)
After thinking about it, it wouldn't really matter, because apr_pstrcat will
already stop
On Thu, 12 Sep 2002 03:47:58 -0700, Paul J. Reder wrote:
Yes, I believe it should check r-args. I don't think you are stupid,
severely or otherwise... ;)
it should not make a difference really
if r-args is null than the strcat should terminate there anyway ;-)
on another note..
Paul.. I'm
But I'm also factoring the hostname into key creation, which
also might be NULL. So even if the args issue could be ignored, the
hostname can't (or at least the possibility of 1 out of 2 NULL
can't be ignored).
Pier Fumagalli wrote:
Paul J. Reder [EMAIL PROTECTED] wrote:
Yes, I believe it
Ian Holsman wrote:
On Thu, 12 Sep 2002 03:47:58 -0700, Paul J. Reder wrote:
Yes, I believe it should check r-args. I don't think you are stupid,
severely or otherwise... ;)
it should not make a difference really
if r-args is null than the strcat should terminate there anyway ;-)
on
Ian Holsman wrote:
On Thu, 12 Sep 2002 03:47:58 -0700, Paul J. Reder wrote:
Yes, I believe it should check r-args. I don't think you are stupid,
severely or otherwise... ;)
it should not make a difference really
if r-args is null than the strcat should terminate there anyway ;-)
