[PATCH] for bug 20832. Add double stat option

2008-01-28 Thread Akins, Brian
Against trunk. Basically, has a new config EnableDoubleStat (I know, horrible name) off by default. If on, will use apr_file_info_get on open file handle. Based on patch in thread: http://issues.apache.org/bugzilla/show_bug.cgi?id=43386 Doesn't apply cleanly against 2.2.8. -- Brian Akins

Re: [PATCH] for bug 20832. Add double stat option

2008-01-28 Thread Jim Jagielski
Me like for trunk... if approved there, I'll backport. Of course, it requires mmn bump. On Jan 28, 2008, at 9:41 AM, Akins, Brian wrote: Against trunk. Basically, has a new config EnableDoubleStat (I know, horrible name) off by default. If on, will use apr_file_info_get on open file

Re: [PATCH] for bug 20832. Add double stat option

2008-01-28 Thread Jim Jagielski
On Jan 28, 2008, at 12:35 PM, William A. Rowe, Jr. wrote: Akins, Brian wrote: Against trunk. Basically, has a new config EnableDoubleStat (I know, horrible name) off by default. If on, will use apr_file_info_get on open file handle. Based on patch in thread:

Re: [PATCH] for bug 20832. Add double stat option

2008-01-28 Thread William A. Rowe, Jr.
Akins, Brian wrote: For trunk, it's time finally to open the file earlier in the request cycle and use the fstat/file_info_get for the lifetime of the request. Thoughts? Maybe. I'm wondering how often we wind-up not using the file. I guess only when we redirect or something in fixups, maybe.

Re: [PATCH] for bug 20832. Add double stat option

2008-01-28 Thread Akins, Brian
On 1/28/08 12:35 PM, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: AFAICT, this still does not resolve the problem, it simply picks up the replacement of the file. Which is what I care about. It does not address the root 80% of the problem when an open file is then changed during the

Re: [PATCH] for bug 20832. Add double stat option

2008-01-28 Thread William A. Rowe, Jr.
Akins, Brian wrote: Against trunk. Basically, has a new config EnableDoubleStat (I know, horrible name) off by default. If on, will use apr_file_info_get on open file handle. Based on patch in thread: http://issues.apache.org/bugzilla/show_bug.cgi?id=43386 Doesn't apply cleanly against