> -Original Message-
> From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]
> Also, when you commit, please just toss the old macro. There is zero
sense in
> keeping the cruft around. -- justin
Sure.. will do.
> P.S. Madhu, *please*, *please*, *please* use unified diffs in the future.
In my experience if more than 16% of the code is changed it's better to
rewrite it. While true, it has gotten me into MORE trouble...
> Just a footnote to that thought. We have a *ton* of internal, private
> entry points and data declarations in mod_ssl.h. IMHO - we should
> be simplifying mod_
--On Wednesday, March 12, 2003 9:30 PM -0500 "MATHIHALLI,MADHUSUDAN
(HP-Cupertino,ex1)" <[EMAIL PROTECTED]> wrote:
Okay.. I've added some little checks to get SSL-C to be recognized. Here's a
patch (relative to Geoff's patch) that does some checking.. I've added the
complete patch as attachment (
At 12:06 AM 3/13/2003, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:
>- Move the inclusion of openssl headers to ssl_toolkit_compat.h, and change
>to include headers of type "openssl/ssl.h" instad of "ssl.h". That is what
>is followed by the openssl sources also, and I believe mod_ssl should also
ms in
versions < 2.3. I thought it had, but I'm totally unaware of it]
-Madhu
-Original Message-
From: William A. Rowe, Jr. [mailto:[EMAIL PROTECTED]
Sent: Wednesday, March 12, 2003 9:03 PM
To: [EMAIL PROTECTED]
Cc: 'Geoff Thorpe'; [EMAIL PROTECTED]; MATHIHALLI,MAD
; OR "-lsslc" to LIBS because restoring LIBS
>> + dnl after AC_CHECK_LIB() obliterates any flags AC_CHECK_LIB() added.
>> + if test "$ap_ssltk_type" = "openssl"; then
>> +APR_ADDTO(LIBS, [-lssl -lcrypto])
>> + else
>> +APR_ADDTO(LIBS,
sslc" to LIBS because restoring LIBS
> + dnl after AC_CHECK_LIB() obliterates any flags AC_CHECK_LIB() added.
> + if test "$ap_ssltk_type" = "openssl"; then
> +APR_ADDTO(LIBS, [-lssl -lcrypto])
> + else
> +APR_ADDTO(LIBS, [-lsslc])
> + fi
Hi Madhu,
Thanks for giving the latest incarnation a review.
* MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) ([EMAIL PROTECTED]) wrote:
>
> I tried the patch, and it seemed to work fine for me (and it's more cleaner
> than what we have today).
>
> - I don't know how SSL-C will be broken with this pa
sting the patch.
- any objections
-Madhu
-Original Message-
From: Geoff Thorpe [mailto:[EMAIL PROTECTED]
Sent: Friday, March 07, 2003 12:59 PM
To: [EMAIL PROTECTED]
Cc: Justin Erenkrantz
Subject: Re: [PATCH] openssl configuration (v2)
Hi there,
* Justin Erenkrantz ([EMAIL PROTECTED])
Hi there,
* Justin Erenkrantz ([EMAIL PROTECTED]) wrote:
>
> Yes, the former is what I would expect as well. I would add a third clause
> to your AC_CHECK_LIB which appends -lLIBRARY to saved_LIBS. Hmm. I wonder
> where saved_LIBS will end up in relationship to AP_LIBS. Ah, it seems that
>
--On Thursday, March 6, 2003 5:16 PM -0500 Geoff Thorpe
<[EMAIL PROTECTED]> wrote:
then strangely the -lcrypto and -lssl checks report success *yet* they
do not find their way into the linker flags (so apache fails to link
after compiling). I can only imagine 2 reasons for this; either my
restori
Hi Justin,
* Justin Erenkrantz ([EMAIL PROTECTED]) wrote:
>
> I think you mean adding -I<...> to CPPFLAGS not to CFLAGS. That should be
> portable and supported everywhere. It's a C preprocessor flag not a flag
> for the compiler. Autoconf will evaluate ac_compile which includes
> $CPPFLAGS
--On Tuesday, March 4, 2003 6:43 PM -0500 Geoff Thorpe <[EMAIL PROTECTED]>
wrote:
Questions for apache gurus/code-reviewers;
- AC_CHECK_HEADERS() appears difficult to coax into accepting additional
include paths, so if "--with-ssl=" is specified there appears no
obvious way to have AC_CHECK_
Hi all,
Thanks to those who replied to my earlier post on this subject,
especially Madhu. Here's the next incarnation of the patch based on that
feedback and some ferretting of my own.
Patch notes;
- This now probes for sslc.h to distinguish between OpenSSL and SSL-C.
- Existing version checki
14 matches
Mail list logo
