I came across a few things that needed attention in my review of the
http filter code:
- ctx-remaining was uninitialized.
- I'm a little uncomfortable with the Content-Length: parsing, please
see my comments in the diff.
- a logic reduction in a do-while loop (reduces the number of times
we
On Thu, Oct 04, 2001 at 12:52:17PM -0700, Aaron Bannert wrote:
I came across a few things that needed attention in my review of the
http filter code:
Cool.
- ctx-remaining was uninitialized.
We don't care what ctx-remaining is unless we have a special
parsing type which sets ctx-remaining.
On Thursday 04 October 2001 01:14 pm, Justin Erenkrantz wrote:
ctx-state = BODY_CHUNK;
ctx-remaining = get_chunk_size(line);
-if (!ctx-remaining)
-{
+if (ctx-remaining = 0) {
No. =) Java weenie.
On Thu, Oct 04, 2001 at 01:14:31PM -0700, Justin Erenkrantz wrote:
On Thu, Oct 04, 2001 at 12:52:17PM -0700, Aaron Bannert wrote:
I came across a few things that needed attention in my review of the
http filter code:
Cool.
[hey! Aren't you supposed to be in class? ;) ]
- ctx-remaining
Aaron Bannert wrote:
On Thu, Oct 04, 2001 at 01:14:31PM -0700, Justin Erenkrantz wrote:
On Thu, Oct 04, 2001 at 12:52:17PM -0700, Aaron Bannert wrote:
I came across a few things that needed attention in my review of the
http filter code:
Cool.
[hey! Aren't you supposed to be in class?
On Thu, Oct 04, 2001 at 01:29:26PM -0700, Ryan Bloom wrote:
-if (!ctx-remaining)
-{
+if (ctx-remaining = 0) {
No. =) Java weenie.
Huh? How is this him being a Java weenie? Aaron has changed a check
for !0 to a check for negative
On Thu, Oct 04, 2001 at 01:53:12PM -0700, Aaron Bannert wrote:
On Thu, Oct 04, 2001 at 01:29:26PM -0700, Ryan Bloom wrote:
-if (!ctx-remaining)
-{
+if (ctx-remaining = 0) {
No. =) Java weenie.
Huh? How is this him being a
On Thu, Oct 04, 2001 at 01:53:53PM -0700, Ian Holsman wrote:
I've been debugging the proxy problem with the input filters, and it also
seems
to be screwing up in this function as well.
The proxy calls this function with a NULL request in the input filter,
causing the pool-alloc to fail
On Thu, Oct 04, 2001 at 06:51:33PM -0700, Justin Erenkrantz wrote:
My comment about Aaron being a Java weenie is that he changed the
brace to fit the recommended Java style. At eBuilt, they wanted
us to place braces on the same line all the time - we had long
discussions about this. I
On Thu, Oct 04, 2001 at 07:13:16PM -0700, Aaron Bannert wrote:
Huh? That's a bit of a stretch. If this is going to turn into a style
war, let it be spoken from the Apache Style Guide:
Opening braces are given on the same lines as statements, or on the
following line at the start of a
Justin Erenkrantz wrote:
On Thu, Oct 04, 2001 at 01:53:53PM -0700, Ian Holsman wrote:
I've been debugging the proxy problem with the input filters, and it also
seems
to be screwing up in this function as well.
The proxy calls this function with a NULL request in the input filter,
causing
[ Not sure if this is going to be sent twice - UCI's network
connection has decided to go bonkers tonight - I'm having
horrendous packet loss problems. ]
On Thu, Oct 04, 2001 at 09:37:51PM -0700, Ian Holsman wrote:
how about we back out the filter changes so that the rest of the
server
On Thu, Oct 04, 2001 at 10:01:37PM -0700, Justin Erenkrantz wrote:
...
On Thu, Oct 04, 2001 at 09:37:51PM -0700, Ian Holsman wrote:
how about we back out the filter changes so that the rest of the
server isn't broken.
I'd rather not see us back this change out. But, it is your
On Thu, Oct 04, 2001 at 07:50:33PM -0700, Justin Erenkrantz wrote:
On Thu, Oct 04, 2001 at 07:13:16PM -0700, Aaron Bannert wrote:
Huh? That's a bit of a stretch. If this is going to turn into a style
war, let it be spoken from the Apache Style Guide:
Opening braces are given on the same
14 matches
Mail list logo
