Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-16 Thread Nick Kew
On Wednesday 15 March 2006 21:34, Jeff Trawick wrote: [ disclaimer: I haven't looked at the code in question, but I've dealt with the issue I mention in mod_dbd, and gone through the logic at greater length for the book ] util_ldap_create_config() creates the per-server config for util_ldap.

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-16 Thread Jeff Trawick
On 3/16/06, Ruediger Pluem [EMAIL PROTECTED] wrote: On 03/16/2006 03:49 AM, Jeff Trawick wrote: On 3/15/06, Brad Nicholes wrote: That is really one pool globally but there is a mutex per server_rec. So a thread handling a request for one vhost grabs the mutex and uses the pool but

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-16 Thread Brad Nicholes
On 3/16/2006 at 7:12 am, in message [EMAIL PROTECTED], Jeff Trawick [EMAIL PROTECTED] wrote: On 3/16/06, Ruediger Pluem [EMAIL PROTECTED] wrote: On 03/16/2006 03:49 AM, Jeff Trawick wrote: On 3/15/06, Brad Nicholes wrote: That is really one pool globally but there is a mutex per

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-16 Thread Jeff Trawick
On 3/16/06, Brad Nicholes [EMAIL PROTECTED] wrote: On 3/16/2006 at 7:12 am, in message [EMAIL PROTECTED], Jeff Trawick [EMAIL PROTECTED] wrote: On 3/16/06, Ruediger Pluem [EMAIL PROTECTED] wrote: On 03/16/2006 03:49 AM, Jeff Trawick wrote: On 3/15/06, Brad Nicholes wrote:

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-16 Thread Brad Nicholes
On 3/16/2006 at 11:34 am, in message [EMAIL PROTECTED], Jeff Trawick [EMAIL PROTECTED] wrote: On 3/16/06, Brad Nicholes [EMAIL PROTECTED] wrote: On 3/16/2006 at 7:12 am, in message [EMAIL PROTECTED], Jeff Trawick [EMAIL PROTECTED] wrote: On 3/16/06, Ruediger Pluem [EMAIL PROTECTED] wrote:

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-16 Thread Graham Leggett
Jeff Trawick wrote: if ldap server times out the connection and we have to bring one back up, that is no pool growth, right? we just get pool growth when we talk to an LDAP server we haven't already talked to yet, or when? Dead LDAP connections (timed out, server gone away, etc) are repaired

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-16 Thread Jeff Trawick
On 3/16/06, Graham Leggett [EMAIL PROTECTED] wrote: Jeff Trawick wrote: if ldap server times out the connection and we have to bring one back up, that is no pool growth, right? we just get pool growth when we talk to an LDAP server we haven't already talked to yet, or when? Dead LDAP

pool use/mutex initialization in util_ldap not thread safe?

2006-03-15 Thread Jeff Trawick
Plz forgive any misunderstanding, as well as my use of 2.0 function names ;) Also, for being slow at learning what ldap stands for. I know this code has been hashed over many many times over the last few years. util_ldap_create_config() creates the per-server config for util_ldap. That saves a

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-15 Thread Brad Nicholes
On 3/15/2006 at 2:34 pm, in message [EMAIL PROTECTED], Jeff Trawick [EMAIL PROTECTED] wrote: Plz forgive any misunderstanding, as well as my use of 2.0 function names ;) Also, for being slow at learning what ldap stands for. I know this code has been hashed over many many times over the last

Re: pool use/mutex initialization in util_ldap not thread safe?

2006-03-15 Thread Jeff Trawick
On 3/15/06, Brad Nicholes [EMAIL PROTECTED] wrote: I think you are right. I am going to take a closer look at that code and see about fixing both the mutex problem and the use of the config pool. This could actually explain some funny things that I have been seeing on the NetWare build