Re: round 2 of mod_authn_mysql

2003-02-19 Thread Günter Knauf
Hi Paul, >> and added this: >> #include "util_md5.h" /* for ap_md5 */ > added. sorry sorry, I didnt backtest on NetWare after inserting util_md5.h on Win32, but now an additional cast is necessary to make our compiler happy: -mysql_hash = (char *) ap_md5(r->pool, apr_pstrca

Re: round 2 of mod_authn_mysql

2003-02-19 Thread Dirk-Willem van Gulik
Your 0.6 version works splendidly. Does not seem to leak (well; less than I can detect as I have other stuff leaking) and survives restarts and other harrasment well. Last nit: #define MYSQL_HARD_MAX_CONNS (255) to #ifndef MYSQL_HARD_MAX_CONNS #define MYSQL_HARD_MAX_CONNS

Re: round 2 of mod_authn_mysql

2003-02-19 Thread Dirk-Willem van Gulik
On Tue, 18 Feb 2003, Paul Querna wrote: > done. This should help with the problems DW had on trusted Solaris.(I hope) Yes the problem there is that you need to point it to the right /tmp for the nobody user the server runs ad. > _dl_lookup_versioned_symbol). I think like DW hinted at earlier

Re: round 2 of mod_authn_mysql

2003-02-18 Thread Paul Querna
> this one could be taken from an OS lib: > mod_authn_mysql.obj : error LNK2001: Nichtaufgeloestes externes > Symbol __imp__tmpnam but I think you should better use here > APR_DECLARE(apr_status_t) apr_file_mktemp(apr_file_t **fp, char > *templ, apr_int32

Re: round 2 of mod_authn_mysql

2003-02-18 Thread William A. Rowe, Jr.
Gunter, presume you just forgot a cc-to, but this discussion belongs on the dev@apr list, so I'm copying it here. You are right, the DECLARE macros are manditory. Certain to commit for 0.9.2, but your completed patch based on that DECLARE assumption would speed things up :-) Bill At 10:03 PM 2/

Re: round 2 of mod_authn_mysql

2003-02-18 Thread Günter Knauf
Hi Paul, > I have put an updated version of mod_auth_mysql onto > http://open.cyanworlds.com/ > Changes from Initial Release: > + Removed evil signal() calls > + Changed Config Style > + Added Database Pooling > + Added Multiple Database Connections > + General Cleanup > TODO: > - Make Database P

Re: round 2 of mod_authn_mysql

2003-02-18 Thread Dirk-Willem van Gulik
On Tue, 18 Feb 2003, Paul Querna wrote: > DW> mysql_init can return a NULL; > According the MySQL Website and documentaion, only > mysql_real_connect/mysql_connect are not thread safe. Ack - I had a bang around the close - must have been something else. > I can't find any function called "apr

Re: round 2 of mod_authn_mysql

2003-02-18 Thread Paul Querna
DW> mysql_init can return a NULL; Added a check for this in 0.0.5 ( now on http://open.cyanworlds.com ) DW> are we sure that mysql_close is DW> thread safe ? According the MySQL Website and documentaion, only mysql_real_connect/mysql_connect are not thread safe. DW> And I'd make the psprint

Re: round 2 of mod_authn_mysql

2003-02-18 Thread Dirk-Willem van Gulik
> I have put the version(0.0.3) with these and a couple over small changes on > http://open.cyanworlds.com Compiles and Works for me gov. Few minor nits below. Feel free to ignore. Nothing major. mysql_init can return a NULL; are we sure that mysql_close is thread safe ? And I'd make the pspr

Re: round 2 of mod_authn_mysql

2003-02-17 Thread Paul Querna
On Mon, 17 Feb 2003 23:02:39 +0100 (CET), Dirk-Willem van Gulik wrote > And or change the apr_pstrcat into things like select "%s" from %s > with an apr_pstrNprintf( with a nice limit; as some of the values > are from potentially doggy sources; such as .htaccess file made by > possibly hostile us

Re: round 2 of mod_authn_mysql

2003-02-17 Thread Dirk-Willem van Gulik
On Mon, 17 Feb 2003, Paul Querna wrote: > - Add end user SQL query as suggested on apache-dev And or change the apr_pstrcat into things like select "%s" from %s with an apr_pstrNprintf( with a nice limit; as some of the values are from potentially doggy sources; such as .htaccess file made by po

round 2 of mod_authn_mysql

2003-02-17 Thread Paul Querna
I have put an updated version of mod_auth_mysql onto http://open.cyanworlds.com/ Changes from Initial Release: + Removed evil signal() calls + Changed Config Style + Added Database Pooling + Added Multiple Database Connections + General Cleanup TODO: - Make Database Pool Size config options (righ