Your filter should run before the content type is set. Then, you can do
the usual redirect to /errors/HTTP_FORBIDDEN.html or whatever document
you should be returning. Yes, a filter should only be working on the
through-put, so you should be handling that. Perhaps someone knows
about the
On 12/07/2007 10:19 PM, Pavel Stano wrote:
thanks for patch, problem is solved
Committed to trunk as r602349
(http://svn.apache.org/viewcvs.cgi?rev=602349view=rev)
and added to the backport proposal as r602439
(http://svn.apache.org/viewcvs.cgi?rev=602439view=rev).
Regards
Rüdiger
On Dec 7, 2007 2:43 PM, Guenter Knauf [EMAIL PROTECTED] wrote:
Hi,
I came a couple of times already over the ifdefs to avoid the inclusion of
unixd.h;
also many 3rd party modules have this problem;
therefore I would like to see a global define somewhere for that, f.e.
AP(R?)_NEEDS_UNIXD_H
On 12/08/2007 04:07 PM, Jim Jagielski wrote:
I didn't see this patch in the commit list but did see it referred
to in the 2.2 STATUS file... I'm reviewing the patch now but two
things did stick out:
-apr_brigade_cleanup(ctx-ctxbb);
-APR_BUCKET_REMOVE(b);
-
I didn't see this patch in the commit list but did see it referred
to in the 2.2 STATUS file... I'm reviewing the patch now but two
things did stick out:
-apr_brigade_cleanup(ctx-ctxbb);
-APR_BUCKET_REMOVE(b);
-APR_BRIGADE_INSERT_TAIL(passbb, b);
-
I hacked up a patch that enables the proxy to keep connections
persistent in the HTTPS case. Having no persistence here was
a big performance penalty.
Basicly the persistence is created by keeping the conn_rec structure
created for our backend connection (whether http or https) in the connection
On Dec 8, 2007, at 10:44 AM, [EMAIL PROTECTED] wrote:
+niq: You're missing my point. That this patch fixes a bug is
+ perfectly clear. But it does so by allocating
(AP_IOBUFSIZE+1)
+ bytes. My point: isn't that likely to be horribly
inefficient
+ if
On 11/27/2007 07:26 PM, Jim Jagielski wrote:
With APR now out, I think we're close to releasing 1.3.40 and
2.2.7... Anyone opposed with that gameplan?
There are 9 backport proposals currently in the STATUS file
and 7 of them only miss one vote. The two remaining ones
only require some
On Sat, 08 Dec 2007 16:04:21 +0100
Ruediger Pluem [EMAIL PROTECTED] wrote:
There are 9 backport proposals currently in the STATUS file
and 7 of them only miss one vote. The two remaining ones
only require some more or less large adjustments to the proposal
and should miss only one vote after
On Dec 8, 2007, at 9:38 AM, Ruediger Pluem wrote:
Thoughts, comments?
A *real quick* review But so far, I see no issues (not
tested yet though :) )
+1
+static apr_status_t socket_cleanup(proxy_conn_rec *conn)
+{
+if (conn-sock) {
+apr_socket_close(conn-sock);
+
On Dec 7, 2007, at 7:09 AM, Plüm, Rüdiger, VF-Group wrote:
-Ursprüngliche Nachricht-
Von: [EMAIL PROTECTED]
Gesendet: Freitag, 7. Dezember 2007 11:24
An: dev@httpd.apache.org
Betreff: Re: Memory consumption of mod_substitute
On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group
[EMAIL
On Dec 8, 2007, at 11:39 AM, Ruediger Pluem wrote:
The reason why the current code handles FLUSH separately
is though, yes, the ap_pass_brigade is done at the end of
the while loop, that is *only* done when we're done handling
the full brigade... The intent was to honor flushes in the
brigade
On Dec 8, 2007, at 11:39 AM, Ruediger Pluem wrote:
In fact the patch does all this as it passes the passbb brigade down
the chain after *each* processed bucket of the original brigade
(the ap_pass_brigade is at *the end* of the while loop *not* after
the while loop).
I didn't catch that when
On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group
[EMAIL PROTECTED] wrote:
* My test case lead to the exceptional situation of a very
large passbb bucket brigade
(about 1,000,000 buckets) as a result of processing 4 MB
of the file. So I add
a flush bucket once I have more than
On 12/08/2007 07:41 PM, Jim Jagielski wrote:
On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group
[EMAIL PROTECTED] wrote:
* My test case lead to the exceptional situation of a very
large passbb bucket brigade
(about 1,000,000 buckets) as a result of processing 4 MB
of the file. So I add
On Dec 8, 2007, at 2:31 PM, Ruediger Pluem wrote:
On 12/08/2007 07:41 PM, Jim Jagielski wrote:
On Dec 5, 2007 8:36 AM, Plüm, Rüdiger, VF-Group
[EMAIL PROTECTED] wrote:
* My test case lead to the exceptional situation of a very
large passbb bucket brigade
(about 1,000,000 buckets) as
On 12/08/2007 07:31 PM, Jim Jagielski wrote:
+static apr_status_t socket_cleanup(proxy_conn_rec *conn)
+{
+if (conn-sock) {
+apr_socket_close(conn-sock);
+conn-sock = NULL;
+}
+if (conn-connection) {
+apr_pool_cleanup_kill(conn-pool, conn,
On Dec 8, 2007, at 2:47 PM, Ruediger Pluem wrote:
Index: modules/proxy/mod_proxy_http.c
+if (is_ssl) {
+ap_proxy_ssl_connection_cleanup(backend, r);
+}
+
/* Step One: Determine Who To Connect To */
if ((status = ap_proxy_determine_connection(p, r, conf, worker,
On Dec 8, 2007, at 2:47 PM, Ruediger Pluem wrote:
BTW: I have not tested with FTP proxing so far.
By the by, found a few cycles to test the patch as is...
so far, I see no issues... So +1 for folding it
into -trunk and we'll address anything that may
pop up in there :)
19 matches
Mail list logo
