new modules in trunk

2008-12-01 Thread Paul Querna
I've committed a few new modules to trunk tonight: mod_ratelimit: Bandwidth Rate Limiting for Clients. mod_heartbeat: Generates Multicast heartbeat messages containing the status of the server. mod_heartmonitor: Collects these Multicast heartbeats for other modules to use.

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Ruediger Pluem
On 12/01/2008 12:42 AM, Nick Kew wrote: On Sun, 30 Nov 2008 18:22:39 -0500 Eric Covener [EMAIL PROTECTED] wrote: On Sun, Nov 30, 2008 at 5:20 PM, Nick Kew [EMAIL PROTECTED] wrote: In practice, the proposed fix looks good, and I want to vote +1. I'm just a little concerned over whether

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Nick Kew
On 1 Dec 2008, at 08:52, Ruediger Pluem wrote: 2. IMHO ap_invoke_handler is only called in three locations: It's a public API, so could be called by any module. So ap_die maybe should do the following: if (type == AP_FILTER_ERROR) { if [ap_http_header_filter is still in chain]

Re: new modules in trunk

2008-12-01 Thread Nick Kew
On 1 Dec 2008, at 08:17, Paul Querna wrote: I've committed a few new modules to trunk tonight: Interesting. Are we expecting docs anytime soon? -- Nick Kew

Re: new modules in trunk

2008-12-01 Thread Kevac Marko
On Mon, Dec 1, 2008 at 11:17 AM, Paul Querna [EMAIL PROTECTED] wrote: mod_heartmonitor: Collects these Multicast heartbeats for other modules to use. Interesting. Is there other modules that create separate thread(s) for bypassing request-response thing? -- С уважением, Кевац Марко Sincerely

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Ruediger Pluem
On 12/01/2008 10:02 AM, Nick Kew wrote: On 1 Dec 2008, at 08:52, Ruediger Pluem wrote: 2. IMHO ap_invoke_handler is only called in three locations: It's a public API, so could be called by any module. Correct. So ap_die maybe should do the following: if (type ==

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Nick Kew
On 1 Dec 2008, at 09:31, Ruediger Pluem wrote: But do you see any objection to the (IMHO simpler) fix of removing error buckets as we detect them? Not directly. Could you please propose a concrete patch? It makes discussion easier :-). I think the one-liner should work, since we don't

Re: new modules in trunk

2008-12-01 Thread Paul Querna
Nick Kew wrote: On 1 Dec 2008, at 08:17, Paul Querna wrote: I've committed a few new modules to trunk tonight: Interesting. Are we expecting docs anytime soon? patches welcome, the reademe files aer all I really had :-)

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Ruediger Pluem
On 12/01/2008 11:01 AM, Nick Kew wrote: On 1 Dec 2008, at 09:31, Ruediger Pluem wrote: But do you see any objection to the (IMHO simpler) fix of removing error buckets as we detect them? Not directly. Could you please propose a concrete patch? It makes discussion easier :-). I think

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Nick Kew
On 1 Dec 2008, at 10:19, Ruediger Pluem wrote: if (eb) { -ap_die(eb-status, r); +int status; + +status = eb-status; +apr_brigade_cleanup(b); +ap_die(status, r); return AP_FILTER_ERROR; } Good call. +1 to that. -- Nick Kew

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Eric Covener
On Mon, Dec 1, 2008 at 6:44 AM, Nick Kew [EMAIL PROTECTED] wrote: On 1 Dec 2008, at 10:19, Ruediger Pluem wrote: if (eb) { -ap_die(eb-status, r); +int status; + +status = eb-status; +apr_brigade_cleanup(b); +ap_die(status, r); return

Re: svn commit: r721952 - in /httpd/httpd/trunk: ./ modules/ modules/cluster/

2008-12-01 Thread Ruediger Pluem
On 12/01/2008 03:55 AM, [EMAIL PROTECTED] wrote: Author: pquerna Date: Sun Nov 30 18:55:14 2008 New Revision: 721952 URL: http://svn.apache.org/viewvc?rev=721952view=rev Log: Add two new modules, originally written at Joost, to handle load balancing across multiple apache servers

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Eric Covener
On Mon, Dec 1, 2008 at 7:33 AM, Eric Covener [EMAIL PROTECTED] wrote: On Mon, Dec 1, 2008 at 6:44 AM, Nick Kew [EMAIL PROTECTED] wrote: On 1 Dec 2008, at 10:19, Ruediger Pluem wrote: if (eb) { -ap_die(eb-status, r); +int status; + +status = eb-status; +

Re: svn commit: r721965 - in /httpd/httpd/trunk/modules/filters: config.m4 mod_ratelimit.c mod_ratelimit.h

2008-12-01 Thread Ruediger Pluem
On 12/01/2008 06:12 AM, [EMAIL PROTECTED] wrote: Author: pquerna Date: Sun Nov 30 21:12:22 2008 New Revision: 721965 URL: http://svn.apache.org/viewvc?rev=721965view=rev Log: Add a new module, mod_ratelimit, originally written at Joost, which can rate limit the outgoing bandwidth to a

Re: new modules in trunk

2008-12-01 Thread Oden Eriksson
Den Monday 01 December 2008 09:17:24 skrev Paul Querna: I've committed a few new modules to trunk tonight: mod_ratelimit: Bandwidth Rate Limiting for Clients. mod_heartbeat: Generates Multicast heartbeat messages containing the status of the server. mod_heartmonitor: Collects these

Re: new modules in trunk

2008-12-01 Thread William A. Rowe, Jr.
Kevac Marko wrote: On Mon, Dec 1, 2008 at 11:17 AM, Paul Querna [EMAIL PROTECTED] wrote: mod_heartmonitor: Collects these Multicast heartbeats for other modules to use. Interesting. Is there other modules that create separate thread(s) for bypassing request-response thing? Considered doing

Re: new modules in trunk

2008-12-01 Thread Paul Querna
William A. Rowe, Jr. wrote: Kevac Marko wrote: On Mon, Dec 1, 2008 at 11:17 AM, Paul Querna [EMAIL PROTECTED] wrote: mod_heartmonitor: Collects these Multicast heartbeats for other modules to use. Interesting. Is there other modules that create separate thread(s) for bypassing

Re: svn commit: r721987 - in /httpd/httpd/trunk: CHANGES modules/proxy/config.m4 modules/proxy/mod_lbmethod_heartbeat.c

2008-12-01 Thread Ruediger Pluem
On 12/01/2008 08:25 AM, [EMAIL PROTECTED] wrote: Author: pquerna Date: Sun Nov 30 23:25:11 2008 New Revision: 721987 URL: http://svn.apache.org/viewvc?rev=721987view=rev Log: Add a new module to read in the heartbeat file and do load balancing for mod_proxy based upon it. Added:

Re: svn commit: r721987 - in /httpd/httpd/trunk: CHANGES modules/proxy/config.m4 modules/proxy/mod_lbmethod_heartbeat.c

2008-12-01 Thread Paul Querna
Ruediger Pluem wrote: +for (i = 0; i balancer-workers-nelts; i++) { +worker = APR_ARRAY_IDX(balancer-workers, i, proxy_worker); +server = apr_hash_get(servers, worker-hostname, APR_HASH_KEY_STRING); Hm, the hash uses IP addresses as keys whereas worker-hostname could be

Re: AuthzMergeRules blocks everything in default configuration

2008-12-01 Thread Roy T. Fielding
IIRC, trunk contains (or contained) a security problem with regard to backward compatibility with 2.x configs. I won't consider it releasable until that has been fixed one way or another, and I can't tell from this mail thread whether the actual fix was committed or not. I thought that Chris

Re: AuthzMergeRules blocks everything in default configuration

2008-12-01 Thread Chris Darroch
Roy T. Fielding wrote: IIRC, trunk contains (or contained) a security problem with regard to backward compatibility with 2.x configs. I won't consider it releasable until that has been fixed one way or another, and I can't tell from this mail thread whether the actual fix was committed or not.

Re: AuthzMergeRules blocks everything in default configuration

2008-12-01 Thread Eric Covener
On Mon, Dec 1, 2008 at 6:16 PM, Chris Darroch [EMAIL PROTECTED] wrote: Finally there was a certain amount of bike-shed re-painting in the form of renaming configuration directives. I settled on Match, MatchAll, etc. based on Eric Covener's comments. I had meant iif containers are used, I'd

Re: AuthzMergeRules blocks everything in default configuration

2008-12-01 Thread Roy T. Fielding
On Dec 1, 2008, at 3:16 PM, Chris Darroch wrote: Roy T. Fielding wrote: IIRC, trunk contains (or contained) a security problem with regard to backward compatibility with 2.x configs. I won't consider it releasable until that has been fixed one way or another, and I can't tell from this

Re: new modules in trunk

2008-12-01 Thread Eli Marmor
Paul Querna wrote: ... If the core fully supported UDP and multicast listeners, it should be possible to write the heartmonitor module as just a protocol module, although heartbeat would still likely need its current structure. ... Issac Goldstand already developed UDP support, for the