Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

Yeah, I tried a 0 len read. Unfortunately, the core input filter is not happy about that: core_filters.c, line 231 AP_DEBUG_ASSERT(readbytes > 0); > Am 12.10.2015 um 10:25 schrieb Plüm, Rüdiger, Vodafone Group > : > > How about the following patch? > >

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

I am about to change that. > Am 12.10.2015 um 12:48 schrieb Plüm, Rüdiger, Vodafone Group > : > > > >> -Original Message- >> From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] >> Sent: Montag, 12. Oktober 2015 10:58 >> To: dev@httpd.apache.org >>

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

The key here is using AP_MODE_INIT first (where 0 make sense) before AP_MODE_SPECULATIVE. On Mon, Oct 12, 2015 at 10:36 AM, Stefan Eissing wrote: > Yeah, I tried a 0 len read. Unfortunately, the core input filter is not happy > about that: > > core_filters.c, line

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

Also, I wonder if we don't need: Index: modules/http2/h2_task_input.c === --- modules/http2/h2_task_input.c(revision 1707888) +++ modules/http2/h2_task_input.c(working copy) @@ -116,7 +116,7 @@ apr_status_t

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

On Mon, Oct 12, 2015 at 11:13 AM, Rainer Jung wrote: > > Since I started this thread: IMHO this discussion shouldn't stop/influence > 2.4.17. mod_http2 is experimental, so even a change of defaults in early > releases should be OK. And any exotic interop problems are not

RE: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

How about the following patch? This separates the triggering of the SSL Handshake and the possible reading of the 24 bytes: Index: h2_h2.c === --- h2_h2.c

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

The AP_MODE_INIT triggers the handshake nicely. But the protocol switching still happens on the first read. currently looking how to trigger that best. The h2_task_input is only ever run on "pseudo" connections. But I agree that it should pass init down the filter chain. //Stefan > Am

RE: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

> -Original Message- > From: Stefan Eissing [mailto:stefan.eiss...@greenbytes.de] > Sent: Montag, 12. Oktober 2015 10:58 > To: dev@httpd.apache.org > Subject: Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is > loaded > > The AP_MODE_INIT triggers the handshake nicely. But

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

It is default for some, others do not do it. No browser speaks h2c nowadays. I think reading bytes on a connection which is supposed to allow h2c traffic should be fine. Then one could argue if 24 bytes can always be expected... Since we no longer enabled h2c by default in a server, I expect

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

Am 12.10.2015 um 11:09 schrieb Stefan Eissing: I plan to change it to only happen for servers, where h2/h2c is among configured protocols. Am 12.10.2015 um 11:07 schrieb Yann Ylavic : On Sun, Oct 11, 2015 at 7:15 PM, Yann Ylavic wrote: On Sun,

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

On Mon, Oct 12, 2015 at 11:12 AM, Yann Ylavic wrote: > Is this something used by real world h2 clients? I meant browers :p

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

I plan to change it to only happen for servers, where h2/h2c is among configured protocols. > Am 12.10.2015 um 11:07 schrieb Yann Ylavic : > > On Sun, Oct 11, 2015 at 7:15 PM, Yann Ylavic wrote: >> On Sun, Oct 11, 2015 at 7:11 PM, Stefan Eissing >>

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

On Sun, Oct 11, 2015 at 7:15 PM, Yann Ylavic wrote: > On Sun, Oct 11, 2015 at 7:11 PM, Stefan Eissing > wrote: >> Don't think so. But loading the module should do no harm, I think. And it >> does now. > > Isn't configuring H2Direct on which

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

That would be better, but still the doc says "This mode falls outside the RFC 7540 but has become widely implemented as it is very convenient for development and testing". Is this something used by real world h2 clients? On Mon, Oct 12, 2015 at 11:09 AM, Stefan Eissing

Re: [VOTE] Release Apache httpd 2.4.17 as GA

On Fri, Oct 9, 2015 at 1:40 PM, Jim Jagielski wrote: > The pre-release test tarballs for Apache httpd 2.4.17 can be found > at the usual place: > > http://httpd.apache.org/dev/dist/ > > I'm calling a VOTE on releasing these as Apache httpd 2.4.17 GA. > > [ ] +1: Good to

Re: [VOTE] Release Apache httpd 2.4.17 as GA

Am 09.10.2015 um 19:40 schrieb Jim Jagielski: The pre-release test tarballs for Apache httpd 2.4.17 can be found at the usual place: http://httpd.apache.org/dev/dist/ I'm calling a VOTE on releasing these as Apache httpd 2.4.17 GA. [X] +1: Good to go [ ] +0: meh [ ] -1: Danger Will

Re: [VOTE] Release Apache httpd 2.4.17 as GA

On Fri, Oct 9, 2015 at 1:40 PM, Jim Jagielski wrote: > I'm calling a VOTE on releasing these as Apache httpd 2.4.17 GA. +1 Tested on AIX 7.1/ppc64/xlc After much head-scratching, compiling of new openssl/nghttp2, and lots of myserious CPAN stuff, Test framework passed

Re: [VOTE] Release Apache httpd 2.4.17 as GA

A little over 4.5 hours until the VOTE closes... test early, test often! :) > On Oct 9, 2015, at 1:40 PM, Jim Jagielski wrote: > > The pre-release test tarballs for Apache httpd 2.4.17 can be found > at the usual place: > > http://httpd.apache.org/dev/dist/ > > I'm

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

On 11 Oct 2015, at 7:00 PM, Stefan Eissing wrote: > Ok, analyzed the code. Here is what seems to be happening: > > - mod_http2, in the connection hook, does a blocking, speculative read to > a) make sure the ALPN has been triggered Looking at the code inside the

Re: [VOTE] Release Apache httpd 2.4.17 as GA

+1 > Am 12.10.2015 um 15:13 schrieb Jim Jagielski : > > A little over 4.5 hours until the VOTE closes... > > test early, test often! :) > >> On Oct 9, 2015, at 1:40 PM, Jim Jagielski wrote: >> >> The pre-release test tarballs for Apache httpd 2.4.17 can be

Re: [VOTE] Release Apache httpd 2.4.17 as GA

All looks fine with building and running Win32/Win64 VC14/11/10 No regressions/issues seen. Build with: nghttp2 1.3.4 apr 1.5.2 with IPv6 enabled apr-util 1.5.4 with Crypto OpenSSL enabled apr-iconv 1.2.1 openssl 1.0.2d +asm zlib 1.2.8 +asm pcre 8.37 httpd.exe with OPENSSL_Applink and

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

With r1708107 I committed the following changes to /trunk: mod_ssl: - calling ap_switch_protocol directly after ap_select protocol from inside the SSL ALPN callback. Error in switching will result in a TLS error which seems correct. This makes sure that after the ALPN has been triggered, the

[RESULT] Re: [VOTE] Release Apache httpd 2.4.17 as GA

The VOTE is CLOSED. With more than the required 3 +1 (binding) votes, the VOTE PASSES! Thx to all testers and contributors. I will start the process of pushing to the mirrors and will announce on Weds. > On Oct 9, 2015, at 1:40 PM, Jim Jagielski wrote: > > The pre-release

Re: [RESULT] Re: [VOTE] Release Apache httpd 2.4.17 as GA

Yay! Thanks to all! > Am 12.10.2015 um 19:41 schrieb Jim Jagielski : > > The VOTE is CLOSED. > > With more than the required 3 +1 (binding) votes, the VOTE > PASSES! > > Thx to all testers and contributors. I will start the process > of pushing to the mirrors and will

Double 101 response on timeout with h2c/mod_http2

I was curious to see how the mod_reqtimeout filter removal worked with mod_http2, since mod_websocket needs something similar. So I opened up telnet and did a manual Upgrade: h2c with some junk HTTP2-Settings. I got the 101 Switching Protocols response and a binary chunk of SETTINGS, then let

Re: 2.4.17 test failure for mod_nntp_like_ssl when mod_http2 is loaded

On 10/12/2015 02:12 AM, Yann Ylavic wrote: That would be better, but still the doc says "[H2Direct] falls outside the RFC 7540 but has become widely implemented as it is very convenient for development and testing". _Does_ it fall outside the RFC? Section 3.4 covers the establishment of