Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

We've committed a fix for the issue that James found and Anton has a bug fix for table locking as well, so I'm going to start a new vote for RC2. Thanks for voting on this, everyone! On Wed, Apr 29, 2020 at 4:18 PM Ryan Blue wrote: > Thanks, Parth! I updated the PR. Could you review it? > > On

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

Thanks, Parth! I updated the PR. Could you review it? On Wed, Apr 29, 2020 at 4:11 PM parth brahmbhatt wrote: > +1 once we apply the patch. > > The patch works with presto but it breaks iceberg build. We need to add a > typecast to FileIO in TableMetadataParserTest here >

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

+1 once we apply the patch. The patch works with presto but it breaks iceberg build. We need to add a typecast to FileIO in TableMetadataParserTest here

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

Thanks, James. Is it possible for you to test with this patch? https://patch-diff.githubusercontent.com/raw/apache/incubator-iceberg/pull/986.patch Those methods were removed, and it should be easy for Presto to update. That said, I don't like breaking downstream projects so it would be nice to

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

Verified signature, checksum, rat checks, build, and unit tests. All looked good. Tried building latest prestosql master with proposed new iceberg release, but received these compilation errors: [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

There is one issue we may want to fix before the release. We should suppress exceptions while unlocking in HiveTableOperations. Right now, we throw a runtime exception. This leads to cases when the commit is actually successful and we swap the pointer but the subsequent exception during unlock

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

+1 . Verified the outlined steps. -R On Wed, Apr 29, 2020 at 8:09 AM tison wrote: > Hi Junjie, > > It is kind of GPG scope issue that you should manually trust Ryan's KEYS. > > FYI https://www.gnupg.org/gph/en/manual/x334.html > > Best, > tison. > > > Junjie Chen 于2020年4月29日周三 下午9:47写道： > >>

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

Hi Junjie, It is kind of GPG scope issue that you should manually trust Ryan's KEYS. FYI https://www.gnupg.org/gph/en/manual/x334.html Best, tison. Junjie Chen 于2020年4月29日周三 下午9:47写道： > Ran 1-7 steps > found a warning: > gpg: assuming signed data in 'apache-iceberg-0.8.0-incubating.tar.gz'

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

+1 (non-binding) [I assume only Apache/Iceberg members have binding votes?) Similar to others I verified: √ RAT checks passed √ signature is correct √ checksum is correct √ build from source √ run tests locally Thanks, Adrian On Tue, 28 Apr 2020 at 21:45, Ryan Blue wrote: > Here are the

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

+1 (non-binding) Validated checksums and signature, ran ./gradlew build, and ran license check. Loaded into a downstream project and it worked as expected. Best, Ryan On Wed, Apr 29, 2020 at 5:26 AM tison wrote: > Hi Ryan, > > Thanks for starting the voting process. > > +1 (non-binding) I

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

+1 (binding) Validated checksums and signature, ran ./gradlew check, and ran license check. I also downloaded Spark 2.4.5 and loaded iceberg-spark-runtime like this: spark-2.4.5-bin-hadoop2.7/bin/spark-shell \ --conf

Re: [VOTE] Release Apache Iceberg 0.8.0-incubating RC1

Here are the steps to verify the release that I sent out last time, for anyone that doesn’t want to look them up: 1. Download the source tarball, signature (.asc), and checksum (.sha512) from https://dist.apache.org/repos/dist/dev/incubator/iceberg/apache-iceberg-0.8.0-incubating-rc1/