finalization?
> Who's now responsible for final Junit3 removal?
>
> On Mon, Feb 18, 2019 at 4:22 PM oignatenko
> oignatenko@
> wrote:
>
>> Hi Anton,
>>
>> I removed @deprecated from javadoc, thanks for noticing. PR #6122 [1] is
>> updated.
>>
>
Hi Anton,
I removed @deprecated from javadoc, thanks for noticing. PR #6122 [1] is
updated.
As for TODOs, I think you are wrong here because Ignite coding guidelines
[2] not only explicitly allow these but also explain the format in which
these should be presented. If you find violations of
Hi Anton,
There you go:
PR to remove deprecation: https://github.com/apache/ignite/pull/6122
JIRA: https://issues.apache.org/jira/browse/IGNITE-11345
If anything there is not as you expected, please let me know.
regards, Oleg
--
Sent from:
Hi Anton,
I would like to re-check if I correctly understand the plan.
So, we are going to remove deprecation from these two methods - and the
reason for this is that the way recommended instead of these methods makes
it less convenient to start and stop the grid.
Now, regarding the mentioned
Hi Maxim,
I believe that whatever style checks we establish at Teamcity, we better
take care of making it easy for developers to find and fix violations in
their typical dev environment (for Ignite this means, in IDEA). I think it
is important that developers can maintain required style with
oncerns.
>
> What do you think?
>
> чт, 7 февр. 2019 г. в 09:44, oignatenko
> oignatenko@
> :
>>
>> Hi Anton,
>>
>> You can start and stop grid from static context required by mentioned
>> annotations using code like:
>>
>> MyTestC
Hi Anton,
You can start and stop grid from static context required by mentioned
annotations using code like:
MyTestClass.class.newInstance().startGrid();
This way doesn't look very convenient and I created JIRA task to address
that:
https://issues.apache.org/jira/browse/IGNITE-11240
.apache.org/confluence/display/IGNITE/How+to+Document with
> you
> :)
>
> пт, 25 янв. 2019 г. в 20:55, oignatenko
> oignatenko@
> :
>
>> Hello,
>>
>> Is it possible to get edit access to Apache Ignite wiki?
>>
>> I've been working on particular JI
Hello,
Is it possible to get edit access to Apache Ignite wiki?
I've been working on particular JIRA ticket [1] and one of reviewers
suggested me update particular wiki page [2] after the ticket is done.
Now that the ticket is done I would like to make proposed edits to wiki
page.
TIA,
, I think that approach I originally planned (before you
proposed this way) would cause us much more hassle in migration.
REGARDS, Oleg
Павлухин Иван wrote
> Cheers!
>
> вт, 22 янв. 2019 г. в 20:19, oignatenko
> oignatenko@
> :
>>
>> ...sort of a follow-up. I gave f
Semen,
As a follow up, fix for discovered regression was merged tto master per
https://issues.apache.org/jira/browse/IGNITE-11038
If this doesn't fully resolve the issue you observe, please let us know.
regards, Oleg
--
Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/
Hi Semen,
Thanks for heads up! What you observe is a regression introduced in the
course of doing changes per IGNITE-10796 [1].
In file IgniteBinaryObjectsCacheTestSuite3.java line 64 currently reads:
List> suite = new ArrayList<>();
Above is wrong, correct code at this line should be:
018 at 10:14 PM oignatenko
> oignatenko@
> wrote:
>
>> Hi Vovan,
>>
>> I just created JIRA ticket to address your concerns:
>> - https://issues.apache.org/jira/browse/IGNITE-10629
>>
>> In brief, the plan is that a week or two after migration is over we wil
Hi Denis,
Mixing JIRA and human mails in one list seems to be inconvenient both for
those interested in monitoring human and JIRA mails and from this
perspective separate lists approach looks superior.
Also, your mention of filtering made me wonder if "mixed" approach may have
effect opposite to
Hi Andrey,
As far as I know tests annotated by @Ignore can be conveniently tracked on
Teamcity but this requires such tests to be included into JUnit 4 test suite
(org.junit.runners.Suite).
Above requirement currently isn't met by many Ignite tests which are
included in JUnit 3 suites
ribed but I missed it. Currently we have tons of tests
> which rely on our home brewed beforeTestsStarted, beforeTest,
> afterTest, afterTestsStarted. Are you going to mark them all with
> corresponding junit4 annotations?
> пн, 17 дек. 2018 г. в 19:13, oignatenko
> oignatenko@
> :
&
n't we?
>
> Also is there any vision how many migration problems do we have so far
> and how many tests was not migrated yet?
> вс, 16 дек. 2018 г. в 17:39, oignatenko
> oignatenko@
> :
>>
>> Hi Ivan,
>>
>> As promised in my prior mail, here is the branc
>>
>> Hi Oleg,
>>
>> Thanks your for detailed answer. Using junit4 annotations where
>> possible sounds good to me.
>>
>> Also I would like to thank everybody involved in migration to junit4
>> process for your efforts. You were able to move
Hi Ivan,
The issues you mentioned are real and these issues are expected to be
addressed per IGNITE-10177.
I am currently experimenting with various approaches to tackle that, will
post here when "early preview implementation" is ready to let others take a
look and test it.
Until this is
using both styles (annotations
> and overridden methods) in the same test. What is your insight?
> вт, 11 дек. 2018 г. в 10:27, Vladimir Ozerov
> vozerov@
> :
>>
>> Hi Oleg,
>>
>> Yes, makes perfect sense. Thank you.
>>
>> On Mon, Dec 10, 2018 at 10:14 PM
н
> vololo100@
> wrote:
>>
>> > Hi Oleg,
>> >
>> > I noticed that GridAbstractTest is now capable to run junit4 tests.
>> > What are the current recommendations for writing new tests? Can we use
>> > junit4 annotation for new tests?
>> >
18 at 1:15 PM Павлухин Иван
> vololo100@
> wrote:
>
>> Hi Oleg,
>>
>> I noticed that GridAbstractTest is now capable to run junit4 tests.
>> What are the current recommendations for writing new tests? Can we use
>> junit4 annotation for new tests?
>> пн, 12 н
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5615
IGNITE-10177 cleanup Junit 3 from the project
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-10177
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5613
IGNITE-10176 migrate non-core modules tests from Junit 3 to 4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite
Following up prior discussion in this thread, suggested changes were merged
to master as a part of IGNITE-10422 and are now included in project default
inspections profile.
Thanks to Maxim and Dmitriy for making it happen.
As for the ticket IGNITE-10450, I plan to keep it open for a little while
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5562
IGNITE-10175 migrate core module tests from Junit 3 to 4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/5382
---
Hi Ivan,
Павлухин Иван wrote
> P.S. Did not really get what was the main problem related to
> IGNITE-10399 [1]. I suppose it should go: simple problem -- fast fix.
Well, speaking of IGNITE-10399 it turned out that problem is indeed simple
and fix was fast, just as you wrote.
What looked wrong
Hi Ivan,
You are right that these things will distract people and from this
perspective it is very well justified that vast majority of style deviations
(currently, all of them) are marked yellow. These are non-critical and if
developer ignores them nothing immediately bad happens.
(For the sake
Hi Dmitry,
When we had preliminary discussion of this with Maxim we both were inclined
to post it here and let it hang for a while to let dev list folks discuss
this idea in more details for just in case if we missed some usability
implications.
Though now that you mentioned it I figured that
Hello,
When discussing issues involved in IGNITE-10399 we have got an idea to
change color highlighting of some code style inspections to make it easier
to see which can lead to problems at Teamcity.
- Screen shot of how it is supposed to work:
Hi Dmitry,
You are right - these failures are expected to be muted, I updated Teamcity
to account for that.
regards, Oleg
PS. Readers interested in more details on that matter can find detailed
discussion in comments of JIRA ticket IGNITE-10174:
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5460
IGNITE-10191 Incorrect comparison of lists in
RendezvousAffinityFunctionSimpleBenchmark#testAffinityCompatibility
You can merge this pull request into a Git repository by running:
$ git
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/5435
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5435
temporary PR to verify renamed tests on Teamcity for review of 10174
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5434
IGNITE-10335 move ML examples datasets files to resources
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite
Personally I am comfortable with the way how things are now because mail
filters appear to work well for me.
However this thread made me curious about whether ASF has some guidance or
recommendations on that matter. I searched quite a bit and found none of
that kind. It looks like Apache leaves
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5382
IGNITE-10200
GridCacheSetAbstractSelfTest#testMultipleStructuresInDifferentGroups and some
other tests are incorrectly muted
You can merge this pull request into a Git repository by running
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5369
IGNITE-10174 migrate examples tests from Junit 3 to 4
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-10174
Hi Ivan,
I am currently testing approach you used in pull/5354 in the "pilot"
sub-task with examples tests (IGNITE-10174).
So far it looks more and more like the way to go. The most promising thing I
observed is that after I changed classes in our test framework the way you
did, execution of
Hi Jörn,
Agree, it is also my understanding that after we migrate part of the tests
that still use JUnit 3 (https://issues.apache.org/jira/browse/IGNITE-10173),
upgrade to next version is going to be easy and low risk.
With regards to asserting exceptions I think you have a good point here, I
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/5359
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5359
IGNITE-10209 some tests in IgniteExamplesMLTestSuite fail with
FileNotFoundException
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
For all details you can see an experiment on github [1]. Among them
> are ticks with @RunWith annotation making possible to run a test
> inherited from TestCase as Junit 4 test. Still, I might have missed
> something.
>
> Does it sound sane anyhow?
>
> [1] https://github.com/
Hi Vyacheslav,
GridCommonAbstractTest is expected to change too.
As pointed in IGNITE-10173 our approach involves all the subclasses of
GridAbstractTest - including but not limited to one you mentioned
(GridCommonAbstractTest).
regards, Oleg
--
Sent from:
Hello,
I created JIRA task for this move, with detailed explanation and
step-by-step subtasks, your comments are welcome:
- https://issues.apache.org/jira/browse/IGNITE-10173
In brief, the plan is to gradually migrate the part of tests that still uses
Junit 3 (hundreds if not thousands of those
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5344
IGNITE-10158 Some tests in IgniteCacheAbstractQuerySelfTest are incorrectly
muted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5055
IGNITE-9884 Some tests are incorrectly muted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9884
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/5036
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5036
IGNITE-9884 Some tests are incorrectly muted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9884
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/5001
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/5001
IGNITE-9884 Some tests are incorrectly muted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9884
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/4992
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4992
IGNITE-9884 Some tests are incorrectly muted
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9884
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4882
IGNITE-9754 Increase timeout waiting for commitLatch in
testRollbackOnTopologyLockPessimistic
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4853
IGNITE-9721 NPE in
IgniteAuthenticationProcessor$RefreshUsersStorageWorker.body
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4828
IGNITE-9691 testConcurrentAuthorize uses outdated assumption about
exception message
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/4774
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4774
Ignite 8619 experimental
Temporary PR to try out particular test change at Teamcity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/4760
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4760
Ignite 9585 experimental
temporary branch and PR for experimenting for Teamcity
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4753
IGNITE-9585 Error message sometimes refers nonexisting log file when remote
node fails to start
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4662
IGNITE-9396 ML Examples: can't run examples, not enough dependencies in
pom.xml
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4569
IGNITE-9316 Analyse and improve code coverage in ML module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4560
IGNITE-9297 Review ML examples javadocs as of release 2.6
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4489
IGNITE-9146 Analyse and improve code coverage in ML module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/4462
IGNITE-9124 Remove some dead code in ML module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9124
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/3418
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3449
IGNITE-7509 Adjust documentation for ML module
- updated docs
-- verified with diffs overview and rebuild per updated instructions
You can merge this pull request into a Git repository
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3418
Ignite 6899 check
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6899-check
Alternatively you can review
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/2600
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3393
IGNITE-7454 Wrong package in IgniteExamplesMLTestSuite
- completed work for ML examples
-- verified with diffs overview, clean rebuild and execution of
IgniteExamplesSelfTestSuite
You can
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3363
IGNITE-5725 Adapt TracerTest for TC builds.
- implemented adaptive testing approach
-- verified with diffs overview, clean rebuild and execution of unit tests
in both desktop and headless
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3314
IGNITE-7214 performance measurement for FCM and KNN algorithms
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3241
IGNITE-7097 performance measurement for SparseDistributedMatrix multiâ¦
â¦plication
- optimised and unoptimised benchmarks, along with respective documentation
- also a common
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3213
IGNITE-6495 performance measurement of decision trees algorithms
- benchmark drafted a while ago integrated with recent changes in master
-- verified with diffs overview, clean rebuild
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/3211
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3211
IGNITE-7118 performance measurement for distributed k-means clustering
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3210
IGNITE-7118 performance measurement for distributed k-means clustering
- enabled benchmark after integration of necessary fix from master
-- verified with diffs overview, clean rebuild
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3173
IGNITE-6373 Create example for local and distributed k-means algorithm
- examples implemented
-- verified with diffs overview, clean build and execution of examples
You can merge this pull
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/3069
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3168
IGNITE-6872 Linear regression should implement Model API
Model and Trainer API implemented for OLS regression
You can merge this pull request into a Git repository by running:
$ git pull
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/3167
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3167
IGNITE-6872 Linear regression should implement Model API
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6872
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/3069
Ignite 6872 1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6872-1
Alternatively you can review and apply
Hello,
I implemented some benchmarks for machine learning algorithms per
IGNITE-6123 [1] and would want to push these to master.
Changes impact "yardstick" module, more details of new benchmarks can be
found in PR #2780 [2]. Yury Babak [3] did preliminary review and sanity
check.
These are
GitHub user oignatenko reopened a pull request:
https://github.com/apache/ignite/pull/2780
Ignite 6123
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6123
Alternatively you can review and apply
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/2780
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/2780
Ignite 6123
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-6123
Alternatively you can review and apply
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/2604
---
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/2604
IGNITE-6193 ML profile is missing in 2.1 binary release
- porting changes to standalone and lgpl pom files from regular one
-- verified with diffs overview
You can merge this pull request
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/2600
IGNITE-6193 ML profile is missing in 2.1 binary release
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-9163
Github user oignatenko closed the pull request at:
https://github.com/apache/ignite/pull/2537
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/2537
IGNITE-6193 ML profile is missing in 2.1 binary release
- verified with diffs overview and trial local build
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user oignatenko opened a pull request:
https://github.com/apache/ignite/pull/1837
IGNITE-5018 Javadocs in Ignite ML module.
- compliance with coding guidelines
(rev 17 at
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- verified with diffs
browse/IGNITE-5000;
>
> —
> Denis
>
>> On Apr 17, 2017, at 8:48 AM, oignatenko
> oignatenko@
> wrote:
>>
>> Denis, I prepared preliminary draft doc for readme.io
>> http://readme.io/;, it reflects proposed
>> rename. You can find it attache
why, thinking of future, it will be a right decision to name it
> accordingly.
>
> Any concerns?
>
> BTW, have the module been fully merged? I want to try to build it and
> check the examples.
>
> —
> Denis
>
>> On Apr 14, 2017, at 7:05 AM, oignatenko
> oignatenko@
&g
Thank you Denis, that sounds like a good plan. I am working on it now. I
didn't reassign IGNITE-4964, just set a watch on it. Will comment on it when
I have concrete details to share.
Side note my build check completed successfully, although it took quite a
bit of time: I cleaned my local maven
Yury, Denis - me and Nikita are going to take care of readme.io docs.
I plan to start on this tomorrow, will keep you posted on the progress.
Current plan is to briefly introduce new package and examples and explain
how to run examples and possibly unit tests.
With regards to build details,
99 matches
Mail list logo
