Re: [DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-10-04 Thread Ivan Pavlukhin
Nikolay, > As I understand, RunningQueryManager track query only for an export. Not quite. Also it is responsible for explicit query cancellation and running queries cancellation on node stop. I do not think that a view should be responsible for it. пт, 4 окт. 2019 г. в 18:17, Nikolay Izhikov :

Re: [DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-10-04 Thread Nikolay Izhikov
Ivan. > RunningQueryManager is responsible for tracking running queries (and query > history) As I understand, RunningQueryManager track query only for an export. So we don't need explicit entity for that, we already have System Views. В Пт, 04/10/2019 в 17:40 +0300, Ivan Pavlukhin пишет: >

Re: [DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-10-04 Thread Ivan Pavlukhin
Nikolay, Thank you for sharing knowledge. > I think we should replace `RunningQueryManager` with the special SystemView > implementation. Not sure that I got the intention and abstraction here. For me a straightforward approach here is to keep RunningQueryManager as is and use a new API to

Re: [DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-10-04 Thread Nikolay Izhikov
Hello, Ivan. > 1. How system views are going to be exposed? Is there any difference > in comparison to other metrics? We have a `SystemViewExporterSpi`. Built-in implementations are `JmxSystemViewExporterSpi` and `SqlViewExporterSpi`. > 2. What should be done to adopt RunningQueryManager to

Re: [DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-10-04 Thread Ivan Pavlukhin
Nikolay, I checked the IEP [1]. Now it is more clear for me about SystemView API. Follow-up questions: 1. How system views are going to be exposed? Is there any difference in comparison to other metrics? 2. What should be done to adopt RunningQueryManager to SystemView API? Also some bits for my

Re: [DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-10-03 Thread Nikolay Izhikov
Hello, Ivan. Thanks for feedback. Initial IEP [1] naming was changed during code review. I updated the IEP [1] with the current naming. Can you take a look and check is all clear now? [1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=112820392 В Ср, 02/10/2019 в 17:21

Re: [DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-10-02 Thread Ivan Pavlukhin
Hi Nikolay, Actually I do not fully understand what is SystemView API. I have not found it in IEP [1] (I searched for words "system" and "view"). RunningQueryManager is a component responsible for tracking running queries internally. This info is exposed to users as SQL view via

[DISCUSSION][IEP-35] Replace RunningQueryManager with GridSystemViewManager

2019-09-30 Thread Nikolay Izhikov
Hello, Igniters. Since the last release `RunningQueryManager` [1] was added. It used to track a running query. In IEP-35 [2] SystemView API was added. SystemView API supposed to be used to track all kinds of internal Ignite objects. I think this RunningQueryManager should be replaced [3] with