Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Igniters, has anyone been able to review yet? Seems like a very useful feature. On Wed, Oct 11, 2017 at 1:44 AM, Nikita Amelchev wrote: > Hello, Igniters. > > I have implemented support for the Externalizable interface in the > BinaryMarshaller without deserialization on servers.[1,2] I have mad

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Hello, Igniters. I have implemented support for the Externalizable interface in the BinaryMarshaller without deserialization on servers.[1,2] I have made it like the Binarylizable does in a raw writer. Please, review. [1]: https://reviews.ignite.apache.org/ignite/review/IGNT-CR-278 [2]: https://

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Nikita, I think it should be consistent with Binarylizable. -Val On Fri, Sep 22, 2017 at 7:12 AM Nikita Amelchev wrote: > Another problem is support BinaryObject methods, for example, when we need > to get a field(often case in queries with annotation QuerySqlField). In a > binary object, fiel

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Another problem is support BinaryObject methods, for example, when we need to get a field(often case in queries with annotation QuerySqlField). In a binary object, fields are getting from the schema, which I don't have (BinaryObjectException: Cannot find schema for object with compact footer). I s

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Nikita, It sounds like the test should be changed, no? In case I'm missing something, can you please give more details about the scenario which requires deserialization? Generally, this sounds weird - in cases when we can get advantage of binary format and avoid deserialization, we definitely shou

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

I have some problem when we don't deserialize Externalizable. Some messages require deserializing in GridCacheIoManager.message0(). For example, tests like testResponseMessageOnUnmarshallingFailed where readExternal throws an exception. A message containing Externalizable is deserialized and proces

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

I also agree that we should try to use Externalizable without deserialization on servers. I will do it in a way suggested in the review. The Externalizable will marshal through type GridBinaryMarshaller.OBJ, in addition, I’ll add a flag in BinaryConfiguration which will be used to turn on the old w

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Vova, I agree. Let's stay loyal to our binary serialization protocol. Do you know if we will be loosing any functionality available in Externalizable, but not present in our binary protocol? D. On Mon, Sep 4, 2017 at 11:38 PM, Vladimir Ozerov wrote: > Folks, > > Let's discuss how this should b

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Folks, Let's discuss how this should be handled properly. I proposed to use the same format as regular binary object, with all data being written in "raw" form. This would give us one critical advantage - we will be able to work with such objects without deserialization on the server. Hence, no cl

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Hello, Igniters! I've developed Externalizable interface support using BinaryMarshaller [1]. I have a misunderstanding with defining BinaryWriteMode in BinaryUtils.mode(cls): there is AffinityKey class which implements Externalizable and registered with ReflectiveSerialize, BinaryMarshaller defin

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Nikita, I think anything binary related should have higher priority than Externalizable. I.e. if user explicitly implemented Binarylizable or provided a BinarySerializer, then BinaryMarshaller should of course use that and ignore Externalizable. -Val On Mon, Aug 21, 2017 at 9:29 AM, Nikita Amelc

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Hello, Igniters. I am developing Externalizable interface support by BinaryMarshaller through new type constant. BinaryMarshaller allows using BinarySerializer to manage serialization. I need to define BinaryWriteMode in the BinaryClassDescriptor constructor. In case of the Binarylizable interface

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Valya, It makes sense to have both Externalizable and Binarylizable, as user might want to serialize object for different systems. E.g. deserialize binary stream from Kafka in Externalizable mode, and then put it to Ignite with Binarylizable to allow for field access without deserialization. Nikit

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Hi Nikita, 1. Makes sense to me. 2. Externalizable object should not be written as binary with flag 103, it should be written in the same way it's written now. I don't see any reason to change the protocol. Purpose of this task it to move the logic to binary marshaller instead of depending on opt

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Hello everebody. I would like to clarify about some moments in marshaller about custom serialization. 1. I suggest to divide the issue into two tasks: support the Externalizable and support the Serializable. The second task is to do as a separate issue. 2. In case the Optimized marshaller when o

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Nikita, For Externalizable option 1 is the correct one. Externalizable objects should not be treated as binary objects. For read/writeObject, you indeed have to extend ObjectOutputStream. writeObject() is final because you should extend writeObjectOverride() instead. Take a look at ObjectOutputSt

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

I see two ways to support the Externalizable in the BM: 1. Add a new type constant to the GridBinaryMarshaller class etc and read/writeExternal in the BinaryClassDescriptor. 2. Make read/writeExternal through the BINARY type without updating metadata. I don't know how to make a support read/writeOb

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Nikita, In my view we just need to support Externalizable and writeObject/readObject in BinaryMarshaller and get rid of delegation to optimized marshaller. Once such classes also go through BinaryMarshaller streams, they will be aware of binary configuration and will share the same set of handles

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

I have some questions about single Marshaller. It seems not easy to merge OptimizedMarshaller with BinaryMarshaller and is there any sense in it? When Binary object inside Externalizable serialized with optimized it losing all benefits. Will OptimizedMarshaller be supported at 2.0 version? Or to me

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Someone else added you to the contributors list in JIRA. This is why I couldn’t add you for the second time. Ignite committers, please reply on the dev list if you add someone to the list. Nikita, yes, this ticket is still relevant. Go ahead and assign it on yourself. Also please you may want t

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

This issue was created long ago. Is still relevant? JIRA account: Username: NSAmelchev Full Name: Amelchev Nikita 2017-01-14 1:52 GMT+03:00 Denis Magda : > Hi Nikita, > > I can’t find provided account in Ignite JIRA > https://issues.apache.org/jira/browse/IGNITE ji

Re: IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Hi Nikita, I can’t find provided account in Ignite JIRA https://issues.apache.org/jira/browse/IGNITE Please create an account there and share with me. This information might be useful for you as well. Subscribe to both dev and user lists: https:/

IGNITE-2894 - Binary object inside of Externalizable still serialized with OptimizedMarshaller

Hello everyone. I'd like to take IGNITE-2894. Can you assign to me? Username: NSAmelchev -- Best wishes, Amelchev Nikita

[jira] [Created] (IGNITE-2894) Binary object inside of Externalizable still serialized with OptimizedMarshaller

Valentin Kulichenko created IGNITE-2894: --- Summary: Binary object inside of Externalizable still serialized with OptimizedMarshaller Key: IGNITE-2894 URL: https://issues.apache.org/jira/browse/IGNITE-2894