[GitHub] ignite pull request #2285: IGNITE-5123

2017-07-24 Thread YevIgn
Github user YevIgn closed the pull request at: https://github.com/apache/ignite/pull/2285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: IGNITE-5123 Review

2017-07-24 Thread Evgeniy Ignatiev
M, Evgeniy Ignatiev < yevgeniy.ignat...@gmail.com> wrote: Hello, Igniters. Could anyone review my request - https://issues.apache.org/jira /browse/IGNITE-5123? - My previous pings seems to got lost. Best regards, Yevgeniy

Re: IGNITE-5123 Review

2017-07-24 Thread Semyon Boikov
Ignatiev < > >> >> yevgeniy.ignat...@gmail.com > >> >>>> : > >> >>>> > >> >> > >> http://ci.ignite.apache.org/viewLog.html?buildId=720722&; > tab=buildResultsDiv&buildTypeId=IgniteTests_IgniteBasic > >> >>&

Re: IGNITE-5123 Review

2017-07-23 Thread Dmitry Pavlov
r >> >> failed >> >>>> tests seem to fail in several other reviews too and are unrelated to >> my >> >>>> changes. >> >>>> >> >>>> >> >>>> On 19.07.2017 17:35, Dmitry Pavlov wrote: >> >>>>> Hi Evgeniy, >> >>>>> >> >>>>> I was not able to find Teamcity run for this change. >> >>>>> Could you please run http://ci.ignite.apache.org test for example >> on >> >>>> branch >> >>>>> pull/2285/head using 'Ignite 2.0 Tests' target 'Run All'. >> >>>>> Or could you please share link to previous run on this changes? >> >>>>> >> >>>>> Sincerely, >> >>>>> Dmitriy Pavlov >> >>>>> >> >>>>> ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov : >> >>>>> >> >>>>>> Igniters, >> >>>>>> >> >>>>>> Could somebody review the fix today? >> >>>>>> >> >>>>>> On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < >> >>>>>> yevgeniy.ignat...@gmail.com> wrote: >> >>>>>> >> >>>>>>> Hello, Igniters. >> >>>>>>> >> >>>>>>> Could anyone review my request - https://issues.apache.org/jira >> >>>>>>> /browse/IGNITE-5123? - My previous pings seems to got lost. >> >>>>>>> >> >>>>>>> Best regards, >> >>>>>>> >> >>>>>>> Yevgeniy >> >>>>>>> >> >>>>>>> >> >>>> >> >>

Re: IGNITE-5123 Review

2017-07-20 Thread Dmitry Pavlov
>>>>> I was not able to find Teamcity run for this change. > >>>>> Could you please run http://ci.ignite.apache.org test for example on > >>>> branch > >>>>> pull/2285/head using 'Ignite 2.0 Tests' target 'Run All'. > >>>>> Or could you please share link to previous run on this changes? > >>>>> > >>>>> Sincerely, > >>>>> Dmitriy Pavlov > >>>>> > >>>>> ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov : > >>>>> > >>>>>> Igniters, > >>>>>> > >>>>>> Could somebody review the fix today? > >>>>>> > >>>>>> On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < > >>>>>> yevgeniy.ignat...@gmail.com> wrote: > >>>>>> > >>>>>>> Hello, Igniters. > >>>>>>> > >>>>>>> Could anyone review my request - https://issues.apache.org/jira > >>>>>>> /browse/IGNITE-5123? - My previous pings seems to got lost. > >>>>>>> > >>>>>>> Best regards, > >>>>>>> > >>>>>>> Yevgeniy > >>>>>>> > >>>>>>> > >>>> > >

Re: IGNITE-5123 Review

2017-07-20 Thread Evgeniy Ignatiev
Could somebody review the fix today? On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < yevgeniy.ignat...@gmail.com> wrote: Hello, Igniters. Could anyone review my request - https://issues.apache.org/jira /browse/IGNITE-5123? - My previous pings seems to got lost. Best regards, Yevgeniy

Re: IGNITE-5123 Review

2017-07-20 Thread Dmitry Pavlov
t; > > > Sincerely, > > > > Dmitriy Pavlov > > > > > > > > ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov : > > > > > > > >> Igniters, > > > >> > > > >> Could somebody review the fix today? > > > >> > > > >> On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < > > > >> yevgeniy.ignat...@gmail.com> wrote: > > > >> > > > >>> Hello, Igniters. > > > >>> > > > >>> Could anyone review my request - https://issues.apache.org/jira > > > >>> /browse/IGNITE-5123? - My previous pings seems to got lost. > > > >>> > > > >>> Best regards, > > > >>> > > > >>> Yevgeniy > > > >>> > > > >>> > > > > > > > > >

Re: IGNITE-5123 Review

2017-07-20 Thread Dmitry Pavlov
le to find Teamcity run for this change. > >>>> Could you please run http://ci.ignite.apache.org test for example on > >>> branch > >>>> pull/2285/head using 'Ignite 2.0 Tests' target 'Run All'. > >>>> Or could you pleas

Re: IGNITE-5123 Review

2017-07-20 Thread Evgeniy Ignatiev
hanges? Sincerely, Dmitriy Pavlov ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov : Igniters, Could somebody review the fix today? On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < yevgeniy.ignat...@gmail.com> wrote: Hello, Igniters. Could anyone review my request - https://issues.apac

Re: IGNITE-5123 Review

2017-07-19 Thread Evgeniy Ignatiev
июл. 2017 г. в 15:26, Anton Vinogradov : Igniters, Could somebody review the fix today? On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < yevgeniy.ignat...@gmail.com> wrote: Hello, Igniters. Could anyone review my request - https://issues.apache.org/jira /browse/IGNITE-5123? - My pre

Re: IGNITE-5123 Review

2017-07-19 Thread Nick Pordash
ase share link to previous run on this changes? > > > > > > Sincerely, > > > Dmitriy Pavlov > > > > > > ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov : > > > > > >> Igniters, > > >> > > >> Could somebody r

Re: IGNITE-5123 Review

2017-07-19 Thread Dmitry Pavlov
Vinogradov : > > > >> Igniters, > >> > >> Could somebody review the fix today? > >> > >> On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < > >> yevgeniy.ignat...@gmail.com> wrote: > >> > >>> Hello, Igniters. > >>> > >>> Could anyone review my request - https://issues.apache.org/jira > >>> /browse/IGNITE-5123? - My previous pings seems to got lost. > >>> > >>> Best regards, > >>> > >>> Yevgeniy > >>> > >>> > >

Re: IGNITE-5123 Review

2017-07-19 Thread Evgeniy Ignatiev
changes? Sincerely, Dmitriy Pavlov ср, 19 июл. 2017 г. в 15:26, Anton Vinogradov : Igniters, Could somebody review the fix today? On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < yevgeniy.ignat...@gmail.com> wrote: Hello, Igniters. Could anyone review my request - https://issues.a

Re: IGNITE-5123 Review

2017-07-19 Thread Dmitry Pavlov
ne review my request - https://issues.apache.org/jira > > /browse/IGNITE-5123? - My previous pings seems to got lost. > > > > Best regards, > > > > Yevgeniy > > > > >

Re: IGNITE-5123 Review

2017-07-19 Thread Anton Vinogradov
Igniters, Could somebody review the fix today? On Wed, Jul 19, 2017 at 1:30 PM, Evgeniy Ignatiev < yevgeniy.ignat...@gmail.com> wrote: > Hello, Igniters. > > Could anyone review my request - https://issues.apache.org/jira > /browse/IGNITE-5123? - My previous pings seems to

IGNITE-5123 Review

2017-07-19 Thread Evgeniy Ignatiev
Hello, Igniters. Could anyone review my request - https://issues.apache.org/jira/browse/IGNITE-5123? - My previous pings seems to got lost. Best regards, Yevgeniy

Re: IGNITE-5123

2017-07-12 Thread Anton Vinogradov
seem to fail in several other > reviews too and be unrelated to my changes. > > Would you be so kind to review my pull-request? > > Best regards, > > Evgeniy. > > > On 05.07.2017 12:35, Evgeniy Ignatiev wrote: > >> Would you mind if I pick the https://issue

Re: IGNITE-5123

2017-07-12 Thread Evgeniy Ignatiev
regards, Evgeniy. On 05.07.2017 12:35, Evgeniy Ignatiev wrote: Would you mind if I pick the https://issues.apache.org/jira/browse/IGNITE-5123 and place PluginProvider#onIgniteStart after the component callbacks are called to comply with its Javadoc? On 04.07.2017 18:06, Evgeniy Ignatiev wrot

[GitHub] ignite pull request #2285: IGNITE-5123

2017-07-12 Thread YevIgn
GitHub user YevIgn opened a pull request: https://github.com/apache/ignite/pull/2285 IGNITE-5123 You can merge this pull request into a Git repository by running: $ git pull https://github.com/YevIgn/ignite ignite-5123 Alternatively you can review and apply these changes as

Re: IGNITE-5123

2017-07-05 Thread Evgeniy Ignatiev
Would you mind if I pick the https://issues.apache.org/jira/browse/IGNITE-5123 and place PluginProvider#onIgniteStart after the component callbacks are called to comply with its Javadoc? On 04.07.2017 18:06, Evgeniy Ignatiev wrote: As it is explicitly stated in Javadoc of PluginProvider

Re: IGNITE-5123

2017-07-04 Thread Evgeniy Ignatiev
wrote: Hello, Igniters. Looking at the ticket https://issues.apache.org/jira/browse/IGNITE-5123, the IgniteKernal#start notifies plugin providers, calling PluginProvider#onIgniteStart, before components are notified, when caches are created in GridCacheProcessor#onIgniteStart. Does it make

IGNITE-5123

2017-07-02 Thread Evgeniy Ignatiev
Hello, Igniters. Looking at the ticket https://issues.apache.org/jira/browse/IGNITE-5123, the IgniteKernal#start notifies plugin providers, calling PluginProvider#onIgniteStart, before components are notified, when caches are created in GridCacheProcessor#onIgniteStart. Does it make sense to

[jira] [Created] (IGNITE-5123) Ignite.cache(String) returns null in PluginProvider.onIgniteStart()

2017-05-01 Thread Nick Pordash (JIRA)
Nick Pordash created IGNITE-5123: Summary: Ignite.cache(String) returns null in PluginProvider.onIgniteStart() Key: IGNITE-5123 URL: https://issues.apache.org/jira/browse/IGNITE-5123 Project: Ignite