Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-09-15 Thread Anton Kalashnikov
Hello, This idea looks great in my opinion. I agree that a more common approach would be better but I am the same as Kirill haven't found the better one. So in my point of view, this library is better than nothing, and if nobody will recommend a different one we can take picocli right now. -- 

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-09-14 Thread Данилов Семён
Hello! I've looked through the picocli manual and it looks really great. We will be able easily add i18n and stuff like this. Nevertheless, we will get rid of the manual formatting of examples and help texts. Kind regards, Semyon. 14.09.2020, 13:00, "Alexey Goncharuk" : > Hi folks, > > Despite

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-09-14 Thread Alexey Goncharuk
Hi folks, Despite the autocompletion support only for bash, I see the following benefits from this change: * It may unify all the CLI tooliing in Ignite, providing a better user experience * The library has an ability to generate man pages, which may be nice * I see there is an open issue for a

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-09-08 Thread ткаленко кирилл
Hello, Ilya! I agree that it would be better if we found a common approach, but I haven't found one yet. 07.09.2020, 18:50, "Ilya Kasnacheev" : > Hello! > > Not everyone is using bash, which leads me to question whether there's any > common approach where we can hint a shell what our executable

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-09-07 Thread Ilya Kasnacheev
Hello! Not everyone is using bash, which leads me to question whether there's any common approach where we can hint a shell what our executable can do so that it can discover and auto-complete our control.sh Regards, -- Ilya Kasnacheev пн, 7 сент. 2020 г. в 17:47, ткаленко кирилл : > Hello, f

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-19 Thread ткаленко кирилл
Hi Alexey! I will take a short pause before the implementation and try to answer all your questions. 18.06.2020, 18:05, "Alexey Goncharuk" : > Definitely a +1 from me for moving the CLI tooling to a separate module. > > As for the autocompletion - can you elaborate how it works? Will it require

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-19 Thread ткаленко кирилл
Hi Evgenii! At first glance, api will not change, but I can see it when I will do it. 17.06.2020, 23:16, "Evgenii Zhuravlev" : > Hi, > > +1 for both moving control.sh to the separate module and adding > autocompletion. > > Will API remain the same in control.sh? > > Evgenii > > пт, 5 июн. 2020 г.

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-18 Thread Petr Ivanov
Autocompletion is a separate shell module that required installing along with adding separate modules for each system (git, etc.) It will require used to run script to install it in the system, so I would left it for RPM or DEB packages where that can be managed correctly. > On 18 Jun 2020, at

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-18 Thread Alexey Goncharuk
Definitely a +1 from me for moving the CLI tooling to a separate module. As for the autocompletion - can you elaborate how it works? Will it require to run an additional tool when a user hits TAB? Or will it generate an autocompletion file during the build? Will we require an install step for Igni

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-17 Thread Evgenii Zhuravlev
Hi, +1 for both moving control.sh to the separate module and adding autocompletion. Will API remain the same in control.sh? Evgenii пт, 5 июн. 2020 г. в 01:59, ткаленко кирилл : > Folks have created a ticket [1]. > > 1 - https://issues.apache.org/jira/browse/IGNITE-13120 > > 02.06.2020, 16:48,

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-05 Thread ткаленко кирилл
Folks have created a ticket [1]. 1 - https://issues.apache.org/jira/browse/IGNITE-13120 02.06.2020, 16:48, "ткаленко кирилл" : > Maxim I suggested moving control.sh in a separate module, are we talking > about the same thing? > > 02.06.2020, 16:15, "Maxim Muzafarov" : >>  Folks, >> >>  +1 >> >>

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread ткаленко кирилл
Maxim I suggested moving control.sh in a separate module, are we talking about the same thing? 02.06.2020, 16:15, "Maxim Muzafarov" : > Folks, > > +1 > > However, AFAIK control.sh is the part of the ignite-core module with > zero dependencies from external resources. > Would it be better going th

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Ivan Daschinsky
> By the way, according to README.md [1] the picocli is already using bythe Apache Ignite, right? :-) Yes, you are right, but a little bit outdated. > Would it be better going the `control.sh` extensions-way? Sounds good. Also, it would be great to incorporate in command line utilities some featur

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Maxim Muzafarov
Folks, +1 However, AFAIK control.sh is the part of the ignite-core module with zero dependencies from external resources. Would it be better going the `control.sh` extensions-way? By the way, according to README.md [1] the picocli is already using by the Apache Ignite, right? :-) > Picocli is

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Ivan Daschinsky
+1 But this is not only usability improvement, but also a huge code improvement. With picocli developers can add custom command without writing a lot of boilerplate and error prone code to do a trivial task of parsing CLI arguments. Cleaner code, less bugs also matter. вт, 2 июн. 2020 г. в 16:02,

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Sergey Antonov
It would be a great usability improvement! +1 From me. вт, 2 июн. 2020 г. в 15:54, Zhenya Stanilovsky : > > > good catch ! it`s a little bit pain for now to working with it. > > > >Hi, Igniters! > > > >At the moment to work with the control.sh we need to know exactly what > the name of the comma

Re: [DISCUSSION] Add autocompletion for commands in control.sh

2020-06-02 Thread Zhenya Stanilovsky
good catch ! it`s a little bit pain for now to working with it.   >Hi, Igniters! > >At the moment to work with the control.sh we need to know exactly what the >name of the command and its options are and so the user can often make >mistakes when using it. So I think it would be useful to do co