Re: PHP thin client

2018-10-23 Thread Stepan Pilschikov
And more, If im use ->setValueType(ObjectType::ENUM) during $cache->get(1); it throwing exception that client can't convert BINARY_ENUM to ENUM вт, 23 окт. 2018 г. в 15:57, Stepan Pilschikov : > Thanks, finally fixes are merged > > I have new question > > I'm trying to put Enum object and get i

Re: PHP thin client

2018-10-23 Thread Stepan Pilschikov
Thanks, finally fixes are merged I have new question I'm trying to put Enum object and get it back, but catch exception that enum is null code with output - https://gist.github.com/pilshchikov/b89c6e25f29da88ac03caa42231a02bc Also can't find Enum data type test in sources I trying to use Enum

Re: PHP thin client

2018-10-20 Thread Pavel Petroshenko
Hi Stepan, I submitted a patch and updated JIRA with some comments. Can you please give it a try? Thanks, P. On Fri, Oct 19, 2018 at 9:07 AM Stepan Pilschikov wrote: > Alexey, > > Hi > > I'm trying to use PHP client for some times and discover one problem with > DATA and TIMESTAMP data types

Re: PHP thin client

2018-10-19 Thread Stepan Pilschikov
Alexey, Hi I'm trying to use PHP client for some times and discover one problem with DATA and TIMESTAMP data types I'ts appear when you trying to use DATA or TIMESTAMP as cache key All description in ticket: https://issues.apache.org/jira/browse/IGNITE-9951 Can you help with that, please? чт,

Re: PHP thin client

2018-10-11 Thread Igor Sapego
Alexey, Since PHP thin client is now in master, can you please add it to our "Thin clients features" wiki page, so we can track the feature parity of our clients? [1] - https://cwiki.apache.org/confluence/display/IGNITE/Thin+clients+features Best Regards, Igor On Wed, Oct 10, 2018 at 2:56 PM V

Re: PHP thin client

2018-10-10 Thread Vladimir Ozerov
I am not sure there is an answer. This is just how we handled it before. IMO both approaches works fine. BTW, I already merged Vyacheslav's PR several hours ago. On Wed, Oct 10, 2018 at 1:24 PM Igor Sapego wrote: > Vyacheslav, > > In this case, we should do the same with all existing doxygen > f

Re: PHP thin client

2018-10-10 Thread Igor Sapego
Vyacheslav, In this case, we should do the same with all existing doxygen files, not only this one (see files with .dxg extension) Vova, Pavel, Were there historically any reasons to exclude doxygen files from check instead of adding a license header? Best Regards, Igor On Tue, Oct 9, 2018 at

Re: PHP thin client

2018-10-09 Thread Vyacheslav Daradur
Great work guys, thanks! I've noticed TC fails in the build plan "Licenses Headers" which Igor have fixed already by excluding Doxyfile from checking. I've filled a ticket [1] and I'd suggest fixing the test in another way by adding the license header to Doxyfile. Igor, please, have a look at pr

Re: PHP thin client

2018-10-09 Thread Igor Sapego
As the seem to be everything OK with the code and tests and no one had any comment for quite some time, I've merged the PHP to Ignite's master. Great job, guys! Best Regards, Igor On Wed, Sep 19, 2018 at 1:00 AM Prachi Garg wrote: > Hi Stephan, Alexey > > That's exactly what readme.io contai

Re: PHP thin client

2018-09-18 Thread Prachi Garg
Hi Stephan, Alexey That's exactly what readme.io contains - installation instructions, configuration, and examples for key-value, sql, etc. for thin clients. For example, see these documentation pages for Node.js (currently hidden in the latest version of the doc) : https://apacheignite.readme.io

Re: PHP thin client

2018-09-18 Thread Stepan Pilshchikov
> You know, I'm confused with all this documentation stuff... > For nodejs client all docs were moved from the repo to readme.io but the > readme.md keeps the installation instructions (duplicated with > readme.io). Probably, that's ok. > Will add similar short readme.md to the PHP PR. Its goo

Re: PHP thin client

2018-09-18 Thread Alexey Kosenchuk
But now in PR we have no readme at all Agree with examples on readme.io, but other information (how to install, how to configurate, install from sources, basic description) may be in sources, it help a lot Or it also should be on readme.io? This question because in other platforms have readme exi

Re: PHP thin client

2018-09-18 Thread Stepan Pilshchikov
> 1. Because finally the docs should not be in the repo (unfortunately) but > on readme.io. > There is a task for that: > https://issues.apache.org/jira/browse/IGNITE-9523 > Added the link in the jira. Ok > 2. Examples in readme.md are more like code snippets (mostly not big) > intended to he

Re: PHP thin client

2018-09-18 Thread Alexey Kosenchuk
Hi Stepan, 1. Why exists second branches with all documentation? I mean they looks good together, why need to separate? Because finally the docs should not be in the repo (unfortunately) but on readme.io. There is a task for that: https://issues.apache.org/jira/browse/IGNITE-9523 Also, one

Re: PHP thin client

2018-09-18 Thread Stepan Pilshchikov
Sorry for interruption but im also review this feature and have couple questions about documentation 1. Why exists second branches with all documentation? I mean they looks good together, why need to separate? Also, one place when i found this branch it is this thread, not in jira, not in a github

Re: PHP thin client

2018-09-13 Thread Igor Sapego
Good. 5) I've filed a separate ticket, so it can be taken by a someone, who is familiar with our build system: [1] [1] - https://issues.apache.org/jira/browse/IGNITE-9465 Best Regards, Igor On Thu, Sep 13, 2018 at 5:07 PM Alexey Kosenchuk < alexey.kosenc...@nobitlost.com> wrote: > 11.09.2

Re: PHP thin client

2018-09-13 Thread Alexey Kosenchuk
11.09.2018 14:46, Igor Sapego пишет: 1) I meant auto-generated doc, this page: [1]. By the way, many methods do not have any description as well. Updated - introduction sentences placed on the main page of the autogenerated API spec. All public methods have description, except setters for

Re: PHP thin client

2018-09-11 Thread Igor Sapego
1) I meant auto-generated doc, this page: [1]. By the way, many methods do not have any description as well. 2) You can, for example, print object as you generate and then get them from cache. 3) Yes, 10800 should be the default port. 4) You are right, I've just used server with SSL enabled

Re: PHP thin client

2018-09-10 Thread Alexey Kosenchuk
Hi Igor, thanks for the review. Pls see below... >> 1. Main page for documentation is empty. What is the main page for documentation? As wrote, the auto-generated API spec is here: https://rawgit.com/nobitlost/ignite/ignite-7783-docs/modules/platforms/php/api_docs/html/index.html All other d

Re: PHP thin client

2018-09-10 Thread Igor Sapego
By the way, I used Ubuntu 18.04, PHP 7.2.7 and what seems to be PhpUnit 7.3 (not sure here). Best Regards, Igor On Mon, Sep 10, 2018 at 3:28 PM Igor Sapego wrote: > Guys, I've reviewed the API (which looks good), run tests and examples and > here are my commments: > > 1. Main page for document

Re: PHP thin client

2018-09-10 Thread Igor Sapego
Guys, I've reviewed the API (which looks good), run tests and examples and here are my commments: 1. Main page for documentation is empty. 2. More output for Auth example is needed. This is not a test, after all, but example. 3. If I try run test with APACHE_IGNITE_CLIENT_ENDPOINTS=127.0.0.1, th

Re: PHP thin client

2018-09-04 Thread Igor Sapego
Great, I'll take a look Best Regards, Igor On Wed, Aug 29, 2018 at 10:37 PM Alexey Kosenchuk < alexey.kosenc...@nobitlost.com> wrote: > Hi folks, > > PHP thin client is ready for review. > > Jira with the scope of work - [1]. > > Implementation, examples, tests: >PR - [2], >repository