Re: TX code cleanup (MVCC removal)

2023-08-25 Thread Вячеслав Коптилин
Hi, all tickets are closed. Thanks, S. ср, 23 авг. 2023 г. в 19:05, Anton Vinogradov : > MVCC test/suites removal PR was merged. > > Slava, > > I think it would be nice to close (with "will not fix" status) all open > > tickets related to MVCC > > Great idea. > Could I ask you to do this? > >

Re: TX code cleanup (MVCC removal)

2023-08-25 Thread Anton Vinogradov
Folks, I'm on vacation in the next few weeks, will continue in September. On Thu, Aug 24, 2023 at 10:41 PM Вячеслав Коптилин wrote: > Hello Anton, > > Hmm, I am a bit confused, to be honest. > IMHO, this simple JIRA cleanup could be done under >

Re: TX code cleanup (MVCC removal)

2023-08-24 Thread Вячеслав Коптилин
Hello Anton, Hmm, I am a bit confused, to be honest. IMHO, this simple JIRA cleanup could be done under https://issues.apache.org/jira/browse/IGNITE-13871 which is assigned to you. Is it required to delegate? Best regards, S. ср, 23 авг. 2023 г. в 19:05, Anton Vinogradov : > MVCC test/suites

Re: TX code cleanup (MVCC removal)

2023-08-23 Thread Anton Vinogradov
MVCC test/suites removal PR was merged. Slava, > I think it would be nice to close (with "will not fix" status) all open > tickets related to MVCC Great idea. Could I ask you to do this? On Wed, Aug 23, 2023 at 6:16 PM Вячеслав Коптилин wrote: > Hi Anton, > > +1 for removal MVCC > > I think

Re: TX code cleanup (MVCC removal)

2023-08-23 Thread Вячеслав Коптилин
Hi Anton, +1 for removal MVCC I think it would be nice to close (with "will not fix" status) all open tickets related to MVCC:

Re: TX code cleanup (MVCC removal)

2023-08-22 Thread Anton Vinogradov
Going to merge on green visa obtaining if there are no objections. On Tue, Aug 22, 2023 at 6:47 PM Anton Vinogradov wrote: > MVCC test/suites removal PR [1] is almost ready, fixing final failures. > > Does anybody ready to review the PR? > > I've rechecked each modified line before pushing the

Re: TX code cleanup (MVCC removal)

2023-08-22 Thread Anton Vinogradov
MVCC test/suites removal PR [1] is almost ready, fixing final failures. Does anybody ready to review the PR? I've rechecked each modified line before pushing the commit button, is this enough? [1] https://github.com/apache/ignite/pull/10900 On Thu, Aug 17, 2023 at 1:18 PM Anton Vinogradov

Re: TX code cleanup (MVCC removal)

2023-08-17 Thread Anton Vinogradov
Great, starting the removal. On Wed, Aug 16, 2023 at 5:35 PM Ivan Daschinsky wrote: > The plan looks good to me. Some of the tests are in the ODBC test suite, so > i can help if needed. > > ср, 16 авг. 2023 г. в 16:32, Anton Vinogradov : > > > Igniters, > > > > I started the TX code cleanup [1]

Re: TX code cleanup (MVCC removal)

2023-08-16 Thread Ivan Daschinsky
The plan looks good to me. Some of the tests are in the ODBC test suite, so i can help if needed. ср, 16 авг. 2023 г. в 16:32, Anton Vinogradov : > Igniters, > > I started the TX code cleanup [1] last month and almost finished with the > obvious garbage. > Now, started the code deduplication, I

TX code cleanup (MVCC removal)

2023-08-16 Thread Anton Vinogradov
Igniters, I started the TX code cleanup [1] last month and almost finished with the obvious garbage. Now, started the code deduplication, I was faced with code overcomplexity because of unfinished MVCC. The community agreed to remove MVCC, but the initial attempt [2] was not successful because