Re: Finished IGNITE-1067

2015-07-17 Thread Artiom Shutak
Anton, What about to add this description to the jira too (as a comment). I think it can be helpful if someone will look at code, which refer to the jira. Thanks, Artem. On Thu, Jul 16, 2015 at 6:13 PM, Anton Vinogradov avinogra...@gridgain.com wrote: Hi, I've finished work on LICENSE file

Release branch ignite-1.3 has been created

2015-07-09 Thread Artiom Shutak
Igniters, Release branch 'ignite-1.3' has been created. Branch created from commit 546d5955a1fdb4a16c186242945d4a27ba13c52c. -- Artem --

I started working on IGNITE-1099 Need to cleanup git

2015-07-07 Thread Artiom Shutak
I started working on IGNITE-1099 Need to cleanup git. https://issues.apache.org/jira/browse/IGNITE-1099 -- Artem --

Re: IGNITE 1055

2015-07-03 Thread Artiom Shutak
:37 PM, Artiom Shutak ashu...@gridgain.com wrote: I think someone from commiters will look at patch (approximately tomorrow) and merge it if it's okey. -- Artem -- On Tue, Jun 30, 2015 at 6:13 PM, Atri Sharma atri.j...@gmail.com wrote: Hi Artem, If the patch is ok, can you

Re: IGNITE-788

2015-07-02 Thread Artiom Shutak
On Jun 30, 2015 8:51 PM, Artiom Shutak ashu...@gridgain.com wrote: Hi Gianfranco, I've done a review of ignite-788. Can you please look on my review (see comment at jira and new attached patch file). Let me know what you think. -- Artem --

Re: IGNITE 1055

2015-06-30 Thread Artiom Shutak
? Thanks and Regards, Atri On Mon, Jun 29, 2015 at 8:40 PM, Artiom Shutak ashu...@gridgain.com wrote: Hi, Atri, I've looked at your patch and I'm ok with it in general. I have a small comment (see jira). -- Artem -- On Mon, Jun 29, 2015 at 12:58 PM, Atri Sharma atri.j...@gmail.com

IGNITE-788

2015-06-30 Thread Artiom Shutak
Hi Gianfranco, I've done a review of ignite-788. Can you please look on my review (see comment at jira and new attached patch file). Let me know what you think. -- Artem --

Re: IGNITE 1055

2015-06-29 Thread Artiom Shutak
Hi, Atri, I've looked at your patch and I'm ok with it in general. I have a small comment (see jira). -- Artem -- On Mon, Jun 29, 2015 at 12:58 PM, Atri Sharma atri.j...@gmail.com wrote: Folks, Any chance we can get this in sprint 7 please? On 26 Jun 2015 21:19, Atri Sharma

IgniteConfiguration#isClientMode returns big Boolean.

2015-06-29 Thread Artiom Shutak
Igniters, I've found that IgniteConfiguration#isClientMode returns big Boolean. Was it done knowingly or is it a bug? It's look like a bug for me. Should I file a ticket on it? -- Artem --

Re: IGNITE 1006

2015-06-26 Thread Artiom Shutak
looking in right place please? On Fri, Jun 26, 2015 at 12:47 AM, Artiom Shutak ashu...@gridgain.com wrote: Hi Atri, Sorry, I've fogotten to answer you. I'm okey with your patch in general. So I've created ignite-1006 branch. I will do a little review changes and merge it in sprint-7

Re: Patch not triggering build

2015-06-26 Thread Artiom Shutak
Yes, you are right, automatic triggering are broken (there is an issue with remote machine). I'm working on it. -- Artem -- On Fri, Jun 26, 2015 at 10:57 AM, Atri Sharma atri.j...@gmail.com wrote: Folks, I just uploaded a new patch for IGNITE 1017 and it did not trigger test run. Is there

Re: IGNITE 1006

2015-06-26 Thread Artiom Shutak
you! On Fri, Jun 26, 2015 at 2:01 PM, Artiom Shutak ashu...@gridgain.com wrote: Can you recheck please now (do not forget about 'git fetch') ? -- Artem -- On Fri, Jun 26, 2015 at 10:14 AM, Atri Sharma atri.j...@gmail.com wrote: Hi Artem, Sorry about bothering but out

Re: IGNITE 1017

2015-06-26 Thread Artiom Shutak
specific datatype so it should be simple matter of changing current function's datatype to Object but thought not to disturb the existing function. On Thu, Jun 25, 2015 at 11:04 PM, Artiom Shutak ashu...@gridgain.com wrote: Igniters, I've looked at patch. It is consistent

Re: IGNITE 917

2015-06-25 Thread Artiom Shutak
Hi, Atri, Ignite-917 was pushed at ignite-sprint-7. Thanks for your contribution! -- Artem -- On Fri, Jun 19, 2015 at 9:09 PM, Artiom Shutak ashu...@gridgain.com wrote: Yes, I've completed changes that I wanted to do. Someone from commiters will review all changes and it will be merged

Re: IGNITE 1017

2015-06-25 Thread Artiom Shutak
at 6:16 PM, Artiom Shutak ashu...@gridgain.com wrote: Atri, I will look at your patch at a couple of days. -- Artem -- On Tue, Jun 23, 2015 at 4:35 PM, Atri Sharma atri.j...@gmail.com wrote: Patch is available. Please seen and let me know your comments. On Fri, Jun 19, 2015

Re: IGNITE 1006

2015-06-25 Thread Artiom Shutak
. Please see and let me know your comments and feedback. Regards, Atri On Wed, Jun 24, 2015 at 5:48 PM, Atri Sharma atri.j...@gmail.com wrote: Thanks. Let me work and revert. On Wed, Jun 24, 2015 at 5:44 PM, Artiom Shutak ashu...@gridgain.com wrote: Hi Atri, see my

Re: IGNITE 1017

2015-06-24 Thread Artiom Shutak
Atri, I will look at your patch at a couple of days. -- Artem -- On Tue, Jun 23, 2015 at 4:35 PM, Atri Sharma atri.j...@gmail.com wrote: Patch is available. Please seen and let me know your comments. On Fri, Jun 19, 2015 at 12:33 AM, Atri Sharma atri.j...@gmail.com wrote: Thanks,

Re: IGNITE 1006

2015-06-23 Thread Artiom Shutak
at 4:09 PM, Artiom Shutak ashu...@gridgain.com wrote: Hi, see my comments at jira. -- Artem -- On Fri, Jun 19, 2015 at 6:43 PM, Atri Sharma atri.j...@gmail.com wrote: Folks, I request to please have a look AT IGNITE 1006. It has been ready for a while. Please let me

Re: IGNITE 1006

2015-06-22 Thread Artiom Shutak
Hi, see my comments at jira. -- Artem -- On Fri, Jun 19, 2015 at 6:43 PM, Atri Sharma atri.j...@gmail.com wrote: Folks, I request to please have a look AT IGNITE 1006. It has been ready for a while. Please let me know if anything is needed.

Re: javadoc for IgniteReflectionFactory

2015-06-19 Thread Artiom Shutak
Dmitriy, I will do it. -- Artem -- On Thu, Jun 18, 2015 at 11:33 AM, Dmitriy Setrakyan dsetrak...@apache.org wrote: Igniters, I noticed that we have added IgniteReflectionFactory in the latest release. I believe this class is extremely useful for the configuration, however, when I look at

Re: IGNITE 917

2015-06-19 Thread Artiom Shutak
? On 11 Jun 2015 15:14, Atri Sharma atri.j...@gmail.com wrote: That makes sense, thanks! Thanks for your review! On Thu, Jun 11, 2015 at 3:13 PM, Artiom Shutak ashu...@gridgain.com wrote: The main part of needed fixes is about the test for new functionality. It will have some

Broken tests, TODOs, commented out code.

2015-06-15 Thread Artiom Shutak
Igniters, I've updated Ignite Coding Guidelines https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines. See 'TODOs', 'Commented out code' and 'Appendices\Broken tests' sections. The main goal is to say about current approach to broken tests: instead of commenting out of broken

Re: IGNITE 917

2015-06-11 Thread Artiom Shutak
: Please let me know your comments and feedback. On 9 Jun 2015 23:38, Artiom Shutak ashu...@gridgain.com wrote: Atri, see my comments at jira. I think someone from commiters should do review. -- Artem -- On Tue, Jun 9, 2015 at 7:56 PM, Atri Sharma atri.j...@gmail.com wrote

Re: Ignite code styles for Idea

2015-06-11 Thread Artiom Shutak
Andrey, thanks! It's really useful thing. I think it would be great to have info about it on the top of https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines (like info box). Can you add it, please. Or should I do it? -- Artem -- On Thu, Jun 11, 2015 at 1:29 PM, Andrey Gura

Re: IGNITE 917

2015-06-08 Thread Artiom Shutak
8, 2015 at 10:07 PM, Artiom Shutak ashu...@gridgain.com wrote: Atri, As usual, then you are using Apache Maven then BUILD SUCCESS means all are OK, and BUILD FAILURE means that something went wrong. -- Artem -- On Mon, Jun 8, 2015 at 7:20 PM, Atri Sharma atri.j...@gmail.com

Re: IGNITE 917

2015-06-08 Thread Artiom Shutak
. On Fri, Jun 5, 2015 at 4:44 PM, Artiom Shutak ashu...@gridgain.com wrote: Hi Atri, See my new review in jira. -- Artem -- On Fri, Jun 5, 2015 at 11:20 AM, Atri Sharma atri.j...@gmail.com wrote: Artem, Thanks for your comments. I incorporated your comments

Re: IGNITE 917

2015-06-08 Thread Artiom Shutak
please? I have no idea of debugging the plethora of tests but I suspect that the same fault in the patch is causing them to fail... On Mon, Jun 8, 2015 at 7:18 PM, Artiom Shutak ashu...@gridgain.com wrote: Atri, see my comments at Jira. I want to ask you to be more careful with all review

Re: IGNITE 917

2015-06-08 Thread Artiom Shutak
at 9:17 PM, Artiom Shutak ashu...@gridgain.com wrote: To run tests locally use: mvn clean test -U -Plgpl,examples,-clean-libs,-release -Dmaven.test.failure.ignore=true -DfailIfNoTests=false -Dtest=%TEST_PATTERN% For example, %TEST_PATTERN% can

Re: IGNITE 917

2015-06-08 Thread Artiom Shutak
have written Java in my life). So I am sure that this patch has allowed me to learn the ways to be used in further patches that I write and review. On Mon, Jun 8, 2015 at 9:34 PM, Artiom Shutak ashu...@gridgain.com wrote: As I can see by history for new failed tests they are not stable

Re: IGNITE 917

2015-06-05 Thread Artiom Shutak
Hi Atri, See my new review in jira. -- Artem -- On Fri, Jun 5, 2015 at 11:20 AM, Atri Sharma atri.j...@gmail.com wrote: Artem, Thanks for your comments. I incorporated your comments and sent new patch. Please see and comment. Regards, Atri On Fri, Jun 5, 2015 at 3:22 AM, Artiom

Re: IGNITE 917

2015-06-04 Thread Artiom Shutak
Atri, please, see my comments at the Jira ticket. -- Artem -- On Thu, Jun 4, 2015 at 7:44 PM, Atri Sharma atri.j...@gmail.com wrote: Thanks. Sorry for the noise on this one. I am off next week so it's helpful if we can close this by this week if possible. I am willing to work in my

Re: Acceptable Patch Format

2015-06-03 Thread Artiom Shutak
a file patch scripts/git-format-patch.sh Thank you, Regards, Gianfranco 2015-06-02 17:44 GMT+02:00 Artiom Shutak ashu...@gridgain.com: Hi Atri, Now, we have useful information about patching here: https://cwiki.apache.org/confluence/display/IGNITE/Sprint+Process. But I agree with Cos

Re: Acceptable Patch Format

2015-06-03 Thread Artiom Shutak
Actually, we do not have any requirements about development process for non-committers (branches and etc.). There is only one requirement: a patch file has to be applicable to the HEAD of current ignite-sprint-xxx branch by git am patch-file (TC actually do it) and has to have all changes in one

Git branches and development process.

2015-06-03 Thread Artiom Shutak
Igniters, As I remember, the question about hard understandable Ignite branches system was discussed many times. But I don't remember the end of it story. I suggest to have next branches system (nothing new). - *development* branch. The branch has the last development state with all new

Re: Acceptable Patch Format

2015-06-03 Thread Artiom Shutak
I've init How to Contribute https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute page. Please, take a look. -- Artem -- On Wed, Jun 3, 2015 at 1:35 PM, Artiom Shutak ashu...@gridgain.com wrote: Actually, we do not have any requirements about development process for non

Re: Acceptable Patch Format

2015-06-02 Thread Artiom Shutak
Hi Atri, Now, we have useful information about patching here: https://cwiki.apache.org/confluence/display/IGNITE/Sprint+Process. But I agree with Cos, we need to have a page like How to contribute. I will do it. Atri, thanks, for your feed back. You should be on branch with your changes. I will

Re: Log4j2 module implementations

2015-06-01 Thread Artiom Shutak
Gianfranco, regular patch file in terms of git. It's like diff between your branch and ignite-sprint-5. Just checkout your branch with your changes and run git-format-patch.sh to create patch file. -- Artem -- On Mon, Jun 1, 2015 at 12:52 PM, Gianfranco Murador murador.gianfra...@gmail.com

Re: Rights to Ignite wiki.

2015-06-01 Thread Artiom Shutak
ashutak -- Artem -- On Mon, Jun 1, 2015 at 8:34 PM, Dmitriy Setrakyan dsetrak...@apache.org wrote: What is your Jira login name? On Mon, Jun 1, 2015 at 10:14 AM, Artiom Shutak ashu...@gridgain.com wrote: Igniters, Can someone give me rights to edit pages on Ignite wiki ( https

Rights to Ignite wiki.

2015-06-01 Thread Artiom Shutak
Igniters, Can someone give me rights to edit pages on Ignite wiki ( https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Home)? I would like to add information about patch creation and patch validation mechanisms, which we have. -- Artem --

Re: IgniteLogger.isQuiet() inconsistency

2015-05-26 Thread Artiom Shutak
, ignite.cluster().localNode().id()); Let me know any suggestions. Thank you, Gianfranco 2015-05-20 14:18 GMT+02:00 Artiom Shutak ashu...@gridgain.com: Hi, Igniters, In process of investigation of a user request Disable ignite console logs ( http://apache-ignite-users.70518.x6

Re: Insert support for log4j2 [IGNITE-788]

2015-05-25 Thread Artiom Shutak
, for the first commit branch I've need the right permissions to git hub repository of apache ignite. Thanks, Greetings, Gianfranco 2015-05-12 19:27 GMT+02:00 Artiom Shutak ashu...@gridgain.com: Hi Glanfranco, I saw your message, but I've already created new branch ignite-788 (based on ignite

Re: Cannot get access to public TC agents

2015-05-22 Thread Artiom Shutak
[Solved] gg user can be used instead of gridgain. -- Artem -- On Fri, May 22, 2015 at 11:46 AM, Artiom Shutak ashu...@gridgain.com wrote: Igniters (especially Sergey), I cannot get access to any public TC agent. Actually, I cannot get access to docker instances (204.14.53.152

Re: Fwd: automatic patch validation on TC

2015-05-21 Thread Artiom Shutak
a while ago, but it isn't mandatory to use it of course ;) On Thu, May 21, 2015 at 12:23AM, Artiom Shutak wrote: I've created new Jira user without granting him some additional privileges. The user cannot move jira status, but he can add any attachment under this user. I see

Re: Fwd: automatic patch validation on TC

2015-05-21 Thread Artiom Shutak
I think I found good way to resolve any security issues here. We will use attachments only from approved users list (contributors). Objections? -- Artem -- On Thu, May 21, 2015 at 1:13 PM, Branko Čibej br...@apache.org wrote: On 21.05.2015 12:00, Dmitriy Setrakyan wrote: On Thu, May 21,

Jira usernames

2015-05-21 Thread Artiom Shutak
Hi, Igniters, Respond to this email with your jira username. I will add your username to approved patchers list and it will enable auto patch validation mechanism for you. -- Artem --

Re: Fwd: automatic patch validation on TC

2015-05-20 Thread Artiom Shutak
Ok, I've reopened the root issue https://issues.apache.org/jira/browse/IGNITE-456 and will continue progress. If there is any objections, let me know. -- Artem -- On Tue, May 19, 2015 at 8:53 PM, Konstantin Boudnik c...@apache.org wrote: Here's two reasons why current approach is secure

IgniteLogger.isQuiet() inconsistency

2015-05-20 Thread Artiom Shutak
Hi, Igniters, In process of investigation of a user request Disable ignite console logs ( http://apache-ignite-users.70518.x6.nabble.com/Disable-ignite-console-logs-td310.html#a330), I've found inconsistency at implementations of IgniteLogger.isQuiet(): - Javadoc of the method says: /**

Re: Insert support for log4j2 [IGNITE-788]

2015-05-12 Thread Artiom Shutak
Hi Glanfranco, I saw your message, but I've already created new branch ignite-788 (based on ignite-sprint-5 - current development branch) and initiate log4j2 module for you. I think it is a good idea to use this branch for your development. -- Artem -- On Tue, May 12, 2015 at 2:38 PM,

[Public TC] bash: which: command not found

2015-05-05 Thread Artiom Shutak
Hi, Sergey, I've found 'which' command cannot be found on public TC agents: http://204.14.53.152/repository/download/Ignite_IgniteStartNodes/47865:id/ignite-startNodes.zip%21/05-05-2015--08-03-11-237aeb53.log . What linux installed on agents? Can we just install which on them? -- Artem --

Apache license header format.

2015-05-05 Thread Artiom Shutak
Cos, I've found that you added some files with not-well formatted AL2 header (it cause failing TC builds). We use FullTextMatchingLicense to exact matching of all symbols of header instead of default SimplePatternBasedLicense (which check only link and starting words of header). If you do not

Re: test

2015-04-29 Thread Artiom Shutak
I've got this one. -- Artem -- On Wed, Apr 29, 2015 at 12:53 PM, Dmitriy Setrakyan dsetrak...@apache.org wrote: Anyone getting dev list emails? D.

Ignite Plugin public API

2015-04-03 Thread Artiom Shutak
Hi, I hope it's not too late to change public API of the Ignite Plugin feature. I have next suggestions: 1. PluginConfiguration interface have only one method Class? extends PluginProvider providerClass(); and we have processing code, which try to instantiate PliginProvider with 3 types of

Unused GridCacheProcessor # checkStoreConsistency

2015-03-31 Thread Artiom Shutak
Hi, I found unused private method GridCacheProcessor # checkStoreConsistency. Maybe somebody knows, is it a bug or method can be safely removed? -- Artem --

Re: [VOTE] Apache Ignite 1.0.0 Release

2015-02-26 Thread Artiom Shutak
Hi all, In bounds IGNITE-325, I added RAT tool to Ignite project, configured him and fixed founded issues. Now, RAT tool cannot find violations. In process of configuration of RAT I used exclude list for files, which should no be checked by RAT. I'm not so good at licenses and it would be better

IgniteIllegalStateException

2015-02-19 Thread Artiom Shutak
Hi, I found IgniteIllegalStateException class, which just extends IllegalStateException, have 2 additional unused methods and reset serialVersionUID to 0L. I propose to remove it and use IllegalStateException instead. Thoughts? Artem.

Re: New home for Ignite documentation

2015-02-09 Thread Artiom Shutak
Hi Dmitriy, Is it okey, that I don't see ignite-geospatial module under The following modules are available: on Maven Setup tab? Artem Shutak GridGain Systems www.gridgain.com On Mon, Feb 9, 2015 at 9:25 AM, Dmitriy Setrakyan dsetrak...@apache.org wrote: Hello Igniters, I think I have found

Re: Git problems

2015-01-30 Thread Artiom Shutak
It's strange, but I'm able to do 'push' now. -- Artem -- On Fri, Jan 30, 2015 at 6:46 PM, Branko Čibej br...@apache.org wrote: On 30.01.2015 16:19, Yakov Zhdanov wrote: Guys, Team was complaining about apache git fails to push changes to. However, updates worked fine. Can anyone