[Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log

2016-04-25 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/10/tests/query_test/test_errorlog.py File test

[Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log

2016-04-25 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/8/be/src/util/error-util.cc File be/src/util/er

[Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log

2016-04-25 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#10). Change subject: IMPALA-3385: Fix crashes on accessing error_log .. IMPALA-3385: Fix crashes on accessing error_log We used to check error_log empty with error_log.empty(), but this m

[Impala-CR](cdh5-trunk) Preview: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY

2016-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/2865/1/fe/src/main/cup/sql-pa

[Impala-CR](cdh5-trunk) IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4

2016-04-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4 .. IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4 This will bring in two patches:

Re: Issues with generating testdata for Impala

2016-04-25 Thread Valencia Serrao
Kindly include me in the reply.

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable(

Re: Issues with generating testdata for Impala

2016-04-25 Thread Alex Behm
Hi Valencia, hard to say what's going on without access to the cluster logs, but it's quite likely some of your services did not come up. One thing I'd strongly recommend is to use consistent versions of the Hadoop components, especially HDFS, Hive and HBase. In your setup you seem to have HBase

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2860/1/source/llvm/build.sh File source/llvm/build.sh: Line 46

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2860/1/source/llvm/build.sh File source/llvm/build.sh: Lin

[Impala-CR](cdh5-trunk) IMPALA-2660: Respect auth_to_local configs from hdfs configs

2016-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs .. Patch Set 4: >Isn't that an expectation for the behaviour of auth_to_local - that it will

Re: Issues with generating testdata for Impala

2016-04-25 Thread Valencia Serrao
Additional Info: I'm using a RHELppc64le machine.

[Impala-CR](cdh5-trunk) IMPALA-3378/IMPALA-3379: fix various JNI issues

2016-04-25 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues .. IMPALA-3378/IMPALA-3379: fix various JNI issues This patch: 1) Removes JniUtil::Cleanup() and Jni

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/common/init.cc Fi

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/2860/1/source/llvm/build.sh File source/llvm/build.sh: Line 46

Re: [Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Matthew Jacobs
Yeah I agree I think it'd be useful. How about weekly then? On Mon, Apr 25, 2016 at 8:25 PM Tim Armstrong wrote: > Sounds like useful coverage, although nightly might even be overkill. > > On Mon, Apr 25, 2016 at 8:22 PM, Casey Ching (Code Review) < > ger...@cloudera.org> wrote: > >> Casey Ching

Re: [Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Tim Armstrong
Sounds like useful coverage, although nightly might even be overkill. On Mon, Apr 25, 2016 at 8:22 PM, Casey Ching (Code Review) < ger...@cloudera.org> wrote: > Casey Ching has posted comments on this change. > > Change subject: Kudu: Exclude non-Kudu symbols during stub client > generation > ...

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: > didn't he say it occurred while executing some BE tests. He may > have had somethin

[Impala-CR](cdh5-trunk) Simplify creating external Kudu tables and add DROP DATABASE CASCADE

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE .. Patch Set 7: (27 comments) http://gerrit.cloudera.org:8080/#/c/2617/7/fe/src/main/java/co

[Impala-CR](cdh5-trunk) Add Kudu test helpers

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new patch set (#3). Change subject: Add Kudu test helpers .. Add Kudu test helpers Changes: 1) Add the python Kudu module to the virtualenv. Building the virtualenv is much slower now because Cython a

[Impala-CR](cdh5-trunk) Simplify creating external Kudu tables and add DROP DATABASE CASCADE

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new patch set (#9). Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE .. Simplify creating external Kudu tables and add DROP DATABASE CASCADE Creating an external Ku

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: Unfortunately this hit a flaky test during the merge that was one of the ones we ho

[Impala-CR](cdh5-trunk) IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0 .. Patch Set 1: Carry +2 from previous version of patch. -- To view, visit http://gerrit.cloudera.org:8080/2866 T

[Impala-CR](cdh5-trunk) IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2866 To unsubscribe, visit http://

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: didn't he say it occurred while executing some BE tests. He may have had something

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems .. Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/2574/18/fe/src/test/ja

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-25 Thread Sailesh Mukil (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2574 to look at the new patch set (#18). Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems ..

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/common/init.c

[Impala-CR](cdh5-trunk) IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4

2016-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2863 To unsubscribe, visit

[Impala-CR](cdh5-trunk) IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2863 To unsubscr

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/common/init

[Impala-CR](cdh5-trunk) IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4

2016-04-25 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/2863 Change subject: IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4 .. IMPALA-3420: Set IMPALA_THRIFT_VERSION patch level to +4 Th

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/21

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems .. Patch Set 17: Added backend tests "hdfs-util-test" to test FilesystemsMatch() -- To

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-25 Thread Sailesh Mukil (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2574 to look at the new patch set (#17). Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems ..

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: > But yeah, we probably want some kind of automated test for the > stubbed kudu confi

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: But yeah, we probably want some kind of automated test for the stubbed kudu configu

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: It might be possible if you set KUDU_IS_SUPPORTED=false and re-bootstrap the toolch

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: > What testing did you do? I only checked the file size of the .so to see that the si

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Hello Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2113 to look at the new patch set (#8). Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() ..

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/2113/6/be/src

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: It would be good to manually confirm that this works with and without kudu enabled.

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: What testing did you do? -- To view, visit http://gerrit.cloudera.org:8080/2864 To

[Impala-CR](cdh5-trunk) Add Kudu test helpers

2016-04-25 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add Kudu test helpers .. Patch Set 1: (13 comments) http://gerrit.cloudera.org:8080/#/c/2855/1/bin/impala-ipython File bin/impala-ipython: Line 6: It would be

[Impala-CR](cdh5-trunk) IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1

2016-04-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1 .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/2721/3/fe/src/main/j

[Impala-CR](cdh5-trunk) IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1

2016-04-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1 .. Patch Set 4: Code-Review+2 Rebase, carry forward +2 -- To view, visit http://ger

[Impala-CR](cdh5-trunk) IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1

2016-04-25 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2721 to look at the new patch set (#4). Change subject: IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1 ...

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/2113/6/be/src/exec/p

[Impala-CR](cdh5-trunk) IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/2866 Change subject: IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0 .. IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0 This is the same as the p

[Impala-CR](cdh5-trunk) IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-775,IMPALA-3374: Upgrade LLVM to 3.8.0 .. Patch Set 1: This is the same as http://gerrit.cloudera.org/#/c/2486/ except without the dependency on libtinfo

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/2860 To unsubscribe, visit http://gerrit.cloud

[Impala-CR](cdh5-trunk) IMPALA-3378/IMPALA-3379: fix various JNI issues

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Hello Michael Ho, Internal Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2820 to look at the new patch set (#7). Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues ..

[Impala-CR](cdh5-trunk) IMPALA-3378/IMPALA-3379: fix various JNI issues

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-3378/IMPALA-3379: fix various JNI issues .. Patch Set 7: Code-Review+2 Fixed stupid test mistake, rebase. Carrying +2 -- To view, visit http://ge

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Disable terminfo dependency for LLVM .. Disable terminfo dependency for LLVM LLVM uses libtinfo/libncurses to detect whether a terminal supports colors.

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: http://unittest.jenkins.cloudera.com/job/verify-impala-toolchain-package-build/181/ succeeded -- To view,

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Hello Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2113 to look at the new patch set (#7). Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() ..

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/2113/6/be/src

[Impala-CR](cdh5-trunk) Simplify creating external Kudu tables and add DROP DATABASE CASCADE

2016-04-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2617/7/tests/query_test/

[Impala-CR](cdh5-trunk) IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node

2016-04-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/1901/10/be/src/exec/top

[Impala-CR](cdh5-trunk) Simplify creating external Kudu tables and add DROP DATABASE CASCADE

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE .. Patch Set 8: > Uploaded patch set 8: Patch Set 7 was rebased. I didn't address any of you

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/2113/6/be/src/exe

[Impala-CR](cdh5-trunk) Preview: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2865 Change subject: Preview: Refactor CREATE TABLE grammar rules in prep for PRIMARY KEY .. Preview: Refactor CREATE TABLE grammar rules in pr

[Impala-CR](cdh5-trunk) Add Kudu test helpers

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new patch set (#2). Change subject: Add Kudu test helpers .. Add Kudu test helpers Changes: 1) Add the python Kudu module to the virtualenv. Building the virtualenv is much slower now because Cython a

[Impala-CR](cdh5-trunk) Simplify creating external Kudu tables and add DROP DATABASE CASCADE

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new patch set (#8). Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE .. Simplify creating external Kudu tables and add DROP DATABASE CASCADE Creating an external Ku

[Impala-CR](cdh5-trunk) IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/1901/10/be/src/exec

[Impala-CR](cdh5-trunk) IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node

2016-04-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/1901/10/be/src/exec/top

[Impala-CR](cdh5-trunk) IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1

2016-04-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3245 / IMPALA-3305: Fix crash with global filters when NUM_NODES=1 .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/2721

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Patch Set 1: Code-Review+1 Cool. Makes sense, though I'm not familiar with c++filt so hopefully

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/2113/5/be/src

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Hello Jim Apple, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2113 to look at the new patch set (#6). Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() ..

[Impala-CR](cdh5-trunk) Simplify creating external Kudu tables and add DROP DATABASE CASCADE

2016-04-25 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Simplify creating external Kudu tables and add DROP DATABASE CASCADE .. Patch Set 7: (25 comments) http://gerrit.cloudera.org:8080/#/c/2617/7/fe/src/main/java

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/common/init.

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Sailesh Mukil (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2850 to look at the new patch set (#4). Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations ..

[Impala-CR](cdh5-trunk) IMPALA-3418: The Impala FE project relies on Z-tools snapshot builds

2016-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3418: The Impala FE project relies on Z-tools snapshot builds .. Patch Set 1: Tried this patch and got this: [ERROR] Plugin net.sourceforge.czt.dev:cup-mave

[Impala-CR](cdh5-trunk) IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2548: Codegen Tuple::MaterializeExprs() and use in TopN node .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/1901/10/be/src/exec

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-25 Thread Sailesh Mukil (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2574 to look at the new patch set (#16). Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems ..

[Impala-CR](cdh5-trunk) Kudu: Exclude non-Kudu symbols during stub client generation

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has uploaded a new change for review. http://gerrit.cloudera.org:8080/2864 Change subject: Kudu: Exclude non-Kudu symbols during stub client generation .. Kudu: Exclude non-Kudu symbols during stub client generatio

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-25 Thread Sailesh Mukil (Code Review)
Hello Taras Bobrovytsky, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2574 to look at the new patch set (#15). Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems ..

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/2850/3/be/src/common/init.cc F

[Impala-CR](cdh5-trunk) IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems

2016-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-1878: Support INSERT and LOAD DATA on S3 and between filesystems .. Patch Set 14: (15 comments) http://gerrit.cloudera.org:8080/#/c/2574/14/be/src/util/

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: > It looks like this won't actually disable Clang colour output for > Impala builds. This only disables the a

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: It looks like this won't actually disable Clang colour output for Impala builds. This only disables the aut

[Impala-CR](cdh5-trunk) IMPALA-2660: Respect auth_to_local configs from hdfs configs

2016-04-25 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2660: Respect auth_to_local configs from hdfs configs .. Patch Set 4: > I'm not sure I understand this. The current patch affects only authorization, >

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2862 To unsubscribe, vi

Showcase your project at ApacheCON: consider Podling Shark Tank

2016-04-25 Thread Roman Shaposhnik
Hi! I apologize for the wide distribution, but since my email to general@ didn't seem to have reached all of the podling communities, I took the liberty of direct email. Here's the deal: If you are (or anybody you know who's passionate about your project is) going to travel to Vancouver for Apach

[Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/8/be/src/util/error-util.cc File be/src/util/er

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: Code-Review+1 I agree that it may confuse customers or support team if there are cores

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2113/5/be/src/exec

[Impala-CR](cdh5-trunk) IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable()

2016-04-25 Thread Skye Wanderman-Milne (Code Review)
Skye Wanderman-Milne has posted comments on this change. Change subject: IMPALA-2784: codegen PartitionedHashJoinNode::Partition::BuildHashTable() .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/2113/5/be/src/

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: libncurses should be available pretty much everywhere, but libtinfo takes precedence so it's a bit weird.

[Toolchain-CR] Disable terminfo dependency for LLVM

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: Disable terminfo dependency for LLVM .. Patch Set 1: Code-Review+2 Color output would be nice though. I guess someone could add it later if they really wanted it.

[Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log

2016-04-25 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/2829/8/be/src/util/error-util.cc File be/src/util/er

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: I think the question is probably what makes most sense for production deployments.

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-25 Thread Casey Ching (Code Review)
Casey Ching has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: > First, thanks a lot for fixing this. > > IMHO, this is a test bug not an Impala b

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. Patch Set 1: First, thanks a lot for fixing this. IMHO, this is a test bug not an Impala bug. If th

[Impala-CR](cdh5-trunk) IMPALA-2883,IMPALA-3383: don't dump core when misconfigured.

2016-04-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/2862 Change subject: IMPALA-2883,IMPALA-3383: don't dump core when misconfigured. .. IMPALA-2883,IMPALA-3383: don't dump core when misconfigur

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations .. Patch Set 3: Code-Review+1 Carry +1. -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-CR](cdh5-trunk) IMPALA-3306: Add command-line flags to set S3 access configurations

2016-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3306: Add command-line flags to set S3 access configurations .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/2850/2/be/src/runtime/hdfs

[Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log .. Patch Set 9: > (1 comment) Right, that's what I put for case #2 here: https://issues.cloudera.org/browse/IMPALA-3

[Impala-CR](cdh5-trunk) IMPALA-3385: Fix crashes on accessing error_log

2016-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3385: Fix crashes on accessing error_log .. Patch Set 9: Can you please add the end-to-end test that reproduces the crash, make sure the change fixes all cra

  1   2   >