Re: [VOTE] Graduate to a TLP

2017-10-17 Thread Michael Ho
+1 On Tue, Oct 17, 2017 at 7:25 PM, Thomas Tauber-Marshall < tmarsh...@cloudera.com> wrote: > +1 > > On Tue, Oct 17, 2017 at 9:12 PM Bharath Vissapragada < > bhara...@cloudera.com> > wrote: > > > +1 > > > > On Tue, Oct 17, 2017 at 7:10 PM, Mostafa Mokhtar > > wrote: > > > > > +1 > > > > > > Than

Re: jenkins.impala.io maintenance

2017-08-07 Thread Michael Ho
Jenkins plugins have been updated. Aborted GVD jobs were restarted. On Mon, Aug 7, 2017 at 5:25 PM, Michael Ho wrote: > jenkins.impala.io need updates for some plugins to address a new security > advisory. > > It will be put into maintenance mode at 5:35pm PST so no new jobs can be

jenkins.impala.io maintenance

2017-08-07 Thread Michael Ho
jenkins.impala.io need updates for some plugins to address a new security advisory. It will be put into maintenance mode at 5:35pm PST so no new jobs can be submitted. The upgrade will happen after all pending jobs complete. Once the upgrade completes, another email will be sent out. Please speak

Re: incubator-impala github repo is gone ?

2017-04-28 Thread Michael Ho
https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git is still around. On Fri, Apr 28, 2017 at 11:16 AM, Michael Ho wrote: > https://github.com/apache/incubator-impala seems to be empty now. > > Just filed https://issues.apache.org/jira/browse/INFRA-14038 > > -- >

incubator-impala github repo is gone ?

2017-04-28 Thread Michael Ho
https://github.com/apache/incubator-impala seems to be empty now. Just filed https://issues.apache.org/jira/browse/INFRA-14038 -- Thanks, Michael

Re: GVO request

2017-03-13 Thread Michael Ho
Done. On Mon, Mar 13, 2017 at 2:35 PM, Zachary Amsden wrote: > Looking to start a verification run for > https://gerrit.cloudera.org/#/c/6275/ > > Thanks in advance, > > - Zach > -- Thanks, Michael

Re: gerrit email notifications

2017-02-08 Thread Michael Ho
I didn't get email notification for https://gerrit.cloudera.org/#/c/5950/ either. On Wed, Feb 8, 2017 at 10:40 PM, Bharath Vissapragada wrote: > https://gerrit.cloudera.org/#/c/5792/ > > For my last two patch sets, I didn't see an email. > > On Wed, Feb 8, 2017 at 10:38 PM, Alex Behm wrote: > >

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 2: Patch #2 reverts to using the boost library condition variable for now. Given the wide

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. IMPALA-4026: Implement double-buffering for BlockingQueue. With recent changes to improve the parquet

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 1: (3 comments) It appears to me that primitive_conjunct_odering_5 and

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4350/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-1616: Improve the Memory Limit Exceeded error report

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1616: Improve the Memory Limit Exceeded error report .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4335/3/be/src/runtime

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue.

2016-09-09 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4350 Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue. .. IMPALA-4026: Implement double-buffering for BlockingQueue

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-tab

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 3: Code-Review+1 Other the formatting problem which I find quite annoying, the

[Impala-ASF-CR] IMPALA-4008: don't bake in hash table and hash join pointers

2016-09-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-tab

[Impala-ASF-CR] IMPALA-3815: clean up cross-compiled comparator

2016-09-06 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3815: clean up cross-compiled comparator .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4307 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-09-02 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 2: (16 comments) The change looks good. Mostly comments are about clarification in

[Impala-ASF-CR] IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch

2016-08-31 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4051: Avoid unnecessary copy of RowDescriptor into RowBatch .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4181/2/be/src/runtime/row

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/4/be/src/exec/hdfs-scan

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 5: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
errit.cloudera.org:8080/4174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I191988ad18d6b4caf892fc967258823edcf9681f Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hech

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan node. Our current code base allows a

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan node. Our current code base allows a

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per scan node. Our current code base allows a

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4174/1/be/src/exec/hdfs-scan

[Impala-ASF-CR] IMPALA-2831: Bound the number of scanner threads per scan node.

2016-08-30 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4174 Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. .. IMPALA-2831: Bound the number of scanner threads per

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 6: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4078/6/bin/run-all-tests.sh File

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4078/3/bin/impala-config.sh File bin/impala

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4078/1/bin/clean.sh File bin/clean.sh: PS1

[Impala-ASF-CR] IMPALA-4006: dangerous rm -rf statements in scripts

2016-08-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4006: dangerous rm -rf statements in scripts .. Patch Set 3: (5 comments) It appears that you are already fixing some of the places which are considered

[Impala-ASF-CR] IMPALA-1731,IMPALA-3868: Float values are not parsed correctly

2016-08-23 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly .. Patch Set 5: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] CDH-43354: Bump CDH components' versions.

2016-08-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: CDH-43354: Bump CDH components' versions. .. Patch Set 1: A core run passed: http://sandbox.jenkins.cloudera.com/job/impala-private-build-and-test/4002/ -

[Impala-ASF-CR] CDH-43354: Bump CDH components' versions.

2016-08-22 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4084 Change subject: CDH-43354: Bump CDH components' versions. .. CDH-43354: Bump CDH components' versions.

[Impala-ASF-CR] IMPALA-4006 impala-config.sh contains dangerous rm -rf statements

2016-08-22 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4006 impala-config.sh contains dangerous rm -rf statements .. Patch Set 1: (12 comments) Thanks for cleaning things up. Not sure if there is a easier way

[Impala-ASF-CR] IMPALA-3988: Only use first 96 bits of query id

2016-08-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3988: Only use first 96 bits of query id .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4065 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-3988: Only use first 96 bits of query id

2016-08-21 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3988: Only use first 96 bits of query id .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/4065/7/be/src/util/uid-util.h File be/src/util

[Impala-ASF-CR] IMPALA-4004: Don't access nested types in test failpoints.py

2016-08-21 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4074 Change subject: IMPALA-4004: Don't access nested types in test_failpoints.py .. IMPALA-4004: Don't access neste

[Impala-ASF-CR] IMPALA-3988: Only use first 96 bits of query id

2016-08-20 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3988: Only use first 96 bits of query id .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/4065/6/be/src/scheduling/simple-scheduler.cc File

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. Patch Set 3: Code-Review+2 Rebase. Carry +2. -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 5: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/3991

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3991/4/be/src/exec/exec-node.cc File

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-19 Thread Michael Ho (Code Review)
eType: newpatchset Gerrit-Change-Id: If1e27a1517d09ccaabdae1492b7e1fbf661ae3e5 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Alex Behm Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4064/1/be/src/exec

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples buffer in parquet scanner

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-3662: Don't double allocate tuples buffer in parquet scanner .. IMPALA-3662: Don't double allocate tuples buffer in parquet scanner H

[Impala-ASF-CR] IMPALA-3662: Don't double allocate tuples' buffer in parquet scanner

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4064 Change subject: IMPALA-3662: Don't double allocate tuples' buffer in parquet scanner .. IMPALA-3662: Don't double allocate

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. IMPALA-3962: Clean up scratch tuple batch on scan failures The parquet scanner doesn't cle

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/3991/3/be/src/exec/exec-node.cc File

[Impala-ASF-CR] IMPALA-3090: always log memory limit errors

2016-08-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3090: always log memory limit errors .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4049 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3991/1/be/src/exec/hdfs-parquet

[Impala-ASF-CR] IMPALA-3090: always log memory limit errors

2016-08-18 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3090: always log memory limit errors .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4049/1/be/src/runtime/mem-tracker.h File be/src

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 4: (16 comments) Still going through the changes and digesting them. Some comments for now

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-08-17 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3774 To

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. IMPALA-3962: Clean up scratch tuple batch on scan failures The parquet scanner doesn't cle

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-17 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. IMPALA-3962: Clean up scratch tuple batch on scan failures The parquet scanner doesn't cle

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: To answer the question of why the stress test hit this: the query was cancelled (I

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/3991/1/be/src/exec/hdfs-parquet

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: (1 comment) Most likely not MEM_LIMIT_EXCEEDED as we would have returned from

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. Patch Set 1: We probably need to create a malformed table with bad data in some columns. -- To view

[Impala-ASF-CR] IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection. .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3940

[Impala-ASF-CR] IMPALA-3201: buffer pool header only

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 1: Please feel free to address them in the next patch though. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3201: buffer pool header only

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3201: buffer pool header only .. Patch Set 1: Sorry to jump in late at this point but there are also some comments at https://gerrit.cloudera.org/#/c/2569

[Impala-ASF-CR] IMPALA-3962: Clean up scratch tuple batch on scan failures

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/3991 Change subject: IMPALA-3962: Clean up scratch tuple batch on scan failures .. IMPALA-3962: Clean up scratch tuple batch on scan failures

[Impala-ASF-CR] IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.

2016-08-15 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3940/3/be/src/exec

[Impala-ASF-CR] IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

2016-08-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs .. Patch Set 2: Added a new test in free-pool-test.cc -- To view, visit http

[Impala-ASF-CR] IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

2016-08-12 Thread Michael Ho (Code Review)
aster Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Tim Armstrong

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-08-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/3774/7/be/src/exec/hdfs

[Impala-ASF-CR] IMPALA-3829: OpenSession() logs errors on valid configuration keys

2016-08-12 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys .. IMPALA-3829: OpenSession() logs errors on valid configuration keys Refactored

[Impala-ASF-CR] IMPALA-3964: Fix crash when a count(*) is performed on a nested collection.

2016-08-12 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3964: Fix crash when a count(*) is performed on a nested collection. .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3940/3/be/src/exec

[Impala-ASF-CR] IMPALA-3829: OpenSession() logs errors on valid configuration keys

2016-08-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys .. Patch Set 3: Code-Review+2 Carry Henry's +2 forward. Attila cannot yet +2 at this

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

2016-08-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3838/2/be/src/runtime/mem-pool.cc File

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

2016-08-10 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3838/2/be/src/runtime

[Impala-ASF-CR] IMPALA-1112: Remove some unncessary code from cross-compilation

2016-08-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation .. Patch Set 4: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-3946: fix MemPool integrity issues with empty chunks

2016-08-09 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3946: fix MemPool integrity issues with empty chunks .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/3838/1/be/src/runtime/mem-pool

[Impala-ASF-CR] IMPALA-1731,IMPALA-3868: Float values are not parsed correctly

2016-08-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3791/3/be/src/util

[Impala-ASF-CR] IMPALA-3637,IMPALA-3636: refactor codegen constant replacement

2016-08-05 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3637,IMPALA-3636: refactor codegen constant replacement .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/3843/1/be/src/codegen/constant

[Impala-ASF-CR] IMPALA-3829: OpenSession() logs errors on valid configuration keys

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/3808 To

[Impala-ASF-CR] IMPALA-3829: OpenSession() logs errors on valid configuration keys

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3829: OpenSession() logs errors on valid configuration keys .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3808/1/tests/hs2/test_hs2.py

[Impala-ASF-CR] IMPALA-1731,IMPALA-3868: Float values are not parsed correctly

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3791/2/be/src/exprs/expr-test.cc

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3774/3/be/src/exec/hdfs

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3774/3/be/src/exec/hdfs

[Impala-CR](cdh5-trunk) IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/3774/3/be/src/exec/hdfs

[Impala-ASF-CR] IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/3807 Change subject: IMPALA-1619, IMPALA-3018: Address various small memory allocation related bugs .. IMPALA-1619, IMPALA-3018: Address

[Impala-ASF-CR] IMPALA-1731,IMPALA-3868: Float values are not parsed correctly

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3791/2/be/src/exprs/expr-test.cc

[Impala-ASF-CR] IMPALA-1112: Remove some unncessary code from cross-compilation

2016-07-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3793/2//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-1112: Remove some unncessary code from cross-compilation

2016-07-28 Thread Michael Ho (Code Review)
t Gerrit-Change-Id: I543809c69da0b4085a0e299b91cd550b274c46af Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho Gerrit-Reviewer: Tim Armstrong

[Impala-ASF-CR] IMPALA-1112: Remove some unncessary code from cross-compilation

2016-07-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation .. IMPALA-1112: Remove some unncessary code from cross-compilation This change stops including some

[Impala-CR](cdh5-trunk) IMPALA-3906: Materialize implicitly referenced IR functions

2016-07-27 Thread Michael Ho (Code Review)
Michael Ho has abandoned this change. Change subject: IMPALA-3906: Materialize implicitly referenced IR functions .. Abandoned Review is moved over to https://gerrit.cloudera.org/#/c/3792/ -- To view, visit http

[Impala-ASF-CR] IMPALA-1112: Remove some unncessary code from cross-compilation

2016-07-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/3793 Change subject: IMPALA-1112: Remove some unncessary code from cross-compilation .. IMPALA-1112: Remove some unncessary code from cross

[Impala-CR](cdh5-trunk) IMPALA-3906: Materialize implicitly referenced IR functions

2016-07-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3906: Materialize implicitly referenced IR functions .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/3740/4/be/src/codegen/llvm-codegen.h

[Impala-ASF-CR] IMPALA-3906: Materialize implicitly referenced IR functions

2016-07-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3906: Materialize implicitly referenced IR functions .. Patch Set 1: Code-Review+2 Review is at https://gerrit.cloudera.org/#/c/3740/. Carry +2 over

[Impala-ASF-CR] IMPALA-3906: Materialize implicitly referenced IR functions

2016-07-27 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/3792 Change subject: IMPALA-3906: Materialize implicitly referenced IR functions .. IMPALA-3906: Materialize implicitly referenced IR functions

[Impala-CR](cdh5-trunk) IMPALA-3906: Materialize implicitly referenced IR functions

2016-07-26 Thread Michael Ho (Code Review)
set Gerrit-Change-Id: I3653f55a1aa063b21cb3a5040f502b4c0ecf82e8 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho Gerrit-Reviewer: Dan Hecht Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong

[Impala-CR](cdh5-trunk) IMPALA-3906: Materialize implicitly referenced IR functions

2016-07-26 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3906: Materialize implicitly referenced IR functions .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/3740/2/be/src/codegen/llvm-codegen.cc

[Impala-CR](cdh5-trunk) IMPALA-3906: Materialize implicitly referenced IR functions

2016-07-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3906: Materialize implicitly referenced IR functions .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3740/2/be/src/codegen/llvm-codegen.h

  1   2   3   4   5   6   >