Re: [disccuss] Apache IoTDB 0.9.0 incubating RC1 release

2019-11-14 Thread Xiangdong Huang
Hi Justin, > I’m not sure that is the right solution. Was this file developed at the ASF or elsewhere? My understanding is that it come from a 3rd party and thus should not have an ASF header but a 3rd party one. Be sure to mention what license it is under in the LICENSE file as well. (I guess th

Re: [disccuss] Apache IoTDB 0.9.0 incubating RC1 release

2019-11-14 Thread Justin Mclean
Hi, >> - NOTICE is incorrect "Copyright 2019 and onwards” is not valid to say > > I checked [1], it should be " Copyright 2001-2019 The Apache Software > Foundation” Probably you just want "Copyright 2019” I think, as they are the only years that IoTDB have made a release. >> - NOTICE is missi

[disccuss] Apache IoTDB 0.9.0 incubating RC1 release

2019-11-14 Thread Xiangdong Huang
Hi, > - LICENSE need to mention license of Maven Wrapper As Lei Rui and Justin pointed out some issues, I find it is my fault that some changes are not cherry-picked from rel/0.8 to master and rel/0.9. So, we need to scan the commitlogs between release-0.8.0 to release-0.8.1 and cherry-pick nee