Re: [PR] OAK-10825 - Indexing job: log [TASK::FAIL] log message for when an indexing phase fails. [jackrabbit-oak]

2024-05-28 Thread via GitHub
nfsantos merged PR #1481: URL: https://github.com/apache/jackrabbit-oak/pull/1481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-27 Thread via GitHub
rishabhdaim commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1616588157 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -16,14 +16,17 @@ */ package

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-27 Thread via GitHub
rishabhdaim commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1616587671 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -216,7 +264,7 @@ static PropertyState

Re: [PR] OAK-10621: o.a.j.o.namepath.JcrPathParser does not accept indexed expanded names [jackrabbit-oak]

2024-05-27 Thread via GitHub
mbaedke merged PR #1488: URL: https://github.com/apache/jackrabbit-oak/pull/1488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-6773: Convert oak-store-composite to OSGi R7 annotations [jackrabbit-oak]

2024-05-27 Thread via GitHub
mbaedke opened a new pull request, #1489: URL: https://github.com/apache/jackrabbit-oak/pull/1489 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-27 Thread via GitHub
Joscorbe commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1616095200 ## oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyStateTest.java: ## @@ -81,4 +88,83 @@ public void

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-27 Thread via GitHub
Joscorbe commented on PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#issuecomment-2133548457 I'm fine with the tests, but both `stringBelowThresholdSize()` and `stringAboveThresholdSize()` are essentially the same - which is correct from a black box test point of view.

Re: [PR] Issue/oak 10621 [jackrabbit-oak]

2024-05-27 Thread via GitHub
mbaedke closed pull request #1286: Issue/oak 10621 URL: https://github.com/apache/jackrabbit-oak/pull/1286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] OAK-10621: o.a.j.o.namepath.JcrPathParser does not accept indexed expanded names [jackrabbit-oak]

2024-05-27 Thread via GitHub
mbaedke opened a new pull request, #1488: URL: https://github.com/apache/jackrabbit-oak/pull/1488 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10833 - Consistency check reports success for repository with SNF… [jackrabbit-oak]

2024-05-27 Thread via GitHub
dulceanu merged PR #1487: URL: https://github.com/apache/jackrabbit-oak/pull/1487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-27 Thread via GitHub
Joscorbe commented on PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2133112904 I'm fine with squashing too @stefan-egli @rishabhdaim. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] OAK-10833 - Consistency check reports success for repository with SNF… [jackrabbit-oak]

2024-05-24 Thread via GitHub
dulceanu opened a new pull request, #1487: URL: https://github.com/apache/jackrabbit-oak/pull/1487 …E in checkpoints -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Issue/oak 10621 [jackrabbit-oak]

2024-05-24 Thread via GitHub
reschke commented on PR #1286: URL: https://github.com/apache/jackrabbit-oak/pull/1286#issuecomment-2129369108 @mbaedke - could you please rebase the patch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Issues/oak 10781 [jackrabbit-oak]

2024-05-24 Thread via GitHub
rootpea commented on PR #1485: URL: https://github.com/apache/jackrabbit-oak/pull/1485#issuecomment-2129047177 @t-rana the jenkins test failed, could you please re-run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Issue/oak 8848 [jackrabbit-oak]

2024-05-24 Thread via GitHub
reschke commented on code in PR #1474: URL: https://github.com/apache/jackrabbit-oak/pull/1474#discussion_r1613082105 ## oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/MoveVersionableNodeWithMemoryRepositoryTest.java: ## @@ -0,0 +1,26 @@ +package

Re: [PR] OAK-10826 - Misleading warning about missing checkpoint [jackrabbit-oak]

2024-05-24 Thread via GitHub
rishabhdaim merged PR #1479: URL: https://github.com/apache/jackrabbit-oak/pull/1479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10830: Upgrade jackson-databind dependency to 2.17.1 [jackrabbit-oak]

2024-05-24 Thread via GitHub
reschke merged PR #1486: URL: https://github.com/apache/jackrabbit-oak/pull/1486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10830: Upgrade jackson-databind dependency to 2.17.1 [jackrabbit-oak]

2024-05-24 Thread via GitHub
reschke opened a new pull request, #1486: URL: https://github.com/apache/jackrabbit-oak/pull/1486 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10780: add azure access token refresh logic [jackrabbit-oak]

2024-05-24 Thread via GitHub
smiroslav merged PR #1441: URL: https://github.com/apache/jackrabbit-oak/pull/1441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Issues/oak 10781 [jackrabbit-oak]

2024-05-24 Thread via GitHub
t-rana opened a new pull request, #1485: URL: https://github.com/apache/jackrabbit-oak/pull/1485 Azure Access token is valid for 1 hour only. Added code to check for token expiry every 1 minutes, and refresh the token when the same is close to expiry. -- This is an automated message from

Re: [PR] OAK-9781 - Report Unique Terms in LuceneIndexMBean [jackrabbit-oak]

2024-05-23 Thread via GitHub
github-actions[bot] commented on PR #580: URL: https://github.com/apache/jackrabbit-oak/pull/580#issuecomment-2128337244 This PR is stale because it has been open 24 months with no activity. Remove stale label or comment or this will be closed in 30 days. -- This is an automated message

[PR] Implementation of OAK-10831 [jackrabbit-oak]

2024-05-23 Thread via GitHub
somarc opened a new pull request, #1484: URL: https://github.com/apache/jackrabbit-oak/pull/1484 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Implementation of OAK-10831 [jackrabbit-oak]

2024-05-23 Thread via GitHub
somarc closed pull request #1484: Implementation of OAK-10831 URL: https://github.com/apache/jackrabbit-oak/pull/1484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Issue/oak 8848 [jackrabbit-oak]

2024-05-23 Thread via GitHub
shodaaan commented on PR #1474: URL: https://github.com/apache/jackrabbit-oak/pull/1474#issuecomment-2127197933 @stefan-egli: I created another unit test where the 2 nodes have version histories and the code flow is the same and throws ConstraintViolationException. So if the 2 nodes

Re: [PR] OAK-6756: Convert oak-auth-external to OSGi R7 annotations [jackrabbit-oak]

2024-05-23 Thread via GitHub
mbaedke merged PR #1371: URL: https://github.com/apache/jackrabbit-oak/pull/1371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Issue/oak 10624 [jackrabbit-oak]

2024-05-23 Thread via GitHub
mbaedke merged PR #1285: URL: https://github.com/apache/jackrabbit-oak/pull/1285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611700150 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilder.java: ## @@ -26,6 +26,8 @@ import

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
mbaedke commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611669404 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -167,6 +169,8 @@ public class

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
reschke commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611566538 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/rdb/RDBDocumentNodeStoreBuilder.java: ## @@ -26,6 +26,8 @@ import

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611564170 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -167,6 +169,8 @@ public class

Re: [PR] OAK-10739 : added feature toggle for embedded verification [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim merged PR #1482: URL: https://github.com/apache/jackrabbit-oak/pull/1482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
mbaedke commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611419373 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -167,6 +169,8 @@ public class

Re: [PR] Issue/oak 8848 [jackrabbit-oak]

2024-05-23 Thread via GitHub
mbaedke commented on PR #1474: URL: https://github.com/apache/jackrabbit-oak/pull/1474#issuecomment-2126720239 > Would it be possible to try to reproduce a constraint violation exception when replacing a node with another node when both have a version history? (to see if this is can be

Re: [PR] OAK-10829: examples: update build-helper-maven-plugin to 3.6.0 [jackrabbit-oak]

2024-05-23 Thread via GitHub
reschke merged PR #1483: URL: https://github.com/apache/jackrabbit-oak/pull/1483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10829: examples: update build-helper-maven-plugin to 3.6.0 [jackrabbit-oak]

2024-05-23 Thread via GitHub
reschke opened a new pull request, #1483: URL: https://github.com/apache/jackrabbit-oak/pull/1483 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611354102 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -167,6 +169,8 @@ public class

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611352766 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -324,6 +346,11 @@ public T

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611352478 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -225,6 +236,8 @@ static

[PR] OAK-10739 : added feature toggle for embedded verification [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim opened a new pull request, #1482: URL: https://github.com/apache/jackrabbit-oak/pull/1482 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Issues/OAK-10675 [jackrabbit-oak]

2024-05-23 Thread via GitHub
smiroslav merged PR #1385: URL: https://github.com/apache/jackrabbit-oak/pull/1385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-23 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2126559969 @thomasmueller, what wanted to point out is that even if the blame view looks fine, there is much more to it than that. -- This is an automated message from the Apache Git

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-23 Thread via GitHub
thomasmueller commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2126514599 > Maybe it's better to move the discussion to the mailing list Well let's discuss here, and then if we use the mailing list we need a link there. -- This is an

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-23 Thread via GitHub
thomasmueller commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2126512130 > nobody cares about the GitHub blame view I do. I do a lot! That's how I find out why the code is like this. This is called "[Chesterton's

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1611228918 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -225,6 +236,8 @@ static

Re: [PR] Issues/OAK-10675 [jackrabbit-oak]

2024-05-23 Thread via GitHub
reschke commented on code in PR #1385: URL: https://github.com/apache/jackrabbit-oak/pull/1385#discussion_r1611216077 ## oak-blob-cloud-azure/pom.xml: ## @@ -50,8 +69,23 @@ azure-storage,

Re: [PR] Issues/OAK-10675 [jackrabbit-oak]

2024-05-23 Thread via GitHub
rootpea commented on code in PR #1385: URL: https://github.com/apache/jackrabbit-oak/pull/1385#discussion_r1611213303 ## oak-blob-cloud-azure/pom.xml: ## @@ -50,8 +69,23 @@ azure-storage,

Re: [PR] OAK-10811: (oak-search-elastic) reduce contention in IndexTracker [jackrabbit-oak]

2024-05-23 Thread via GitHub
fabriziofortino merged PR #1466: URL: https://github.com/apache/jackrabbit-oak/pull/1466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10825 - Indexing job: log [TASK::FAIL] log message for when an indexing phase fails. [jackrabbit-oak]

2024-05-23 Thread via GitHub
nfsantos opened a new pull request, #1481: URL: https://github.com/apache/jackrabbit-oak/pull/1481 Currently, the indexing job logs start/end messages for each phase: ``` [TASK::START] ... [TASK::END] Metrics: ... ``` This PR adds a corresponding FAIL message in case there

[PR] OAK-10711 : replaced preconditions.checkNotNull with Objects.requireN… [jackrabbit-oak]

2024-05-23 Thread via GitHub
rishabhdaim opened a new pull request, #1480: URL: https://github.com/apache/jackrabbit-oak/pull/1480 …otNull -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] OAK-10789 - Log paths used for inclusing/exclusion for Mongo regex filters in job summary [jackrabbit-oak]

2024-05-22 Thread via GitHub
nfsantos merged PR #1478: URL: https://github.com/apache/jackrabbit-oak/pull/1478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10823 : replaced db.collection.remove with db.collection.deleteOn… [jackrabbit-oak]

2024-05-22 Thread via GitHub
rishabhdaim merged PR #1477: URL: https://github.com/apache/jackrabbit-oak/pull/1477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-6756: Convert oak-auth-external to OSGi R7 annotations [jackrabbit-oak]

2024-05-22 Thread via GitHub
anchela commented on PR #1371: URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2125145788 @jsedding , i didn't know. so thanks for all the explanation that helps @mbaedke , thanks for the additional info so, i think we are good and sorry for not being

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124984455 Final remark here: It's not just Whitespace/EOL if the Javadoc gets reformatted. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124976698 > My Prediction: you will face a lot of resistance :) I already am ;) Doesn't change the fact that it brings huge advantages. There is a reason most organizations have a

[PR] OAK-10826 - Misleading warning about missing checkpoint [jackrabbit-oak]

2024-05-22 Thread via GitHub
daniancu opened a new pull request, #1479: URL: https://github.com/apache/jackrabbit-oak/pull/1479 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124966824 > Maybe it's better to move the discussion to the mailing list That makes sense. My Prediction: you will face a lot of resistance :) For (at least) the reasons mentioned,

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
reschke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124946276 Because 1.22 is our maintenance branch. Anyway, I don't think we're having a productive discussion here. -- This is an automated message from the Apache Git Service. To

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124944785 Maybe it's better to move the discussion to the mailing list: https://lists.apache.org/thread/0519b0m34m8853zxncmt4cc6omo155k4 -- This is an automated message from the Apache

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124943255 Question: Why are we regularly backporting in the first place? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124936612 > Again, if you want to detect what has changed at all and you compare with an old revision, it's very annoying. It's also very annoying working with a codebase with

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124934958 > Do you expect cherry-pick to run smoothly in this situation? Depending on the amount of changes, it's going to be pretty simple to fix the conflicts yeah. Just keep the

Re: [PR] OAK-10823 : replaced db.collection.remove with db.collection.deleteOn… [jackrabbit-oak]

2024-05-22 Thread via GitHub
rishabhdaim commented on code in PR #1477: URL: https://github.com/apache/jackrabbit-oak/pull/1477#discussion_r1610077563 ## oak-run/src/main/js/oak-mongo.js: ## @@ -352,12 +352,12 @@ var oak = (function(global){ * @param {string} pattern the pattern to match the nodes to

Re: [PR] OAK-10823 : replaced db.collection.remove with db.collection.deleteOn… [jackrabbit-oak]

2024-05-22 Thread via GitHub
rishabhdaim commented on code in PR #1477: URL: https://github.com/apache/jackrabbit-oak/pull/1477#discussion_r1610073932 ## oak-run/src/main/js/oak-mongo.js: ## @@ -352,12 +352,12 @@ var oak = (function(global){ * @param {string} pattern the pattern to match the nodes to

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124906935 > Then we backport the code with the new formatting applied? Do you expect cherry-pick to run smoothly in this situation? -- This is an automated message from the Apache

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124875447 > to me that also sounds like a one time thing. If both revisions have the same formatting, this should not be a problem? Again, if you want to detect what has changed at all

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124863273 Then we backport the code with the new formatting applied? The formatting doesn't change the functionality of the code. -- This is an automated message from the Apache Git

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
reschke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124831064 > If both revisions have the same formatting, this should not be a problem? So do you propose to reformat the current maintenance branch and historic branches as well? What

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124828538 > when diffing with other branches that may have not been reformatted Well then you can either ignore the whitespace when you perform a diff, or you can apply the formatting

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124825995 > If you - for example during debugging - compare between revisions to see what has changed and git will always tell you that everything did, it's very annoying. to me

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609854378 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -225,6 +236,8 @@ static DocumentStoreType

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124724483 > the fact that we don't have one is concerning May I ask what's so critical about that? Also, nobody cares about the GitHub blame view. People want to use the command line

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124697511 Also we are talking git diff, not git blame, right? I guess you can use git blame in an intermediate step to produce a list of file for the diff, but really??? -- This is an

Re: [PR] OAK-10823 : replaced db.collection.remove with db.collection.deleteOn… [jackrabbit-oak]

2024-05-22 Thread via GitHub
stefan-egli commented on code in PR #1477: URL: https://github.com/apache/jackrabbit-oak/pull/1477#discussion_r1609872160 ## oak-run/src/main/js/oak-mongo.js: ## @@ -352,12 +352,12 @@ var oak = (function(global){ * @param {string} pattern the pattern to match the nodes to

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609854378 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java: ## @@ -225,6 +236,8 @@ static DocumentStoreType

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609851349 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -167,6 +169,8 @@ public class

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on code in PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#discussion_r1609849335 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java: ## @@ -324,6 +346,11 @@ public T

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
reschke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124655346 but that doesn't help in all cases, for instance: - when diffing with other branches that may have not been reformatted - when trying to cherrypick changes to maintenance

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124643187 That's why we can put the formatting commits inside .git-blame-ignore-revs -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124638076 @steffenvan, If you - for example during debugging - compare between revisions to see what has changed and git will always tell you that **everything** did, it's very annoying.

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124630432 @mbaedke how so? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124613457 @steffenvan, it messes up diffs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124606686 I can see that deciding on _which_ formatter we should use could warrant a bit of discussion. But I find it strange that **introducing** one would be controversial. On the

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
steffenvan commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124597730 I put this as a draft just to test it and see how the PR would look like :) -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Formatting the entire code base [jackrabbit-oak]

2024-05-22 Thread via GitHub
reschke commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2124571152 No. This needs proper discussion in the Jackrabbit PMC and likely a vote because it'll be controversial. -- This is an automated message from the Apache Git Service. To

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-22 Thread via GitHub
stefan-egli commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609773530 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +43,59 @@ import

Re: [PR] OAK-6756: Convert oak-auth-external to OSGi R7 annotations [jackrabbit-oak]

2024-05-22 Thread via GitHub
mbaedke commented on PR #1371: URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2124542074 @jsedding , that actually makes sense. @anchela, do you have specific worries about the diff? To me it looks perfectly fine. -- This is an automated message from the Apache

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-22 Thread via GitHub
rishabhdaim commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609710827 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -161,8 +210,9 @@ private PropertyState

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-22 Thread via GitHub
rishabhdaim commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609711000 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -172,8 +222,8 @@ PropertyState

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-22 Thread via GitHub
rishabhdaim commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609710827 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -161,8 +210,9 @@ private PropertyState

Re: [PR] OAK-10803 - Modified DocumentPropertyState.java to compress values ba… [jackrabbit-oak]

2024-05-22 Thread via GitHub
rishabhdaim commented on code in PR #1473: URL: https://github.com/apache/jackrabbit-oak/pull/1473#discussion_r1609709936 ## oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentPropertyState.java: ## @@ -38,24 +43,59 @@ import

Re: [PR] OAK-10771 - Add disk cache size stats and issue warning if evicted segment has zero length [jackrabbit-oak]

2024-05-22 Thread via GitHub
reschke commented on code in PR #1427: URL: https://github.com/apache/jackrabbit-oak/pull/1427#discussion_r1609655472 ## oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/persistentcache/package-info.java: ## @@ -14,7 +14,7 @@ * See the License for the

Re: [PR] OAK-10771 - Add disk cache size stats and issue warning if evicted segment has zero length [jackrabbit-oak]

2024-05-22 Thread via GitHub
reschke commented on code in PR #1427: URL: https://github.com/apache/jackrabbit-oak/pull/1427#discussion_r1609608631 ## oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/persistentcache/package-info.java: ## @@ -14,7 +14,7 @@ * See the License for the

Re: [PR] OAK-10771 - Add disk cache size stats and issue warning if evicted segment has zero length [jackrabbit-oak]

2024-05-22 Thread via GitHub
smiroslav merged PR #1427: URL: https://github.com/apache/jackrabbit-oak/pull/1427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] OAK-10789 - Log paths used for inclusing/exclusion for Mongo regex filters in job summary [jackrabbit-oak]

2024-05-22 Thread via GitHub
nfsantos opened a new pull request, #1478: URL: https://github.com/apache/jackrabbit-oak/pull/1478 This PR adds the `Information` section below. ``` ... oak.indexer.pipelined.sortBufferMemoryPercentage: 25 oak.indexer.pipelined.transformThreads: 2

Re: [PR] OAK-6756: Convert oak-auth-external to OSGi R7 annotations [jackrabbit-oak]

2024-05-22 Thread via GitHub
jsedding commented on PR #1371: URL: https://github.com/apache/jackrabbit-oak/pull/1371#issuecomment-2124026921 I read the spec on the subject of the `pid` in the `Designate` element and found that the `pid` attribute is ignored if a `factoryPid` attribute is present. Both, the

[PR] OAK-10823 : replaced db.collection.remove with db.collection.deleteOn… [jackrabbit-oak]

2024-05-21 Thread via GitHub
rishabhdaim opened a new pull request, #1477: URL: https://github.com/apache/jackrabbit-oak/pull/1477 …e/deleteMany to make it compatible with both mongo & mongosh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] OAK-10780: add azure access token refresh logic [jackrabbit-oak]

2024-05-21 Thread via GitHub
t-rana commented on code in PR #1441: URL: https://github.com/apache/jackrabbit-oak/pull/1441#discussion_r1609259400 ## oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureUtilities.java: ## @@ -207,6 +230,61 @@ public void write(@NotNull byte[] bytes,

Re: [PR] OAK-10813 : using projection while listing/removing root temp nodes [jackrabbit-oak]

2024-05-21 Thread via GitHub
rishabhdaim merged PR #1475: URL: https://github.com/apache/jackrabbit-oak/pull/1475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] OAK-10739 : Provide support for FullGC in Mongo DocumentStore [jackrabbit-oak]

2024-05-21 Thread via GitHub
stefan-egli commented on PR #1454: URL: https://github.com/apache/jackrabbit-oak/pull/1454#issuecomment-2122919624 previous, direct commit was just a fix for a previous revert - aka a detail -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Formatting the entire code base [jackrabbit-oak]

2024-05-21 Thread via GitHub
steffenvan opened a new pull request, #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476 Reformatted all the code with https://google.github.io/styleguide/javaguide.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on

<    1   2   3   4   5   6   7   8   9   10   >