nfsantos commented on code in PR #1094:
URL: https://github.com/apache/jackrabbit-oak/pull/1094#discussion_r1329183290
##
oak-lucene/src/test/java/org/apache/jackrabbit/oak/jcr/query/ResultSizeTest.java:
##
@@ -126,5 +151,90 @@ private void doTestResultSize(boolean union, int
adamcin commented on PR #1094:
URL: https://github.com/apache/jackrabbit-oak/pull/1094#issuecomment-1724298220
@thomasmueller I don't have commit rights, so if you are willing to merge
it, please do.
--
This is an automated message from the Apache Git Service.
To respond to the message,
tihom88 commented on code in PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1333888606
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/IncrementalFlatFileStoreStrategy.java:
##
@@ -0,0 +1,181 @@
amit-jain commented on code in PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1331505640
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/DocumentStoreIndexerBase.java:
##
@@ -207,6 +212,29 @@ private List
nit0906 commented on code in PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1331256931
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileStore.java:
##
@@ -54,8 +57,18 @@ public
fabriziofortino commented on code in PR #1127:
URL: https://github.com/apache/jackrabbit-oak/pull/1127#discussion_r1331844469
##
oak-solr-osgi/pom.xml:
##
@@ -178,6 +178,12 @@
commons-math3
runtime
+
+org.apache.yetus
+
nfsantos commented on code in PR #1127:
URL: https://github.com/apache/jackrabbit-oak/pull/1127#discussion_r1331839958
##
oak-solr-osgi/pom.xml:
##
@@ -178,6 +178,12 @@
commons-math3
runtime
+
+org.apache.yetus
+
fabriziofortino opened a new pull request, #1132:
URL: https://github.com/apache/jackrabbit-oak/pull/1132
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke opened a new pull request, #1134:
URL: https://github.com/apache/jackrabbit-oak/pull/1134
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reschke merged PR #1134:
URL: https://github.com/apache/jackrabbit-oak/pull/1134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #1134:
URL: https://github.com/apache/jackrabbit-oak/pull/1134#issuecomment-1739588561
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
adamcin opened a new pull request, #314:
URL: https://github.com/apache/jackrabbit-filevault/pull/314
Replaces the user/group creation test for determining the usersPath and
groupsPath config values with a condition based only on the nodetype for the
node being removed.
--
This is an
nfsantos opened a new pull request, #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
kwin commented on code in PR #314:
URL:
https://github.com/apache/jackrabbit-filevault/pull/314#discussion_r1343669589
##
vault-core/src/main/java/org/apache/jackrabbit/vault/fs/spi/impl/jcr20/JackrabbitACLManagement.java:
##
@@ -202,18 +182,22 @@ private static boolean
nit0906 commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1343534093
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java:
##
@@ -130,7 +131,7 @@ public class
kwin commented on PR #314:
URL:
https://github.com/apache/jackrabbit-filevault/pull/314#issuecomment-1744410124
Looks good, is it possible to have an IT verifying that this doesn't require
particular permissions (apart from read) to prevent regressions here?
--
This is an automated
fabriziofortino merged PR #1131:
URL: https://github.com/apache/jackrabbit-oak/pull/1131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tihom88 merged PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nfsantos opened a new pull request, #1133:
URL: https://github.com/apache/jackrabbit-oak/pull/1133
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
fabriziofortino merged PR #1132:
URL: https://github.com/apache/jackrabbit-oak/pull/1132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adamcin commented on PR #314:
URL:
https://github.com/apache/jackrabbit-filevault/pull/314#issuecomment-1745274386
> Looks good, is it possible to have an IT verifying that this doesn't
require particular permissions (apart from read) to prevent regressions here?
I've added an IT,
sonarcloud[bot] commented on PR #:
URL: https://github.com/apache/jackrabbit-oak/pull/#issuecomment-1745344997
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
fabriziofortino commented on code in PR #1123:
URL: https://github.com/apache/jackrabbit-oak/pull/1123#discussion_r1335595549
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/incrementalstore/MergeIncrementalFlatFileStore.java:
##
@@ -0,0 +1,220
fabriziofortino merged PR #1129:
URL: https://github.com/apache/jackrabbit-oak/pull/1129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tihom88 merged PR #1130:
URL: https://github.com/apache/jackrabbit-oak/pull/1130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rishabhdaim opened a new pull request, #1137:
URL: https://github.com/apache/jackrabbit-oak/pull/1137
…d dependency for oak-segment-tar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
nfsantos commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347125441
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreUtils.java:
##
@@ -39,6 +40,23 @@
public class
amit-jain commented on code in PR #1135:
URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1346787350
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java:
##
@@ -410,11 +536,19 @@ public static File sortAndSave(List tmplist,
steffenvan commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347106722
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreUtils.java:
##
@@ -39,6 +40,23 @@
public class
steffenvan commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347106722
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreUtils.java:
##
@@ -39,6 +40,23 @@
public class
nfsantos commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347121152
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreUtils.java:
##
@@ -39,6 +40,23 @@
public class
reschke merged PR #1137:
URL: https://github.com/apache/jackrabbit-oak/pull/1137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tihom88 commented on code in PR #1135:
URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1347019114
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java:
##
@@ -410,11 +536,19 @@ public static File sortAndSave(List tmplist,
steffenvan commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347108455
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreUtils.java:
##
@@ -39,6 +40,23 @@
public class
steffenvan commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347108455
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/indexstore/IndexStoreUtils.java:
##
@@ -39,6 +40,23 @@
public class
dulceanu merged PR #1043:
URL: https://github.com/apache/jackrabbit-oak/pull/1043
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
amit-jain commented on code in PR #1135:
URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1346787350
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java:
##
@@ -410,11 +536,19 @@ public static File sortAndSave(List tmplist,
nfsantos commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347062712
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java:
##
@@ -130,7 +131,7 @@ public class
nfsantos commented on code in PR #1136:
URL: https://github.com/apache/jackrabbit-oak/pull/1136#discussion_r1347061053
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/FlatFileNodeStoreBuilder.java:
##
@@ -130,7 +131,7 @@ public class
nfsantos commented on PR #1130:
URL: https://github.com/apache/jackrabbit-oak/pull/1130#issuecomment-1748183653
> In this approach we are adding some processing to be done by mongo
download thread which is the main bottleneck. Would it make sense to do these
transformations on download
tihom88 commented on code in PR #1135:
URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1347035822
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java:
##
@@ -460,11 +602,21 @@ public static File sortAndSave(List tmplist,
amit-jain commented on code in PR #1135:
URL: https://github.com/apache/jackrabbit-oak/pull/1135#discussion_r1347067310
##
oak-commons/src/main/java/org/apache/jackrabbit/oak/commons/sort/ExternalSort.java:
##
@@ -460,11 +602,21 @@ public static File sortAndSave(List tmplist,
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352092119
##
oak-blob-cloud-azure/pom.xml:
##
@@ -191,10 +191,10 @@
mockito-core
test
-
-com.arakelian
-
reschke merged PR #1145:
URL: https://github.com/apache/jackrabbit-oak/pull/1145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352503502
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
nfsantos commented on code in PR #1142:
URL: https://github.com/apache/jackrabbit-oak/pull/1142#discussion_r1351850691
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentNodeStoreBuilderBase.java:
##
@@ -212,6 +213,15 @@
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352117183
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352093896
##
oak-blob-cloud-azure/src/test/java/org/apache/jackrabbit/oak/blob/cloud/azure/blobstorage/AzuriteDockerRule.java:
##
@@ -16,55 +16,88 @@
*/
package
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352111852
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352125451
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
oak lucene uses the MongoConnectionFactory in IT(s)
reschke commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352130678
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
But isn't that automatically inherited?
--
This is
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352125451
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
oak-lucene uses the MongoConnectionFactory in IT(s)
kwin commented on code in PR #1144:
URL: https://github.com/apache/jackrabbit-oak/pull/1144#discussion_r1352423985
##
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3DataStoreService.java:
##
@@ -19,10 +19,23 @@
package
reschke commented on code in PR #1144:
URL: https://github.com/apache/jackrabbit-oak/pull/1144#discussion_r1352434938
##
oak-blob-cloud/src/main/java/org/apache/jackrabbit/oak/blob/cloud/s3/S3DataStoreService.java:
##
@@ -19,10 +19,23 @@
package
thomasmueller merged PR #1142:
URL: https://github.com/apache/jackrabbit-oak/pull/1142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352268966
##
oak-segment-azure/src/test/resources/logback-test.xml:
##
@@ -21,11 +21,19 @@
%d{-MM-dd HH:mm:ss.SSS} [%thread] %-5level
%logger{36} -
t-rana opened a new pull request, #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
sonarcloud[bot] commented on PR #1144:
URL: https://github.com/apache/jackrabbit-oak/pull/1144#issuecomment-1755239775
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
t-rana commented on code in PR #1143:
URL: https://github.com/apache/jackrabbit-oak/pull/1143#discussion_r1352342828
##
oak-lucene/pom.xml:
##
@@ -471,5 +471,11 @@
1.19.0
test
+
Review Comment:
No, testcontainers dependency is defined under
sonarcloud[bot] commented on PR #1139:
URL: https://github.com/apache/jackrabbit-oak/pull/1139#issuecomment-1752830777
SonarCloud Quality Gate failed. [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
401 - 500 of 4103 matches
Mail list logo
