[jira] [Commented] (JENA-1437) text:multilingualSupport true vs false inconsistent results

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271481#comment-16271481 ] ASF GitHub Bot commented on JENA-1437: -- GitHub user xristy opened a pull request:

[GitHub] jena pull request #322: JENA-1437-multiLingual

2017-11-29 Thread xristy
GitHub user xristy opened a pull request: https://github.com/apache/jena/pull/322 JENA-1437-multiLingual Corrects issue reported in JENA-1437 You can merge this pull request into a Git repository by running: $ git pull https://github.com/BuddhistDigitalResourceCenter/jena

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271284#comment-16271284 ] ASF GitHub Bot commented on JENA-1438: -- Github user xristy commented on a diff in the pull request:

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

2017-11-29 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/320#discussion_r153872049 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -295,6 +295,14 @@ private String chooseGraphURI(ExecutionContext execCxt)

[GitHub] jena pull request #319: Jena 1441 tracing

2017-11-29 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153867385 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/TextIndexLuceneAssembler.java --- @@ -144,6 +144,17 @@ public TextIndex open(Assembler

Fwd: [GitHub] jena pull request #321: Just doing some syntax cleanup by using the new Grap...

2017-11-29 Thread ajs6f
Andy-- this is so trivial I would have just committed it, but I didn't want to bump into anything you might be doing to prep for a release. ajs6f > Begin forwarded message: > > From: ajs6f > Subject: [GitHub] jena pull request #321: Just doing some syntax cleanup by >

[GitHub] jena pull request #321: Just doing some syntax cleanup by using the new Grap...

2017-11-29 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/321 Just doing some syntax cleanup by using the new Graph::find method You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena FindANYtoFind

[GitHub] jena pull request #319: Jena 1441 tracing

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153861908 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/TextIndexLuceneAssembler.java --- @@ -144,6 +144,17 @@ public TextIndex open(Assembler

[GitHub] jena issue #319: Jena 1441 tracing

2017-11-29 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/319 Logging statements look good to me! ---

[GitHub] jena pull request #319: Jena 1441 tracing

2017-11-29 Thread xristy
Github user xristy commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153838075 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -224,12 +234,16 @@ private QueryIterator resultsToQueryIterator(Binding

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

2017-11-29 Thread Code Ferret (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271020#comment-16271020 ] Code Ferret commented on JENA-1438: --- The single space is the response from {{o.getLiteralLanguage()}}

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270965#comment-16270965 ] ASF GitHub Bot commented on JENA-1438: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/320#discussion_r153824555 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -295,6 +295,14 @@ private String chooseGraphURI(ExecutionContext execCxt)

[GitHub] jena pull request #319: Jena 1441 tracing

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153822758 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -204,7 +204,10 @@ public void close() { @Override public

[GitHub] jena pull request #319: Jena 1441 tracing

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153822788 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -224,12 +234,16 @@ private QueryIterator resultsToQueryIterator(Binding

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270947#comment-16270947 ] ASF GitHub Bot commented on JENA-1438: -- GitHub user xristy opened a pull request:

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

2017-11-29 Thread xristy
GitHub user xristy opened a pull request: https://github.com/apache/jena/pull/320 JENA-1438 rdf:langString args JENA-1438 allow rdf:langString arguments to text:query You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (JENA-1438) rdf:langString argument to text:query silently ignored

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270927#comment-16270927 ] ASF GitHub Bot commented on JENA-1438: -- GitHub user xristy opened a pull request:

[jira] [Commented] (JENA-1441) jena-text tracing for development

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270926#comment-16270926 ] ASF GitHub Bot commented on JENA-1441: -- Github user xristy closed the pull request at:

[GitHub] jena pull request #319: Jena 1441 tracing

2017-11-29 Thread xristy
GitHub user xristy opened a pull request: https://github.com/apache/jena/pull/319 Jena 1441 tracing Opening new to not include JENA-1438 related commit. This adds tracing in TextQueryPF and TextIndexLucene to track calls to exec and subsequent processing as well as the

[jira] [Commented] (JENA-1441) jena-text tracing for development

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270925#comment-16270925 ] ASF GitHub Bot commented on JENA-1441: -- Github user xristy commented on the issue:

[GitHub] jena issue #318: JENA-1441 jena-text tracing for development

2017-11-29 Thread xristy
Github user xristy commented on the issue: https://github.com/apache/jena/pull/318 Closing to reissue without the JENA-1438 commit ---

[GitHub] jena pull request #318: JENA-1441 jena-text tracing for development

2017-11-29 Thread xristy
Github user xristy closed the pull request at: https://github.com/apache/jena/pull/318 ---

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270922#comment-16270922 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153816757 --- Diff: jena-core/src/main/java/org/apache/jena/assembler/assemblers/AssemblerBase.java --- @@ -63,11 +63,16 @@ protected static RDFNode getUnique( Resource

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270917#comment-16270917 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153815330 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/core/assembler/TestDatasetAssembler.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270914#comment-16270914 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153815022 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -20,54 +20,45 @@ import static

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270910#comment-16270910 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153814226 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssemblerVocab.java --- @@ -31,7 +31,7 @@ // General dataset

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270911#comment-16270911 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153814026 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -57,28 +65,31 @@ public Dataset createDataset(Assembler a,

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270907#comment-16270907 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270909#comment-16270909 ] ASF GitHub Bot commented on JENA-1430: -- Github user ajs6f commented on a diff in the pull request:

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153813914 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -26,25 +30,29 @@ import

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153813903 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -26,25 +30,29 @@ import

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270616#comment-16270616 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270617#comment-16270617 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270620#comment-16270620 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270621#comment-16270621 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270618#comment-16270618 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270619#comment-16270619 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270614#comment-16270614 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[jira] [Commented] (JENA-1430) Quad loading for in-memory assemblers

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270615#comment-16270615 ] ASF GitHub Bot commented on JENA-1430: -- Github user afs commented on a diff in the pull request:

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153755081 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/core/assembler/TestDatasetAssembler.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153754571 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssemblerVocab.java --- @@ -31,7 +31,7 @@ // General dataset

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153745192 --- Diff: jena-core/src/main/java/org/apache/jena/assembler/assemblers/AssemblerBase.java --- @@ -63,11 +63,16 @@ protected static RDFNode getUnique( Resource

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153758968 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -57,28 +65,31 @@ public Dataset createDataset(Assembler a,

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153753744 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -26,25 +30,29 @@ import

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153745134 --- Diff: jena-core/src/main/java/org/apache/jena/assembler/assemblers/AssemblerBase.java --- @@ -63,11 +63,16 @@ protected static RDFNode getUnique( Resource

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153753683 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -26,25 +30,29 @@ import

[GitHub] jena pull request #314: JENA-1430

2017-11-29 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153751942 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -20,54 +20,45 @@ import static