Re: Jena OSGi pull request

2015-02-03 Thread Andy Seaborne
On 03/02/15 00:46, Stian Soiland-Reyes wrote: Ouch.. seems like a bug in Maven (or more likely) this magic org.rzo.yajsw.os.posix.PosixProcess used by org.everit.osgi. I guess setting it manually with -Djna.nosys=true didn't help either? Another reason to have a quick look at the PAX Exam

Re: Jena OSGi pull request

2015-02-03 Thread Stian Soiland-Reyes
Uhm, well must admit I have no clue as to why JNA should be involved in the first place. If it happens on your machine on two JDKs I guess it could happen to anyone. I suggest was try to go with the alternative PAX test I made for JENA-879 instead, even if its not as maintainable

Re: Jena OSGi pull request

2015-02-03 Thread Andy Seaborne
On 03/02/15 09:07, Stian Soiland-Reyes wrote: then I can put in the pull request. BTW - if the PR comment has the string JENA-879 in it, then it should get referenced by the JIRA. After what seems like a few dropped emails, we seem to be back connected for github/asf emails so it would be

Re: Jena OSGi pull request

2015-02-02 Thread Andy Seaborne
On 02/02/15 11:33, Stian Soiland-Reyes wrote: 1/ Build failure jena-osgi-test fails the build in step verify tried: java-8-openjdk and java-7-openjdk Exception in thread main java.lang.Error: There is an incompatible JNA native library installed on this system. To

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
Ouch.. seems like a bug in Maven (or more likely) this magic org.rzo.yajsw.os.posix.PosixProcess used by org.everit.osgi. I guess setting it manually with -Djna.nosys=true didn't help either? Another reason to have a quick look at the PAX Exam (JENA-879) - which I'm in the middle of now. It's

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
On 2 February 2015 at 13:11, Andy Seaborne a...@apache.org wrote: As far as I know, we can not ship source-release that pulls in LGPL, even to test, without the user making an explicit act to knowingly do that and work without it. Some relevant LEGAL issues (which don't really clarify as they

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
So the jena-osgi-test is not needed for *building* any artifacts (except itself, which doesn't depend on LGPL but probably need not be pushed to Maven central anyway). jena-osgi-test is not required for anything else. The test is only run during the integration-test phase (which happens during mvn

Re: Jena OSGi pull request

2015-02-02 Thread Benson Margulies
The maven-bundle-plugin + the pax-exam tools make for a full AL solution to making bundles and testing bundles. See, for example: https://github.com/basis-technology-corp/tcl-regex-java On Mon, Feb 2, 2015 at 8:11 AM, Andy Seaborne a...@apache.org wrote: On 02/02/15 11:33, Stian Soiland-Reyes

Re: Jena OSGi pull request

2015-02-02 Thread Andy Seaborne
On 02/02/15 11:33, Stian Soiland-Reyes wrote: 2/ There is a LGPL dependency (scope test) which needs investigation. (I would have appreciated that having been pointed out first) Sorry, I didn't mention this outside the pom.xml as it was a build/test dependency, which I thought would be OK -

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
Thanks for the hint, Benson! I had looked at PAX before without figuring it out, but this time I found more documentation, and it looks like it is definitely worth a try (even if it has a bit more heavyweight setup than eosgi). Tracked as: https://issues.apache.org/jira/browse/JENA-879 (I'm

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
On 1 February 2015 at 13:12, Andy Seaborne a...@apache.org wrote: Current status: * Pull request merged Thanks! * jena-osgi-test commented out of the build * Fatal problem building * LGPL issue (not an issue ATM as not in the build) Oh no :-( 1/ Build failure jena-osgi-test

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
As do I! I added to the pull request systemProperties !-- We don't care if there are any JNAs -- jna.nosystrue/jna.nosys /systemProperties to both enviroment according to http://www.everit.org/eosgi-maven-plugin/#environment_settings

Re: Jena OSGi pull request

2015-02-02 Thread Andy Seaborne
On 02/02/15 11:33, Stian Soiland-Reyes wrote: I'm not sure what JNl library you have, possibly some OS X thing? I'm on Ubuntu 14.10 Andy

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
Did you mean to just include the jena-osgi.jar in the apache-jena/ dist? It would add only 7 MB. If on the otherside we do a separate download of jena-osgi, we probably want a separate 'apache-' like dist ZIP/tar.gz instead of the direct JAR file - not sure how well the mirrors (and anti virus

Re: Jena OSGi pull request

2015-02-02 Thread Andy Seaborne
On 02/02/15 14:11, Stian Soiland-Reyes wrote: Tracked as: https://issues.apache.org/jira/browse/JENA-879 (I'm unable to assign it to myself in Jira - anyone else want to have a go?:-) There are two roles here - the committer who lets it into the code base the doer who makes the contribution.

Re: Jena OSGi pull request

2015-02-02 Thread Andy Seaborne
On 02/02/15 13:30, Stian Soiland-Reyes wrote: So the jena-osgi-test is not needed for *building* any artifacts (except itself, which doesn't depend on LGPL but probably need not be pushed to Maven central anyway). jena-osgi-test is not required for anything else. The test is only run during the

Re: Jena OSGi pull request

2015-02-02 Thread Andy Seaborne
On 02/02/15 17:50, Stian Soiland-Reyes wrote: OK, agree that it should be easy out of the box to compile. With remove you mean to move out of source code or just not include it in the release? Out of the source tree. That's clear cut. Just disabling it in modules (or require the

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
OK, agree that it should be easy out of the box to compile. With remove you mean to move out of source code or just not include it in the release? Just disabling it in modules (or require the -Papache-release flag) would work for me. The test source is IP and license clean - so there's no issue

Re: Jena OSGi pull request

2015-02-02 Thread Andy Seaborne
On 02/02/15 11:53, Stian Soiland-Reyes wrote: Did you mean to just include the jena-osgi.jar in the apache-jena/ dist? It would add only 7 MB. I think it's a different audience. apache-jena-dist is for standalong use + source + javadoc. I'd rather start cautious and add later, rather than

Re: Jena OSGi pull request

2015-02-02 Thread Stian Soiland-Reyes
On 2 February 2015 at 17:03, Andy Seaborne a...@apache.org wrote: I think it's a different audience. apache-jena-dist is for standalong use + source + javadoc. Right, that is what I would prefer as well. So if/when we go for a Jena-OSGi download, it would be a separate one. So you are happy

Re: Jena OSGi pull request

2015-02-01 Thread Andy Seaborne
Current status: * Pull request merged * jena-osgi-test commented out of the build * Fatal problem building * LGPL issue (not an issue ATM as not in the build) 1/ Build failure jena-osgi-test fails the build in step verify tried: java-8-openjdk and java-7-openjdk

Jena OSGi pull request

2015-01-30 Thread Andy Seaborne
https://github.com/apache/jena/pull/10 Conversations around this seem to have settled down around the latest state of pull request 10 (to me as a non-OSGi person). I propose to pull and merge this. This message is lazy consensus (24hr minimum deadline) on pulling that so that there will be