[GitHub] jmeter issue #358: Checkstyle: LineLength max 165, AnonInnerLength 45 and ot...

2017-12-12 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/jmeter/pull/358 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/358?src=pr&el=h1) Report > Merging [#358](https://codecov.io/gh/apache/jmeter/pull/358?src=pr&el=desc) into [trunk](https://codecov.io/gh/

[GitHub] jmeter pull request #358: Checkstyle: LineLength max 165, AnonInnerLength 45...

2017-12-12 Thread ham1
GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/358 Checkstyle: LineLength max 165, AnonInnerLength 45 and other whitespace checks Also removed some unnecessary `StringBuilder`s ## How Has This Been Tested? `ant checkstyle test` You can m

Re: Menu item ordering

2017-12-12 Thread Vincent HERILIER
Maybe could we propose different layouts (full flat (default ?), full grouped, plugin only... defined by a property) mixed with LRU proposition, Search box... accordingly to user preferences/habits/needs ? Le mar. 12 déc. 2017 à 16:40, Vincent HERILIER a écrit : > In the PR, I proposed, I grou

Re: Menu item ordering

2017-12-12 Thread Vincent HERILIER
In the PR, I proposed, I grouped JMeter native elements as example, but the PR insured to let some elements at their initial place (JMEter ones to keep its current usability) and allow others to be grouped (3rd party ones if required and proposed by their related maintainers). So it was just allowi

Re: Menu item ordering

2017-12-12 Thread Graham Russell
Ah, I didn't appreciate the use case you had. I still think the additional menu groupings would be detrimental to more common use cases. Perhaps we can keep plugin menus ordered separated from the native ones this might help slightly. I will make sure I test my changes with some plugins! I was t

Re: Menu item ordering

2017-12-12 Thread Vincent HERILIER
I clearly understand your points of view. But with plugins used in my case (and average 300 testers) which bring average 40 config elements and 90 samplers, they are mixed (with JMeter native ones too) for complex and cross-protocol flows we would like to simulate (average 15 protocols - new , red

Re: Menu item ordering

2017-12-12 Thread Graham Russell
I agree with Phillipe that adding more menus, and therefore steps to get to items you need (key presses or mouse moves) and items to read is not an improvement. I like the idea of a configurable palette (with some sensible defaults), much easier for beginners. This still requires use of the mouse

Re: Menu item ordering

2017-12-12 Thread Philippe Mouawad
Hello, I am personally against an additional level in the popup menu as it would be a loss of time. If it's about reorganizing the menu order to put most popular ones on top, why not. A configurable palette in the right or bottom left (now we have dropped workbench) might be a better alternative

Re: Menu item ordering

2017-12-12 Thread Vincent HERILIER
Hi, I already proposed a PR in that way ( https://github.com/apache/jmeter/pull/236) and I'm still interested in having the capability to group some elements ,per protocol class for example, to reduce the amount of different menus entries shown. Vincent Le mar. 12 déc. 2017 à 10:07, Antonio Gome

Re: Menu item ordering

2017-12-12 Thread Antonio Gomes Rodrigues
Hi, About advanced mode, some code has been written and maybe we need to remove it and discuss again and finish it. Yes, it's hockey. For the moment I have few free time but I probably write some blog post (Apache provide blog) about some features. Thanks to the PR Antonio 2017-12-11 21:00