[GitHub] [jmeter] Tinywan commented on a diff in pull request #711: Update get-started.xml

Tinywan commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r868776856 ## xdocs/usermanual/get-started.xml: ## @@ -279,7 +279,7 @@ jmeter -t test.jmx … DDRAWJVM options to influence usage of direct draw, e.g. -Dsun.java2d.ddscale=true. Def

[GitHub] [jmeter] codecov-commenter commented on pull request #712: Use kotlinx-coroutines for UI launcher

codecov-commenter commented on PR #712: URL: https://github.com/apache/jmeter/pull/712#issuecomment-1121605827 # [Codecov](https://codecov.io/gh/apache/jmeter/pull/712?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software

[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053

rollno748 commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121550885 Yes the current shortcut is assigned to ctrl+alt+f to reset the search. I haven't considered the esc to set it as reset search. I thought, It would be easier for us to remember to go

[GitHub] [jmeter] vlsi commented on a diff in pull request #713: Update Kotlin to 1.6.21

vlsi commented on code in PR #713: URL: https://github.com/apache/jmeter/pull/713#discussion_r868421320 ## checksum.xml: ## @@ -35,6 +35,7 @@ + Review Comment: In case you wonder, the same key has already been listed for other Google groups. -- Thi

[GitHub] [jmeter] vlsi commented on pull request #710: Added Shortcut key event for Reset search - 66053

vlsi commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121541948 Am I right the suggested shortcut is `ctrl+alt+f` to reset the search? Does it come from a standard? Have you considered using `esc` shortcut to reset the search? -- This is an autom

[GitHub] [jmeter] vlsi merged pull request #713: Update Kotlin to 1.6.21

vlsi merged PR #713: URL: https://github.com/apache/jmeter/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org F

[GitHub] [jmeter] rollno748 commented on pull request #710: Added Shortcut key event for Reset search - 66053

rollno748 commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121514349 Thanks for reviewing it @pmouawad I have applied the autostyle and committed it -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [jmeter] pmouawad commented on pull request #710: Added Shortcut key event for Reset search - 66053

pmouawad commented on PR #710: URL: https://github.com/apache/jmeter/pull/710#issuecomment-1121507626 Hello @rollno748 , Thanks for contributing. Can you run ./gradlew autostyleApply and commit the result please ? Thank you -- This is an automated message from the Apache Git S

[GitHub] [jmeter] pmouawad merged pull request #709: Revert Bugfix 65885

pmouawad merged PR #709: URL: https://github.com/apache/jmeter/pull/709 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.or

[GitHub] [jmeter] pmouawad commented on a diff in pull request #711: Update get-started.xml

pmouawad commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r868371345 ## xdocs/usermanual/get-started.xml: ## @@ -279,7 +279,7 @@ jmeter -t test.jmx … DDRAWJVM options to influence usage of direct draw, e.g. -Dsun.java2d.ddscale=true. De

[GitHub] [jmeter] vlsi commented on a diff in pull request #711: Update get-started.xml

vlsi commented on code in PR #711: URL: https://github.com/apache/jmeter/pull/711#discussion_r868368164 ## xdocs/usermanual/get-started.xml: ## @@ -279,7 +279,7 @@ jmeter -t test.jmx … DDRAWJVM options to influence usage of direct draw, e.g. -Dsun.java2d.ddscale=true. Defaul

[GitHub] [jmeter] vlsi opened a new pull request, #713: Update Kotlin to 1.6.21

vlsi opened a new pull request, #713: URL: https://github.com/apache/jmeter/pull/713 See https://kotlinlang.org/docs/whatsnew1620.html ## Motivation and Context Note: Kotlin is a new dependency in JMeter 5.5, so let's start with an up-to-date version. ## Checklist:

[GitHub] [jmeter] vlsi commented on a diff in pull request #712: Use kotlinx-coroutines for UI launcher

vlsi commented on code in PR #712: URL: https://github.com/apache/jmeter/pull/712#discussion_r867881621 ## src/core/src/main/java/org/apache/jmeter/JMeterGuiLauncher.kt: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [jmeter] vlsi commented on a diff in pull request #712: Use kotlinx-coroutines for UI launcher

vlsi commented on code in PR #712: URL: https://github.com/apache/jmeter/pull/712#discussion_r867880630 ## src/core/src/main/java/org/apache/jmeter/JMeterGuiLauncher.kt: ## @@ -0,0 +1,151 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contribut

[GitHub] [jmeter] vlsi opened a new pull request, #712: Use kotlinx-coroutines for UI launcher

vlsi opened a new pull request, #712: URL: https://github.com/apache/jmeter/pull/712 ## Description This PR moves `startGui` from `class JMeter` to another class. ## Motivation and Context a) It is nice to factor UI from non-UI code b) Current code fails to update prog