Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/439
Hello @artem-fedorov ,
Can you provide a documentation of new property, it's in
properties_reference.xml and we also usually add it commented to
jmeter.properties.
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/429
Hello @artem-fedorov ,
There seem to be a place for this PR amended for users that use JMeter for
functional testing as per the 2 last comments in:
- https://bz.apache.org/bugzilla
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/438
Hi Felix,
Since you're working on this.
I see that when when we use openjdk11, we have those warnings:
warning: [options] bootstrap class path not set in conjunction with
-source 8
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/438
+1
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/437
+1, Thanks
---
GitHub user pmouawad opened a pull request:
https://github.com/apache/jmeter/pull/436
Bug 62959 - Ability to create a Test plan from a cURL command
POC contributed by https://ubikloadpack.com
## Description
This is a POC for Bug 62959 - Ability to create a Test plan
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/432
Hello,
I'll be merging it today.
Regards
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/434
agreed
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/432
Hello Felix,
I have committed the fixes following your review.
Let me know if you will commit the PR (which I would prefer), otherwise
I'll do it.
Thanks
Regards
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/429
@artem-fedorov ,
Yes if the are in the test plan.
No guarantee if they are automatically handled by resources download and it
is done in parallel, but since 5.0, we add the URL in the CSV
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/434#discussion_r235892281
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
---
@@ -196,12 +196,18 @@ private void
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/429
Hi @artem-fedorov,
Is it ok if we stay as we are ?
Reporter of issue says itâs ok for him.
Do you see any issue on your side that would need a fix ?
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/433
Iâll try to merge it this evening.
So hopefully yes
Thanks for your patience and contribution
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/432
Hi Felix,
Youâre right.
Take your time
Sorry, I am always impatient guy :)
Regards
---
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/413#discussion_r23521
--- Diff: docs/usermanual/get-started.html ---
@@ -930,6 +930,11 @@ 1.4.3 Using JMeter behind a
proxy
+
--- End diff --
To update
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/413#discussion_r23500
--- Diff: src/core/org/apache/jmeter/JMeter.java ---
@@ -746,13 +751,15 @@ private void setProxy(CLArgsParser parser) throws
IllegalUserActionException
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/413
Thanks for updating your PR to add the cmd line option.
Yes french labels are also mandatory, can you update it (I would correct it
if needed) so that we see if all tests pass.
Once
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/431
Hello Felix,
I guess this is a first step before generalization ?
As I see other places in code where newInstance() is used.
Regards
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/429
Thanks Artem for the PR, but I don't understand it.
It seems to me it breaks what has been modified in 5.0.
---
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/429#discussion_r232387245
--- Diff: bin/testfiles/HTMLParserTestFile_2.xml ---
@@ -10,7 +10,7 @@
file:testfiles/HTMLParserTestFile_2.html
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/429#discussion_r232387123
--- Diff: bin/testfiles/Bug52310.xml ---
@@ -2,16 +2,16 @@
-
--- End diff --
I don't understand why this test result
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/429#discussion_r232387286
--- Diff: bin/testfiles/HTMLParserTestFile_2.xml ---
@@ -10,7 +10,7 @@
file:testfiles/HTMLParserTestFile_2.html
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/429#discussion_r232387592
--- Diff: bin/testfiles/TEST_HTTP_HttpClient4.xml ---
@@ -144,7 +144,7 @@
-
--- End diff --
I don't understand
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/429#discussion_r232387619
--- Diff: bin/testfiles/TEST_HTTP_Java.xml ---
@@ -120,7 +120,7 @@
-
--- End diff --
Same note here
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/397
Hi Team,
Anybody had a chance to test this behind a proxy and under regular
conditions ?
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/413
Thanks for patch update.
Thinking more about it **and to be coherent** we should also add this as a
command line option as per:
- http://jmeter.apache.org/usermanual/get-started.html
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/413#discussion_r228741947
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -1037,7 +1044,7 @@ private CloseableHttpClient
setupClient
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/406
+1
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/409
+1
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/408
+1
Should you test «.javafx. » instead of only javafx?
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/405
+1 Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/399
Thanks for PR.
We'll merge it once version 5.0 is released.
Regards
---
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/397#discussion_r214180268
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -574,10 +574,12 @@ protected HTTPSampleResult sample(URL url
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/397#discussion_r213465187
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java ---
@@ -574,10 +574,12 @@ protected HTTPSampleResult sample(URL url
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/389
This looks good to me.
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/393
Hello,
What is the purpose of this Pr ?
It looks like itâs empty.
Can you close it please ?
Thank you
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/390
Hi Felix,
My opinion is that if you did the upgrade itâs ok to break old plan
provided we clearly state we did this.
It is fair that we upgrade now a very old version of MongoDB API
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/356
Hello @ham1 ,
I hope you're fine.
Thanks for this PR which took some time to be taken into account.
It now conflicts with a lot of files so it would be nice if you could
rebase
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/233
It appears similar feature is now available a 3rd party plugin :
* https://jmeter-plugins.org/?search=Weighted
So I propose to close this one.
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/72
It appears that you have made this a 3rd party plugin for MQTT.
So we'll close this PR as WONTFIX.
Thank you anyway for your contribution.
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/387
Hi Felix,
Did you have time to check the changes are working ?
If yes, +1 for committing it.
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/385
Thanks for PR and contribution.
Still as answered by Felix, this PR is too simple and would break a lot of
things in JMeter and important data are stored in ThreadLocal.
Thank you
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/384
Thanks for PR, still I think the initial phrase is correct without comma:
- Load test functional behaviour
Unless I misunderstand, can you close your PR ?
Thank you
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/387
Thanks Felix
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/387
Thanks for PR.
Just wondering, why do we use httpcomponents package ?
- org.apache.http.impl.auth.DelegatingKerberosScheme
- org.apache.http.impl.auth.DelegatingSPNegoScheme
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/380
Hello,
Thanks @FSchumacher , looks like a good start.
@vlsi , looks interesting .
Can you help on integrating it ?
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/378
Hello @artem-fedorov ,
Is your PR for the bug you indicate which is supposed to be fixed long time
ago or for this one:
- https://bz.apache.org/bugzilla/show_bug.cgi?id=60782
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/320
Merged:
- http://svn.apache.org/viewvc?rev=1825269=rev
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/374
Hi Felix,
Why not commit this before release ?
Do you have a doubt about it ?
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/374
Very good idea
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/369
ÐолÑÑое ÑпаÑибо!!
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/231
Hi @vsi,
When do you think youâll be able to provide a documentation PR ?
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/231
@vlsi ,
What about:
- Poisson Arrivals timer ?
- Precise Throughput Timer ?
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/231
Hi @vsi,
It looks ok to me, if you can add doc as separate PR it would be great !
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/231
Hi @vlsi ,
Thanks for your clarifications.
It is just that as per your confirmation, one of the aims of this new
component was:
**"The very basic requirement is to ensure you e
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/231
Hi @vlsi ,
Thanks for your feedback.
I tried many configurations including thread delay to 0, and I never really
reach exact sampling on duration.
Is it really supposed to be exact
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/231
Hi @vlsi ,
Could you confirm your component implements the following features:
1) "Specific number of iterations per hour".
The very basic requirement is to ensure you end
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/343
Hi Team,
if there are volunteer to merge this one, thanks in advance.
Regards
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/358
Hi @ham1 ,
Thanks for this PR.
Unfortunately I am not very comfortable with PR that touch a lot of file
and where the code modification may touch more things than what the PR
describes
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/356
Hi @ham1 ,
Thanks for this PR.
Unfortunately I am not very comfortable with PR that touch a lot of file
and where the code modification may touch more things than what the PR
describes
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/355
Hi Graham,
Thanks for the PR.
would it be possible to update it with last trunk as there has been an
intermediate commit which changes things a bit.
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/350
Hi @ham1 ,
It seems there are issues in headless mode following my merge of this PR.
See https://travis-ci.org/apache/jmeter/jobs/313214205
I'll have a look this week-end
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/345
Hi team, anybody wants to merge this one ? if not Iâll do it this
week-end. Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/341
Hi @FSchumacher ,
Good idea.
Is this in relation with https://github.com/apache/jmeter/pull/313 ?
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/348
Hi @ham1 ,
I never used this Access log sampler in JMeter .
But I think the classes you removed are used as possible implementations
for filtering.
See:
- http
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/342
Hi Felix,
It seems there is a consensus to drop CamelCase from function.
I agree also with it as I have never really needed in all my tests camel
case nor any member of our team. So I have
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/344
Hi @artem-fedorov ,
Thanks for the PR
Regarding build:
- You might have to merge the trunk as I made a fix in JMS few minutes ago.
Regarding PR itself:
- Package
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/342
+1 for trim
Ok for me to merge.
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/341
Hi @max3163 ,
0/ In order to justify the user case, can you illustrate your use case ?
1/ I think we should add a log in debug level when we ignore a SampleResult
2/ Could you also add
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/321
Resolved by commit:
http://svn.apache.org/viewvc?rev=1815893=rev
@max3163 , can you close this one please ?
Thank you
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/332
Hi @ham1 ,
Thanks for this interesting PR.
There is a conflict in it, could you rebase it as you proposed.
Also, there is something I don't understand, I see coverage has decreased
while
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/329
Hi @ham1 ,
Thanks for PR.
As commented on @max3163 PR, I feel this renderer is not very useful.
I think improving more the XPath Tester and removing this one would bring a
better UX
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/324
Thanks @ham1 ,
Could you review my commit as your PR had a conflict after merging of
Workbench before it.
I think I didn't miss anything but another eye is welcome.
Regards
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/325
Hello @bennyvw ,
Thanks for updating PR.
It seems the changes have introduced an issue in JMS_TESTS.jmx which is
located in source files on github/svn (only, not in binary) in bin/testfiles
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/321
@max3163 , thanks for updating your PR.
It is ok for me now.
Regards
---
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150327668
--- Diff:
src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java ---
@@ -142,48 +173,244 @@ public SampleResult sample(Entry entry
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150327166
--- Diff: docs/usermanual/component_reference.html ---
@@ -4276,10 +4289,32 @@
temporary queues will be used for the communication between
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150328441
--- Diff:
src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java ---
@@ -142,48 +173,244 @@ public SampleResult sample(Entry entry
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150328248
--- Diff:
src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java ---
@@ -142,48 +173,244 @@ public SampleResult sample(Entry entry
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150328288
--- Diff:
src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java ---
@@ -142,48 +173,244 @@ public SampleResult sample(Entry entry
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150328999
--- Diff:
src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java ---
@@ -142,48 +173,244 @@ public SampleResult sample(Entry entry
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150328360
--- Diff:
src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java ---
@@ -142,48 +173,244 @@ public SampleResult sample(Entry entry
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150327021
--- Diff: docs/usermanual/component_reference.html ---
@@ -3813,7 +3813,7 @@
--- End diff --
HTML files are generated from XML. Could
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/325#discussion_r150328109
--- Diff:
src/protocol/jms/org/apache/jmeter/protocol/jms/sampler/JMSSampler.java ---
@@ -142,48 +173,244 @@ public SampleResult sample(Entry entry
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/321#discussion_r149436677
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
---
@@ -318,6 +335,13 @@ public void setupTest
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/321#discussion_r149435419
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java ---
@@ -71,6 +72,10 @@
/** A panel allowing the user
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/321#discussion_r149132449
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
---
@@ -318,6 +335,13 @@ public void setupTest
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/321#discussion_r149131377
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/BackendListenerGui.java ---
@@ -71,6 +72,10 @@
/** A panel allowing the user
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/321#discussion_r149132569
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
---
@@ -92,6 +92,18 @@
private static
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/321#discussion_r149131482
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
---
@@ -105,7 +117,7 @@
private String
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/321#discussion_r149133328
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbBackendListenerClient.java
---
@@ -318,6 +335,13 @@ public void setupTest
Github user pmouawad commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/231#discussion_r148880960
--- Diff:
src/components/org/apache/jmeter/timers/ExponentialTimerBeanInfo.java ---
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/231
Hello,
I will commit this PR unless there is a NO GO within 2 days.
Thanks
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/283
See:
http://svn.apache.org/viewvc?rev=1798405=rev
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/318
Merged, thank you !
---
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/315
Hello,
For your information, I used part of your code to handle migration to Java9:
- http://svn.apache.org/viewvc?view=revision=1813017
If you're able to provide the same
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/313
Hello @vherilier ,
There is indeed a problem (good catch) as this new field should be
persisted to XML/CSV.
But my issue here is that it only concerns Transaction Controller and would
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/313
Thanks @vherilier for your update, it looks good to me.
May I ask one last thing, there is no documentation nor illustration of how
this feature can be used.
So if we want this feature
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/315
Thanks for your PR.
But this code has recently been updated to work differently:
https://github.com/apache/jmeter/blob/trunk/bin/jmeter
We'll be happy to integrate an update
Github user pmouawad commented on the issue:
https://github.com/apache/jmeter/pull/313
Hello @vherilier ,
Thanks for PR.
Could you amend it to:
- Add a property that would apply to all TC
- add a TristateCheckBox in GUI 'Use comment in SampleResult'
I
1 - 100 of 267 matches
Mail list logo
