Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-06-03 Thread Felix Schumacher
Am 03.06.2017 um 10:55 schrieb Philippe Mouawad: On Wed, May 31, 2017 at 2:54 PM, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: Philippe>- switch everywhere to R1 (also in commons-math) Can you please clarify why do you prefer R1? Because from what the reporter wrote, it looked

Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-06-03 Thread Vladimir Sitnikov
Philippe>"If the 90% percentile is 1200 ms than that means that 90% of tests take no more than 1200 ms" Well, I get your point. It makes sense to keep the old approach unless there's some data that confirms some other approach is better. Vladimir>What I mean is R8 kind of Vladimir> computation

Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-06-03 Thread Philippe Mouawad
On Wed, May 31, 2017 at 2:54 PM, Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Philippe>- switch everywhere to R1 (also in commons-math) > > Can you please clarify why do you prefer R1? > Because from what the reporter wrote, it looked good to me: "If the 90% percentile is 1200 ms

Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-31 Thread Vladimir Sitnikov
Philippe>- switch everywhere to R1 (also in commons-math) Can you please clarify why do you prefer R1? I'm inclined to R8 (as it is recommended by R for sample quantile calculation). 1) I think interpolation would reduce run-to-run variance. 2) Interpolation-like estimation is easier to

Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-31 Thread Antonio Gomes Rodrigues
Hi, I don't have time to read the posted links yet But I am OK to have the same way to calculate percentiles and documented it Antonio 2017-05-28 11:51 GMT+02:00 Philippe Mouawad : > Hello, > After reading further on this topic and also reading the different >

Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-28 Thread Philippe Mouawad
Hello, After reading further on this topic and also reading the different comments, my position would be: - switch everywhere to R1 (also in commons-math) - use the PR from contributor for the median and jorphan computations - document the change and algo somewhere >From my understanding, tests

[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-25 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/296 Hi Team, What shall we do ? As per Felix note on dev mailing list, it is more an algorithm variation than a bug. --- If your project is set up for it, you can reply to

[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-10 Thread abalanonline
Github user abalanonline commented on the issue: https://github.com/apache/jmeter/pull/296 @Wyatts Thank you. R-8 is good if the interpolated approach is required. But for JMeter the R-1 is preferable because data calculated that way have a concrete understandable meaning. ---

[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-10 Thread Wyatts
Github user Wyatts commented on the issue: https://github.com/apache/jmeter/pull/296 FWIW, [this article](https://analyse-it.com/blog/2013/2/quantiles-percentiles-why-so-many-ways-to-calculate-them) has two citations in favour of defaulting to what Wikipedia calls R-8 (though it

Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-09 Thread Philippe Mouawad
Hi Felix, Thanks for this precious information. Maybe we should document what option was taken by JOrphan if you know it. On another side, do you agree we should make percentiles / median uniform accross JMeter ? It seems we have at least those choices: - commons-math we already use in

Re: [GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-09 Thread Felix Schumacher
Am 09.05.2017 09:11, schrieb pmouawad: Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/296 Hello @abalanonline , Thanks for your replies and explanations ! I am not a math expert as you seem to be, so I have few questions you may be able to

[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-09 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/296 Hello @abalanonline , Thanks for your replies and explanations ! I am not a math expert as you seem to be, so I have few questions you may be able to help on: 1. Thanks to your

[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-08 Thread abalanonline
Github user abalanonline commented on the issue: https://github.com/apache/jmeter/pull/296 @FSchumacher thank you for the remark, it is fixed now @pmouawad DescriptiveStatistics uses legacy percentile calculation method by default, which is Linear Interpolation Third Variant

[GitHub] jmeter issue #296: Bug 61078 - Percentile calculation error

2017-05-08 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/296 Thanks for your patch. This test fails for me: `@Test public void testPercentagePointBug() throws Exception { long values[] = new long[] {